Redmine

Thank you!

+1
I love this feature. For me, it seems mandatory to define the assignee as a watcher per default. Then, if the assignee wants, he can change the watcher status.

Would it be possible to integrate it in the next release (v0.9 ?)

Hi Teddy,

I wanted to try your plugin on v0.8.1. I have copied the folder redmine_auto_watch in the vendor/plugins folder, ran rake db:migrate_plugins and restart my server.
I can see your plugin in the administration plugin list.
But, when I assign a issue to user1, it is not automatically added as a watcher.

So, your plugin does not work for me. Do you know if it comes from the redmine version used, or if I missed something ?

Jerome Vanthournout wrote:

...

Hi,

I just tried with 0.8.1 and it's still working.

The test1 user should not be the author of your test issue (author always receive notifications), and check your View watchers list rights.

And for info, rake db:migrate_plugins is not needed because i didn't make db modifications.

Hi Teddy,

Ok, it works now.

Thanks for your plug-in which should be integrated in the trunk version.

I don't seem to be able to link tickets.

See also #1737

Hi,

Do you think when a user not in the watchers list updates the issue, should him/her be added to the watchers list automatically?

Sometimes I when I gives feedback to an issue that I am not part of, I might forget to add the issue to my watch list. But I think most of the time the user would like to watch the issue by default if he joins the discussion.

Thanks,
Michael

Is it compactible with Redmine 2.x ?

Try it out: https://github.com/logical-and/redmine_auto_watch. Watchers added on issue update and issue create from: author, assignee, previous assignee if any.

Would it be difficult to extend this to be on creation per project? That is, any issue created in a certain project gets default watchers?

When you create issues by sending an email to an address and then reading the email with rake redmine:email:receive_imap
the issue is created but the creator (email sender) it is not marked as watcher. Could the plugin be modified to support this feature? Is there any hook to handle when you create with receive_imap rake task?

+1

+1

+1 this would be really important!

# And wrote:

Try it out: https://github.com/logical-and/redmine_auto_watch. Watchers added on issue update and issue create from: author, assignee, previous assignee if any.

I can confirm that the forked and enhanced version of this plugin which can be found at https://github.com/mephi-ut/redmine_auto_watch works very well for Redmine 3.3.1

hi guys!
can someone confirm that this plugin is compatible with redmine > 4.0.0?
we have been using Teddy L's Version so far sucessfuly with up to 3.4.6 - thanks Teddy L by the way.
Kind Regards,
Matt

Hi, i have forked this plugin on Github and fixed Redmine 4 compatibility:

https://github.com/PewPewMeowMeow/redmine_auto_watch

Have Fun

Kai

PS: all hail Teddy L :)

kai b wrote:

Hi, i have forked this plugin on Github and fixed Redmine 4 compatibility:

https://github.com/PewPewMeowMeow/redmine_auto_watch

Have Fun

Kai

PS: all hail Teddy L :)

It doesn't work with version 4.0.4.stable
If you try make new issue, and assign user - it will crash.
In logs:

Parameters: {"utf8"=>"✓", "authenticity_token"=>"Vc04yOzbC6cPGklEN5cotxnXkx7i3qRd+X9VcysTcrk3JtDb6ommPRqUlBH13E2AAHqGQGCcfyGd9QlCl0sOgQ==", "form_update_triggered_by"=>"", "issue"=>{"is_private"=>"0", "tracker_id"=>"8", "subject"=>"TEST", "description"=>"", "status_id"=>"6", "priority_id"=>"2", "assigned_to_id"=>"777", "fixed_version_id"=>"", "parent_issue_id"=>"", "start_date"=>"2019-08-28", "due_date"=>"", "estimated_hours"=>"", "done_ratio"=>"0", "custom_field_values"=>{"79"=>"", "13"=>"", "62"=>"", "83"=>"", "84"=>""}, "watcher_user_ids"=>["", "4", "927"]}, "commit"=>"Make", "project_id"=>"utm-level3-ckp-okp"}

Anton Koptsev wrote:

kai b wrote:

Hi, i have forked this plugin on Github and fixed Redmine 4 compatibility:

https://github.com/PewPewMeowMeow/redmine_auto_watch

It doesn't work with version 4.0.4.stable

All ok wuth 4.1
but i add

diff --git a/lib/auto_watch_hook.rb b/lib/auto_watch_hook.rb
index bc95b2f..e24e2e3 100644
--- a/lib/auto_watch_hook.rb
+++ b/lib/auto_watch_hook.rb
@@ -38,7 +38,7 @@ class AutoWatchHook < Redmine::Hook::Listener
   end

   def add_watcher_to_issue(issue, assignee)
-    return if assignee.nil? || !assignee.is_a?(User) || assignee.anonymous? || !assignee.active?
+    return if assignee.nil? || !assignee.is_a?(User) || assignee.anonymous? || !assignee.active? || assignee == issue.author

     issue.add_watcher(assignee) unless issue.watched_by?(assignee)
   end

hello lucky boy and Anton Koptsev!
Thanks for your input. Anton still has not acknowledged Lukes PullRequest [1] on github and I think this is a good thing. Because the creator of the issue is not added anymore. This is, however, wanted. I still dont know what the actual problem is. Errormessage is "Watchers is invalid" altough I dont see any errors in the log? Overmore the errormessage has no meaning - issue is still created and watchers are correctly set - still works if that issue gets a new owner - plugin works flawlessly except for that misleading error message.

Kind Regards,
Matt

PS: would still be great if that feature would be moved into redmine itself

[1]
https://github.com/PewPewMeowMeow/redmine_auto_watch/pull/1

Matt V wrote:

hello lucky boy and Anton Koptsev!
Thanks for your input. Anton still has not acknowledged Lukes PullRequest [1] on github and I think this is a good thing. Because the creator of the issue is not added anymore. This is, however, wanted. I still dont know what the actual problem is. Errormessage is "Watchers is invalid" altough I dont see any errors in the log? Overmore the errormessage has no meaning - issue is still created and watchers are correctly set - still works if that issue gets a new owner - plugin works flawlessly except for that misleading error message.

Kind Regards,
Matt

PS: would still be great if that feature would be moved into redmine itself

[1]
https://github.com/PewPewMeowMeow/redmine_auto_watch/pull/1

Hello!
Today I check this plugin (with correction by Lucky Boy). Now all work perfect. Thank you!

hello!
have you tried adding a new issue and then check if you are subscribed to it? For me that wasnt the case. Lucky Boys request just omits that the creator is added to watchers which is bad.

I have the correct change: change issue.assigned_to to issue.assigned_to_id - this solved the problem for me. can you please recheck the behaviour i described - I was about to send you the correct pull request.

Kind Regards,
Matt

Matt V wrote:

hello!
have you tried adding a new issue and then check if you are subscribed to it? For me that wasnt the case. Lucky Boys request just omits that the creator is added to watchers which is bad.

I have the correct change: change issue.assigned_to to issue.assigned_to_id - this solved the problem for me. can you please recheck the behaviour i described - I was about to send you the correct pull request.

Kind Regards,
Matt

Your pull request solved my problem. Thank you!

hi anton!

great to hear. if you are satisfied with the change can you please dismiss lucky boys PR and accept mine? so that your master holds the correct change.
thank you guys

Here is how I solved this problem https://www.redmine.org/plugins/tw_watchers

+1 per behavior number 2

Marius BĂLTEANU wrote in #note-39:

1. Auto watch issues assigned to me: the assignee is automatically added to the list of watchers
2. Issues previous assigned to me: the previous assignee is added to the list of watchers

I prefer option 1: "Auto watch issues assigned to me".

I think this behavior is easier for most people to understand because when you become the assignee, you automatically become a watcher at the same time. Also, becoming a watcher together with becoming the assignee doesn't cause any problems from a notification perspective.

On the other hand, "Issues previous assigned to me" feels a bit confusing since you get added as a watcher only after you are no longer the assignee. It is also harder to explain this behavior clearly compared to option 1.

Given that, I don't see any significant advantage in option 2 despite its complexity.

I'm with Maeda-san here. The first option appears to be much clearer. It also helps to eventually be able to allow users to get notifications for only Watched issues while still emulating most of the "For things I watch (or which I created) or which are assigned to me" notification setting.

With that being said, what do you think about resolving groups and individually adding members who have the pref enabled? That would "settle" the list of users as watchers even if the group is changed later, but I think this could be part of this feature explicitly.

Finally, I think we need to explicitly check if the new assignee can currently see the issue before adding the user as a watcher and perform general checks. We can use the existing Issue#valid_watcher? method here which is provided by acts_as_watchable.

Feature added, users can now enable "Issues assigned to me" option in their account settings to be automatically added as a watcher when an issue is assigned to them.

Holger Just wrote in #note-42:

I'm with Maeda-san here. The first option appears to be much clearer. It also helps to eventually be able to allow users to get notifications for only Watched issues while still emulating most of the "For things I watch (or which I created) or which are assigned to me" notification setting.

With that being said, what do you think about resolving groups and individually adding members who have the pref enabled? That would "settle" the list of users as watchers even if the group is changed later, but I think this could be part of this feature explicitly.

Yes, that it is a good ideea and I agree that we should track it as another feature explicitly. Also, I think we should use delayed jobs to add them as watchers async.

Finally, I think we need to explicitly check if the new assignee can currently see the issue before adding the user as a watcher and perform general checks. We can use the existing Issue#valid_watcher? method here which is provided by acts_as_watchable.

Yes, I will improve the code in both cases.