Redmine

2018-02-26

22:39 Defect #5593: Grey out workflow checkboxes for transitions to the same status

Go MAEDA wrote:
> That makes sense. Do you mean like this?
Exactly.
Marius BĂLTEANU

10:41 Defect #5593: Grey out workflow checkboxes for transitions to the same status

Marius' suggestion is a neat additional improvement. It coherently presents the current implementation but lets room ... Bernhard Rohloff

01:29 Defect #5593: Grey out workflow checkboxes for transitions to the same status

Marius BALTEANU wrote:
> I'm wondering if is better to show a disabled checked checkbox instead of "-" in order to m... Go MAEDA

22:34 Feature #12704: Allow selecting subprojects on new issue form

Indeed, I missed the tests updates for Rails 5.1 in my previous patch.
I'm attaching now the updated patch which i... Marius BĂLTEANU

06:06 Feature #12704 (Needs feedback): Allow selecting subprojects on new issue form

Marius, I had to change your code slightly in order to run @test/functional/issues_controller_test.rb@. Could you rev... Go MAEDA

13:08 Patch #28242 (Closed): Add toggle checkboxes link (green tick) to several screens

Committed the patches. Thank you for your contribution. Go MAEDA

01:08 Patch #28242: Add toggle checkboxes link (green tick) to several screens

Thank you for extracting these patches from #27807.
LGTM, setting target version to 4.1.0. Go MAEDA

11:35 Feature #28247 (Closed): Upgrade Rails versions

* Trunk should be updated to Rails 5.1.5, which was "released on 2018-02-14":http://weblog.rubyonrails.org/2018/2/14/... Mischa The Evil

10:43 Defect #14846: Calculation of the start date of following issues ignores the "non-working days" setting

I have updated the patch for the current trunk (r17212).
Setting target version to 4.0.0. Go MAEDA

09:34 Feature #27672: Show selected columns in gantt chart

This is a very interesting patch.
But I found that selected columns cannot be saved in a custom query. The behavio... Go MAEDA

09:04 Feature #4138: Add spent time comments in search

Marius BALTEANU wrote:
> @Mischa, do you have the time to update your patch in order to apply cleanly on the current... Mischa The Evil

07:58 Feature #13947 (Closed): Add spent time issue list filter

Yes. Thanks. Btw: little effort for me to do it myself while posting this... ;) Mischa The Evil

2018-02-25

20:46 Defect #28243 (Closed): Principal.not_member_of scope does not accept ActiveRecord::Relation

Principal model has the following two scopes: member_of and not_member_of, both of them expect project or collection ... Anonymous

17:58 Feature #4138: Add spent time comments in search

+1
Having the possibility to search in spent time comments will be very useful.
@Mischa, do you have the time to ... Marius BĂLTEANU

17:48 Feature #13947 (Needs feedback): Add spent time issue list filter

Mischa, can I close this ticket in favour of #26826 which has a patch and was prioritized in version:"4.1.0"? Marius BĂLTEANU

17:41 Feature #25578 (Closed): Import spent time

Closing this one in favour of #28234 which has more details and patches proposed. Marius BĂLTEANU

17:34 Defect #1662 (Closed): Issue's custom fields don't appear on some filters and custom queries editor

Works as expected:
Custom fields:
!custom_fields.png!
Available filters in global issues page:
!custom_fields... Marius BĂLTEANU

17:27 Defect #1495 (Closed): Queries on versions don't work globally

Works as expected:
!issues_without_target_version.png! Marius BĂLTEANU

17:20 Defect #17302 (Closed): Forwarding from issues time entries page to project time entries page

I'm closing this issue from 2 reasons:
- I tried again and it works as expected
- Lack of feedback. Marius BĂLTEANU

17:12 Defect #5538 (Closed): Default 'my page' widgets lost after adding first widget.

I'm closing this issue because "My page" was refactorized in version:"3.4.0" and "Personalize" mode doesn't exists an... Marius BĂLTEANU

17:04 Defect #5593: Grey out workflow checkboxes for transitions to the same status

Reading the tickets and comments from the related issue (#16364) where some users request the "force status transitio... Marius BĂLTEANU

16:47 Defect #5593: Grey out workflow checkboxes for transitions to the same status

+1
Attached is a patch that fixes an existing failing test and adds a test for Go Maeda's patch. Marius BĂLTEANU

12:04 Defect #5593: Grey out workflow checkboxes for transitions to the same status

+1
This patch also provides great reference points within the checkbox matrix. Bernhard Rohloff

08:12 Defect #5593: Grey out workflow checkboxes for transitions to the same status

Updated the patch for the current trunk.
*Before:*
!{width: 756px}.5593-before@2x.png!
*After:*
!{width: 756p... Go MAEDA

15:54 Patch #27807: Use a unique way to check/uncheck a group/fieldset with checkboxes

I've moved the patches that add the toggle checkboxes feature (the green tick) to several screens to this ticket (#28... Marius BĂLTEANU

07:30 Patch #27807: Use a unique way to check/uncheck a group/fieldset with checkboxes

I agree to fix the problem that green tick icons are missing on some pages.
But I am worried that patch 0005 and 0... Go MAEDA

15:52 Patch #28242 (Closed): Add toggle checkboxes link (green tick) to several screens

- Active activities from Time tracking tab (Project settings)
- Trackers and custom fields settings from Issues trac... Marius BĂLTEANU

03:41 Defect #28240: Issue parents are getting set incorrectly

Tomoko Shimizu wrote:
> * Redmine 3.2
I'd first suggest to update to the current release branch, 3.4.x. As Toshi... Mischa The Evil

03:24 Patch #28138: Add link to add a new issue on the version page

I'm just reading along – visually scanning the patches, while being aware of #5005. Nevertheless, I wanted to drop a ... Mischa The Evil

2018-02-24

10:35 Defect #12510: Issues PDF export: Spent time/Float-values aren't rounded to 2 digits

A fix for issues_pdf_test was submitted as #28233. I committed the fix in r17212. Go MAEDA

10:29 Defect #28233 (Closed): IssuesPdfHelperTest fails when run in isolation

Committed as r17212. Thank you. Go MAEDA

07:50 Defect #28240 (New): Issue parents are getting set incorrectly

It is same as Defect #27066.
---
When adding and saving a sub issue under a parent issue, the subtask appear unde... Tomoko Shimizu

05:33 Patch #28138: Add link to add a new issue on the version page

I really like this improvement. In fact, I posted a similar patch #5005#note-6 years ago.
But I noticed that the "... Go MAEDA

04:52 Defect #28160: Misleading russian translation for "Log time" button

I made a patch file from Roman Yagodin's post. I would like Russian people to review this change. Go MAEDA

04:31 Patch #28229 (Closed): Remove unused i18n key "setting_app_subtitle"

Committed. Go MAEDA

01:09 Defect #28239 (Closed): redmine3.3: issue charts plugins install successed - Error Loading Chart: No adapter found

We don't provide plugin support here. Please use the forum#3 forum for such questions or contact the plugin author di... Mischa The Evil

01:09 Defect #28238 (Closed): redmine3.3: issue charts - Error Loading Chart: No adapter found

We don't provide plugin support here. Please use the forum#3 forum for such questions or contact the plugin author di... Mischa The Evil

00:51 Feature #28234: Add CSV Import for Time Entries

Thanks for sharing this, Gregor. I really like these patches (especially the first one).
I'd target this issue again... Mischa The Evil

00:42 Feature #28085: Wiki Toolbar on Full Width Custom Fields

I'll attach the same patch, but renamed so that it is recognized by Redmine as a patch (which will ease the review pr... Mischa The Evil

00:31 Feature #28237 (Closed): Add label next to the markers in the Gantt

Support is not provided through issues. Please hop over to the forum#4 forum and ask for support there.
I'll close... Mischa The Evil