Redmine

2019-10-01

19:51 Patch #29216: Replace the searchbox label in the header with a placeholder

I've tried Marius's patch and it works very nice. IMHO this would be a nice improvement. LGTM! Bernhard Rohloff

18:03 Patch #29216: Replace the searchbox label in the header with a placeholder

Also, switching to a search input field, it'll add the nice clear input icon (HTML 5 feature).
!x_icon.png! Marius BĂLTEANU

18:00 Patch #29216: Replace the searchbox label in the header with a placeholder

What about of using the same search input available for mobile version, but with the magnifier icon clickable?
Non... Marius BĂLTEANU

10:50 Feature #32178 (New): Conditioned Custom Fields

Dear all,
is it possible to create conditioned custom fields, which pop-up only, if a first custom field is answer... Tina M.

10:28 Defect #32168: Allow issue id with "#" prefix for the value of issue ids filter

Accepted to input with "#" prefix even in "Issue" filter.
I attached a patch.
Yuichi HARADA

07:07 Revision 18578 (svn): fix Redmine::Themes#scan_themes is not private

Toshi MARUYAMA

07:07 Revision 18577 (svn): fix Watcher#prune_single_user is not private

Toshi MARUYAMA

05:49 Feature #18043 (Closed): Links to anchors inside the page should be pagename-independent

The feature has been delivered in Redmine 4.0.0 (#16313). Go MAEDA

05:20 Defect #24008 (Closed): Remove 'Copied from' / 'Copied to' relationship between issues

Go MAEDA

05:18 Revision 18576 (svn): Update RuboCop to 0.75.0 (#31509).

Go MAEDA

04:48 Defect #24160 (Closed): Gantt diagram returns internal error

Go MAEDA

2019-09-30

20:14 Feature #31322: Provide a way to automatically close all open subtasks too when a parent issue is being closed

@$ LC_ALL=en_US.UTF-8 firefox@
!POC.png! Toshi MARUYAMA

20:01 Feature #31322: Provide a way to automatically close all open subtasks too when a parent issue is being closed

Simplified. Toshi MARUYAMA

19:51 Feature #31322: Provide a way to automatically close all open subtasks too when a parent issue is being closed

This is POC.
There is no test.
You need apply #28492 patch first. Toshi MARUYAMA

18:18 Feature #31353: Replace user related links in the top menu bar with a proper user menu.

By the way...
... *display:block;* and *padding:0;* on the avatar link aligns it vertically with the rest. ;-)
<p... Bernhard Rohloff

18:13 Feature #31353: Replace user related links in the top menu bar with a proper user menu.

Go MAEDA wrote:
> Thank you for writing the patch. I have some requests:
>
> * Change the link text name to "Prof... Bernhard Rohloff

13:24 Feature #31353: Replace user related links in the top menu bar with a proper user menu.

Go MAEDA wrote:
> Perhaps we can study from Planio, a Redmine based online service. Planio already has account drop-... Anonymous

04:05 Feature #31353: Replace user related links in the top menu bar with a proper user menu.

Perhaps we can study from Planio, a Redmine based online service. Planio already has account drop-down.
!{width: 4... Go MAEDA

03:49 Feature #31353: Replace user related links in the top menu bar with a proper user menu.

Thank you for writing the patch. I have some requests:
* Change the link text name to "Profile" (@label_profile@).... Go MAEDA

17:27 Feature #32029: Replace gantt and calendar tooltips with jquery tooltips

Marius BALTEANU wrote:
> Nice job! I will help you with this. Also, we should preserve the white background for thes... Anonymous

16:24 Feature #16098: On relation change/add notification setting

Setting the target version to 4.2.0. Go MAEDA

15:39 Revision 18575 (svn): Merged r18569 from trunk to 3.4-stable

fix duplicate name of IssuesControllerTest#test_bulk_copy_should_allow_copying_the_subtasks Toshi MARUYAMA

15:37 Revision 18574 (svn): Merged r18569 from trunk to 4.0-stable

fix duplicate name of IssuesControllerTest#test_bulk_copy_should_allow_copying_the_subtasks Toshi MARUYAMA

15:36 Revision 18573 (svn): 4.0-stable: add missing fixture added in trunk r17725

Toshi MARUYAMA

15:31 Feature #32169 (Closed): Add links to the detailed Wiki formatting help in Quick Reference

Committed the patch. Go MAEDA

00:26 Feature #32169: Add links to the detailed Wiki formatting help in Quick Reference

Setting the target version to 4.1.0. Go MAEDA

15:31 Revision 18572 (svn): Fix wrong markup in public/help/ja/wiki_syntax_detailed_(markdown|textile).html (#32169).

Patch by Go MAEDA. Go MAEDA

15:28 Revision 18571 (svn): Add links to the detailed Wiki formatting help in Quick Reference (#32169).

Patch by Go MAEDA. Go MAEDA

15:16 Feature #31879 (Closed): "starts with" and "ends with" filter operators for string values

Yuichi HARADA wrote:
> I added "starts with" and "ends with" filter operators to File filter, but didn't create an i... Go MAEDA

10:26 Feature #31879 (Reopened): "starts with" and "ends with" filter operators for string values

Go MAEDA

10:21 Feature #31879: "starts with" and "ends with" filter operators for string values

I added "starts with" and "ends with" filter operators to File filter, but didn't create an implementation.
I create... Yuichi HARADA

15:15 Revision 18570 (svn): Add support for "start with" and "end with" operators to "Files" filter (#31879).

Patch by Yuichi HARADA. Go MAEDA

14:47 Revision 18569 (svn): fix duplicate name of IssuesControllerTest#test_bulk_copy_should_allow_copying_the_subtasks

Toshi MARUYAMA

14:32 Defect #32176 (Closed): Emails are not getting triggered

When we create a new ticket and update existing one emails are not getting triggered. Kindly help as we have to manua... Prashant Chavan

13:42 Revision 18568 (svn): rubocop: remove app/models/issue.rb from Layout/ElseAlignment fixed by previous revisions

Toshi MARUYAMA

13:42 Revision 18567 (svn): code cleanup: rubocop: fix Layout/ElseAlignment in Issue class total_spent_hours method

Toshi MARUYAMA

13:42 Revision 18566 (svn): code cleanup: rubocop: fix Layout/ElseAlignment in Issue class visible? method

Toshi MARUYAMA

13:42 Revision 18565 (svn): code cleanup: rubocop: fix Layout/ElseAlignment in Issue class visible_condition method

Toshi MARUYAMA

13:42 Revision 18564 (svn): code cleanup: rubocop: fix Layout/EmptyLineBetweenDefs in app/helpers/application_helper.rb

Toshi MARUYAMA

13:40 Defect #32153: Repository browser does not render previews for audio/video files

Go MAEDA wrote:
> Attaching a quick-and-dirty workaround.
Thanks :-)
I'll share more feedback after I test it if I... Anonymous

12:59 Revision 18563 (svn): rubocop: remove test/integration/api_test/issues_test.rb from Layout/IndentationConsistency fixed by previous revisions

Toshi MARUYAMA

12:59 Revision 18562 (svn): code cleanup: rubocop: fix Layout/IndentHeredoc in test/integration/api_test/issues_test.rb

Toshi MARUYAMA

12:58 Revision 18561 (svn): code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in test/integration/api_test/issues_test.rb

Toshi MARUYAMA

12:58 Revision 18560 (svn): rubocop: remove app/models/attachment.rb from Layout/EmptyLineBetweenDefs fixed by r18558

Toshi MARUYAMA

11:51 Feature #7360: Issue custom query: default query per instance, project and user

+1
Is this patch workable on 4.0.4 ? Because "redmine_default_custom_query" is conflict with DMSF. So I am seeking a... Ryoji Takeuchi

11:00 Revision 18559 (svn): code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in app/models/setting.rb

Toshi MARUYAMA

10:59 Revision 18558 (svn): code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in app/models/attachment.rb

Toshi MARUYAMA

10:59 Revision 18557 (svn): code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in app/helpers/application_helper.rb

Toshi MARUYAMA

10:59 Revision 18556 (svn): code cleanup: rubocop: fix Layout/MultilineBlockLayout in app/models/issue.rb

Toshi MARUYAMA

10:59 Revision 18555 (svn): code cleanup: rubocop: fix Layout/EmptyLinesAroundBlockBody in test/unit/changeset_test.rb

Toshi MARUYAMA

09:42 Defect #32172: Warning "constant Loofah::HTML5::WhiteList is deprecated"

The fix has already merged to master before I filed an issue.
https://github.com/rails/rails-html-sanitizer/pull/100 Go MAEDA

05:18 Defect #32172: Warning "constant Loofah::HTML5::WhiteList is deprecated"

Reported the issue to the rails-html-sanitizer team.
https://github.com/rails/rails-html-sanitizer/issues/101 Go MAEDA

01:45 Defect #32172: Warning "constant Loofah::HTML5::WhiteList is deprecated"

I observed this after loofah was updated from 2.2.3 to 2.3.0. Go MAEDA

01:38 Defect #32172 (Closed): Warning "constant Loofah::HTML5::WhiteList is deprecated"

... Go MAEDA

04:44 Revision 18554 (svn): code cleanup: rubocop: fix Layout/LeadingCommentSpace in test/unit/issue_test.rb

Toshi MARUYAMA

04:44 Revision 18553 (svn): code cleanup: rubocop: fix Layout/LeadingCommentSpace in test/integration/api_test/issues_test.rb

Toshi MARUYAMA

04:23 Revision 18552 (svn): add test "removing issue shows confirm dialog"

Toshi MARUYAMA

04:23 Revision 18551 (svn): remove extra space from app/views/issues/_edit.html.erb

Toshi MARUYAMA

02:29 Defect #32170 (Resolved): Text enclosed in pre tag in Wiki formatting reference is not displayed in monospaced font in Chrome

Committed the patch. Go MAEDA

00:26 Defect #32170: Text enclosed in pre tag in Wiki formatting reference is not displayed in monospaced font in Chrome

Setting the target version to 4.1.0. Go MAEDA

02:28 Revision 18550 (svn): Text enclosed in pre tag in Wiki formatting reference is not displayed in a monospaced font in Chrome (#32170).

Patch by Go MAEDA. Go MAEDA

2019-09-29

16:05 Feature #31353: Replace user related links in the top menu bar with a proper user menu.

Marius BALTEANU wrote:
> Bernhard, Antonio, I've reworked the entire patch, you can use the new one for testing. It'... Anonymous

14:54 Feature #31353: Replace user related links in the top menu bar with a proper user menu.

Bernhard, Antonio, I've reworked the entire patch, you can use the new one for testing. It's more complete, but it st... Marius BĂLTEANU

09:01 Feature #31353: Replace user related links in the top menu bar with a proper user menu.

Version 2 FTW! This search bar in the header annoys me as hell.
I've tried your patch and looked nice already. One t... Bernhard Rohloff

04:35 Feature #31353: Replace user related links in the top menu bar with a proper user menu.

Marius BALTEANU wrote:
> I made some progress and I would like to share two screenshots
I am all for the second imp... Anonymous

04:35 Feature #31353: Replace user related links in the top menu bar with a proper user menu.

Edit: _deleted, because dupe_ Anonymous

15:07 Defect #32170 (Closed): Text enclosed in pre tag in Wiki formatting reference is not displayed in monospaced font in Chrome

This is related to #20372, should have been fixed together with it.
*Before:*
!{width: 250px; border: 1px solid #... Go MAEDA

12:43 Feature #32169 (Closed): Add links to the detailed Wiki formatting help in Quick Reference

The attached patch adds links to the detailed Wiki formatting help in Quick Reference.
Currently, there is only on... Go MAEDA

03:27 Defect #32168 (New): Allow issue id with "#" prefix for the value of issue ids filter

I found an inconsistent behavior regarding issues filter.
"Parent task" and "Subtasks" filter accept issue ids wit... Go MAEDA

02:04 Feature #25540 (Closed): Unify fields of subtasks and related issues on issue page

Committed the patch. Thank you all for your contribution. Go MAEDA

02:03 Revision 18549 (svn): Unify fields of subtasks and related issues on issue page (#25540).

Patch by Takenori TAKAKI. Go MAEDA

01:50 Patch #31147 (Closed): Add custom styles for all fields

Marius BALTEANU wrote:
> We should make the disabled fields more obvious using the below patch:
Committed the fix... Go MAEDA

01:50 Revision 18548 (svn): Make the disabled fields more obvious (#31147).

Patch by Marius BALTEANU. Go MAEDA