Project

General

Profile

Activity

From 2017-08-17 to 2017-08-19

2017-08-19

07:54 Patch #26721: use find_by instead of detect
Please don't use "Defect" tracker for *not* defect.
Please use code highlighting in description. It is too hard to read.
Toshi MARUYAMA
05:27 Patch #26721: use find_by instead of detect
same situation for copy_issues jwjw yy
05:01 Patch #26721 (Closed): use find_by instead of detect
In project.rb jwjw yy
02:40 Defect #26699: Anonymous user should have their icon
I think it is problematic that an assignee's icon looks like an author's icon in Redmine 3.4 when the issue's author is an anonymous user.
I suggest including this fix in 3.4.3.
Go MAEDA

2017-08-18

22:51 Patch #10702: Change "Create and Continue" translation to "Create and add another"
For me and for our users, the "Create and continue" call to action is very vague and sends an unclear message because it can be interpreted also, for example, as "continue on the issue page". We made some research internally and we conc... Marius BĂLTEANU
19:50 Patch #26714 (New): pluck instead of map in issue_query
Toshi MARUYAMA
19:01 Patch #26714 (Resolved): pluck instead of map in issue_query
jwjw yy
05:54 Patch #26714 (New): pluck instead of map in issue_query
pluck(:id) in IssueQuery#version_ids is missing.
Toshi MARUYAMA
10:29 Feature #1565: Custom query on My page
I just stumbled over that 3 custom query limit too. I would very much like to use more queries :( Martin von Wittich
03:08 Defect #26537: Column Project is not longer added by default to the list of default columns for time entries
LGTM. Setting target version to 4.0.0.
Thank you for fixing this issue.
Go MAEDA

2017-08-17

23:21 Patch #26714: pluck instead of map in issue_query
done jwjw yy
09:44 Patch #26714 (Needs feedback): pluck instead of map in issue_query
I think your IssueQuery#versions_for_id is named IssueQuery#version_ids and pluck(:id) is in it for consistency.
source:tags/3.4.2/app/models/issue_query.rb#L310
Please add ".diff" in your patch file name and remove commented lines f...
Toshi MARUYAMA
08:30 Patch #26714 (Closed): pluck instead of map in issue_query
The previous issue_query.rb, line 438 version_ids = versions(:conditions => [where]).map(&:id) will issue query as: jwjw yy
14:14 Defect #24864: svn.redmine.org: "The certificate is not issued by a trusted authority"
The certificate itself is fine and valid. However, it appears that the server for https://svn.redmine.org does not send along the required intermediate certificates to allow clients to verify the full certificate chain as shown in Toshi'... Holger Just
10:28 Feature #26409: Show assignee on gantt
Marius BALTEANU wrote:
> …
> ...
Thank you for your advice.
I changed patch as follows:
Mizuki ISHIKAWA
06:05 Patch #26711: Use pluck instead of collect/map
Go MAEDA
05:03 Patch #26711 (Closed): Use pluck instead of collect/map
In app/helpers/my_helpers,
68: where(:project_id => User.current.projects.map(&:id)).
Use pluck to get the id is much more efficient, since the query will only access the id field, instead of select * from projects:
Before:
SELE...
jwjw yy
01:26 Feature #26709 (Closed): Use correct http status codes
1/ redmine ignores accept headers and jquery dataType attribute
The Accept request-header field can be used to specify certain media types which are acceptable for the response.
If no Accept header field is present, then it is assu...
Pavel Rosický
 

Also available in: Atom