Project

General

Profile

Activity

From 2019-09-27 to 2019-09-29

2019-09-29

16:05 Feature #31353: Replace user related links in the top menu bar with a proper user menu.
Marius BALTEANU wrote:
> Bernhard, Antonio, I've reworked the entire patch, you can use the new one for testing. It's more complete, but it still need some work to improve the code and of course, fixes. I've tested only one Chrome.
> ....
Anonymous
14:54 Feature #31353: Replace user related links in the top menu bar with a proper user menu.
Bernhard, Antonio, I've reworked the entire patch, you can use the new one for testing. It's more complete, but it still need some work to improve the code and of course, fixes. I've tested only one Chrome.
All 3 proposals were been i...
Marius BĂLTEANU
09:01 Feature #31353: Replace user related links in the top menu bar with a proper user menu.
Version 2 FTW! This search bar in the header annoys me as hell.
I've tried your patch and looked nice already. One thing I would like to change is the drop-down trigger. I'm used to trigger the drop-down menu on click rather then on hov...
Bernhard Rohloff
04:35 Feature #31353: Replace user related links in the top menu bar with a proper user menu.
Marius BALTEANU wrote:
> I made some progress and I would like to share two screenshots
I am all for the second implementation, so we could close #32115 but couple of cents from me:
- It feels like links on the left side are too small...
Anonymous
04:35 Feature #31353: Replace user related links in the top menu bar with a proper user menu.
Edit: _deleted, because dupe_ Anonymous
15:07 Defect #32170 (Closed): Text enclosed in pre tag in Wiki formatting reference is not displayed in monospaced font in Chrome
This is related to #20372, should have been fixed together with it.
*Before:*
!{width: 250px; border: 1px solid #ccc;}.before@2x.png!
*After:*
!{width: 250px; border: 1px solid #ccc;}.after@2x.png!
Go MAEDA
12:43 Feature #32169 (Closed): Add links to the detailed Wiki formatting help in Quick Reference
The attached patch adds links to the detailed Wiki formatting help in Quick Reference.
Currently, there is only one link to the detailed help in Quick Reference. The link is placed at the bottom of the page, so it is not prominent. So...
Go MAEDA
03:27 Defect #32168 (New): Allow issue id with "#" prefix for the value of issue ids filter
I found an inconsistent behavior regarding issues filter.
"Parent task" and "Subtasks" filter accept issue ids with "#" prefix (e.g. !#123), however, "Issues" filter does not. I think "Issues" filter should also behave the same.
|_...
Go MAEDA
02:04 Feature #25540 (Closed): Unify fields of subtasks and related issues on issue page
Committed the patch. Thank you all for your contribution. Go MAEDA
02:03 Revision 18549 (svn): Unify fields of subtasks and related issues on issue page (#25540).
Patch by Takenori TAKAKI. Go MAEDA
01:50 Patch #31147 (Closed): Add custom styles for all fields
Marius BALTEANU wrote:
> We should make the disabled fields more obvious using the below patch:
Committed the fix in r18548. Thank you.
Go MAEDA
01:50 Revision 18548 (svn): Make the disabled fields more obvious (#31147).
Patch by Marius BALTEANU. Go MAEDA

2019-09-28

23:08 Feature #31353: Replace user related links in the top menu bar with a proper user menu.
I made some progress and I would like to share two screenshots:
1. Move only user related links under a user dropdown:
!user_dropdown.png!
2. Move search and project jump box to top menu:
!search_and_jump_box_in_top_menu.png!
Marius BĂLTEANU
19:16 Patch #31147 (Reopened): Add custom styles for all fields
We should make the disabled fields more obvious using the below patch: Marius BĂLTEANU
19:08 Patch #31971 (Closed): Change the color of the input field frame when in focus
Marius BĂLTEANU
19:08 Patch #31971 (Reopened): Change the color of the input field frame when in focus
Go Maeda, Mizuki, is there any reason for why you chose to target each type of @input@ instead of using @input@? Marius BĂLTEANU
18:46 Feature #29482: Query system for Projects page
Dmitry Makurin wrote:
> According to the "current trunk":http://www.redmine.org/projects/redmine/repository/entry/trunk/app/helpers/projects_helper.rb#L62 you should probably change 'my project' icon
> ...
Thanks for pointing this out...
Marius BĂLTEANU
18:17 Defect #32167 (Closed): Inconsistent border coloring of UI elements?
- Table lists (list.table), Boxes (.box) and fieldsets (fieldset) border color is #e4e4e4
- Gantt (table.gantt-table) border color is #c0c0c0
- Calendar (table.cal) border color is #d7d7d7
- Separrator after tabs (#content .tabs ul), ...
Anonymous
16:22 Patch #32014: Rounded corners on table.list elements
Go MAEDA wrote:
> I will revert this change because the change caused other changes such as #32165 and #32166 and I cannot predict how much the impact will spread further.
#32165 and #32166 would be the last patches for the tables anyw...
Anonymous
15:48 Patch #32014 (Reopened): Rounded corners on table.list elements
I will revert this change because the change caused other changes such as #32165 and #32166 and I cannot predict how much the impact will spread further. Go MAEDA
02:07 Patch #32014 (Closed): Rounded corners on table.list elements
Committed the patch. Thank you for improving Redmine. Go MAEDA
14:52 Patch #26030: Like issues and news comments, want to specify the display order of the forum's reply.
Opps, Thank you for checking my patch. I've removed the duplicated @MessageTest@.
Popoki Tom (@cat_in_136)
14:42 Patch #32166 (New): Rounded corners on table.gantt-table
This patch is a follow up to #32014 to add 3px border-radius to gantt table. Anonymous
14:40 Patch #32165 (Closed): Rounded corners on table.cal
This patch is a follow up to #32014 to add 3px border-radius to calendar table. Anonymous
14:07 Feature #25540: Unify fields of subtasks and related issues on issue page
Looks good to me and it's a useful improvement until we make these columns configurable in the admin. Marius BĂLTEANU
13:52 Feature #29752 (Needs feedback): Render Textile and Markdown attachments on the preview page
The patch looks good to me with one small observation, do you see any problem if we add @'text/textile' => 'textile'@ to @MIME_TYPES@? In this way, we can replace in the patch @self.filename =~ /\.(textile)$/i@ with @Redmine::MimeType.o... Marius BĂLTEANU
13:41 Patch #32162: Improved progress bars for issues and versions
I think I like rounded one better :D Maybe 25% border radius would also look quite cool.
We should probably add #32016 as related, so we could remember to close it later as well, in case rounded version of the bar in this patch will be ...
Anonymous
10:51 Patch #32162: Improved progress bars for issues and versions
Antonio McDeal wrote:
> +1 :D
> ...
A 50% border radius looks not too bad either. :-)
!{border: 1px solid grey;}round-progress-bars.png!
Bernhard Rohloff
13:13 Feature #31505: Mark edited journal notes as "Edited"
Updated to apply cleanly on the current trunk. Marius BĂLTEANU
12:19 Feature #1237: Add support for two-factor authentication
Go MAEDA wrote:
> Two-factor authentication is becoming a must-have feature nowadays. Thanks to Planio, now there is a complete and ready-to-commit patch with test code.
> ...
Totally agree with you regarding the need for this feature....
Marius BĂLTEANU
10:33 Feature #1237 (New): Add support for two-factor authentication
Two-factor authentication is becoming a must-have feature nowadays. Thanks to Planio, now there is a complete and ready-to-commit patch with test code.
I think it is the time to commit the patch. Setting the target version to 4.1.0.
Go MAEDA
08:46 Feature #1237: Add support for two-factor authentication
I have slightly fixed two of the four patches to apply to the latest trunk, r18547. You can add two-factor authentication by applying the following patches.
* attachment:0001-adds-two-factor-authentication-support-r18547.patch (update...
Go MAEDA
04:53 Patch #32145 (Resolved): Update locales for Vietnamese
Closed Enziin System
04:53 Patch #32163 (Closed): Update locales for Vietnamese
Update locales for Vietnamese Enziin System
02:06 Revision 18547 (svn): Rounded corners on table.list elements (#32014).
Patch by Antonio McDeal. Go MAEDA

2019-09-27

20:50 Patch #32162: Improved progress bars for issues and versions
+1 :D
Do you think also having rounded corners edition could be good too? ;-)
Anonymous
17:58 Patch #32162 (New): Improved progress bars for issues and versions
This patch implements an improved and more versatile version of the bar graphs shown for version and issue progress.
Despite the existing solution it's less restricted to a specific purpose. It's not limited to two stacked bars only and...
Bernhard Rohloff
20:46 Patch #32014: Rounded corners on table.list elements
Bernhard Rohloff wrote:
> Maybe an additional @overflow: hidden;@ is missing here.
Not that it's a biggie, as our border radius doesn't seem to be that big anyway, for cells under to stick out, it's only 3px after all, but here is the ...
Anonymous
17:26 Patch #32014: Rounded corners on table.list elements
Yes, as Antonio wrote, it's necessary to get the border radius and @border-spacing: 0;@ compensates it.
One notice of caution: I played with the border radius and found out that the cells don't get clipped to the round shape. Maybe an a...
Bernhard Rohloff
17:03 Patch #32014: Rounded corners on table.list elements
Go, roundness with *border-radius* on table elements can't seem to be achieved if *border-collapse: collapse;* is present, so I cleared it in a favor of *border-spacing: 0;* for this reason, which it did seem like does the same thing, on... Anonymous
16:45 Patch #32014: Rounded corners on table.list elements
The patch removes @border-collapse@ property. Do you think it is OK? (sorry if this is a stupid question. I am not a CSS expert). Go MAEDA
18:22 Patch #26122 (Resolved): Implementation of visible conditions with inner join instead of subselect
no, I agree. Thanks for the feedback, this can be closed. Pavel Rosický
17:34 Patch #26122: Implementation of visible conditions with inner join instead of subselect
Pavel Rosický wrote:
> Well, it havily depends on what filters and other conditions are used, it isn't easy to measure. For my long time observations using INNER JOINS is slightly faster (especially on big tables like issues) and mysql ...
Marius BĂLTEANU
17:19 Patch #32106: Slightly restyled ajax loading indicator
If we would still like to keep it in the center as is now, here is the alternative patch which at least removes unnecessary percent based width.
!alternative-loading.png!
Anonymous
11:38 Patch #31598 (Closed): Move the links (All time entries, Import) from Spent time section of the spent time list sidebar under a dropdown
Committed the patch. Thank you. Go MAEDA
11:38 Revision 18546 (svn): Move the links (All time entries, Import) from Spent time section of the spent time list sidebar under a dropdown (#31598).
Patch by Marius BALTEANU. Go MAEDA
10:40 Defect #29838: Time logging via commit message does not work when the configured activity has been overridden on the project level
Removing from 4.1.0 because the test fails. Go MAEDA
07:18 Defect #32156: No left padding for first level entries in discussion board list
Adding the fixed one now :)
Edit: actually, I already came up with even better alternative for this, and it could be bare CSS indentation with minor changes to the view, I'll post another version some time next week.
Anonymous
06:30 Defect #32156: No left padding for first level entries in discussion board list
Edit: don't review it just yet, I overlooked the parent/child indentation, I will update the patch to fix this, to avoid hacky behavior like now. Anonymous
06:07 Defect #32156 (Closed): No left padding for first level entries in discussion board list
The left padding of the table rows is hard-coded to create a tree structure through indentation. The current solution is unfortunate as it adds no padding to the first level (level-0) but overrides padding rules from *table.list td* in t... Anonymous
03:30 Revision 18545 (svn): Add "Highlighted code" section in Wiki Syntax Quick Reference (#32123).
Patch by Go MAEDA. Go MAEDA
03:29 Feature #32123 (Closed): Add "Highlighted code" section in Wiki Syntax Quick Reference
Committed the patch. Go MAEDA
 

Also available in: Atom