Redmine

2020-01-27

23:09 Defect #32896: Totals not working in projects list view

Here is the fix with a test. Thanks for detecting the issue. All tests "pass":https://gitlab.com/redmine-org/redmine/... Marius BĂLTEANU

17:46 Defect #32896 (Confirmed): Totals not working in projects list view

Marius BĂLTEANU

16:29 Defect #32896 (Closed): Totals not working in projects list view

Projects list view that was introduced in Redmine 4.1.0 has "Totals" checkboxes if numeric custom fields are defined ... Go MAEDA

23:07 Defect #32897 (Closed): Rails 6: Pass `case_sensitive: true` option explicitly to the uniqueness validator

Rails 6 displays deprecation warning for uniqueness validator:... Marius BĂLTEANU

18:00 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading

Go MAEDA wrote:
> I started work on this issue.
>
> Here is the very first version of the work-in-progress patch ... Marius BĂLTEANU

05:31 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading

I started work on this issue.
Here is the very first version of the work-in-progress patch but there are still man... Go MAEDA

17:19 Feature #21950: API Metadata

Is there any chance that this could be implemented sometime in the future?
How can it be solved?
By adding specs ... Mikhail Mikhaylov

15:02 Patch #32841 (Closed): Drop support for Bundler prior to 1.12.0

Committed the patch. Go MAEDA

11:10 Defect #32737: Duplicate sort keys for issue query cause SQL error with SQL Server

Maybe also this patch will work. Go MAEDA

09:58 Defect #32891: Bookmark link on project page should not use full path with hostname

I messed up with title a little bit. Bookmark link on project page. Dmitry Makurin

09:56 Defect #32891 (Closed): Bookmark link on project page should not use full path with hostname

Currently bookmark url creating with default protocol. If rails server setup with secure protocol bookmarks link stil... Dmitry Makurin

08:51 Patch #32835 (Closed): Make breadcrumbs of repository browser copy-paste friendly

Go MAEDA

08:43 Defect #32845: New line codes are not reflected in tables created in textile format.

Currently, <br> is not allowed in Redmine's Textile. Please try the following syntax instead.... Go MAEDA

08:26 Defect #32861: Strange issue tree after importing subtasks

Could you try the following command to fix the tree?... Go MAEDA

04:54 Patch #32886 (Closed): Rails 6: Use #media_type instead of #content_type to test the MIME type of a response

Committed the patch. Go MAEDA

01:01 Feature #32764: Make form validation errors more obvious for users

Here is the patch.
Mischa The Evil wrote:
> I think that would be a nice improvement indeed. Though I'm not sure ... Marius BĂLTEANU

00:46 Feature #22913: Auto-select fields mapping in Importing

Sorry for my late review on this.
My main concern with the proposed patch are the hardcoded fields from @mapping@ ... Marius BĂLTEANU

00:44 Patch #32890: Fix violations reported by Stylelint

Setting the target version to 4.2.0. Go MAEDA

00:28 Defect #32889: Responsive layout for issue tree and issue relation on issue page is broken

Setting the target version to 4.1.1. Go MAEDA

2020-01-26

23:10 Patch #32887 (Closed): Rails 6: Use "render template:" instead of "render file:" in app/views/layouts/admin.html.erb

Committed the patch. Go MAEDA

16:07 Patch #32887 (Closed): Rails 6: Use "render template:" instead of "render file:" in app/views/layouts/admin.html.erb

... Go MAEDA

22:06 Patch #32890 (Closed): Fix violations reported by Stylelint

Linting the CSS files using the rules proposed in #32888 generates the following violations:... Marius BĂLTEANU

21:59 Defect #32889: Responsive layout for issue tree and issue relation on issue page is broken

Until we decide how the fix should look, I'm attaching a patch that moves the hardcoded @width: 50%@ style from view ... Marius BĂLTEANU

21:48 Defect #32889: Responsive layout for issue tree and issue relation on issue page is broken

Marius BĂLTEANU

21:45 Defect #32889 (Closed): Responsive layout for issue tree and issue relation on issue page is broken

Unified fields of subtasks and related issues added by #25540 broke the responsive layout added in #21775.
Actual ... Marius BĂLTEANU

21:04 Patch #32888: Use stylelint to avoid errors and enforce conventions in CSS files

Updated the patch to ignore consecutive duplicated properties with different values in order to not trigger a violati... Marius BĂLTEANU

19:52 Patch #32888: Use stylelint to avoid errors and enforce conventions in CSS files

Running Stylelint over the existing CSS code from public folder, returns the following violations:... Marius BĂLTEANU

19:50 Patch #32888 (Closed): Use stylelint to avoid errors and enforce conventions in CSS files

In the last few months we had some cases when we added/fixed broken CSS code (ex: r18173, r18144, #32838). These type... Marius BĂLTEANU

15:40 Patch #32886 (Closed): Rails 6: Use #media_type instead of #content_type to test the MIME type of a response

Rails 6 displays deprecation warning if you use @@response.content_type@ to check the MIME type of the response.
... Go MAEDA

15:06 Defect #32859 (Closed): Issue list: long text custom field missing in PDF export

Committed the patch. Thank you. Go MAEDA

10:07 Defect #32885 (Closed): Rails 6: DEPRECATION WARNING: Single arity template handlers are deprecated

A deprecation warning "Single arity template handlers are deprecated" is shown in Rails 6.... Go MAEDA

05:45 Feature #3088: Estimated hours field able to hide role based

Now the patch cannot be applied cleanly. Go MAEDA

02:37 Patch #32841: Drop support for Bundler prior to 1.12.0

Go MAEDA wrote:
> I think #32788#note-7 is a better solution because it does not force admins to update bundler.
... Go MAEDA

02:17 Patch #32788 (Closed): Specify supported Ruby version in Gemfile and doc/INSTALL

Committed the fix described in #32788#note-7. Go MAEDA

2020-01-25

11:18 Defect #32859: Issue list: long text custom field missing in PDF export

Attached is the fix. I used the same logic from issue list to display the block columns instead of hardcoding each co... Marius BĂLTEANU

08:59 Defect #32859 (Confirmed): Issue list: long text custom field missing in PDF export

Marius BĂLTEANU

10:12 Patch #32835: Make breadcrumbs of repository browser copy-paste friendly

Committed the patch. Go MAEDA

09:39 Defect #32860: Invalid links to versions with sharing in project tree

Here is a test for this patch. This patch also correct link to shared version with hierarchy. Without this patch, ver... Alexander Meindl

08:55 Defect #32860: Invalid links to versions with sharing in project tree

Thanks for the patch. Can you add a test case for this scenario? Marius BĂLTEANU

06:26 Patch #32841: Drop support for Bundler prior to 1.12.0

I think #32788#note-7 is a better solution because it does not force admins to update bundler.
Removing the target... Go MAEDA

06:21 Patch #32788 (Reopened): Specify supported Ruby version in Gemfile and doc/INSTALL

The @ruby@ directive in Gemfile is supported by @bundler@ 1.12.0 or later. So, r19425 causes the following error when... Go MAEDA

04:09 Defect #32858 (Closed): Exporting issue as PDF fails when the issue has private journal

Committed the patch. Thank you for catching and fixing the issue. Go MAEDA

03:29 Defect #32839 (Closed): Redmine 4.1 installation fails due to an attempt to install sprockets 4.0.0 if bundler prior to 1.15.2 is used on Ruby prior to 2.5

Committed the fix.
Go MAEDA wrote:
> * Option 1: Raise the minimum required version of @bundler@ to 1.15.2 by upd... Go MAEDA