Activity
From 2020-01-26 to 2020-01-28
2020-01-28
-
23:39 Patch #32911 (Closed): Rails 6: Fix deprecation warning "Class level methods will no longer inherit scoping"
- fixes
-
23:17 Defect #32910 (Closed): Rails 6: add lookup_context to hook_test.rb
- fixes
-
23:03 Patch #32909 (Closed): Replace pluck().first with pick()
- https://github.com/rails/rails/pull/31941
-
22:56 Defect #32908 (Closed): Rails 6: Sending mail with DeliveryJob is deprecated
- this change isn't compatible with Rails < 6
#29914 -
22:51 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading
- Go MAEDA wrote:
>
> ...
Let's do it then. I've prepared "this":https://gitlab.com/redmine-org/redmine/pipelines/113081049 branch on my Gitlab CI instance, it should be easier to track the test fails.
As next steps, I propose to open ... -
14:57 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading
- +1 however I guess lot's of plugin developers will need to be notified and start their upgrades as well...
-
06:34 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading
- Marius BALTEANU wrote:
> I'm willing to help with this, but I think we should have first a decision (from Jean-Philippe, I guess) regarding next Redmine major version. If we're going to update to Rails 6, we should merge version 4.2.0 t... -
22:36 Defect #32897: Rails 6: Pass `case_sensitive: true` option explicitly to the uniqueness validator
- Here is the correct patch, please revert r19478 and commit this one.
-
10:55 Defect #32897 (Reopened): Rails 6: Pass `case_sensitive: true` option explicitly to the uniqueness validator
- Sorry, I've attached a broken patch, please revert it and will post later the correct one.
-
10:49 Defect #32897 (Closed): Rails 6: Pass `case_sensitive: true` option explicitly to the uniqueness validator
- Committed the patch. Thank you for your contribution.
-
10:19 Defect #32897: Rails 6: Pass `case_sensitive: true` option explicitly to the uniqueness validator
- Tests results "here":https://gitlab.com/redmine-org/redmine/pipelines/112841765.
-
22:24 Patch #32907 (Closed): Update capybara (~> 3.31.0)
- the patch reduces warnings for Ruby 2.7 support #31500
https://github.com/teamcapybara/capybara/blob/master/History.md -
21:59 Patch #32906 (Closed): Update i18n (~> 1.8.2)
- the patch reduces warnings for Ruby 2.7 support #31500
https://github.com/ruby-i18n/i18n/releases -
17:42 Feature #1712: add custom fields that are calculations of other fields
- +1
-
10:32 Patch #18770: Make issue history collapsable
- Can you update for Redmine 4
also, can you create normal patch, not hg one, because I'm getting: -
04:01 Patch #32890 (Closed): Fix violations reported by Stylelint
- Committed the patches. Thank you.
-
02:20 Defect #32896 (Closed): Totals not working in projects list view
-
02:18 Defect #32896: Totals not working in projects list view
- Committed the patch. Thank you for posting the patch so quickly.
-
01:34
Defect #32899 (Closed): Javascript error caused by tooltip
- Improved tooltip in Redmine 4.1.0 ( #31441) causes a Javascript error on some (self-made) plugin pages using the "title" attribute.
This is caused by the absence of the tooltip() function in the "title" attribute. By inserting a judgmen... -
01:32
Feature #32898 (Closed): PDF thumbnails support on Windows
- Redmine 4.1.0 don't support PDF thumbnails on Windows. ( #22481 )
For Windows, "gswin64c(32c).exe"(command line version) can be used instead of "gswin64(32).exe".
By applying this diff, we can detect the presence of Ghostscript on Wind...
2020-01-27
-
23:09 Defect #32896: Totals not working in projects list view
- Here is the fix with a test. Thanks for detecting the issue. All tests "pass":https://gitlab.com/redmine-org/redmine/pipelines/112740436.
-
17:46 Defect #32896 (Confirmed): Totals not working in projects list view
-
16:29 Defect #32896 (Closed): Totals not working in projects list view
- Projects list view that was introduced in Redmine 4.1.0 has "Totals" checkboxes if numeric custom fields are defined for projects. The total value of the custom fields is expected to be displayed when the checkbox is on, I think.
Howe... -
23:07 Defect #32897 (Closed): Rails 6: Pass `case_sensitive: true` option explicitly to the uniqueness validator
- Rails 6 displays deprecation warning for uniqueness validator:
-
18:00 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading
- Go MAEDA wrote:
> I started work on this issue.
> ...
I'm willing to help with this, but I think we should have first a decision (from Jean-Philippe, I guess) regarding next Redmine major version. If we're going to update to Rails 6, w... -
05:31 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading
- I started work on this issue.
Here is the very first version of the work-in-progress patch but there are still many errors. -
17:19 Feature #21950: API Metadata
- Is there any chance that this could be implemented sometime in the future?
How can it be solved?
By adding specs with "rswag":https://github.com/rswag/rswag?
I found a redmine's swagger on "github":https://github.com/komikoni/redm... -
15:02 Patch #32841 (Closed): Drop support for Bundler prior to 1.12.0
- Committed the patch.
-
11:10 Defect #32737: Duplicate sort keys for issue query cause SQL error with SQL Server
- Maybe also this patch will work.
-
09:58 Defect #32891: Bookmark link on project page should not use full path with hostname
- I messed up with title a little bit. Bookmark link on project page.
-
09:56 Defect #32891 (Closed): Bookmark link on project page should not use full path with hostname
- Currently bookmark url creating with default protocol. If rails server setup with secure protocol bookmarks link still creating with http.
Jquery raises error on that kind of links: -
08:51 Patch #32835 (Closed): Make breadcrumbs of repository browser copy-paste friendly
-
08:43 Defect #32845: New line codes are not reflected in tables created in textile format.
- Currently, <br> is not allowed in Redmine's Textile. Please try the following syntax instead.
-
08:26 Defect #32861: Strange issue tree after importing subtasks
- Could you try the following command to fix the tree?
-
04:54 Patch #32886 (Closed): Rails 6: Use #media_type instead of #content_type to test the MIME type of a response
- Committed the patch.
-
01:01 Feature #32764: Make form validation errors more obvious for users
- Here is the patch.
Mischa The Evil wrote:
> I think that would be a nice improvement indeed. Though I'm not sure if the field label should be changed too or if the highlighting of the actual field (border) itself is sufficient. We mi... -
00:46 Feature #22913: Auto-select fields mapping in Importing
- Sorry for my late review on this.
My main concern with the proposed patch are the hardcoded fields from @mapping@ method (@ImportsController@). Because of them, the "auto mapping" feature it won't be easily extended by plugins or othe... -
00:44 Patch #32890: Fix violations reported by Stylelint
- Setting the target version to 4.2.0.
-
00:28 Defect #32889: Responsive layout for issue tree and issue relation on issue page is broken
- Setting the target version to 4.1.1.
2020-01-26
-
23:10 Patch #32887 (Closed): Rails 6: Use "render template:" instead of "render file:" in app/views/layouts/admin.html.erb
- Committed the patch.
-
16:07 Patch #32887 (Closed): Rails 6: Use "render template:" instead of "render file:" in app/views/layouts/admin.html.erb
-
22:06 Patch #32890 (Closed): Fix violations reported by Stylelint
- Linting the CSS files using the rules proposed in #32888 generates the following violations:
-
21:59 Defect #32889: Responsive layout for issue tree and issue relation on issue page is broken
- Until we decide how the fix should look, I'm attaching a patch that moves the hardcoded @width: 50%@ style from view files to @application.css@ and changes some properties in @responsive.css@ in order to drop the @!important@ rule.
-
21:48 Defect #32889: Responsive layout for issue tree and issue relation on issue page is broken
-
21:45 Defect #32889 (Closed): Responsive layout for issue tree and issue relation on issue page is broken
- Unified fields of subtasks and related issues added by #25540 broke the responsive layout added in #21775.
Actual layout:
!{width:50%; border:1px solid grey}.relations.png! -
21:04 Patch #32888: Use stylelint to avoid errors and enforce conventions in CSS files
- Updated the patch to ignore consecutive duplicated properties with different values in order to not trigger a violation for the following case:
-
19:52 Patch #32888: Use stylelint to avoid errors and enforce conventions in CSS files
- Running Stylelint over the existing CSS code from public folder, returns the following violations:
-
19:50 Patch #32888 (Closed): Use stylelint to avoid errors and enforce conventions in CSS files
- In the last few months we had some cases when we added/fixed broken CSS code (ex: r18173, r18144, #32838). These types of errors can be easily avoid if we use a lint tool for CSS (as we started using Rubocop for Ruby).
My proposal is ... -
15:40 Patch #32886 (Closed): Rails 6: Use #media_type instead of #content_type to test the MIME type of a response
- Rails 6 displays deprecation warning if you use @@response.content_type@ to check the MIME type of the response.
-
15:06 Defect #32859 (Closed): Issue list: long text custom field missing in PDF export
- Committed the patch. Thank you.
-
10:07 Defect #32885 (Closed): Rails 6: DEPRECATION WARNING: Single arity template handlers are deprecated
- A deprecation warning "Single arity template handlers are deprecated" is shown in Rails 6.
-
05:45 Feature #3088: Estimated hours field able to hide role based
- Now the patch cannot be applied cleanly.
-
02:37 Patch #32841: Drop support for Bundler prior to 1.12.0
- Go MAEDA wrote:
> I think #32788#note-7 is a better solution because it does not force admins to update bundler.
The change has been committed as r19463 but "@if Bundler::VERSION >= '1.12.0'@" does not look good. So, I suggest droppi... -
02:17 Patch #32788 (Closed): Specify supported Ruby version in Gemfile and doc/INSTALL
- Committed the fix described in #32788#note-7.