Redmine

2021-04-04

20:44 Defect #35028: Deprecation message when executing 'bundle install'

I do not worry about the first deprecation.
For the second one, it seems I have some plugin that is the cause. My ... Ivan Cenov

14:16 Defect #35028: Deprecation message when executing 'bundle install'

1/ this should be just a documentation change in Redmine Installation Guide.
2/ Your Gemfile contains multiple prima... Pavel Rosický

13:11 Defect #35028: Deprecation message when executing 'bundle install'

Thanks Ivan for reporting the issue.
Regarding second deprecation (Gemfile multiplesources), are you using any plu... Marius BĂLTEANU

11:52 Defect #35028 (New): Deprecation message when executing 'bundle install'

Here is a part of the console output when upgrading Redmine to version 4.2.0:... Ivan Cenov

19:01 Feature #14130: Spent Time Report Filter options

+1 Alexandr Chernyaev

17:53 Patch #35031 (Closed): Remove deprecated code that are supposed to be removed in Redmine 5

The attached patch removes that are marked "remove in Redmine 5". Go MAEDA

15:47 Feature #35030 (Closed): Allow parallel testing

Rails 6.0 or later supports parallel testing. Enabling this feature can reduce the time required for testing and impr... Go MAEDA

14:02 Defect #34999: The result of Attachment.latest_attach is unstable if attachments have the same timestamp

I don't think the ID column should be used as a timestamp, but I'm ok with using it as a second option, in case both ... Pavel Rosický

10:05 Defect #34999: The result of Attachment.latest_attach is unstable if attachments have the same timestamp

Thank you for pointing it out.
My understanding is that the root cause is that @Attachment.latest_attach@ is unsta... Go MAEDA

13:15 Patch #33337: Clean-up workflows controller

Update the patches for current trunk, the tests still pass.
Setting target to version:"5.0.0", I think it's a nice... Marius BĂLTEANU

12:47 Defect #33757: Cannot get Revisions to work or Issues to link to Commits.

I have similar problem.
I used "this tutorial":/projects/redmine/wiki/HowTo_Easily_integrate_a_%28SSH_secured%29_GI... Janeks Kamerovskis

12:12 Patch #35029 (Closed): Bulgarian translation

Translated several new texts Ivan Cenov

10:29 Feature #35014: Review and update supported database engines and versions

"Tests pass":https://gitlab.com/redmine-org/redmine/-/jobs/1151965543 on MySQL 8, but @issue_nested_set_concurrency_t... Marius BĂLTEANU

08:54 Defect #35027 (Closed): Gantt PNG export ignores imagemagick_convert_command

Gantt PNG export uses ImageMagick's convert command, but it ignores imagemagick_convert_command in configration.yml.
... Go MAEDA

07:04 Patch #35024 (Closed): System test fails in Windows due to "/" path separator

Committed the fix. Thank you for detecting and fixing the issue. Go MAEDA

04:50 Patch #35026 (Closed): Remove rake task check_parsing_by_psych

This patch removes the Rake task "check_parsing_by_psych".
In Ruby 1.8, Syck was used as a YAML library, and in Ru... Go MAEDA

03:53 Feature #34978: Add the list of supported browsers to docs and drop support for IE 11

I see, thanks for the explanation. Pavel Rosický

02:07 Feature #34978: Add the list of supported browsers to docs and drop support for IE 11

Pavel Rosický wrote:
> 15% seems to be a lot are you sure you don't count Edge users? It's ~2% on https://gs.statcou... Go MAEDA

02:55 Patch #35025 (Closed): Update capybara to 3.36

Committed the patch. Thank you. Go MAEDA

2021-04-03

18:56 Defect #33752: Uploading a big file fails with NoMemoryError

@Go MAEDA may I ask for a review? it's a simple change. Pavel Rosický

18:46 Patch #35025 (Closed): Update capybara to 3.36

https://github.com/teamcapybara/capybara/blob/master/History.md Pavel Rosický

18:08 Patch #35024 (Closed): System test fails in Windows due to "/" path separator

Chrome expects backslashes and it doesn't recognize "/" separators on Windows.
fixes... Pavel Rosický

15:14 Feature #34981: Allow to change a project identifier

here's the patch for testing Pavel Rosický

04:32 Feature #34981: Allow to change a project identifier

I have a POC patch with this feature and I have a few questions:
1/ based on https://github.com/paginagmbh/redmine_p... Pavel Rosický

12:53 Defect #35017 (Closed): X-Redmine-Issue-Assignee email header field is empty when the assignee of an issue is a group

When I assign an issue to a group, the X-Redmine-Issue-Assignee: header in the notification mail is empty.
As is:
... Akihiro MATOBA

11:51 Patch #35016 (Closed): French translations for two-factor authentication

Hello,
I attached a patch for french translation for the two fa feature :) Sébastien NOIRIE

11:43 Feature #34978: Add the list of supported browsers to docs and drop support for IE 11

for those who still rely on Internet Explorer 11 (even if I don't understand why), they should stay on Redmine 4.x or... Pavel Rosický

08:43 Feature #34978: Add the list of supported browsers to docs and drop support for IE 11

Marius BALTEANU wrote:
> Also, I don't think that Redmine 5.0.0 will be released sooner than this autumn (6 months f... Go MAEDA

08:17 Feature #34978: Add the list of supported browsers to docs and drop support for IE 11

Most of the well know platforms already ended support for IE (Github, Gitlab, Jira, Gmail, etc) and the fact that Mic... Marius BĂLTEANU

11:12 Feature #34992 (Resolved): Ruby 3.0 support

Committed the patches. Thank you. Go MAEDA

08:44 Feature #34992: Ruby 3.0 support

All tests pass on Ruby 3.0 if we apply first 2 patches (the second one is the one posted by Pavel in #34986).
The ... Marius BĂLTEANU

11:04 Defect #34986 (Closed): Ruby 3.0 fix super calls

Committed the patch as a part of #34992. Thank you. Go MAEDA

08:46 Patch #35012 (Closed): Czech translations

Committed the patch. Thank you. Go MAEDA

08:37 Feature #35014 (Closed): Review and update supported database engines and versions

Supported database engines and versions were not been updated for a while and we should do it in Redmine version:"6.0... Marius BĂLTEANU

08:31 Patch #35011 (Closed): Traditional Chinese translation (to r20905)

Committed the patch. Thank you. Go MAEDA

07:55 Patch #32922: Reload detached attachments

This change passes all the tests now: https://gitlab.com/redmine-org/redmine/-/pipelines/280930686
The fail report... Marius BĂLTEANU

03:38 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading

Marius BALTEANU wrote:
> We should update Rubocop TargetRailsVersion to 6.1
Done in r20908. Go MAEDA

03:34 Patch #32909 (Closed): Replace pluck().first with pick()

Committed the patch. Thank you. Go MAEDA

03:09 Defect #35009: db migration failed after updating to r20905

Hi,
In fact, I do have a secret_token.rb file.
It was dated back to 2012.
Should I run the command, bundle exec ... ChunChang (Nagaharu) Lo

03:07 Defect #35005 (Closed): RuntimeError "Couldn't find Active Storage configuration" is raised at startup

Committed the fix as a part of #29914. Go MAEDA

2021-04-02

22:50 Patch #32909: Replace pluck().first with pick()

I've rebased the patches added by Pavel, the changes looks good to me. Marius BĂLTEANU

22:49 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading

We should update Rubocop TargetRailsVersion to 6.1 Marius BĂLTEANU

07:57 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading

I've created #35002 to track the compatibility with MS SQL. Marius BĂLTEANU

03:17 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading

Pavel Rosický wrote:
> @yuichi activerecord-sqlserver-adapter doesn't support Rails 6.1 yet, but there's an open PR
... Yuichi HARADA

02:47 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading

@yuichi activerecord-sqlserver-adapter doesn't support Rails 6.1 yet, but there's an open PR
https://github.com/rail... Pavel Rosický

02:35 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading

Updating activerecord-sqlserver-adapter with r20900, but when I execute @bundle update@, the following error occurs.
... Yuichi HARADA

22:29 Defect #35009: db migration failed after updating to r20905

Do you have the secret token generated? It should be in @config/initializers/secret_token.rb@. If not, you can run @b... Marius BĂLTEANU

19:22 Defect #35009 (Closed): db migration failed after updating to r20905

error message was:
ArgumentError: Missing `secret_key_base` for 'development' environment, set this string with `bin... ChunChang (Nagaharu) Lo

22:17 Defect #35005: RuntimeError "Couldn't find Active Storage configuration" is raised at startup

Looks good to me. Marius BĂLTEANU

10:14 Defect #35005: RuntimeError "Couldn't find Active Storage configuration" is raised at startup

We can fix this by making the following change. Redmine currently does not use active_storage, so commenting out this... Go MAEDA

10:09 Defect #35005 (Closed): RuntimeError "Couldn't find Active Storage configuration" is raised at startup

Trying to run Redmine in production mode results in the error "Couldn't find Active Storage configuration in /path/to... Go MAEDA

22:15 Defect #35010 (Closed): redmine failed to start after updating to r20905

Duplicates #35005. Marius BĂLTEANU

20:12 Defect #35010 (Closed): redmine failed to start after updating to r20905

error message was:
Couldn't find Active Storage configuration in /var/www/html/redmine/config/storage.yml (RuntimeEr... ChunChang (Nagaharu) Lo

20:40 Patch #35012 (Closed): Czech translations

Pavel Rosický

20:36 Patch #35011 (Closed): Traditional Chinese translation (to r20905)

* New tag added
** error_invalid_authenticity_token, error_query_statement_invalid ChunChang (Nagaharu) Lo

16:35 Defect #35004: DEPRECATION WARNING during startup

refs #32938 Pavel Rosický

09:25 Defect #35004 (Closed): DEPRECATION WARNING during startup

... Go MAEDA

08:31 Feature #3143: Add an 'Add Note' function to issue, to avoid optimistic-lock of issue' update when user just want to add a note

Ismael Barros² wrote:
> Directories @a/@ and @b/@ won't actually exist on your filesystem, so I think you need to us... Leo L.

08:07 Defect #35003 (Closed): Update Rails UJS

Marius BĂLTEANU

07:56 Defect #35002 (Closed): Fix MS SQL on Rails 6.1

MS SQL support is broken for now because the gem supports only Rails 6.0, but I'm confident that will be fixed in the... Marius BĂLTEANU

07:55 Defect #32910 (Closed): Rails 6: add lookup_context to hook_test.rb

Fixed by r20889. Marius BĂLTEANU

05:26 Feature #35001: Disable API authentication with username and password when two-factor authentication is enabled for the user

The following code is a sample implementation.... Go MAEDA

05:18 Feature #35001 (Closed): Disable API authentication with username and password when two-factor authentication is enabled for the user

In Redmine 4.2, two-factor authentication has been introduced.
When two-factor authentication is enabled, it becom... Go MAEDA

04:11 Patch #35000 (Closed): Update SimpleCov to 0.21

Done. Go MAEDA

04:07 Patch #35000 (Closed): Update SimpleCov to 0.21

Go MAEDA

01:11 Feature #32938: Rails 6: Zeitwerk support

I had to remove some references due to your spam protection :) Pavel Rosický

01:10 Feature #32938: Rails 6: Zeitwerk support

sry, I don't. This is a pretty heavy change and Redmine has a lot of technical debt in this area. But I have a few hi... Pavel Rosický