Project

General

Profile

Actions

Defect #8628

closed

"Related to" reference may yield circular dependency error message

Defect #8628: "Related to" reference may yield circular dependency error message

Added by Christian Zagrodnick over 15 years ago. Updated over 10 years ago.

Status:
Closed
Priority:
Normal
Category:
Issues
Target version:
Resolution:
Fixed
Affected version:

Description

The "related to" reference is neither directed nor declaring a dependency. Thus the error "This relation would create a circular dependency" seems wrong. "Related to" references should be possible in any case, should they not?


Files

fix_issue_relations.diff (853 Bytes) fix_issue_relations.diff Egbert van der Wal, 2014-05-12 18:10
fix_issue_relations.diff (655 Bytes) fix_issue_relations.diff Egbert van der Wal, 2014-05-12 18:13
issue_relation_test.patch (1.82 KB) issue_relation_test.patch Uwe Koloska, 2014-09-05 16:42

Related issues 4 (1 open — 3 closed)

Related to Redmine - Feature #16818: Allow multiple relationships between two issuesNewActions
Related to Redmine - Defect #13654: Can't set parent issue when issue relations among child issues are presentClosedJean-Philippe LangActions
Has duplicate Redmine - Feature #14660: Excluding "related to" relation from circular dependency checkClosedActions
Has duplicate Redmine - Defect #13914: Circular dependency issue when issue dependency is setClosedActions

Updated by Jean-Baptiste Barth over 15 years ago Actions #1

  • Category set to Issues
  • Status changed from New to 7
  • Assignee set to Jean-Baptiste Barth
  • Target version set to Candidate for next major release

Agreed, definitely. I'll have a look at it since I already worked on issue relations today.

Updated by Victor Engmark almost 15 years ago Actions #2

"Related to" is reciprocal to itself. In other words, when such a relation is created, there should be a link from both issues to the other one of the relation.

Updated by Christian Zagrodnick almost 15 years ago Actions #3

Victor Engmark wrote:

"Related to" is reciprocal to itself. In other words, when such a relation is created, there should be a link from both issues to the other one of the relation.

That is the case but you could still want to build larger circles A -> B -> C -> A.

Updated by Fares Abdullah almost 15 years ago Actions #4

I had the same problem -

In my case I had an issue, A. I created issue B and set it as related to A. Then I found that B was a duplicate of an existing issue, C, that someone else had created.

I marked B as a duplicate of C, and wanted to relate A to C, and got the "circular dependency" error. I had to manually go and delete the relation between A and B to be able to relate A to C, even though it should not be necessary.

"related to" should allow many different issues related together, as it is not a "dependency".

Cheers and thanks for the great application!

Updated by Jean-Baptiste Barth over 14 years ago Actions #5

  • Assignee deleted (Jean-Baptiste Barth)

Updated by Jean-Philippe Lang almost 14 years ago Actions #6

  • Status changed from 7 to New

Assigned issue with no assignee back to New status.

Updated by Leandro Guida over 13 years ago Actions #7

Here we are having the same problem.

I have an issue A, which is "father" of the issues B and C. When I try to set that C follows B, it gives me the "circular dependency" message.

Updated by Robin McKenzie over 13 years ago Actions #8

+1 "related to" isn't a dependency.

Having the same problem, since we upgraded to the latest version of Redmine.

I've had to advise all our devs to stop using the Related Issues functionality, as this is preventing us setting up tickets with parent/child relationships.

e.g. Create a parent ticket, and two child tickets of this. Attempt to relate the two child tickets - "This relation would create a circular dependency".

Alternatively, create two tickets and relate them to each other. Create another ticket, and then set child A to have this as its parent. Attempt to set child B to have the same parent - "Parent task is invalid".

Would it be possible to get a fix for this prioritised?

Updated by Ralf S. over 13 years ago Actions #9

+1 for this ticket from our side to (using V2.3.1)

It would be very nice, if this fix would get high priority for the next release.

Updated by Benjamin Roberts over 13 years ago Actions #10

+1 for this issue

Environment:
Redmine version 2.3.0.stable
Ruby version 1.9.3 (i386-mingw32)
Rails version 3.2.13
Environment production
Database adapter Mysql2
Redmine plugins:
no plugin installed

Updated by Luke Purdy over 13 years ago Actions #11

+1 for this update.

At the moment I can't create any parent "summary" tasks, for any children who have following dependencies between them (as 4).

It would be helpful if this fix is included as a high priority within the next release.

Updated by Robin McKenzie about 13 years ago Actions #12

Would it be possible to get some feedback as to whether this is being considered for the next release? It was originally set to "Candidate for next major release" over two years ago...

Updated by Akiko Takano over 12 years ago Actions #13

+1 for this update.

Updated by Egbert van der Wal over 12 years ago Actions #14

How can this still be open when it's such a simple fix?

I applied the attached patch to my Redmine SVN checkout to fix this. Feel free to merge it in. It basically takes the type of relations into account when traversing them and ignores 'copied_to', 'duplicates' and 'relates' relationships as these do not imply any dependency.

Updated by Egbert van der Wal over 12 years ago Actions #15

Sorry, this was the incorrect patch. Attached is the correct version. Please remove the previous patch.

Updated by Egbert van der Wal over 12 years ago Actions #16

Just a tiny update after reading the Patch page.

The patch I submitted is against revision 13127 of the stable-2.5 branch. I just tested it against trunk, revision 13138 and it also applies cleanly.

Updated by Toshi MARUYAMA over 12 years ago Actions #17

  • Has duplicate Feature #14660: Excluding "related to" relation from circular dependency check added

Updated by Toshi MARUYAMA over 12 years ago Actions #18

  • Related to deleted (Defect #13914: Circular dependency issue when issue dependency is set)

Updated by Toshi MARUYAMA over 12 years ago Actions #19

  • Has duplicate Defect #13914: Circular dependency issue when issue dependency is set added

Updated by James H over 12 years ago Actions #20

+1

Updated by Uwe Koloska about 12 years ago Actions #21

What about the fix for #7320? Shouldn't the tests for r4723 and r5104 detect the problem described here?

Updated by Uwe Koloska about 12 years ago Actions #22

It looks like related to has a direction!

  • create three tickets 1, 2, 3
  • create relation 1 -> 2
  • create relation 2 -> 3
  • create relation 3 -> 1 gives the circular dependency error
  • create relation 1 -> 3 succeeds
instead of related to you can also use in any combination:
  • duplicates (no error with duplicated by)
  • copied to (no error with copied from)

Since both are really meant to have a direction their's nothing wrong if there is a circle of all duplicates or copied to, but it should definitely not treat all relations the same.

Updated by Uwe Koloska about 12 years ago Actions #23

attached a test for the current 2.5 branch (but has not changed in trunk) that tests for the following dependencies that should both not be circular:
  • 1->2, 2->3, 3->1 (error)
  • 1->2, 2->3, 1->3 (no error)

Updated by Etienne Rossignon about 12 years ago Actions #24

+1 to get a fix for this one

Updated by Mischa The Evil almost 12 years ago Actions #25

  • Related to Feature #16818: Allow multiple relationships between two issues added

Updated by Marco Shima almost 12 years ago Actions #26

+1 to finally get this fixed. Redmine is only partially useful as long as this major bug exists.

Updated by Anton Statutov over 11 years ago Actions #27

+1. This definitely needs to be fixed.

Updated by Nayuta Taga about 11 years ago Actions #28

+1

Updated by Jānis Elmeris about 11 years ago Actions #29

+1

Updated by Go MAEDA almost 11 years ago Actions #30

r15056 also seems to have fixed this issue.
Now I can make A->B, B->C, C->A relations on Redmine 3.2.0.devel.15056.

Updated by Go MAEDA almost 11 years ago Actions #31

  • Status changed from New to Resolved
  • Target version changed from Candidate for next major release to 3.3.0

Fixed by #13654.
I am setting target version to 3.3.0 because I think it would be better to list this important issue in Changelog.

Updated by Go MAEDA almost 11 years ago Actions #32

  • Related to Defect #13654: Can't set parent issue when issue relations among child issues are present added

Updated by Jean-Philippe Lang almost 11 years ago Actions #33

  • Status changed from Resolved to Closed
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Thanks.

Updated by Robin McKenzie over 10 years ago Actions #34

Hi, any idea when 3.3.0 will be released?

Actions

Also available in: PDF Atom