Activity
From 2017-08-15 to 2017-08-17
2017-08-17
-
23:21 Patch #26714: pluck instead of map in issue_query
- done
-
09:44 Patch #26714 (Needs feedback): pluck instead of map in issue_query
- I think your IssueQuery#versions_for_id is named IssueQuery#version_ids and pluck(:id) is in it for consistency.
source:tags/3.4.2/app/models/issue_query.rb#L310
Please add ".diff" in your patch file name and remove commented lines f... -
08:30 Patch #26714 (Closed): pluck instead of map in issue_query
- The previous issue_query.rb, line 438 version_ids = versions(:conditions => [where]).map(&:id) will issue query as:
-
14:14 Defect #24864: svn.redmine.org: "The certificate is not issued by a trusted authority"
- The certificate itself is fine and valid. However, it appears that the server for https://svn.redmine.org does not send along the required intermediate certificates to allow clients to verify the full certificate chain as shown in Toshi'...
-
10:28 Feature #26409: Show assignee on gantt
- Marius BALTEANU wrote:
> …
> ...
Thank you for your advice.
I changed patch as follows: -
06:05 Patch #26711: Use pluck instead of collect/map
-
05:03 Patch #26711 (Closed): Use pluck instead of collect/map
- In app/helpers/my_helpers,
68: where(:project_id => User.current.projects.map(&:id)).
Use pluck to get the id is much more efficient, since the query will only access the id field, instead of select * from projects:
Before:
SELE... -
01:26 Feature #26709 (Closed): Use correct http status codes
- 1/ redmine ignores accept headers and jquery dataType attribute
The Accept request-header field can be used to specify certain media types which are acceptable for the response.
If no Accept header field is present, then it is assu...
2017-08-16
-
22:49 Defect #26708: Diff formatting results empty lines if they contains HTML tags
- Live example:
-
22:48 Defect #26708 (Closed): Diff formatting results empty lines if they contains HTML tags
- h2. Steps to reproduce:
In issue description write something like (need to remove space in @< /pre>@): -
18:28 Defect #26705 (Closed): Unable to download file if custom field is not defined as visible to any users
- Even if my user account has all available roles (and is also an administrator), i am not able to download custom field file, unless custom field is configured as visible to any users.
I am getting a "403 - You are not authorized to ac... -
17:30 Defect #26702: Getting an internal error when I tried to open up a project.
- Just want to apologize.... The database was "initialized" with an earlier version of Redmine. There were so many things that happened in between that I didn't even remember it.
-
09:01 Defect #26702 (Closed): Getting an internal error when I tried to open up a project.
- Check your schema_migrations table.
-
12:35 Defect #26544: SQL-Error occurs sometimes when clicking on "calendar" tab
- I am also having this issue: https://www.screencast.com/t/J1ajHPH6fnP
-
10:29 Patch #26703 (Closed): German translations in 3.4-stable
- Hi,
I'm missing some German translations in 3.4.2.
I've made the translations.
Attached is a patch for config/locales/de.yml
-
04:56 Patch #26682 (New): URL-escape the ! character in generated markup for dropped uploads
- I have tested the updated patch (#26682#note-3). Now it works fine in both Markdown and Textile.
Thank you for updating the patch so quickly. -
02:55 Patch #26655: Additional icon for contextmenu
- FYI:
"Mastodon":https://github.com/tootsuite/mastodon (social network server) uses horizontal three dots button for context menu.
!{width: 312px;}.mastodon-context-menu-button@2x.png!
2017-08-15
-
23:39 Defect #26702: Getting an internal error when I tried to open up a project.
- This is strange... The "projects" table has the following columns: name, description, homepage, is_public, parent_id, created_on, updated_on, identifier, status, lft, rgt, interit_members and default_version_id.
I swore that I didn't... -
23:09 Defect #26702 (Needs feedback): Getting an internal error when I tried to open up a project.
- Make sure projects table has default_assigned_to_id column.
-
22:40 Defect #26702 (Reopened): Getting an internal error when I tried to open up a project.
- This is not an upgrade from an earlier release of Redmine...
I installed Redmine 3.4.1; it was working and it stopped working "suddenly" in the sense that I don't recall any changes except that one change with copying the public/dispa... -
22:04 Defect #26702 (Closed): Getting an internal error when I tried to open up a project.
- See #26485.
-
21:01 Defect #26702 (Closed): Getting an internal error when I tried to open up a project.
- Currently, if I logged on as regular user to my redmine installation of 3.4.1; I can see the list of projects, but when I tried to open any "Project", I got the following:
-
21:48 Defect #26544: SQL-Error occurs sometimes when clicking on "calendar" tab
- I cannot reproduce on my CentOS 7 and Redmine 3.4.2.
-
18:18 Defect #26691: N + 1 queries when rendering the Gantt
- Another thing is that, if the issue is updated, then the GanttsController.index action page needs to be refresh, which will reconstruct the project_tree, so there will no problem for the rendering.
-
17:56 Defect #26691: N + 1 queries when rendering the Gantt
- If there is only problem, then some updated issue can be applied to project with the update of issue, such as:
-
07:20 Defect #26691 (New): N + 1 queries when rendering the Gantt
- Thank you for providing the patch.
It is interesting but IMHO, the cache should be invalidated when an issue or a version in the project is updated. With the patch applied, @Project#start_date@ and @Project#due_date@ returns a wrong v... -
06:12 Defect #26691: N + 1 queries when rendering the Gantt
- here is the patch, what I have done is to calculate the start date and due date in a group queries.
-
04:05 Defect #26691 (Needs feedback): N + 1 queries when rendering the Gantt
- Thank you for pointing out the problem and sharing your work.
Could you provide a patch file instead of @project.rb@?
See also:
* [[Patch]]
* [[Contribute]] -
03:27 Defect #26691 (Closed): N + 1 queries when rendering the Gantt
- Rails 4.2.7.1
20000 issues in the database
When rendering the GanttsController.show action, it will issue a lot of queries to get the the start_date and due_date of an project like: -
17:52 Defect #26699: Anonymous user should have their icon
- Updated tests.
-
17:01 Defect #26699 (Closed): Anonymous user should have their icon
- @ApplicationHelper#avatar@ method returns blank string instead of @img@ tag for the anonymous user. The behavior causes disordered layout in IssuesController#show page.
This patch adds an icon for the anonymous user and fixes the brok... -
14:03 Patch #26655: Additional icon for contextmenu
- I am attaching an updated patch, that sets correct colspan when grouping issue lists.
-
12:11 Patch #26682: URL-escape the ! character in generated markup for dropped uploads
- Thank you for the review Maeda-san. I had a look at the Markdown generation but completely missed the parenthesis. In addition to that, it turns out that in my previous patch, only the first instance of an exclamation mark would have be...
-
05:05 Patch #26682 (Needs feedback): URL-escape the ! character in generated markup for dropped uploads
- '(' and ')' have to be escaped for Markdown formatter.
Holger, would you update the patch to escape those characters?
!{width: 167px; border: 1px solid #ccc;}.parentheses@2x.png! -
04:34 Patch #26682: URL-escape the ! character in generated markup for dropped uploads
- Confirmed the problem. Setting target version to 3.4.3.
Thank you for sharing the patch.
*Before:*
!{width: 280px; border: 1px solid #ccc;}.26682-before@2x.png!
*After:*
!{width: 280px; border: 1px solid #ccc;}.26682-after@2x.png! -
11:08 Defect #26508: excel have wrong column name at custom field
- Randa Bustami wrote:
> thank you for your feedback , but what is the relation between plugins and the custom fields ?
As I said, Redmine core does not provide i18n custom fields feature.
So custom field name should not be translated... -
08:06 Feature #26409: Show assignee on gantt
- Go MAEDA wrote:
> Marius BALTEANU wrote:
> ...
Sorry for the mistake, it seems that my local repository didn't have the latest changes from the trunk. Now the second patch applies cleanly. -
02:34 Feature #26409: Show assignee on gantt
- Marius BALTEANU wrote:
> 1. the patch doesn't apply cleanly on the current trunk (r16948).
The patch depends on another patch #20481. Could you try again after applying it?
> ...
I agree with you. Gravatar icon should be shown for... -
02:20 Patch #26689: Add title to author's and assignee's icon
- Marius BALTEANU wrote:
> I'm thinking that adding a title to that icons could help users to understand better the functionality.
You are right, thank you for improving the feature.
Setting target version to 3.4.3 (next minor release...