Project

General

Profile

Activity

From 2019-09-10 to 2019-09-12

2019-09-12

23:54 Patch #32054 (Closed): Add test for 4 byte characters (emoji) support
In #31921 was added proper support for 4 byte characters (emoji) for new installations with MySQL as database.
I proposed to have a test for this case, but we're worried that the test will broke the CI server.
The scope of this ti...
Marius BĂLTEANU
23:53 Feature #31910 (Closed): Add additional mail headers for issue tracker
Committed the patch. Thank you for suggesting this improvement. Go MAEDA
23:46 Defect #32046: SQL to get counts when using created_on in MySQL to group issues does not work correctly
Go MAEDA wrote:
> Marius, could you review this patch? It updates MySQL support for the date grouping filter option committed in r17745.
The fix works well, thanks for catching and fixing this issue.
Marius BĂLTEANU
19:25 Defect #31986: Error selecting issues between dates after upgrading redmine 2.3.2 to 4.0.x
Adauto Serpa wrote:
> Hi,
> ...
I tested with a normal Redmine installation and the bug did not occur. This bug is occurring in a docker installation.
Adauto Serpa
18:18 Feature #31300: Automatically switch between native date picker and custom date picker based on mobile or not mobile devices
I vote for this. We recently updated to 3.4.11 from 3.2.? and discovered that our corporate standard date format (yyyy-mm-dd) is not available in Redmine Date pickers. I have read the W3 consortium's implementation notes and cannot bel... James Byrne
14:51 Patch #13468 (Closed): REST API for News
Go MAEDA wrote:
> The test fails due to a missing fixture.
Committed in r18455.
Go MAEDA
14:48 Patch #13468 (Reopened): REST API for News
The test fails due to a missing fixture. Go MAEDA
12:08 Feature #32052: Auto-complete issues #id in search form
I think this small but great improvement should be delivered together with #31989. Setting the target version to 4.1.0. Go MAEDA
09:09 Feature #32052: Auto-complete issues #id in search form
I attached a patch.
* The change to inlineAutoComplete is to disable the autocomplete built-in Firefox browser.
!{width: 300px; border: 1px solid #ccc}firefox-screen.png!
* Issue id(#nnnnn) keyword can search for issues in other ...
Mizuki ISHIKAWA
08:59 Feature #32052 (Closed): Auto-complete issues #id in search form
I think it would be useful to be able to autocomplete #id in the search form.
Example:
!{width: 500px; border: 1px solid #ccc}search1.png!
!{width: 500px; border: 1px solid #ccc}search2.png!
Mizuki ISHIKAWA
12:02 Feature #31921 (Closed): Changes to properly support 4 byte characters (emoji) when database is MySQL
Committed the updated patch in #31921#note-33. Thanks. Go MAEDA
09:39 Defect #32047: Do not delete parent issues that have child issues
Go Maeda,good!
I would like to request the same way
Hirofumi Kadoya
04:39 Patch #31640: Add clear query icon next to selected query in sidebar
Marius BALTEANU wrote:
> Regarding the patch, you have attached a wrong one.
Sorry, here is the correct patch.
Go MAEDA
01:36 Patch #31994 (Closed): Allow issue auto complete to return 10 issues when there is not search term provided
Mischa The Evil wrote:
> Shouldn't this change be reflected in the name of the test that is committed (@test_auto_complete_without_term_should_return_last_10_updated_issues@)?
Thank you for pointing it out. Committed the fix posted i...
Go MAEDA

2019-09-11

22:19 Feature #13919: Mention user on issues and wiki pages using @user with autocomplete
Mizuki ISHIKAWA wrote:
>
> ...
Thanks for you quick feedback. Do you like to continue from here? I would be very happy to review the patch.
Marius BĂLTEANU
02:24 Feature #13919: Mention user on issues and wiki pages using @user with autocomplete
Marius BALTEANU wrote:
> Please let me know what do you think about this.
Thank you for your activity on this Issue(feature)!
The implementation using the "acts_as_mentionable" plugin looks more beautiful than the patch implementati...
Mizuki ISHIKAWA
21:44 Patch #31994 (Reopened): Allow issue auto complete to return 10 issues when there is not search term provided
Mischa The Evil wrote:
> Marius BALTEANU wrote:
> ...
Indeed, it should, sorry for it.
Marius BĂLTEANU
19:36 Patch #31994: Allow issue auto complete to return 10 issues when there is not search term provided
Marius BALTEANU wrote:
> Go MAEDA wrote:
> ...
Shouldn't this change be reflected in the name of the test that is committed (@test_auto_complete_without_term_should_return_last_10_updated_issues@)?
Mischa The Evil
09:18 Patch #31994 (Closed): Allow issue auto complete to return 10 issues when there is not search term provided
Committed the patches. Thank you for your contribution. Go MAEDA
09:16 Patch #31994: Allow issue auto complete to return 10 issues when there is not search term provided
Marius BALTEANU wrote:
> Second patch removes a view that is not used from my checks (code cleanup).
app/views/auto_completes/issues.html.erb is no longer used after r17881 (@render :layout => false@ was replaced with @render :json =...
Go MAEDA
13:00 Defect #32047: Do not delete parent issues that have child issues
+1
Sounds like a great idea and prevents the user from unforeseen side effects.
Bernhard Rohloff
11:24 Defect #32047: Do not delete parent issues that have child issues
+1
How about showing a confirmation dialog like the following instead of disallowing to delete a parent issue? In the current versions, a similar dialog is shown when deleting an issue which has spent time logs.
!{width: 580px; borde...
Go MAEDA
09:19 Defect #32047 (New): Do not delete parent issues that have child issues
Do not delete parent issues that have child issues please
--jp--
子チケットがあるチケットを削除した場合、子チケット含めて消えてしまいます
子チケットがある親チケットを削除できないような制限をかけてもらえませんか?
ーーー
Hirofumi Kadoya
12:57 Defect #32049 (Closed): Redmine allows same user to login from different machines simulteniously
Using Redmine 4.0.4
Able to Login using same user credentials from different machines at same time.
Expected :- If user is already logged in on 1 machine then it should not allow user to log-in on other machine.
Thanks
Amit Mehendale
08:05 Defect #32046: SQL to get counts when using created_on in MySQL to group issues does not work correctly
Marius, could you review this patch? It updates MySQL support for the date grouping filter option committed in r17745. Go MAEDA
02:37 Defect #32046: SQL to get counts when using created_on in MySQL to group issues does not work correctly
You have to make changes like the diff below. Mizuki ISHIKAWA
02:36 Defect #32046 (Closed): SQL to get counts when using created_on in MySQL to group issues does not work correctly
Reproduction procedure
* Use MySQL
* "Time zone data":https://dev.mysql.com/doc/refman/5.6/en/mysql-tzinfo-to-sql.html is loaded(If it is not loaded, time zone conversion will fail.)
* Change user language from UTC to something else
...
Mizuki ISHIKAWA
07:15 Patch #13468: REST API for News
Sorry, I should have run tests locally before commenting.
Thanks for fixing.
vzvu 3k6k
03:53 Patch #13468: REST API for News
Yuichi HARADA wrote:
> @Redmine::ApiTest::NewsTest#test_GET_/news/:id.xml@ fails if config.time_zone is set.
Committed the fix in r18445. Thank you for reporting and fixing it.
Go MAEDA
04:07 Defect #30467 (Closed): Footer is not placed at the bottom on pages with little content
Marius BALTEANU wrote:
> I think it's safer to target the wrapper elements by their id instead of using "starting with":
> ...
Committed the fix in r18446. Thanks.
Go MAEDA
02:49 Defect #31972: An empty group_count badge is displayed when grouped with created_on
I forgot to attach the patch.
Change the same as "timelog":http://www.redmine.org/projects/redmine/repository/entry/trunk/app/views/timelog/_list.html.erb#L25 .
Mizuki ISHIKAWA

2019-09-10

21:52 Defect #32041: Unable to reuse project name after delete
James Byrne wrote:
> invalid. New repo simply took a long time to load.
Thanks for your feedback.
Marius BĂLTEANU
21:52 Defect #32041 (Closed): Unable to reuse project name after delete
Marius BĂLTEANU
21:17 Defect #32041 (Resolved): Unable to reuse project name after delete
invalid. New repo simply took a long time to load. James Byrne
19:07 Feature #13919: Mention user on issues and wiki pages using @user with autocomplete
@Mizuki ISHIKAWA, what do you think if we try to implement this feature using a new plugin named "acts_as_mentionable" which will be able to look for mentioned users (for now, it can be extended to another entities in the future) only on... Marius BĂLTEANU
18:28 Patch #31994: Allow issue auto complete to return 10 issues when there is not search term provided
Go MAEDA wrote:
> The subject says "return last 10 updated issues" but actually the patch returns last 10 created issues. Is it OK?
> ...
Indeed, my initial intention was to return the last 10 updated issues, but during the implementat...
Marius BĂLTEANU
00:00 Patch #31994: Allow issue auto complete to return 10 issues when there is not search term provided
The subject says "return last 10 updated issues" but actually the patch returns last 10 created issues. Is it OK? Go MAEDA
15:07 Defect #30467: Footer is not placed at the bottom on pages with little content
Marius BALTEANU wrote:
> I think it's safer to target the wrapper elements by their id instead of using "starting with":
> ...
No, you're right. wrapper is quite generic and could be used in more places.
I think it should be changed t...
Bernhard Rohloff
13:08 Defect #13781: CJK(Chinese/Japanese/Korean) characters are not shown in PDF on non CJK locales
Hello i found solution for this issue:
1. you need to create mysql database with utf8 parameter.
2. go to /redmine/app/models/user.rb and replace this line and comment the default one
#validates_format_of :login, :with => /\A[a-z0-9...
nikunj begda
12:33 Defect #25207: Cannot assign users to project of projects to user
Hi, I have the same issue on Redmine 4.0.4, but I don't have CSP enabled. It happens on all the browsers. Can't find the resolution anywhere. Would appreciate any hints. It is happening after upgrade from 3.4 to 4.0. Paweł Szmigiel
12:29 Defect #31708: Not able to add member to a project
Carmelo Pansera wrote:
> Hello
> ...
Hi, I have the same issue on Redmine 4.0.4, don't have CSP enabled, can't find any solution to this, would appreciate any help.
Paweł Szmigiel
11:23 Feature #32042 (New): Show in summary
Add "Show in summary" when creating/editing custom field.
Show in summary would show custom field in summary (report) which is accessible via issues sidebar.
Aleksandar Pavic
08:16 Patch #13468: REST API for News
@Redmine::ApiTest::NewsTest#test_GET_/news/:id.xml@ fails if config.time_zone is set.
Set config.time_zone in config/additional_environment.rb.
Yuichi HARADA
 

Also available in: Atom