Project

General

Profile

Activity

From 2019-10-01 to 2019-10-03

2019-10-03

16:24 Patch #32122: Fix test failure due to missing call to set_tmp_attachments_directory
LGTM. Setting the target version to 4.2.0.
@set_tmp_attachments_directory@ and @set_fixtures_attachments_directory@ are methods which change @Attachment.storage_path@ during tests.
If a test method which creates/deletes attachments...
Go MAEDA
15:43 Defect #32184: Incorrect headings example in Textile help
Setting the target version to 3.4.12. Go MAEDA
10:23 Defect #32184: Incorrect headings example in Textile help
Here is a patch to fix this issue. Go MAEDA
08:37 Defect #32184 (Closed): Incorrect headings example in Textile help
Example in the help (source:tags/4.0.4/public/help/en/wiki_syntax_detailed_textile.html#L203): Go MAEDA
15:41 Defect #32110 (Resolved): "already initialized constant Redmine::Scm::Adapters::SubversionAdapter::SVN_BIN" warning when executing rake tasks
Committed the fix. Go MAEDA
07:57 Defect #32110: "already initialized constant Redmine::Scm::Adapters::SubversionAdapter::SVN_BIN" warning when executing rake tasks
Setting the target version to 4.0.5.
The patch to commit: #32110#note-5
Go MAEDA
15:36 Patch #32189 (Closed): Remove unnecessary requiring of "rexml/document"
Committed the fix. Go MAEDA
15:33 Patch #32189 (Closed): Remove unnecessary requiring of "rexml/document"
rexml/document is unnecessary in lib/redmine/version.rb because the code that uses the library has been removed in r10616. Go MAEDA
14:47 Defect #32183: Notification sub-events for "Issue updated" does not cover all events which consist its parent
+1
This will make the email sending condition MECE.
By the way, is Relation updated included in other attributes?
I think it is better to be independent.
https://www.redmine.org/issues/16098#note-18
Yuuki NARA
14:36 Defect #32183: Notification sub-events for "Issue updated" does not cover all events which consist its parent
+1
That's an awesome idea. :)
I've never thought of it ("Issue updated" includes "hidden" events).
Kohei Nakamura
07:54 Defect #32183: Notification sub-events for "Issue updated" does not cover all events which consist its parent
+1
So Nice!
ryou soda
07:16 Defect #32183 (New): Notification sub-events for "Issue updated" does not cover all events which consist its parent
You can configure notification events in "Administration" > "Settings" > "Select actions for which email notifications should be sent.". In the section, you can see "Issue updated" and its sub-events, "Note added", "Status updated", "Ass... Go MAEDA
14:45 Patch #32166: Rounded corners on table.gantt-table
Go MAEDA wrote:
> Thank you for posting the patch.
> ...
Thanks for pointing it out. I did this on purpose, to mark the gantt containing parent table (table.gantt-table), so it would kind of be exactly like calendar in styling, or else...
Anonymous
14:24 Patch #32166: Rounded corners on table.gantt-table
Thank you for posting the patch.
But I found a small issue. You will see an unnecessary vertical line after applying the patch. Please see the screenshots below.
*Before:*
!{width: 250px;}.unnecessary-line-before@2x.png!
*After...
Go MAEDA
14:29 Patch #29216: Replace the searchbox label in the header with a placeholder
I like the idea with _clear_ button, but I think it wastes horizontal space of the bar when typing while appearing from the other side, the search icon is really useless after you already began typing in the bar anyway. I think search ic... Anonymous
14:10 Patch #32165 (Closed): Rounded corners on table.cal
Go MAEDA
14:09 Patch #32165: Rounded corners on table.cal
Committed the patch. Thank you. Go MAEDA
13:49 Defect #32187: Email notifications and create ticket
ok no problem. sorry, i have create a new discussion in "how to". brice wilmet
13:45 Defect #32187 (Closed): Email notifications and create ticket
Go MAEDA
13:45 Defect #32187: Email notifications and create ticket
Please use forums for "how to" questions. Issues are used to report a bug, suggesting a new feature, or submitting a patch. Reading "How to request help":http://www.redmine.org/boards/2/topics/667 may be helpful for you. Go MAEDA
13:42 Defect #32187 (Closed): Email notifications and create ticket
Hi,
I have redmine application in my company.
I use this for create ticket for any problem for my customers.
Ticket automaticaly create when one customer send email.
After my customer is notifie by email when this ticket is crea...
brice wilmet
11:31 Feature #29752 (Closed): Render Textile and Markdown attachments on the preview page
Committed the patch #29752#note-13 in r18586. Go MAEDA
09:01 Feature #29752: Render Textile and Markdown attachments on the preview page
This patch replaces the regexp that checks '.textile' extension with @Redmine::MimeType.of@. Go MAEDA
08:47 Feature #29752: Render Textile and Markdown attachments on the preview page
Go MAEDA wrote:
> Marius BALTEANU wrote:
> ...
I like your idea to use "text/x-textile".
Marius BĂLTEANU
03:36 Feature #29752 (Reopened): Render Textile and Markdown attachments on the preview page
Mischa The Evil wrote:
> What about the note Marius made in #29752#note-5?
Oh, I forgot to handle that. Thank you for pointing it out.
Marius BALTEANU wrote:
> ...
I like the approach but there is only one problem that "text/text...
Go MAEDA
03:04 Feature #29752: Render Textile and Markdown attachments on the preview page
Go MAEDA wrote:
> Committed the patch. [...]
What about the note Marius made in #29752#note-5?
Mischa The Evil
02:33 Feature #29752 (Closed): Render Textile and Markdown attachments on the preview page
Committed the patch. Thank you all for contributing and reviewing the patch. Go MAEDA
10:29 Feature #5840: Live lookup of the existing issues based on the keywords entered in the title for new issue
+1: I tried another approach to create a feature that displays issues with similar subjects.
By using the existing action "/issues/auto_complete" in Ajax, the feature could be implemented with a little changes.
The UI is as shown belo...
Takenori TAKAKI
03:46 Feature #16098: On relation change/add notification setting
Go MAEDA wrote:
> Go MAEDA wrote:
> ...
Thank you for pointing it out. The reason for the incorrect assertion result was not enough fixtures.
I rewrote the patch.
Yuichi HARADA

2019-10-02

19:22 Feature #9122: Tracking adding/removal of watchers in the ticket history
+1 James H
17:47 Feature #29752: Render Textile and Markdown attachments on the preview page
I suggest adding the following change to the patch in order to make distinguishable between the UI of Redmine and the content of the file by adding a border around the content. Go MAEDA
16:42 Patch #32014 (Closed): Rounded corners on table.list elements
Go MAEDA
15:47 Feature #12036 (Closed): Allow backtip for inline code with inline block style
Caio Cunha wrote:
> No problem dropping the backtips,
In Redmine 2.5 or later, you can use backticks if you use Markdown as a text formatting markup.
> ...
The upcoming Redmine 4.1 sets background-color for inline code (#31343)....
Go MAEDA
15:19 Feature #15928: Disable email notifications for ticket's updates
+1 I hope this function! Makoto Saito
14:54 Feature #15928: Disable email notifications for ticket's updates
+1
Yuuki NARA
11:31 Feature #557 (Closed): Changing user preferrences
The feature was added in Redmine 1.1.0 (#3503).
Daniel Felix wrote:
> But for some reasons, there is no setting to enable or disable the default behaviour of the checkbox for "notify me for my own changes". This would be quite useful...
Go MAEDA
11:08 Feature #32181 (New): Auto Status Change from New to In Progress
Hi All,
Is there any way to change status automatically when we update the new issue?
Thanks,
Ahmet
Ahmet Demir
09:00 Defect #32110: "already initialized constant Redmine::Scm::Adapters::SubversionAdapter::SVN_BIN" warning when executing rake tasks
Here is a workaround. Go MAEDA
08:41 Defect #32110: "already initialized constant Redmine::Scm::Adapters::SubversionAdapter::SVN_BIN" warning when executing rake tasks
It is caused by r17407. Reverting the change fixes the issue. Go MAEDA
06:36 Defect #32110: "already initialized constant Redmine::Scm::Adapters::SubversionAdapter::SVN_BIN" warning when executing rake tasks
The warning can be observed only when the current directory is a working copy of the Subversion repo. It means that you obtained the source code of Redmine using "svn" command. Go MAEDA
05:22 Feature #16098: On relation change/add notification setting
Go MAEDA wrote:
> A test fails on r18582. Could you check the patch?
I think the expected value of @ActionMailer::Base.deliveries.size@ should be 4 because notification for 2 issues (both ends of the relation) are sent to 2 users (js...
Go MAEDA
03:17 Feature #16098 (Needs feedback): On relation change/add notification setting
Yuichi HARADA wrote:
> Added "Relation updated" checkbox to "Administration" > "Settings" > "Email notifications" tab.
> ...
A test fails on r18582. Could you check the patch?
Go MAEDA
03:09 Defect #32170 (Closed): Text enclosed in pre tag in Wiki formatting reference is not displayed in monospaced font in Chrome
Go MAEDA
01:31 Defect #14964 (Closed): No http(s) support in Subversion in redmine stack
Closing this issue because Redmine 2.3, Subversion 1.6.11, and CentOS 6.0 are too old. Please contact the BitNami team or reopen this issue if you still experience this issue. Go MAEDA

2019-10-01

19:51 Patch #29216: Replace the searchbox label in the header with a placeholder
I've tried Marius's patch and it works very nice. IMHO this would be a nice improvement. LGTM! Bernhard Rohloff
18:03 Patch #29216: Replace the searchbox label in the header with a placeholder
Also, switching to a search input field, it'll add the nice clear input icon (HTML 5 feature).
!x_icon.png!
Marius BĂLTEANU
18:00 Patch #29216: Replace the searchbox label in the header with a placeholder
What about of using the same search input available for mobile version, but with the magnifier icon clickable?
Non-mobile:
!search.png!
Mobile:
!search_mobile.png!
Marius BĂLTEANU
10:50 Feature #32178 (New): Conditioned Custom Fields
Dear all,
is it possible to create conditioned custom fields, which pop-up only, if a first custom field is answered with a predefined content?
Custom Field 1 = Answer 1 -> other custom fields appear and completion is possible
Cus...
Tina M.
10:28 Defect #32168: Allow issue id with "#" prefix for the value of issue ids filter
Accepted to input with "#" prefix even in "Issue" filter.
I attached a patch.
Yuichi HARADA
05:49 Feature #18043 (Closed): Links to anchors inside the page should be pagename-independent
The feature has been delivered in Redmine 4.0.0 (#16313). Go MAEDA
05:20 Defect #24008 (Closed): Remove 'Copied from' / 'Copied to' relationship between issues
Go MAEDA
04:48 Defect #24160 (Closed): Gantt diagram returns internal error
Go MAEDA
 

Also available in: Atom