Project

General

Profile

Activity

From 2019-10-03 to 2019-10-05

2019-10-05

15:01 Defect #32200: Handle bot activity
This issue is probably a dupe or related to #29450 Anonymous
12:41 Defect #32200: Handle bot activity
Is there anything we can do on the server side to lower the amount of human efforts? Bernhard Rohloff
05:44 Defect #32200: Handle bot activity
Deleted the accounts.
Every day, 100 - 200 accounts are created and I delete 10 - 20 accounts that posted spam or test issue. Probably a considerable number of new accounts are created by spammers.
Go MAEDA
05:23 Defect #32200 (Closed): Handle bot activity
See the following messages:
* message#58123
* message#56563
* message#58122
* message#58115
I could delete the message(s) myself, but I think that (some of) these accounts need to be locked/deleted also.
Mischa The Evil
12:39 Defect #32201: Issue auto-assignment to JPL based on Website category
Mischa The Evil wrote:
> Is this still desirable/needed?
I don't know if it's needed but perhaps it's a thing JPL whould have changed himself if it annoys him. It would also be interesting to know who else could work on those issues ...
Bernhard Rohloff
05:26 Defect #32201 (New): Issue auto-assignment to JPL based on Website category
Is this still desirable/needed? Mischa The Evil
12:02 Patch #32202 (Closed): Japanese translation update (r18593)
Committed the patch. Go MAEDA
11:59 Patch #32202 (Closed): Japanese translation update (r18593)
Go MAEDA
12:02 Revision 18597 (svn): Japanese translation update (#32202).
Patch by Go MAEDA. Go MAEDA
11:48 Revision 18596 (svn): Update locales (#17840).
Go MAEDA
11:48 Feature #17840 (Closed): Option to send email notification on "Target version updated"
Committed the patch. Thank you for your contribution. Go MAEDA
11:46 Revision 18595 (svn): Option to send email notification on "Target version updated" (#17840).
Patch by Yuichi HARADA. Go MAEDA
11:22 Defect #32198 (Confirmed): Issues associated revisions not showing due to bad reference to lvar instead of ivar
Go MAEDA
11:08 Feature #1237: Add support for two-factor authentication
Marius, thank you for reviewing the patch series. Here are patches to commit:
* attachment:0001-adds-two-factor-authentication-support-r18593.patch
* attachment:0002-adds-a-setting-to-disable-enable-require-2fa-auth-r18593.patch
* a...
Go MAEDA
07:47 Defect #29601 (Closed): Redmine::VERSION::revision may return wrong value
Committed the patch. Thank you for your contribution. Go MAEDA
05:47 Defect #29601: Redmine::VERSION::revision may return wrong value
Mischa The Evil wrote:
> The issue however could be that by utilizing @svn info --show item ...@ we effectively drop support for Subversion <1.9 because that command is introduced only as part of the 1.9 branch (see the "Subversion Mail...
Go MAEDA
04:59 Defect #29601: Redmine::VERSION::revision may return wrong value
Go MAEDA wrote:
> We don't have to parse XML with regexp if we use @`svn info --show-item last-changed-revision`@.
That's nice indeed. The issue however could be that by utilizing @svn info --show item ...@ we effectively drop suppor...
Mischa The Evil
02:25 Defect #29601: Redmine::VERSION::revision may return wrong value
We don't have to parse XML with regexp if we use @`svn info --show-item last-changed-revision`@. The command simply returns the number of last changed revision without any other unnecessary data. Go MAEDA
07:46 Revision 18594 (svn): Redmine::VERSION::revision may return wrong value (#29601).
Patch by Yuichi HARADA. Go MAEDA
05:28 Defect #32192 (Closed): Do not allow to send a security notification when the user account is locked.
I am closing this as a "Wont fix" because the requested behavior change can be a security loophole. Go MAEDA
05:15 Defect #32192: Do not allow to send a security notification when the user account is locked.
Go MAEDA wrote:
> I think the notification should be sent even to locked users [...]
I agree.
Mischa The Evil
05:11 Defect #32193: Add turn on/off button to control sending security notifications
Go MAEDA wrote:
> I think the "Administration" page must not have such a setting. [...]
I agree. If this is really something that we want to make configurable, which I would not prefer, the best place to do that is via the configurat...
Mischa The Evil
04:50 Defect #32193: Add turn on/off button to control sending security notifications
I think the "Administration" page must not have such a setting. It can be abused by a malicious admin.
But I think adding a setting to turn off security notifications in config/configuration.yml is OK because only a few people can tou...
Go MAEDA
04:06 Defect #32199 (Closed): Security notification is not sent when an admin changes the password of a user
Security notifications should be sent when admin changes a user's password in order to prevent admins from changing a user's password for malicious purposes.
See the table below. It describes the current behavior. Security notificatio...
Go MAEDA

2019-10-04

21:26 Defect #32198 (Closed): Issues associated revisions not showing due to bad reference to lvar instead of ivar
Fixes bad references on issue_controller
This is the error
José Esteves
16:25 Defect #29601 (Confirmed): Redmine::VERSION::revision may return wrong value
I have confirmed the issue.
---
Now the current directory is the working copy of /branches/4.0-stable branch.
Go MAEDA
15:59 Defect #32192: Do not allow to send a security notification when the user account is locked.
Hinako Tajima wrote:
> This situation happens Ver.3.4.10, when the administrator saved after changed his/her email address who is a locked account.
I have confirmed that the trunk behaves the same. I think the notification should be ...
Go MAEDA
09:26 Defect #32192: Do not allow to send a security notification when the user account is locked.
Go MAEDA wrote:
> I could not confirm the behavior that locked users get security notifications. Could you describe the steps to reproduce?
This situation happens Ver.3.4.10, when the administrator saved after changed his/her email...
Hinako Tajima
07:19 Defect #32192: Do not allow to send a security notification when the user account is locked.
I could not confirm the behavior that locked users get security notifications. Could you describe the steps to reproduce? Go MAEDA
07:14 Defect #32192 (Closed): Do not allow to send a security notification when the user account is locked.
I suggest that to add the function which if the account is locked, make disable to send security notifications.
アカウントがロック状態の場合はセキュリティメールの通知を無効にしてほしい。
Hinako Tajima
13:32 Feature #28234: Add CSV Import for Time Entries
I've added a new ticket (#32196) where we should discuss how to allow importing time entries for other users because the current implementation sticks to the current user only. Marius BĂLTEANU
13:30 Patch #32196 (Closed): Allow import time entries for other users
#28234 allows importing time entries only for the current user. I think we should support importing for other users as well and I see two options:
1. We allow based on the new permission "Log spent time for other users" added in #3848...
Marius BĂLTEANU
13:18 Patch #32122 (Closed): Fix test failure due to missing call to set_tmp_attachments_directory
Committed the patch. Thank you for investigating the test failure. Go MAEDA
13:17 Revision 18593 (svn): Fix test failure due to missing call to set_tmp_attachments_directory (#32122).
Patch by Yuichi HARADA. Go MAEDA
13:00 Feature #1237: Add support for two-factor authentication
Please reassign this to version:"4.1.0" after the above issues are fixed. Marius BĂLTEANU
12:41 Feature #30346: Add "Target Version" to the list of "Available columns" in "Spent time" Tab
What about this issue? Is it going to plan to be added for next redmine version?
I think it's quite easy to implement and very useful and demanded. I don't know too much about redmine source code but I think patch would be very simila...
Pablo Sanxiao
08:52 Defect #32194 (Closed): Calendar page lacks buttons to manage custom queries
You can apply existing custom queries to Calendar but you cannot create, edit, or delete custom queries on the Calendar page because the page lacks "Save", "Edit", or "Delete" buttons for queries.
Like Issues and Gantt, the Calendar p...
Go MAEDA
07:17 Defect #32193 (New): Add turn on/off button to control sending security notifications
For sending security notifications, I wish to add the function that to make possible with controlling turn on/off by configuration or management console.
セキュリティ通知メールの送信を設定でON/OFFできるようにしてほしい。
Hinako Tajima
05:42 Feature #17840: Option to send email notification on "Target version updated"
The patch works fine. Setting the target version to 4.2.0. Go MAEDA
03:18 Feature #17840: Option to send email notification on "Target version updated"
This is a truly useful feature. The change of the target version is one of the important information to be notified.
The following screenshot is the notified_events configuration that I am actually using in my company. I have disabled...
Go MAEDA
02:46 Feature #17840: Option to send email notification on "Target version updated"
I added "Target version updated" checkbox to "Administration" > "Settings" > "Email notifications" tab.
!{width:410px;border:1px solid #ccc;}notified_events_target_version.png!
I attached a patch.
Yuichi HARADA
05:00 Feature #16098 (New): On relation change/add notification setting
Go MAEDA
02:20 Defect #32191 (New): Duplicate associated revisions when using multiple repositories for a project
I have a project that has several repositories linked to it. Repo A includes an extern to a folder in Repo B. When a commit is made to Repo A the associated issue displays the associated revision entry twice. Both are identical. When... Jon Schell
02:18 Revision 18592 (svn): Fix incorrect headings example in Textile help (#32184).
Patch by Go MAEDA. Go MAEDA
02:18 Defect #32184 (Resolved): Incorrect headings example in Textile help
Committed the patch. Go MAEDA
01:30 Defect #32110 (Closed): "already initialized constant Redmine::Scm::Adapters::SubversionAdapter::SVN_BIN" warning when executing rake tasks
Go MAEDA
01:30 Revision 18591 (svn): Merged r18589 from trunk to 4.0-stable (#32110).
Go MAEDA
01:28 Revision 18590 (svn): Merged r18588 from trunk to 4.0-stable (#32189).
Go MAEDA

2019-10-03

16:24 Patch #32122: Fix test failure due to missing call to set_tmp_attachments_directory
LGTM. Setting the target version to 4.2.0.
@set_tmp_attachments_directory@ and @set_fixtures_attachments_directory@ are methods which change @Attachment.storage_path@ during tests.
If a test method which creates/deletes attachments...
Go MAEDA
15:43 Defect #32184: Incorrect headings example in Textile help
Setting the target version to 3.4.12. Go MAEDA
10:23 Defect #32184: Incorrect headings example in Textile help
Here is a patch to fix this issue. Go MAEDA
08:37 Defect #32184 (Closed): Incorrect headings example in Textile help
Example in the help (source:tags/4.0.4/public/help/en/wiki_syntax_detailed_textile.html#L203): Go MAEDA
15:41 Defect #32110 (Resolved): "already initialized constant Redmine::Scm::Adapters::SubversionAdapter::SVN_BIN" warning when executing rake tasks
Committed the fix. Go MAEDA
07:57 Defect #32110: "already initialized constant Redmine::Scm::Adapters::SubversionAdapter::SVN_BIN" warning when executing rake tasks
Setting the target version to 4.0.5.
The patch to commit: #32110#note-5
Go MAEDA
15:40 Revision 18589 (svn): Fix "already initialized constant Redmine::Scm::Adapters::SubversionAdapter::SVN_BIN" warning when executing rake tasks (#32110).
Patch by Go MAEDA. Go MAEDA
15:36 Patch #32189 (Closed): Remove unnecessary requiring of "rexml/document"
Committed the fix. Go MAEDA
15:33 Patch #32189 (Closed): Remove unnecessary requiring of "rexml/document"
rexml/document is unnecessary in lib/redmine/version.rb because the code that uses the library has been removed in r10616. Go MAEDA
15:36 Revision 18588 (svn): Remove unnecessary requiring of "rexml/document" (#32189).
Go MAEDA
14:47 Defect #32183: Notification sub-events for "Issue updated" does not cover all events which consist its parent
+1
This will make the email sending condition MECE.
By the way, is Relation updated included in other attributes?
I think it is better to be independent.
https://www.redmine.org/issues/16098#note-18
Yuuki NARA
14:36 Defect #32183: Notification sub-events for "Issue updated" does not cover all events which consist its parent
+1
That's an awesome idea. :)
I've never thought of it ("Issue updated" includes "hidden" events).
Kohei Nakamura
07:54 Defect #32183: Notification sub-events for "Issue updated" does not cover all events which consist its parent
+1
So Nice!
ryou soda
07:16 Defect #32183 (New): Notification sub-events for "Issue updated" does not cover all events which consist its parent
You can configure notification events in "Administration" > "Settings" > "Select actions for which email notifications should be sent.". In the section, you can see "Issue updated" and its sub-events, "Note added", "Status updated", "Ass... Go MAEDA
14:45 Patch #32166: Rounded corners on table.gantt-table
Go MAEDA wrote:
> Thank you for posting the patch.
> ...
Thanks for pointing it out. I did this on purpose, to mark the gantt containing parent table (table.gantt-table), so it would kind of be exactly like calendar in styling, or else...
Anonymous
14:24 Patch #32166: Rounded corners on table.gantt-table
Thank you for posting the patch.
But I found a small issue. You will see an unnecessary vertical line after applying the patch. Please see the screenshots below.
*Before:*
!{width: 250px;}.unnecessary-line-before@2x.png!
*After...
Go MAEDA
14:29 Patch #29216: Replace the searchbox label in the header with a placeholder
I like the idea with _clear_ button, but I think it wastes horizontal space of the bar when typing while appearing from the other side, the search icon is really useless after you already began typing in the bar anyway. I think search ic... Anonymous
14:10 Patch #32165 (Closed): Rounded corners on table.cal
Go MAEDA
14:09 Patch #32165: Rounded corners on table.cal
Committed the patch. Thank you. Go MAEDA
14:09 Revision 18587 (svn): Rounded corners on table.cal (#32165).
Patch by Antonio McDeal. Go MAEDA
13:49 Defect #32187: Email notifications and create ticket
ok no problem. sorry, i have create a new discussion in "how to". brice wilmet
13:45 Defect #32187 (Closed): Email notifications and create ticket
Go MAEDA
13:45 Defect #32187: Email notifications and create ticket
Please use forums for "how to" questions. Issues are used to report a bug, suggesting a new feature, or submitting a patch. Reading "How to request help":http://www.redmine.org/boards/2/topics/667 may be helpful for you. Go MAEDA
13:42 Defect #32187 (Closed): Email notifications and create ticket
Hi,
I have redmine application in my company.
I use this for create ticket for any problem for my customers.
Ticket automaticaly create when one customer send email.
After my customer is notifie by email when this ticket is crea...
brice wilmet
11:31 Feature #29752 (Closed): Render Textile and Markdown attachments on the preview page
Committed the patch #29752#note-13 in r18586. Go MAEDA
09:01 Feature #29752: Render Textile and Markdown attachments on the preview page
This patch replaces the regexp that checks '.textile' extension with @Redmine::MimeType.of@. Go MAEDA
08:47 Feature #29752: Render Textile and Markdown attachments on the preview page
Go MAEDA wrote:
> Marius BALTEANU wrote:
> ...
I like your idea to use "text/x-textile".
Marius BĂLTEANU
03:36 Feature #29752 (Reopened): Render Textile and Markdown attachments on the preview page
Mischa The Evil wrote:
> What about the note Marius made in #29752#note-5?
Oh, I forgot to handle that. Thank you for pointing it out.
Marius BALTEANU wrote:
> ...
I like the approach but there is only one problem that "text/text...
Go MAEDA
03:04 Feature #29752: Render Textile and Markdown attachments on the preview page
Go MAEDA wrote:
> Committed the patch. [...]
What about the note Marius made in #29752#note-5?
Mischa The Evil
02:33 Feature #29752 (Closed): Render Textile and Markdown attachments on the preview page
Committed the patch. Thank you all for contributing and reviewing the patch. Go MAEDA
11:30 Revision 18586 (svn): Use Redmine::MimeType.of instead of regexp to check if the attachment is Textile (#29752).
Go MAEDA
10:29 Feature #5840: Live lookup of the existing issues based on the keywords entered in the title for new issue
+1: I tried another approach to create a feature that displays issues with similar subjects.
By using the existing action "/issues/auto_complete" in Ajax, the feature could be implemented with a little changes.
The UI is as shown belo...
Takenori TAKAKI
03:46 Feature #16098: On relation change/add notification setting
Go MAEDA wrote:
> Go MAEDA wrote:
> ...
Thank you for pointing it out. The reason for the incorrect assertion result was not enough fixtures.
I rewrote the patch.
Yuichi HARADA
02:32 Revision 18585 (svn): Add styles for Textile/Markdown attachments preview (#29752).
Patch by Go MAEDA. Go MAEDA
02:09 Revision 18584 (svn): Render Textile and Markdown attachments on the preview page (#29752).
Patch by Takenori TAKAKI. Go MAEDA
02:08 Revision 18583 (svn): RuboCop: Disable Layout/SpaceInsideHashLiteralBraces
Go MAEDA
 

Also available in: Atom