Redmine

Patch to apply against redmine-0.8.4

I think a new permission would be required if we add this feature.

You can update the patch to version 0.9.3?

This patch is not entirely correct, since there is no information who (instead of the user) has made him the information. In addition, there is a need to create new questions and make comments from another user. Both questions are needed when the user is not possible to do it yourself, and he asked the operator to do so by phone.

I'm very interested in this patch. Is the patch submitted by Oleg still working ?
We are running redmine against trunk r4359.

I still think this is a very useful feature. In our company, we have projects where the workers do not encode their spent times themselves.
Eric and Jean-Philippe both have shown interest in this so I am hopeful in seeing this integrated in trunk ?

Is there any plan to include this in current?

this worked for 1.3.3
but unfortunately last patch doesn't work with current 2.x.x
any suggestions?

Maybe this could be a candidate for 2.4?

Agreed. This is definitely something I need (my co-workers are very lazy on logging their times).

The last patch requires ruby >= 1.9.2.

+1 for including this in asap

Paul Freund wrote:

The patch from Gary Watson also works with version 2.4.2 if you remove the diff for issue.rb. I've attatched an updated patch. All use cases we tested worked but I can't guarantee it works in all.

is there any plan to include this functionality in trunk?

I just threw together a hacky plugin that seeks to achieve the same thing
It doesn't check any permissions and probably has other bugs, but it works for us on redmine 2.6 without hacking core:

https://github.com/evolvingweb/redmine_timesheet_log_user

We tested Patrick Halfars patch, Redmine_foreign_timelog.patch and it breaks redmine 2.6.1.

+1 is there a plugin for that?

Our Admin only want to implement plugins and no patch files. Thanks a Lot!

Unfortunately this path doesn't work in redmine 3.x.
If you select another person you want to log time for, you'll get time entries logged by yourself and not by that person.

We use this plugin http://www.redmine.org/plugins/redmine_work_time with Redmine 3.1.0. It allows to add / edit work time of another users. But it is not very simple, please add this functionality to Redmine core!

How select collection: assigned and current user only?

My Synology docker Redmine recently went to 3.3.6-1 so instead of manually patching I just put it in a plugin. I'll be adding my own custom stuff, but for now the master version is just a plugin for Patrik's 3.2 patch. YMMV, and it's my first attempt at ruby and Redmine plugins.
https://github.com/gferley/redmine_ferplugin

Grant Ferley wrote:

My Synology docker Redmine recently went to 3.3.6-1 so instead of manually patching I just put it in a plugin. I'll be adding my own custom stuff, but for now the master version is just a plugin for Patrik's 3.2 patch. YMMV, and it's my first attempt at ruby and Redmine plugins.
https://github.com/gferley/redmine_ferplugin

great! do you know if your plugins supports also redmine 3.2.1. If so I can be your alpha tester...

By the way, the issue is already 8 years old. Is there any plan to integrate this patch into latest 3.x branch or maybe even into 4.0 branch?

Marius, thank you for your great work. This is one of the long-awaited features.

The patch 0001-Allow-the-current-user-to-log-time-for-other-users.patch works almost fine, however, I found only one small issue. Users who don't have "Log spent time" permission should not be able to access TimelogController#new page, however, they can access the page via "+" button if they have "Log time for other users" permission. They can fill the form but they will see 403 error after hitting "Create" button.

I really like the idea of this feature and would love to have the ability to log time for other users in Redmine. Good job on polishing the patch and making it ready for inclusion, Marius!

I still have some behavior-related comments about the latest patch by Marius from #3848-44:

• If the current user doesn't have the permission to edit time entries for other users, I would rather see the creation / edit of a time entry rejected rather than silently logged to the current user, e.g. with a validation error. The currentlt defined behavior could lead to unexpected data, esp. when used via the API
• TimelogHelper#user_collection_for_select_options should probably use collection = project.members.active.map(&:user) to ensure that locked users don't show up in the list of users
• The list of allowed users should be checked with a validation on the TimeEntry model too in order to prevent someone assigning hours to arbitrary users.
• In the TimelogController#create action, we will see an exception if somene (e.g. via the API) doesn't correctly provide params[:time_entries]. This case should be handled.

Holger Just wrote:

I really like the idea of this feature and would love to have the ability to log time for other users in Redmine. Good job on polishing the patch and making it ready for inclusion, Marius!

I still have some behavior-related comments about the latest patch by Marius from #3848-44:

• If the current user doesn't have the permission to edit time entries for other users, I would rather see the creation / edit of a time entry rejected rather than silently logged to the current user, e.g. with a validation error. The currentlt defined behavior could lead to unexpected data, esp. when used via the API
• TimelogHelper#user_collection_for_select_options should probably use collection = project.members.active.map(&:user) to ensure that locked users don't show up in the list of users
• The list of allowed users should be checked with a validation on the TimeEntry model too in order to prevent someone assigning hours to arbitrary users.
• In the TimelogController#create action, we will see an exception if somene (e.g. via the API) doesn't correctly provide params[:time_entries]. This case should be handled.

Thanks Holger for your feedback. I'll update my patch these days to integrate your feedback.

Oh, sorry, I've missed to update the translation for en-GB.yml in my previous patch (source:trunk/config/locales/en-GB.yml#L1263).

Hello, thanks for the good work.

Is there a patch that I can apply on redmine 4.0.7? I can't upgrade because of redmine debian multiple instances solution we use.