Redmine

2019-09-13

23:44 Feature #8016: Drag-and-drop issue (ticket) ordering

+1 Frederic Defoy

20:41 Defect #31708: Not able to add member to a project

libjs-jquery-ui updated itself after upgrade from Ubuntu 17.10 Artful while doing dist-upgrade... Even tried to get b... Paweł Szmigiel

16:51 Defect #31708: Not able to add member to a project

Paweł Szmigiel wrote:
> I figured out that this problem is connected to the jquery-ui version 1.12, which has Deprec... Go MAEDA

14:43 Defect #31708: Not able to add member to a project

I figured out that this problem is connected to the jquery-ui version 1.12, which has Deprecated .zIndex() function. ... Paweł Szmigiel

16:44 Revision 18467 (svn): Merged r18377 from trunk to 4.0-stable (#31870).

Go MAEDA

15:46 Revision 18466 (svn): code cleanup: rubocop: fix Layout/IndentationConsistency in test/functional/repositories_git_controller_test.rb

Toshi MARUYAMA

15:09 Feature #3224: Better project list

related to #29482 Sebastian Paluch

11:27 Defect #32003: Project copy always send email notifications ignoring "Send email notifications during the project copy" option

this method is problematic and should be deprecated because it can't reliably work with async deliveries https://gith... Pavel Rosický

08:01 Defect #32003 (Confirmed): Project copy always send email notifications ignoring "Send email notifications during the project copy" option

The option does not work since Redmine 4.0.0. Probably it is caused by #26791. Replacing @deliver_later@ with @delive... Go MAEDA

10:52 Patch #32025 (Closed): mail_body method in test/test_helper.rb raises an exception if the message is not multipart

Committed the fix. Thank you for catching the issue. Go MAEDA

03:58 Patch #32025: mail_body method in test/test_helper.rb raises an exception if the message is not multipart

Go MAEDA wrote:
> The root cause of the issue is that @mail_body@ method in test/test_helper.rb supports only multi-... Yuichi HARADA

02:47 Patch #32025: mail_body method in test/test_helper.rb raises an exception if the message is not multipart

Thank you for catching and investigating the issue.
The root cause of the issue is that @mail_body@ method in test... Go MAEDA

10:51 Revision 18465 (svn): mail_body method in test/test_helper.rb raises an exception if the message is not multipart (#32025).

This change fixes random test failures. Go MAEDA

07:00 Revision 18464 (svn): code clean up test/functional/repositories_mercurial_controller_test.rb

Toshi MARUYAMA

07:00 Revision 18463 (svn): code clean up test/functional/repositories_git_controller_test.rb

Toshi MARUYAMA

07:00 Revision 18462 (svn): code cleanup: rubocop: fix Style/MethodCallWithoutArgsParentheses in test/functional/repositories_git_controller_test.rb

Toshi MARUYAMA

05:17 Feature #14300: E-mail notification for things I am assigned to or I am owner of

I am against this change.
Watchers are supposed to receive email notifications. When a user adds another user as a... Go MAEDA

04:25 Revision 18461 (svn): rubocop: disable Naming/PredicateName

Toshi MARUYAMA

00:56 Defect #32046 (Closed): SQL to get counts when using created_on in MySQL to group issues does not work correctly

Committed the fix as a part of #13803. Thank you all for working on fixing the issue. Go MAEDA

00:55 Revision 18460 (svn): Fix that date grouping for MySQL is not working (#32046, #13803).

Patch by Mizuki ISHIKAWA. Go MAEDA

00:17 Feature #1448: Add tags to issues

I would like to discuss this for the next major release, it is one of the most requested feature. Marius BĂLTEANU

00:16 Feature #1448: Add tags to issues

Updated the patch to apply cleanly on the current trunk.
Marius BĂLTEANU

2019-09-12

23:54 Patch #32054 (Closed): Add test for 4 byte characters (emoji) support

In #31921 was added proper support for 4 byte characters (emoji) for new installations with MySQL as database.
I ... Marius BĂLTEANU

23:53 Feature #31910 (Closed): Add additional mail headers for issue tracker

Committed the patch. Thank you for suggesting this improvement. Go MAEDA

23:52 Revision 18459 (svn): Add additional mail headers for issue tracker (#31910).

Patch by Go MAEDA. Go MAEDA

23:46 Defect #32046: SQL to get counts when using created_on in MySQL to group issues does not work correctly

Go MAEDA wrote:
> Marius, could you review this patch? It updates MySQL support for the date grouping filter option ... Marius BĂLTEANU

19:25 Defect #31986: Error selecting issues between dates after upgrading redmine 2.3.2 to 4.0.x

Adauto Serpa wrote:
> Hi,
>
> I'm having problem to upgrade redmine 2.3.2 to 4.0.
>
> After the Redmine update... Adauto Serpa

18:23 Revision 18458 (svn): code cleanup: rubocop: fix Lint/HandleExceptions in lib/redmine/scm/adapters/mercurial_adapter.rb

Toshi MARUYAMA

18:23 Revision 18457 (svn): rubocop: use Lint/HandleExceptions AllowComments true

Toshi MARUYAMA

18:18 Feature #31300: Automatically switch between native date picker and custom date picker based on mobile or not mobile devices

I vote for this. We recently updated to 3.4.11 from 3.2.? and discovered that our corporate standard date format (yy... James Byrne

17:08 Revision 18456 (svn): code cleanup: rubocop: fix Lint/AmbiguousOperator in lib/redmine/scm/adapters/mercurial_adapter.rb

Toshi MARUYAMA

14:51 Patch #13468 (Closed): REST API for News

Go MAEDA wrote:
> The test fails due to a missing fixture.
Committed in r18455.
Go MAEDA

14:48 Patch #13468 (Reopened): REST API for News

The test fails due to a missing fixture.... Go MAEDA

14:51 Revision 18455 (svn): Add missing fixture (#13468).

Go MAEDA

12:08 Feature #32052: Auto-complete issues #id in search form

I think this small but great improvement should be delivered together with #31989. Setting the target version to 4.1.0. Go MAEDA

09:09 Feature #32052: Auto-complete issues #id in search form

I attached a patch.
* The change to inlineAutoComplete is to disable the autocomplete built-in Firefox browser.
!... Mizuki ISHIKAWA

08:59 Feature #32052 (Closed): Auto-complete issues #id in search form

I think it would be useful to be able to autocomplete #id in the search form.
Example:
!{width: 500px; border: 1p... Mizuki ISHIKAWA

12:02 Feature #31921 (Closed): Changes to properly support 4 byte characters (emoji) when database is MySQL

Committed the updated patch in #31921#note-33. Thanks. Go MAEDA

12:02 Revision 18454 (svn): Update default database config for MySQL to support 4 byte characters (emoji) (#31921).

Patch by Marius BALTEANU and Go MAEDA. Go MAEDA

09:39 Defect #32047: Do not delete parent issues that have child issues

Go Maeda,good!
I would like to request the same way
Hirofumi Kadoya

07:27 Revision 18453 (svn): code cleanup: scm: cvs: remove unused branchPoint method from CvsRevisionHelper class

Toshi MARUYAMA

04:39 Patch #31640: Add clear query icon next to selected query in sidebar

Marius BALTEANU wrote:
> Regarding the patch, you have attached a wrong one.
Sorry, here is the correct patch.
Go MAEDA

01:36 Patch #31994 (Closed): Allow issue auto complete to return 10 issues when there is not search term provided

Mischa The Evil wrote:
> Shouldn't this change be reflected in the name of the test that is committed (@test_auto_co... Go MAEDA

01:31 Revision 18452 (svn): Fix the test name different from the actual behavior (#31994).

Patch by Marius BALTEANU. Go MAEDA

2019-09-11

22:19 Feature #13919: Mention user on issues and wiki pages using @user with autocomplete

Mizuki ISHIKAWA wrote:
>
> Thank you for your activity on this Issue(feature)!
> The implementation using the "ac... Marius BĂLTEANU

02:24 Feature #13919: Mention user on issues and wiki pages using @user with autocomplete

Marius BALTEANU wrote:
> Please let me know what do you think about this.
Thank you for your activity on this Iss... Mizuki ISHIKAWA

21:44 Patch #31994 (Reopened): Allow issue auto complete to return 10 issues when there is not search term provided

Mischa The Evil wrote:
> Marius BALTEANU wrote:
> > Go MAEDA wrote:
> > > The subject says "return last 10 updated... Marius BĂLTEANU

19:36 Patch #31994: Allow issue auto complete to return 10 issues when there is not search term provided

Marius BALTEANU wrote:
> Go MAEDA wrote:
> > The subject says "return last 10 updated issues" but actually the patc... Mischa The Evil

09:18 Patch #31994 (Closed): Allow issue auto complete to return 10 issues when there is not search term provided

Committed the patches. Thank you for your contribution. Go MAEDA

09:16 Patch #31994: Allow issue auto complete to return 10 issues when there is not search term provided

Marius BALTEANU wrote:
> Second patch removes a view that is not used from my checks (code cleanup).
app/views/au... Go MAEDA

13:00 Defect #32047: Do not delete parent issues that have child issues

+1
Sounds like a great idea and prevents the user from unforeseen side effects. Bernhard Rohloff

11:24 Defect #32047: Do not delete parent issues that have child issues

+1
How about showing a confirmation dialog like the following instead of disallowing to delete a parent issue? In th... Go MAEDA

09:19 Defect #32047 (New): Do not delete parent issues that have child issues

Do not delete parent issues that have child issues please
--jp--
子チケットがあるチケットを削除した場合、子チケット含めて消えてしまいます
子チケットがある親チ... Hirofumi Kadoya

12:57 Defect #32049 (Closed): Redmine allows same user to login from different machines simulteniously

Using Redmine 4.0.4
Able to Login using same user credentials from different machines at same time.
Expected :... Amit Mehendale

10:08 Revision 18451 (svn): Code cleanup: RuboCop: Fix Performance/RedundantMatch and Rails/DynamicFindBy in app/controllers/auto_completes_controller.rb

Go MAEDA

09:18 Revision 18450 (svn): Remove 'app/views/auto_completes/issues.html.erb' which is not used (#31994).

Patch by Marius BALTEANU. Go MAEDA

08:39 Revision 18449 (svn): Issue auto complete should return last 10 issues (#31994).

Patch by Marius BALTEANU. Go MAEDA

08:05 Defect #32046: SQL to get counts when using created_on in MySQL to group issues does not work correctly

Marius, could you review this patch? It updates MySQL support for the date grouping filter option committed in r17745. Go MAEDA

02:37 Defect #32046: SQL to get counts when using created_on in MySQL to group issues does not work correctly

You have to make changes like the diff below.... Mizuki ISHIKAWA

02:36 Defect #32046 (Closed): SQL to get counts when using created_on in MySQL to group issues does not work correctly

Reproduction procedure
* Use MySQL
* "Time zone data":https://dev.mysql.com/doc/refman/5.6/en/mysql-tzinfo-to-sql.h... Mizuki ISHIKAWA

07:51 Revision 18448 (svn): code cleanup: rubocop: fix Layout/SpaceInsideReferenceBrackets in test/unit/lib/redmine/scm/adapters/git_adapter_test.rb

Toshi MARUYAMA

07:50 Revision 18447 (svn): code cleanup: rubocop: fix Layout/SpaceInsideReferenceBrackets in lib/redmine/scm/adapters/subversion_adapter.rb

Toshi MARUYAMA

07:15 Patch #13468: REST API for News

Sorry, I should have run tests locally before commenting.
Thanks for fixing. vzvu 3k6k

03:53 Patch #13468: REST API for News

Yuichi HARADA wrote:
> @Redmine::ApiTest::NewsTest#test_GET_/news/:id.xml@ fails if config.time_zone is set.
Comm... Go MAEDA

04:07 Defect #30467 (Closed): Footer is not placed at the bottom on pages with little content

Marius BALTEANU wrote:
> I think it's safer to target the wrapper elements by their id instead of using "starting wi... Go MAEDA

04:06 Revision 18446 (svn): Don't use ^= operator to target the wrapper elements (#30467).

Patch by Marius BALTEANU. Go MAEDA

03:53 Revision 18445 (svn): Fix that Redmine::ApiTest::NewsTest fails when config.time_zone is set (#13468).

Patch by Yuichi HARADA. Go MAEDA

02:49 Defect #31972: An empty group_count badge is displayed when grouped with created_on

I forgot to attach the patch.
Change the same as "timelog":http://www.redmine.org/projects/redmine/repository/entry/... Mizuki ISHIKAWA