Redmine

2021-04-03

18:56 Defect #33752: Uploading a big file fails with NoMemoryError

@Go MAEDA may I ask for a review? it's a simple change. Pavel Rosický

18:46 Patch #35025 (Closed): Update capybara to 3.36

https://github.com/teamcapybara/capybara/blob/master/History.md Pavel Rosický

18:08 Patch #35024 (Closed): System test fails in Windows due to "/" path separator

Chrome expects backslashes and it doesn't recognize "/" separators on Windows.
fixes... Pavel Rosický

15:14 Feature #34981: Allow to change a project identifier

here's the patch for testing Pavel Rosický

04:32 Feature #34981: Allow to change a project identifier

I have a POC patch with this feature and I have a few questions:
1/ based on https://github.com/paginagmbh/redmine_p... Pavel Rosický

12:53 Defect #35017 (Closed): X-Redmine-Issue-Assignee email header field is empty when the assignee of an issue is a group

When I assign an issue to a group, the X-Redmine-Issue-Assignee: header in the notification mail is empty.
As is:
... Akihiro MATOBA

11:51 Patch #35016 (Closed): French translations for two-factor authentication

Hello,
I attached a patch for french translation for the two fa feature :) Sébastien NOIRIE

11:43 Feature #34978: Add the list of supported browsers to docs and drop support for IE 11

for those who still rely on Internet Explorer 11 (even if I don't understand why), they should stay on Redmine 4.x or... Pavel Rosický

08:43 Feature #34978: Add the list of supported browsers to docs and drop support for IE 11

Marius BALTEANU wrote:
> Also, I don't think that Redmine 5.0.0 will be released sooner than this autumn (6 months f... Go MAEDA

08:17 Feature #34978: Add the list of supported browsers to docs and drop support for IE 11

Most of the well know platforms already ended support for IE (Github, Gitlab, Jira, Gmail, etc) and the fact that Mic... Marius BĂLTEANU

11:12 Feature #34992 (Resolved): Ruby 3.0 support

Committed the patches. Thank you. Go MAEDA

08:44 Feature #34992: Ruby 3.0 support

All tests pass on Ruby 3.0 if we apply first 2 patches (the second one is the one posted by Pavel in #34986).
The ... Marius BĂLTEANU

11:11 Revision 20913 (svn): Ruby 3.0: Update supported Ruby versions (#34992).

Go MAEDA

11:04 Defect #34986 (Closed): Ruby 3.0 fix super calls

Committed the patch as a part of #34992. Thank you. Go MAEDA

11:01 Revision 20912 (svn): Ruby 3.0: Fix `super` calls (#34992, #34986).

Patch by Pavel Rosický. Go MAEDA

09:12 Revision 20911 (svn): Remove trailing whitespaces in doc/INSTALL and doc/UPGRADING.

Go MAEDA

08:46 Patch #35012 (Closed): Czech translations

Committed the patch. Thank you. Go MAEDA

08:46 Revision 20910 (svn): Czech translation update (#35012).

Patch by Pavel Rosický. Go MAEDA

08:37 Feature #35014 (Closed): Review and update supported database engines and versions

Supported database engines and versions were not been updated for a while and we should do it in Redmine version:"6.0... Marius BĂLTEANU

08:31 Patch #35011 (Closed): Traditional Chinese translation (to r20905)

Committed the patch. Thank you. Go MAEDA

08:30 Revision 20909 (svn): Traditional Chinese translation update (#35011).

Patch by ChunChang Lo. Go MAEDA

07:55 Patch #32922: Reload detached attachments

This change passes all the tests now: https://gitlab.com/redmine-org/redmine/-/pipelines/280930686
The fail report... Marius BĂLTEANU

03:38 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading

Marius BALTEANU wrote:
> We should update Rubocop TargetRailsVersion to 6.1
Done in r20908. Go MAEDA

03:38 Revision 20908 (svn): Set TargetRailsVersion of RuboCop to 6.1 (#29914).

Go MAEDA

03:34 Patch #32909 (Closed): Replace pluck().first with pick()

Committed the patch. Thank you. Go MAEDA

03:34 Revision 20907 (svn): Replace pluck().first with pick() (#32909).

Patch by Pavel Rosický and Marius BALTEANU. Go MAEDA

03:09 Defect #35009: db migration failed after updating to r20905

Hi,
In fact, I do have a secret_token.rb file.
It was dated back to 2012.
Should I run the command, bundle exec ... ChunChang (Nagaharu) Lo

03:07 Defect #35005 (Closed): RuntimeError "Couldn't find Active Storage configuration" is raised at startup

Committed the fix as a part of #29914. Go MAEDA

03:06 Revision 20906 (svn): RuntimeError "Couldn't find Active Storage configuration" is raised at startup (#29914, #35005).

Go MAEDA

2021-04-02

22:50 Patch #32909: Replace pluck().first with pick()

I've rebased the patches added by Pavel, the changes looks good to me. Marius BĂLTEANU

22:49 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading

We should update Rubocop TargetRailsVersion to 6.1 Marius BĂLTEANU

07:57 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading

I've created #35002 to track the compatibility with MS SQL. Marius BĂLTEANU

03:17 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading

Pavel Rosický wrote:
> @yuichi activerecord-sqlserver-adapter doesn't support Rails 6.1 yet, but there's an open PR
... Yuichi HARADA

02:47 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading

@yuichi activerecord-sqlserver-adapter doesn't support Rails 6.1 yet, but there's an open PR
https://github.com/rail... Pavel Rosický

02:35 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading

Updating activerecord-sqlserver-adapter with r20900, but when I execute @bundle update@, the following error occurs.
... Yuichi HARADA

22:29 Defect #35009: db migration failed after updating to r20905

Do you have the secret token generated? It should be in @config/initializers/secret_token.rb@. If not, you can run @b... Marius BĂLTEANU

19:22 Defect #35009 (Closed): db migration failed after updating to r20905

error message was:
ArgumentError: Missing `secret_key_base` for 'development' environment, set this string with `bin... ChunChang (Nagaharu) Lo

22:17 Defect #35005: RuntimeError "Couldn't find Active Storage configuration" is raised at startup

Looks good to me. Marius BĂLTEANU

10:14 Defect #35005: RuntimeError "Couldn't find Active Storage configuration" is raised at startup

We can fix this by making the following change. Redmine currently does not use active_storage, so commenting out this... Go MAEDA

10:09 Defect #35005 (Closed): RuntimeError "Couldn't find Active Storage configuration" is raised at startup

Trying to run Redmine in production mode results in the error "Couldn't find Active Storage configuration in /path/to... Go MAEDA

22:15 Defect #35010 (Closed): redmine failed to start after updating to r20905

Duplicates #35005. Marius BĂLTEANU

20:12 Defect #35010 (Closed): redmine failed to start after updating to r20905

error message was:
Couldn't find Active Storage configuration in /var/www/html/redmine/config/storage.yml (RuntimeEr... ChunChang (Nagaharu) Lo

20:40 Patch #35012 (Closed): Czech translations

Pavel Rosický

20:36 Patch #35011 (Closed): Traditional Chinese translation (to r20905)

* New tag added
** error_invalid_authenticity_token, error_query_statement_invalid ChunChang (Nagaharu) Lo

16:35 Defect #35004: DEPRECATION WARNING during startup

refs #32938 Pavel Rosický

09:25 Defect #35004 (Closed): DEPRECATION WARNING during startup

... Go MAEDA

08:31 Feature #3143: Add an 'Add Note' function to issue, to avoid optimistic-lock of issue' update when user just want to add a note

Ismael Barros² wrote:
> Directories @a/@ and @b/@ won't actually exist on your filesystem, so I think you need to us... Leo L.

08:07 Defect #35003 (Closed): Update Rails UJS

Marius BĂLTEANU

07:56 Defect #35002 (Closed): Fix MS SQL on Rails 6.1

MS SQL support is broken for now because the gem supports only Rails 6.0, but I'm confident that will be fixed in the... Marius BĂLTEANU

07:55 Defect #32910 (Closed): Rails 6: add lookup_context to hook_test.rb

Fixed by r20889. Marius BĂLTEANU

05:26 Feature #35001: Disable API authentication with username and password when two-factor authentication is enabled for the user

The following code is a sample implementation.... Go MAEDA

05:18 Feature #35001 (Closed): Disable API authentication with username and password when two-factor authentication is enabled for the user

In Redmine 4.2, two-factor authentication has been introduced.
When two-factor authentication is enabled, it becom... Go MAEDA

04:11 Patch #35000 (Closed): Update SimpleCov to 0.21

Done. Go MAEDA

04:07 Patch #35000 (Closed): Update SimpleCov to 0.21

Go MAEDA

04:10 Revision 20905 (svn): Update SimpleCov to 0.21 (#35000).

Go MAEDA

01:11 Feature #32938: Rails 6: Zeitwerk support

I had to remove some references due to your spam protection :) Pavel Rosický

01:10 Feature #32938: Rails 6: Zeitwerk support

sry, I don't. This is a pretty heavy change and Redmine has a lot of technical debt in this area. But I have a few hi... Pavel Rosický

2021-04-01

21:52 Feature #3143: Add an 'Add Note' function to issue, to avoid optimistic-lock of issue' update when user just want to add a note

Directories @a/@ and @b/@ won't actually exist on your filesystem, so I think you need to use @patch -p1@ instead of ... Ismael Barros²

18:16 Feature #3143: Add an 'Add Note' function to issue, to avoid optimistic-lock of issue' update when user just want to add a note

Ismael Barros² wrote:
> Which command did you use to apply the patch? @patch -p0@? @patch -p1@? @git apply@?
Hey ... Leo L.

21:46 Feature #32938: Rails 6: Zeitwerk support

Pavel, do you have any working patch for this? Marius BĂLTEANU

21:42 Defect #34999 (Closed): The result of Attachment.latest_attach is unstable if attachments have the same timestamp

refs #27780
test_latest_attach_should_support_unicode_case_folding... Pavel Rosický

20:13 Defect #32885: Rails 6: DEPRECATION WARNING: Single arity template handlers are deprecated

why not use the source directly? see the patch file Pavel Rosický

19:16 Defect #32885 (Closed): Rails 6: DEPRECATION WARNING: Single arity template handlers are deprecated

Done in r20886 as a part of #29914. Go MAEDA

19:05 Feature #31128 (Closed): Drop Ruby < 2.5 support

Done. Go MAEDA

19:05 Revision 20904 (svn): Set TargetRubyVersion of RuboCop to 2.5 (#31128).

Go MAEDA

18:27 Revision 20903 (svn): Update .rubocop_todo.yml (#31128).

Go MAEDA

18:20 Revision 20902 (svn): Drop Ruby < 2.5 support (#31128).

Go MAEDA

18:12 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading

Committed 19 patches attached to #29914#note-38 and #29914#note-39 (r20879 .. r20901). Go MAEDA

10:29 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading

Go MAEDA wrote:
> The following error was reported while running the test suite.
>
> [...]
I will fix @Reposit... Go MAEDA

09:58 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading

The following error was reported while running the test suite.... Go MAEDA

18:06 Revision 20901 (svn): Fix a test failure caused by an assert forgotten to be deleted (#29914, #32913).

Go MAEDA

17:48 Revision 20900 (svn): Update activerecord-sqlserver-adapter to 6.0.1 (#29914).

Go MAEDA

17:45 Defect #32935 (Closed): Rails 6: fix set role_ids

Committed the patch as a part of #29914.
Go MAEDA

17:45 Revision 20899 (svn): Rails 6.1: fix set roleids (#29914, #32935).

Patch by Pavel Rosický. Go MAEDA

17:41 Revision 20898 (svn): Fix "DEPRECATION WARNING: Calling '<<' to an ActiveModel::Errors message array in order to add an error is deprecated." (#29914, #34985).

Go MAEDA

17:37 Defect #34984 (Closed): Rails 6.1 Rendering actions with '.' in the name is deprecated

Committed the patch as a part of #29914.
Go MAEDA

17:36 Revision 20897 (svn): Fix "DEPRECATION WARNING: Rendering actions with '.' in the name is deprecated: common/error_messages.api" (#29914, #34984).

Patch by Pavel Rosický. Go MAEDA

17:34 Revision 20896 (svn): Reverts r20895 (#29914, #34985).

Wrong issue number. Go MAEDA

17:27 Defect #34985 (Closed): Rails 6.1 replace ActiveModel::Errors #<< with #add

Committed the patch as a part of #29914.
Go MAEDA

17:27 Revision 20895 (svn): Fix "DEPRECATION WARNING: Rendering actions with '.' in the name is deprecated: common/error_messages.api" (#29914, #34985).

Patch by Pavel Rosický. Go MAEDA

17:25 Defect #32923 (Closed): Rails 6: detach attachments when a conflict occurs

Committed the patch as a part of #29914.
Go MAEDA

17:25 Revision 20894 (svn): Fix detach attachments when a conflict occurs (#29914, #32923).

Patch by Pavel Rosický. Go MAEDA

17:22 Defect #32936 (Closed): Rails 6: disable AJ test adapter for integration tests

Committed the patch as a part of #29914.
Go MAEDA

17:22 Revision 20893 (svn): Disable TestAdapter on IntegrationTest (#29914, #32936).

Patch by Pavel Rosický. Go MAEDA

17:19 Defect #32914 (Closed): Rails 6: remove #filename_for_content_disposition for MS browsers

Committed the patch as a part of #29914.
Go MAEDA

17:19 Revision 20892 (svn): Remove #filename_for_content_disposition for MS browsers (#29914, #32914).

Patch by Pavel Rosický. Go MAEDA

17:16 Defect #32913 (Closed): Rails 6: add filename header

Committed the patch as a part of #29914.
Go MAEDA

17:16 Revision 20891 (svn): Add filename header (#29914, #32913).

Patch by Pavel Rosický. Go MAEDA

17:06 Revision 20890 (svn): Use media_type to get the MIME type of the request (#29914).

Patch by Marius BALTEANU. Go MAEDA

17:05 Revision 20889 (svn): Fix ArgumentError: wrong number of arguments (given 1, expected 3) (#29914).

Patch by Marius BALTEANU. Go MAEDA

17:03 Defect #32939 (Closed): Rails 6: fix plugin migrations

Committed the patch as a part of #29914.
Go MAEDA

17:02 Revision 20888 (svn): Fix "ArgumentError: wrong number of arguments (given 1, expected 2) on Redmine::PluginTest#test_migrate_redmine_plugin" (#29914, #32939).

Patch by Pavel Rosický. Go MAEDA

16:59 Defect #32921 (Closed): Rails 6: add header=present to csv tests

Committed the patch as a part of #29914.
Go MAEDA

16:59 Revision 20887 (svn): Rails 6.1: add header=present to csv tests (#29914, #32921).

Patch by Pavel Rosický. Go MAEDA

16:54 Revision 20886 (svn): Fix "ActionView::Template::Error (wrong number of arguments (given 2, expected 1))" (#29914).

Patch by Marius BALTEANU. Go MAEDA

16:53 Revision 20885 (svn): Fix "DEPRECATION WARNING: Passing a path to relative to is deprecated." (#29914).

Patch by Marius BALTEANU. Go MAEDA

16:49 Defect #32912 (Closed): Rails 6: update no longer bypass optimistic locking

Committed as a part of #29914.
Go MAEDA

16:48 Revision 20884 (svn): Fix "ActiveRecord::StaleObjectError: Attempted to update a stale object: Issue." (#29914, #32912).

Patch by Pavel Rosický. Go MAEDA

16:46 Revision 20883 (svn): Fix Subclasses must implement a find_templates(name, prefix, partial, details, locals = []) method (#29914).

Patch by Go MAEDA. Go MAEDA

16:41 Defect #32908 (Closed): Rails 6: Sending mail with DeliveryJob is deprecated

Committed as a part of #29914.
Go MAEDA

16:41 Revision 20882 (svn): Fix sending mail with DeliveryJob is deprecated (#29914, #32908).

Patch by Pavel Rosický. Go MAEDA

16:37 Defect #34980 (Closed): Fix "undefined method `represent_boolean_as_integer=' for nil:NilClass" in Rails 6.1

Committed as a part of #29914. Go MAEDA

16:35 Defect #32897 (Closed): Rails 6: Pass `case_sensitive: true` option explicitly to the uniqueness validator

Committed as a part of #29914. Go MAEDA

16:34 Revision 20881 (svn): Fix "undefined method for nil:NilClass" in Rails 6.1 (#29914, #34980).

Patch by Marius BALTEANU. Go MAEDA

16:32 Revision 20880 (svn): DEPRECATION WARNING: Uniqueness validator will no longer enforce case sensitive comparison in Rails 6.1. (#29914, #32897).

Patch by Marius BALTEANU. Go MAEDA

16:29 Revision 20879 (svn): Gemfile: Update Rails to 6.1 (#29914).

Go MAEDA

08:47 Feature #32898: PDF thumbnails support on Windows

Go MAEDA wrote:
> Steve Zhou wrote:
> > MAEDA-san, I tested the patch, it can successfully show PDF thumbnails on W... Steve Zhou

06:14 Feature #32898: PDF thumbnails support on Windows

Steve Zhou wrote:
> MAEDA-san, I tested the patch, it can successfully show PDF thumbnails on Windows with setting i... Go MAEDA

05:57 Feature #32898: PDF thumbnails support on Windows

Go MAEDA wrote:
> Steve Zhou, thank you for your feedback.
>
> Could you try the attached patch *without* setting... Steve Zhou

07:53 Defect #33127 (Closed): Assignee icon is misaligned when print stylesheet is applied

The current version of Firefox (87.0) does not have this issue. Closing. Go MAEDA

07:21 Defect #34998: Cannot open journal dropdown menu after editing note

Mizuki, one question, why not binding directly on document? Marius BĂLTEANU

03:31 Defect #34998: Cannot open journal dropdown menu after editing note

The following changes will resolve the issue.... Mizuki ISHIKAWA

02:09 Defect #34998 (Closed): Cannot open journal dropdown menu after editing note

After rewriting the journal note, clicking the journal dropdown does not open the menu. Reloading will fix the menu t... Mizuki ISHIKAWA

01:33 Feature #29285: Add "Assign to me" shortcut to issue edit form

Please open a new issue for feature requests or bug reports.
This issue has already closed and the feature has bee... Go MAEDA