Project

General

Profile

Activity

From 2016-11-17 to 2016-11-19

2016-11-19

18:52 Patch #24407 (Closed): Dutch (NL) translation enhancements and complete review (major update)
Major review and enhancements for Dutch (NL) translations on revision r15993.
Affected files:
* @config/locales/nl.yml@
* @public/javascripts/jstoolbar/lang/jstoolbar-nl.js@
Improvements and common mistakes:
* Compounds and comp...
Gregory V
14:52 Feature #23179 (Closed): Add heading to table of contents macro
Committed and tests fixed, thanks. Jean-Philippe Lang
08:03 Feature #23179: Add heading to table of contents macro
UX improvement.
Setting target version to 3.4.0.
Go MAEDA
14:51 Revision 15993 (svn): Adds label_table_of_contents i18n string (#23179).
Jean-Philippe Lang
14:50 Revision 15992 (svn): Add "Table of contents" heading to toc macro (#23179).
Jean-Philippe Lang
14:24 Revision 15991 (svn): Wrong validation introduced in r15989 (#24283).
Jean-Philippe Lang
12:17 Revision 15990 (svn): Don't replace the already entered comment when quoting a previous comment.
Jean-Philippe Lang
12:14 Patch #24283 (Resolved): Validate length of string fields
Committed, thanks. Jean-Philippe Lang
12:13 Revision 15989 (svn): Add length validations for string fields (#24283).
Patch by Felix Schäfer. Jean-Philippe Lang
12:10 Revision 15988 (svn): Use #get instead of #[] to read errors on the attribute.
Jean-Philippe Lang
11:50 Revision 15987 (svn): Don't return 2 errors when identifier is blank (blank + too short).
Jean-Philippe Lang
11:44 Revision 15986 (svn): Move the star to the right to preserve the indentation.
Jean-Philippe Lang
11:41 Revision 15985 (svn): Set the border for children of root projects only.
Jean-Philippe Lang
11:34 Revision 15984 (svn): Move the closed project checkbox out of the sidebar.
Jean-Philippe Lang
11:30 Revision 15983 (svn): Use the main menu for project related actions that support cross-project display.
Jean-Philippe Lang
11:26 Feature #22802: Add the posibility to set/change the position of an issue in a version
Jean-Philippe Lang wrote:
>
> ...
Totally agree with this approach. Thank you again for your feedback, it really help me understands some of the decisions :)
Marius BĂLTEANU
11:24 Feature #22802: Add the posibility to set/change the position of an issue in a version
Marius BALTEANU wrote:
> Jean-Philippe Lang, is there anything I can make to have this feature implemented? I'm very sure that this feature is a must (almost all modern issue trackers has this implemented) and it'll be very useful fo...
Jean-Philippe Lang
10:33 Feature #22802: Add the posibility to set/change the position of an issue in a version
One last remark:
These 2 types of prioritisation (by rank and by priority, start dates and relations) are not mutually exclusive. They work very well together because address different needs.
For example:
* The classical prioritisa...
Marius BĂLTEANU
10:21 Feature #22802: Add the posibility to set/change the position of an issue in a version
Jean-Philippe Lang wrote:
> Marius, thank you for submitting this patch but I prefer not to merge it into core. As you mentionned, we already have priorities that could be used to sort issues assigned to a version or start dates for tho...
Marius BĂLTEANU
10:03 Feature #22802: Add the posibility to set/change the position of an issue in a version
Marius, thank you for submitting this patch but I prefer not to merge it into core. As you mentionned, we already have priorities that could be used to sort issues assigned to a version or start dates for those who would like a chronolig... Jean-Philippe Lang
08:36 Feature #22802: Add the posibility to set/change the position of an issue in a version
Updated the patch to cleanly apply on the current trunk. Looking forward to see this patch committed. Marius BĂLTEANU
11:05 Feature #3425 (Closed): View progress bar of related issues
Progress bar added to the related issues. Jean-Philippe Lang
11:04 Revision 15982 (svn): View progress bar of related issues (#3425).
Jean-Philippe Lang
11:03 Revision 15981 (svn): Extracts the rendering of related issues to an helper (#3425).
Jean-Philippe Lang
10:36 Patch #24313: Use the regular "icon icon-*" classes for all elements with icons
Marius BALTEANU wrote:
> I think that one more change is required
Committed, thanks.
Jean-Philippe Lang
10:04 Patch #24313: Use the regular "icon icon-*" classes for all elements with icons
Thanks Jean-Philippe Lang for your feedback on these patches.
I think that one more change is required, you committed the *02_use_regular_icons_in_overview_tab.patch* and not the second version of the patch *02_use_regular_icons_in_ov...
Marius BĂLTEANU
09:58 Patch #24313 (Closed): Use the regular "icon icon-*" classes for all elements with icons
And I've hidden the user icon on the member list, just like it was before the patches.
All patches are now committed, thanks.
Jean-Philippe Lang
09:55 Patch #24313: Use the regular "icon icon-*" classes for all elements with icons
Patch 6 committed with several changes. I've added a few @icon-*@ (eg. @icon-sticky@) classes that are more meaningful than @icon-arrow-right@, even if they actually use the same image in the default CSS. Jean-Philippe Lang
09:28 Patch #24313: Use the regular "icon icon-*" classes for all elements with icons
Marius BALTEANU wrote:
> h3. - 05_use_regular_icons_in_search_results.patch:
> ...
There was a difference between Issue and Journal acts_as_event definition. It's fixed and I've removed the #parameterize call from the patch.
Jean-Philippe Lang
10:36 Revision 15980 (svn): Fix icon-news class (#24313).
Jean-Philippe Lang
09:57 Revision 15979 (svn): Small improvement (#24313).
Patch by Marius BALTEANU. Jean-Philippe Lang
09:53 Revision 15978 (svn): Use the regular "icon icon-*" in other pages (#24313).
Jean-Philippe Lang
09:26 Revision 15977 (svn): Use the regular "icon icon-*" on search results (#24313).
Jean-Philippe Lang
09:14 Patch #23417: Make the ID column configurable in the issues listing like the other columns
Updated the patch to cleanly apply on the current trunk. Marius BĂLTEANU
05:09 Defect #24402 (Needs feedback): sqlserver2014: db:migrate failed
Please post full log with --trace option. Toshi MARUYAMA

2016-11-18

18:52 Patch #24313: Use the regular "icon icon-*" classes for all elements with icons
Jean-Philippe Lang wrote:
> Activity view: event type class preserved in addition to the icon-* class.
I've updated the patch *05_use_regular_icons_in_search_results.patch* in order to preserve the event type class like you made in t...
Marius BĂLTEANU
17:05 Patch #24313: Use the regular "icon icon-*" classes for all elements with icons
Activity view: event type class preserved in addition to the icon-* class. Jean-Philippe Lang
17:06 Revision 15976 (svn): Use the regular "icon icon-*" on roadmap (#24313).
Patch by Marius BALTEANU. Jean-Philippe Lang
17:04 Revision 15975 (svn): Use the regular "icon icon-*" on activity view (#24313).
Patch by Marius BALTEANU. Jean-Philippe Lang
17:01 Feature #14418: Copy inner issues relations along with issues
still important and relevant Hal Glenn
17:00 Revision 15974 (svn): Adds tests for #hours_field (#23996).
Jean-Philippe Lang
15:45 Revision 15973 (svn): Use the regular "icon icon-*" on project overview (#24313).
Patch by Marius BALTEANU. Jean-Philippe Lang
15:44 Revision 15972 (svn): Use the regular "icon icon-*" for admin menu links (#24313).
Patch by Marius BALTEANU. Jean-Philippe Lang
15:39 Feature #23996 (Closed): Introduce a setting to change the display format of timespans to HH:MM
Patch committed, thanks. Jean-Philippe Lang
15:17 Revision 15971 (svn): Show the entered value when it's not valid (#23996).
Jean-Philippe Lang
14:58 Revision 15970 (svn): Test failure (#23996).
Jean-Philippe Lang
14:51 Revision 15969 (svn): Test failure (#23996).
Jean-Philippe Lang
14:49 Revision 15968 (svn): Test failure (#23996).
Jean-Philippe Lang
14:47 Revision 15967 (svn): Test broken, display hours like in other tables (#23996).
Jean-Philippe Lang
13:43 Revision 15966 (svn): Adds setting_timespan_format i18n string (#23996).
Jean-Philippe Lang
13:42 Revision 15965 (svn): Introduce a setting to change the display format of timespans to h:mm (#23996).
Patch by Jens Kraemer. Jean-Philippe Lang
13:20 Patch #24007 (Closed): Change plugins directory through the configuration.yml file
Patch committed, thanks. Jean-Philippe Lang
13:20 Revision 15964 (svn): Code cleanup (#24007).
Jean-Philippe Lang
13:14 Revision 15963 (svn): Change plugins directory through the configuration.yml file (#24007).
Patch by Helder Manuel Torres Vieira. Jean-Philippe Lang
13:11 Defect #23979 (Closed): Elements are not aligned properly in issues table for some cases
Patch committed, thanks. Jean-Philippe Lang
13:11 Revision 15962 (svn): Elements are not aligned properly in issues table for some cases (#23979).
Patch by Marius BALTEANU. Jean-Philippe Lang
13:07 Defect #24150 (Closed): Typo in class name and unidentified (left-over) code comment
Thanks Mischa, both fixes are applied. Jean-Philippe Lang
13:06 Revision 15961 (svn): Removed left-over code comment.
Jean-Philippe Lang
13:04 Revision 15960 (svn): Typo in class name (#24150).
Jean-Philippe Lang
12:57 Defect #24311 (Resolved): Project field disappears when target project disallows user to edit the project
Fixed in r15959 using a slightly different solution and tests added.
Thanks for pointing this out.
Jean-Philippe Lang
12:56 Revision 15959 (svn): Project field disappears when target project disallows user to edit the project (#24311).
Jean-Philippe Lang
09:46 Patch #24296 (Resolved): Add tablename to siblings query to prevent AmbiguousColumn errors
Jean-Philippe Lang
09:46 Patch #24296: Add tablename to siblings query to prevent AmbiguousColumn errors
Patch committed, thanks. Jean-Philippe Lang
09:46 Revision 15958 (svn): Add tablename to siblings query (#24296).
Patch by Danil Tashkinov. Jean-Philippe Lang
09:43 Defect #24308 (Closed): Allow Journal to return empty Array instead nil in Journal#attachments
Patch committed, thanks. Jean-Philippe Lang
09:41 Revision 15957 (svn): Allow Journal to return empty Array instead nil in Journal#attachments (#24308).
Patch by Roman Shipiev. Jean-Philippe Lang
09:37 Defect #24297 (Resolved): Show action not allowed for time entries in closed projects
Fix committed with a test, thanks. Jean-Philippe Lang
09:37 Revision 15956 (svn): Adds a test for #24297.
Jean-Philippe Lang
09:37 Revision 15955 (svn): Show action not allowed for time entries in closed projects (#24297).
Patch by Felix Schäfer. Jean-Philippe Lang
09:29 Defect #23922: Time Entries context menu/bulk edit shows activities not available for the time entry's project
Thanks! Felix Schäfer
09:22 Defect #23922 (Resolved): Time Entries context menu/bulk edit shows activities not available for the time entry's project
Patch applied, thanks. Bulk edit also fixed. Jean-Philippe Lang
09:23 Defect #24000 (Resolved): z-index children menu should be greater than content
Fix committed, thanks. Jean-Philippe Lang
09:23 Revision 15954 (svn): Setting z-index of project menu drop down to 45, above context menus, below modals (#24000).
Patch by Jan Schulz-Hofen. Jean-Philippe Lang
09:21 Revision 15953 (svn): Bulk edit for shows activities not available for the time entry's project (#23922).
Jean-Philippe Lang
09:19 Revision 15952 (svn): Time Entries context menu shows activities not available for the time entry's project (#23922).
Patch by Felix Schäfer. Jean-Philippe Lang
09:14 Defect #24402 (Closed): sqlserver2014: db:migrate failed
Installing Redmine-3.3.1、ruby 2.3.1p112、sqlserver2014.
run commond:db:migrate
errors:
undefine method 'type' for nil:NilClass in/opt/redmine-3.3.1/db/migrate/20160416072926_remove_position_defaults.rb
hao to fixed it?
I'm delete 20...
刘 彤彤
09:11 Defect #24041 (Resolved): Issue subject is not updated when you select another issue in the new "Log time" page
This should be fixed on both new and edit forms by r15951, thanks. Jean-Philippe Lang
09:11 Revision 15951 (svn): Issue subject is not updated when you select another issue on time entry form (#24041).
Jean-Philippe Lang
08:20 Defect #24348 (Resolved): acts_as_versioned use old style (Rails 2.x) of method call for #all
Patch committed, thanks. Jean-Philippe Lang
08:19 Revision 15950 (svn): acts_as_versioned use old style (Rails 2.x) of method call for #all (#24348).
Jean-Philippe Lang
07:15 Patch #24400 (Closed): Bulgarian translation ()
Translated:
* error_no_projects_with_tracker_allowed_for_new_issue
Changed:
* label_font_monospace
* label_font_proportional
Ivan Cenov
04:02 Feature #24399 (New): Enhance referencing and fixing issue in commit message (e.g. no space between words)
Is there any way to enhance referencing issue ID in commit message without comma and space ?
It is useful in Non-English language (no space between words).
for example, I set a keyword "处理了" for fixing issues and a keyword "处理了" for re...
Hang Xie
00:19 Defect #24397 (Closed): this text in description or note cause an internal server error
The description field cannot be larger than 64KB if MySQL is used as a backend database.
It will be fixed in Redmine 3.4.0 (not released yet). Please see #20127 for details.
Go MAEDA

2016-11-17

20:12 Feature #13919: Mention user on issues and wiki pages using @user with autocomplete
+1 Y Z
18:04 Feature #5864: Regex Text on Receiver Email
Marius BALTEANU wrote:
> We made a patch with tests that implements this feature. Without regex delimiters, we weren't able to truncate correctly the emails received. I think that this feature is really needed in core.
Does this patc...
Toshi MARUYAMA
16:44 Defect #24396 (Closed): Continuing_a_list_item_after_a_sub-item
Textile is duplicate of #18032.
Markdown:
Toshi MARUYAMA
15:09 Defect #24396 (Closed): Continuing_a_list_item_after_a_sub-item
How can i solve this issue?
[[https://en.wikipedia.org/wiki/Help:List#Continuing_a_list_item_after_a_sub-item]]
Enrico Ricci
16:34 Defect #24397 (Needs feedback): this text in description or note cause an internal server error
Please describe more details. Toshi MARUYAMA
15:26 Defect #24397 (Closed): this text in description or note cause an internal server error
tried on http://demo.redmine.org/issues/153401 Stéphane Schoorens
13:44 Feature #4602: User specific theme
Welcome :). Credit goes to the Author. Would be nice if this becomes part of standard Redmine Installation. Kush Suryavanshi
09:30 Feature #4602: User specific theme
Kush Suryavanshi wrote:
> For what it's worth, if anyone needs, the following plugin is compatible with Redmine 3.3
> ...
Thanks, work very well.
Alexandru Semenenco
13:43 Feature #5458: Extend Start/Due date to include time
I have tried this patch - 5458-use_time_in_issue_start_and_due_date_2.3_stable_V9_3.diff
I second what Roman and Victor said earlier. DateTimepicker doesn't show up in UI. This is probably what Jérôme & Daniel mentioned earlier in the t...
Kush Suryavanshi
11:43 Feature #16045: Add "Author / Previous assignee" group to assignee dropdown in issue form
Alright, this from how I patched it at our company.
As you can see from the comments, it is a work in progress.
If you like it and want to include it, I can make a "cleaner" diff and add a unit test for the last_assignee method.
(...
Luka Lüdicke
09:26 Feature #16045: Add "Author / Previous assignee" group to assignee dropdown in issue form
Luka Lüdicke wrote:
> I have a solution for this which does not require an extra column in the database for this, the information can be gathered from the @journal_details@
Sounds great. Could you attach your patch to this issue?
Go MAEDA
09:18 Feature #16045: Add "Author / Previous assignee" group to assignee dropdown in issue form
I have a solution for this which does not require an extra column in the database for this, the information can be gathered from the @journal_details@
I am mentioning it just in case the reason for ignoring this proposal is the extra ...
Luka Lüdicke
08:55 Defect #10189: Inline image does not work with spaces in file name
+1 Jose Mari M
08:05 Feature #7774: Sub groups or Multi-level groups
+1
I uses redmine for 300 users and this feature is a must to have :)
Patrick LANVIN
03:36 Feature #24065 (Closed): Commit message shouldn't be rendered by Markdown or Textile
Marius BALTEANU wrote:
> Duplicates #22758?
Thank you for your pointing out.
Toshi MARUYAMA
01:33 Patch #24189: Time entry form - limit issue autocomplete to already selected project
This patch works fine for me. The candidates displayed on the screen is only the issues of the selected project.
Setting target version to 3.4.0.
Go MAEDA
 

Also available in: Atom