Project

General

Profile

Activity

From 2017-08-12 to 2017-08-14

2017-08-14

22:51 Patch #26655: Additional icon for contextmenu
Marius BALTEANU wrote:
> From my knowledge, the drag and drop handlers have a green arrow as icon.
You are right, I am sorry, the 3 dots are used in a theme, and vertical dots are used as drag and drop handlers in Gmail for example too.
Felix Schäfer
22:33 Patch #26655: Additional icon for contextmenu
Felix Schäfer wrote:
> Marius BALTEANU wrote:
> ...
From my knowledge, the drag and drop handlers have a green arrow as icon. Anyway, it is not so important how the dots are displayed, both options look good to me and also, the dots ca...
Marius BĂLTEANU
22:17 Patch #26655: Additional icon for contextmenu
Marius BALTEANU wrote:
> It looks good also with a vertical three dotted icon.
This would be confusing as the vertical dots are already used as drag and drop handlers for trackers, enumerations, statuses and so on.
Felix Schäfer
22:01 Patch #26655: Additional icon for contextmenu
Very nice feature, especially that it will make the context menu available on the mobile.
It looks good also with a vertical three dotted icon.
!vertical.png!
Marius BĂLTEANU
22:48 Patch #26689 (Closed): Add title to author's and assignee's icon
After the release of Redmine 3.4.2 in our company, we received some complains regarding the author and assignee icons (feature added in #25775). Some users thought that is a bug (especially when the author = assignee).
I'm thinking th...
Marius BĂLTEANU
22:13 Feature #26409: Show assignee on gantt
I've tested the patch and I've two observations:
1. the patch doesn't apply cleanly on the current trunk (r16948).
2. it'll be nice to have also gravatar shown for the assignee.
Marius BĂLTEANU
17:01 Patch #26685 (New): Check of child classes of all levels is added for Redmine::SubclassFactory::ClassMethods
SubQuery < Query
NewSubQuery < SubQuery
And I will see "Undefined method new for nil class"
Vladimir Litov
15:52 Feature #26677: HTTP code 401 on login failure
This is not what I obtain with other services (e.g. with Jenkins CI instances), where a 401 code is returned, and presents the usual HTML login form (not through the browser, as the authentication is made through the application, not the... Rémi Saurel
15:42 Feature #26677: HTTP code 401 on login failure
The 401 status code is specifically used for Basic or Digest authentication. It has no value when using form authentication as done with Redmine.
If Redmine would return a 401 here, your browser would ask for authentication with a Bas...
Holger Just
14:05 Feature #26677 (Closed): HTTP code 401 on login failure
When purposely causing a login error on Redmine, I can see (using web inspector and/or logfiles) that the HTTP return code is 200, i.e. "everything is ok", for the page that presents the error to the user.
It would be great if Redmine...
Rémi Saurel
15:46 Feature #23119: Hook for deleted issues
You can already use the basic ActiveRecord callbacks on the @Issue@ model, which include @before_destroy@ and @after_destroy@ callbacks. Please check the "Documentation":http://api.rubyonrails.org/classes/ActiveRecord/Callbacks.html for ... Holger Just
15:44 Defect #26681 (Closed): disk_filename of attachment when issue is created via mail
Toshi MARUYAMA
15:34 Defect #26681: disk_filename of attachment when issue is created via mail
As you can see in the code, we are using the original filename, as long as it follows some strict rules (i.e. only contains ascii characters, numbers, underscore, hyphen and dot). If any other character (including a space) is included in... Holger Just
15:25 Defect #26681 (Closed): disk_filename of attachment when issue is created via mail
Hello,
when an issue with attachment is created via mail, the disk_filename of this attachment get created with an hash-function.
I think this is the code.
\xampp\Redmine\app\models\attachment.rb line 369:
Felix Muster
15:39 Defect #26679 (Needs feedback): Edit Journal - Can't verify CSRF token authenticity
Toshi MARUYAMA
15:37 Defect #26679: Edit Journal - Can't verify CSRF token authenticity
See [[Submissions]]. What exactly are you doing when the error occurs? Please at least show the log entries.
How are you triggering the error? With a browser or with an API client? Which URL are you querying?
Holger Just
14:52 Defect #26679 (Closed): Edit Journal - Can't verify CSRF token authenticity
From View: 402 - Invalid form authenticity token.
Possible solution:
add: config/application.rb
config.action_controller.allow_forgery_protection = false
Adriano Baptistella
15:26 Patch #26682 (Closed): URL-escape the ! character in generated markup for dropped uploads
In #26071, we introduced the ability to just drag an image into a textbox and have Redmine generate the correct image markup for the uploaded file for easy inclusion.
Unfortunately, the @!@ character in the filename is not escaped he...
Holger Just
14:55 Feature #26680 (New): Show default assignee when creating new issue
With new redmine version, 3.4, a default assignee can be specified (which is great).
However, contrary to a stipulated default target version, the stipluated default assignee does show up when creating a new ticket:
!DefaultAssigne...
Andreas Deininger
14:32 Defect #26678 (Closed): Custom field required not work with 3.4.2
I cannot reproduce.
Please use forum for question.
Toshi MARUYAMA
14:17 Defect #26678 (Closed): Custom field required not work with 3.4.2
I created a custom field and setup in the workflow as required during some status and not worked.
But Setting default field as required worked.
I also tried 3.3.2 and still same.
James Wang
14:29 Defect #26665: comment button in wiki editing page not work
I had thought this comment is like "comment_form from this plugin":https://www.r-labs.org/projects/r-labs/wiki/Wiki_Extensions_en.
Sorry waist your time!Thanks.
James Wang
08:34 Defect #26665 (Closed): comment button in wiki editing page not work
You can see "comment" in wiki history.
https://www.redmine.org/projects/redmine/wiki/Overview/history
Toshi MARUYAMA
07:39 Defect #26665: comment button in wiki editing page not work
After inputting test like below
!{width:500px}inputting.png!
I got nothing like below
!{width:500px}submitted.png!
James Wang
12:09 Feature #4511: Allow adding user groups as watchers for issues
Stephane Lapie wrote:
> The fix is committed to my github.
Stephane, thanks for your efforts.
> ...
I just installed the master of your github project on an fresh Redmine 3.4.2 instance, and yes, I can confirm that the plugin is...
Andreas Deininger
11:38 Patch #26674 (Closed): Add CSS classes to column headers of issues and timelogs list
For now there no any chances to style table headers for several columns becouse there no any css classes (it just <th> with column caption)
In patch I offer to add two classes: @query-column-header@ and @query-column-header-#{column.name}@
Dmitry Lisichkin
07:58 Patch #26671 (Closed): Use the new pagination style in gantt
This patch applies the new pagination style introduced by #21258.
I think it would be better to use this style in gantt to improve consistency and usability.
**Before:**
!{width: 785px;border: 1px solid #ccc;}.pagination-before@2x....
Go MAEDA
03:17 Feature #26648: Show transparency grid when previewing images
Let's deliver this feature in 4.1.0. Go MAEDA

2017-08-13

10:26 Defect #26668: Create "Documentation support" subsection in the "Non Code Related" section of the "Contribution" page.
Sorry, only Contributors can upate the page because the page is locked.
I will update the page after waiting for feedback for a few days.
Go MAEDA
03:27 Defect #26668: Create "Documentation support" subsection in the "Non Code Related" section of the "Contribution" page.
Thank you for suggesting the improvement. I think it is very good idea to add the information about updating the official Wiki to [[Contribute]] page.
Please don't hesitate to update the page.
Go MAEDA

2017-08-12

17:51 Defect #26665: comment button in wiki editing page not work
Please post your wiki "comment" screen image. Toshi MARUYAMA
15:48 Defect #26665: comment button in wiki editing page not work
Below is my environment: James Wang
10:33 Defect #26668 (New): Create "Documentation support" subsection in the "Non Code Related" section of the "Contribution" page.
It would be great to show "how to contribute to documentation" in the "Non Code Related" section of the "Contribute" page.
The related information is already in the "Code documentation" subsection in the "Code Related" section. Surely...
Masakazu IZUI
04:08 Defect #26667: Filtering time entries after issue's target version doesn't work as expected in some cases
It seems that the drop-down have been broken by r16170. Go MAEDA
03:23 Defect #26667: Filtering time entries after issue's target version doesn't work as expected in some cases
Thank you for finding the probelem. But I think that the root cause of the problem is that TimeEntryQuery#project returns nil instead of the current project. Because of this, subproject dropdown also is not working.
!{width: 531px; bo...
Go MAEDA
 

Also available in: Atom