Activity
From 2018-12-01 to 2018-12-03
2018-12-03
-
22:16 Feature #16717: Add _blank support for "Link values to URL"
- +1
-
22:14 Patch #29951: Quick design fix/proposals for projects index page
- Bernhard Rohloff wrote:
> First of all I really like the idea of different views to navigate through projects in Redmine. I think that it can be very beneficial if you offer the user different viewing angles to fit their specific needs.... -
21:59 Patch #29951: Quick design fix/proposals for projects index page
- Kim Henriksen wrote:
> Tried to apply the patch, but doesn't seems to make sub-sub projects not break:
Did you restart your webserver or hard reset your cache? -
20:00 Patch #29951: Quick design fix/proposals for projects index page
- Tried to apply the patch, but doesn't seems to make sub-sub projects not break:
!projects-overview.png! -
18:10 Patch #30071: Show parent projects when filtering in the project jump box
- The original patch uses on font-weight to grey out the non-matched parent nodes. This relies on the used font to provide the font-style which often it does not. Just realised this as I tested on Windows.
Supplied patch uses "color" in... -
09:27 Patch #30071 (Needs feedback): Show parent projects when filtering in the project jump box
- It is an interesting improvement.
I tried out the patch. But parent projects were displayed in not grey but black. And the checkmark for the current project was not displayed even after applying the patch 0002-Mark-current-project-whe... -
15:02 Feature #10267: Show custom date fields in calendar
- Any chance to get this feature for redmine >=3.4 ?
Thanks -
10:34 Defect #26785: Wrong columns after CSV export
- LGTM. Setting the target version to 3.4.7.
-
10:06 Defect #26785: Wrong columns after CSV export
- I cleaned up the code a little.
-
09:49 Defect #26785: Wrong columns after CSV export
- Go MAEDA wrote:
> The problem can be addressed by restoring the session value after sending CSV to the client.
The patch attached to #26785#note-5 worked fine for me, but I think it would be better to use the argument use_session of ... -
06:14 Defect #26785: Wrong columns after CSV export
- You can fix this issue with the attached patch.
My customer experiences @ActionDispatch::Cookies::CookieOverflow@ exception due to this defect. The Redmine has 200+ custom fields. A list of all custom fields is set to @session[:issue_... -
01:59 Feature #27672: Show selected columns in gantt chart
- Iwan Yudhistira wrote:
> how to run the patch in windows, thank you before
You should be able to apply the patch in the following way.
# Change into your Redmine directory (the one with app, test, and config folders)
# Download t...
2018-12-02
-
23:32 Patch #29406 (Closed): Use sorted instead of sort
- Committed. Thank you for improving Redmine.
-
02:20 Patch #29406: Use sorted instead of sort
- Passed all tests. Setting the target version to 4.1.0.
The attached patch is a combination of Pavel Rosický's three patches. -
23:31 Revision 17685 (svn): Use sorted instead of sort (#29406).
- Patch by Pavel Rosický.
-
17:35 Defect #29855: add_working_days may return wrong date when the start date is a non-working day
- Jean-Philippe Lang wrote:
>
> ...
Thanks, but are still not clear for me the expected results so I'll leave Go Maeda or Mizuki ISHIKAWA to fix this issue.
-
17:23 Defect #29855: add_working_days may return wrong date when the start date is a non-working day
- Marius BALTEANU wrote:
> The number of the expected working days according to the test is 4. But in my opinion, it should be 5 days (Tuesday, Wednesday, Thursday, Friday and Monday). 4 could be only if we exclude the end date from the... -
12:39 Defect #29855: add_working_days may return wrong date when the start date is a non-working day
- I took a look and there are some strange (or wrong) test cases the we should review before changing anything else.
Taking the following test scenario: -
08:53 Defect #29855: add_working_days may return wrong date when the start date is a non-working day
- Mizuki ISHIKAWA wrote:
> Any feedback is welcome.
@DateCalculation#working_days@ should be fixed in a similar way to be consistent with the proposed fix. These new assertions should pass: -
16:35 Defect #9708 (Closed): Adding relation to the issue sometimes does not work
-
16:34 Feature #26620 (Closed): Change the text of the submit button on search page from button_submit to label_search
- Marius BALTEANU wrote:
> For me, this change generates "translation missing: en.button_search". Please see the below screenshot.
> ...
Fixed in r17684. Thanks.
I changed button_search to label_search before committing as I wrote in ... -
16:27 Feature #26620 (Reopened): Change the text of the submit button on search page from button_submit to label_search
- For me, this change generates "translation missing: en.button_search". Please see the below screenshot.
!{width:70%; border: 1px solid black;}button_search.png!
In the existing locales, we have only "label_search". We can use this ... -
15:15 Feature #26620 (Closed): Change the text of the submit button on search page from button_submit to label_search
- Committed. Thank you for improving Redmine.
-
16:31 Revision 17684 (svn): Fix for r17683: s/button_search/label_search/ (#26620).
-
16:19 Feature #4491 (Closed): Direct Image Upload in Forum
- Implemented by #26071.
-
15:15 Revision 17683 (svn): Change the text of the submit button on search page from button_submit to label_search (#26620).
- Patch by Dmitry Lisichkin.
-
15:05 Feature #1777 (Closed): Allow %2650 in Wiki to display and linke the Title of the Ticket (next to #2650
- The new syntax "##123" which renders tracker name, issue id, and title will be available in Redmine 4.0.0.
-
12:52 Patch #29951: Quick design fix/proposals for projects index page
- We can achieve a better projects page only with some CSS changes. The most important change is to not allow to break inside a column.
The proposed solution has a down side effect on Safari (which is a known issue and I didn't find any... -
12:26 Feature #29993 (Closed): Option to unarchive the project when admins visit an archived project
- When trying to access an archived project, a link to unarchive it will now be displayed to admin users.
-
12:23 Revision 17682 (svn): Let admins unarchive the project when trying to access an archived project (#29993).
-
12:13 Revision 17681 (svn): Let admin users unarchive subprojects of archived projects (#29993).
-
11:07
Feature #30069: Use GitHub Actions as a secondary CI solution to run tests through the existing mirroring
- Hopefully soon™...
-
09:36 Revision 17680 (svn): Don't send notifications when using Issue.generate! in tests in order to speed up tests.
-
08:54 Revision 17679 (svn): Current user should be nil to prevent ActiveJob::DeserializationError errors in tests.
-
08:34 Revision 17678 (svn): Moves some action links on the wiki page to a dropdown menu (#26575).
-
07:25 Patch #28662 (Closed): Replace "Cancel" buttons from the modals with "Cancel" link
- Committed the patch. Thank you for your contribution.
-
07:24 Revision 17677 (svn): Replace cancel button with cancel link in modals (#28662).
- Patch by Marius BALTEANU.
-
01:33 Patch #30075 (Closed): Czech translation update
- Committed. Thank you for your contribution.
-
01:33 Revision 17676 (svn): Czech translation update (#30075).
- Patch by Pavel Rosický.
2018-12-01
-
20:38 Patch #30075 (Closed): Czech translation update
- 1/ new translations
2/ "deleted." line in error_can_not_delete_auth_source: key was removed (bad merge) -
20:06 Defect #30074: Puma shouldn't be included in the Gemfile
- IMO, your CI should add Puma to Gemfile.local in a before_script or use Capybara.server = :webrick if Puma isn't available
-
19:52 Defect #30074 (Closed): Puma shouldn't be included in the Gemfile
- right now it isn't possible to use a different Puma version or define it for a production environment because there's a conflict
https://github.com/redmine/redmine/blob/master/Gemfile#L91 -
19:41 Defect #30073 (Closed): Ajax Request Returns 200 but an error event is fired instead of success
- here's an explanation of the issue
https://stackoverflow.com/questions/6186770/ajax-request-returns-200-ok-but-an-error-event-is-fired-instead-of-success
IMO https://github.com/redmine/redmine/blob/dcb545efadc586ab15065870b943763263e... -
19:19 Defect #26066 (Closed): Selenium::WebDriver doesn't work with current version of Firefox
- Thanks Pavel for updating the ticket.
I’m setting version version:"4.0.0" because it is an useful fix for Redmine developers. -
19:14 Defect #26066 (Resolved): Selenium::WebDriver doesn't work with current version of Firefox
- the version restiction was removed in https://github.com/redmine/redmine/commit/530eef96033bf1474157bbc9c7739ff8dc7e2ae4
resolved, thanks -
19:08 Feature #30069: Use GitHub Actions as a secondary CI solution to run tests through the existing mirroring
- +1
Yes, it's very time consuming to contribute and also for maintainers to verify existing patches.
If you don't want to move to git which was discussed and rejected many times, please at least enable travis on
https://github.com/... -
19:02
Feature #30069: Use GitHub Actions as a secondary CI solution to run tests through the existing mirroring
- +1
However technically tough that could sound (since I'm not even a web dev XD), less time consuming = faster, and anything that has a potential to speed up the development and generally make it less stressful, is imho should be welcome... -
14:03 Feature #30069 (Closed): Use GitHub Actions as a secondary CI solution to run tests through the existing mirroring
- On my local development box, I've a lot of branches with my entire work for Redmine. These branches contain features or bug fixes in a stable phase that are already posted on Redmine.org or my work in progress for future features or bug ...
-
18:54 Feature #29041: Update session token only once per minute
- if you have time, could you review? https://www.redmine.org/attachments/20901/user.rb.patch
GET requests shouldn't update a database all the time. It's even more relevant for #29513
disabling Rails.application.config.redmine_verify... -
18:28 Patch #29406: Use sorted instead of sort
- > issue priorities on the issue's report page were originaly sorted by id
forget about this statement. I was wrong, enumerations have a default scope, so it's already sorted and I changed the order. I reverted this change and attached a... -
10:21 Patch #29406: Use sorted instead of sort
- Pavel Rosický wrote:
> issue priorities on the issue's report page were originaly sorted by id (desc), but I think they should be sorted by position.
I prefer the current sort order. Showing the highest priority first is reasonable. -
17:22 Patch #30071 (New): Show parent projects when filtering in the project jump box
- Attached patch returns parents projects to matched projects when filtering in the project jump box (improves #23310)
It looks like this:
!redmine-show-parent-projects-jump-box.png!
This solves a problem when having several project... -
15:43 Defect #22046 (Needs feedback): Markdown XML code blocks not properly supported
- I could not reproduce the issue on Redmine 3.4.6. Do you still experience the issue in the latest version?
-
15:12 Feature #27313: More custom queries on My page
- Jean-Philippe, what do you think about increasing the maximum number of "issuequery" block?
-
14:36 Defect #30070 (Closed): Unable to update assignee with rdm-mailhandler.rb
- h1. Issue Summary
I try to update ticket status by sending email.
But assignee cannot be updated.
So, I commented out following line from https://github.com/redmine/redmine/blob/master/app/models/mail_handler.rb. -
13:38 Revision 17675 (svn): Tests failure with SQLite3.
- ActiveRecord::RecordNotUnique: SQLite3::ConstraintException: UNIQUE constraint failed: custom_fields_trackers.custom_field_id, custom_fields_trackers.tracker_id: INSERT INTO "custom_fields_trackers" ("custom_field_id", "tracker_id") VALU...
-
13:35 Revision 17674 (svn): Tests failure with SQLite3.
- ActiveRecord::RecordNotUnique: SQLite3::ConstraintException: UNIQUE constraint failed: custom_fields_trackers.custom_field_id, custom_fields_trackers.tracker_id: INSERT INTO "custom_fields_trackers" ("custom_field_id", "tracker_id") VALU...
-
13:33 Revision 17673 (svn): Tests failure with SQLite3.
- ActiveRecord::RecordNotUnique: SQLite3::ConstraintException: UNIQUE constraint failed: custom_fields_trackers.custom_field_id, custom_fields_trackers.tracker_id: INSERT INTO "custom_fields_trackers" ("custom_field_id", "tracker_id") VALU...
-
12:43 Revision 17672 (svn): Fix random test failure, assertion must be made against displayed values.
- IssuesControllerTest#test_index_sort_by_spent_hours_should_sort_by_visible_spent_hours
Expected: [3.0, 0.0, 0.0]
Actual: [3.0, 4.0, 0.0] -
12:25 Revision 17671 (svn): Current user should be nil to prevent ActiveJob::DeserializationError errors in tests.
-
11:04 Patch #28895 (Closed): view_projects_copy_only_items hook
- Committed the patch. Thank you for your contribution.
-
11:03 Revision 17670 (svn): Adds view_projects_copy_only_items hook (#28895).
- Patch by Jens Krämer.
-
10:29 Defect #29291 (Closed): NoMethodError: undefined method `migrate' for Redmine::Plugin::Migrator:Class
- This should have been fixed in #28934.
-
09:55 Feature #29725: Show recent documents first when sorting documents by date
- LGTM. Setting the target version to 4.1.0.
-
09:50 Defect #29855: add_working_days may return wrong date when the start date is a non-working day
- Jean-Philippe, do you think we can accept this performance deterioration?
I think it is OK because 'add_working_days' method will not be executed hundreds of times by the user's single operation. So, it does not affect the performance... -
09:38 Patch #30000 (Closed): Japanese translation update (r17623)
- Committed.
-
09:38 Revision 17669 (svn): Japanese translation update (#30000).
- Patch by Go MAEDA.
-
09:30 Feature #29752: Render Textile and Markdown attachments on the preview page
- LGTM. Setting the target version to 4.1.0.
-
08:13 Feature #30068 (Closed): Remove :async_smtp and :async_sendmail delivery methods
- The purpose of this issue is not to implement any feature but to add a notice regarding the removal of a feature done by #26791 to the changelog.
:async_smtp and :async_sendmail delivery methods, which were used for sending emails asy... -
07:57 Defect #30067 (Closed): About installation
- You can not get home page after installation done with these steps.
-
07:45 Revision 17668 (svn): Use "abort" instead of "exit" in order to make error log more informative (# 26791).