Activity
From 2018-12-14 to 2018-12-16
2018-12-16
-
20:36 Feature #28595: Please remove font definition from the body element.
- Default font is a user setting, that user can define in browser settings.
My choice is 20px DejaVu. It's comfortable for me. And you say: "NO! you will break you eyes on my 12px verdana and will not be able to change it!"
It's ok to ... -
17:23 Feature #28595 (Needs feedback): Please remove font definition from the body element.
- Why is bad to define font size and family in body element? I'm asking because I would like to understand the reasons and honestly, is the first time when I hear this.
-
20:12 Defect #30176 (Confirmed): Anonymous users cannot upload attachment if added to project member
-
20:03 Feature #3848 (Closed): Permission to log time for another user
- You're right, thanks!
-
19:31 Feature #3848 (Reopened): Permission to log time for another user
- Jean-Philippe, please apply the attached patch in order to update the translation for @error_not_allowed_to_log_time_for_other_users@ also for the generated locales. I think that you first generated the locales and after that you have ch...
-
17:40 Feature #3848 (Closed): Permission to log time for another user
- Patch is committed, thanks for your work on this feature.
-
17:09 Patch #29391: Show version status in Roadmap and Version pages
- Update the patches for the current trunk.
The "Private" badge from issue page is rendered inside a h3 element, the versions status is rendered outside the h3 and because of that, the styles differ. We should render also the version st... -
17:02 Patch #30115 (Resolved): Move Version#fixed_issues extension to a module
- Committed, thanks.
-
16:37 Feature #30233: Allow grouping of time entries by creation date
- Also, I think that we should add Created and Updated to available filters, what do you think?
Tests result: https://gitlab.com/marius-balteanu/redmine/-/jobs/135221327 -
16:37 Feature #30233 (Closed): Allow grouping of time entries by creation date
- Same as #13803, but for time entries.
-
16:29 Feature #23980: Replace icon images with Tabler SVG icons
- Max Johansson wrote:
> Yey! This asap pls! !{width:20px}https://cdn.discordapp.com/emojis/471854100984758274.png!
> ...
Max, I'll be very happy to update my patch if Jean-Philippe agrees to replace the current icons with FA icons. -
08:46
Feature #23980: Replace icon images with Tabler SVG icons
- Yey! This asap pls! !{width:20px}https://cdn.discordapp.com/emojis/471854100984758274.png!
+1 -
15:59 Feature #3058: Show issue history using tabs
- Updated the patches series to apply cleanly on the current trunk. Jean-Philippe, please do not forget about this feature.
-
15:55 Feature #29482: Query system for Projects page
- Jean-Philippe, what do you think about the proposed implementation?
I'm assigning this to version:"4.1.0" because it is a long requested feature (a lot of related issues) and allows us to make future improvements (for ex: #23954, #13... -
15:49 Feature #29482: Query system for Projects page
- Tatsuya Saito wrote:
> > 2. If the default view (Board or List) should be configurable in the Administration page.
> ...
I'll do it in a next patch.
> BTW **default_sort_criteria** in project_query.rb is correct?
> ...
I preferred ... -
10:03
Defect #30232 (New): Renaming some of the containers to HTML5 specific tags instead of just DIVs
- HTML5 has support for new markup tags, like <nav>, <header>, <section>, <article>, <footer>
By renaming containers with these tags instead, we could get rid of redundant class and ID definitions for styling, since you will be able to ju... -
09:47
Patch #30231: Operation: "Unwraping The Mine" or conerns about how elements are wrapped
- share feedback please, or potentially other bad containers you had spotted, if the interest is good, I'll attach the patch later.
-
09:45
Patch #30231 (Closed): Operation: "Unwraping The Mine" or conerns about how elements are wrapped
- Here are some things that look suspicious to me:
1. I think maybe it would be good to kill the two wrappers (wrapper2 and wrapper3), leaving only one top wrapper which would wrap everything except for the *footer* container, this is to ... -
09:11 Patch #26646 (Closed): Remove hardcoded width in query column selects
- Committed, thanks.
-
09:10 Defect #17219 (Closed): Rename label for "Issues can be assigned to this role"
- Committed, thanks.
-
08:41 Feature #23392 (Closed): Link to remove a subtask from its parent task
- Patch committed, except for the test that was failing as the anonymous user is not allowed to manage relations.
Thanks. -
08:39
Feature #30229: Optimization: all UI icons collapsed into a single sprite
- Well, in this case, it's better to go with font icons, because fonts are vector information, which means it's scalable and also cheaper in size, there is also more of them.
-
07:20 Feature #30229: Optimization: all UI icons collapsed into a single sprite
- @Max there is also an ongoing attempt to switch the icon set to Font Awesome (#23980). As there are more icons available for plugin developers I think it's a good thing to back it, too. ;-)
-
01:22
Feature #30229 (Closed): Optimization: all UI icons collapsed into a single sprite
- I don't have a CSS mapped yet, but I did collapse the icons into a single sprite (all, except loading spinner). There is also a variety of online tools out there to map the sprite icons, so it's fairly easy to do.
But, need feedback fir... -
08:07 Defect #27330 (Closed): "Name" field in the 'edit version' form has no "maxlength"
- Committed, thanks.
-
08:05 Feature #13803 (Closed): Implement grouping issues by date (start, due, creation, update, closing dates)
- Committed, thanks.
-
08:02 Feature #22368 (Closed): Ability to add private comments from the issue bulk edit page
- Takenori TAKAKI wrote:
> I made the patch (compatible with latest trunk 17055).
> ...
The patch always displays the "Private notes" checkbox and returns a 403 if the user is not allowed. I think it's better to display the checkbox when... -
07:40 Defect #11359 (Closed): Wiki diff doesn't keep spaces
- Committed, thanks.
-
06:04 Defect #30171: Decrypting LDAP and SCM passwords fail if the plaintext password is longer than 31 bytes
- Updated the test in order to catch the problem.
-
05:20 Patch #2635 (Closed): Display notice on forum updates
-
03:10 Feature #30230: Redmine reference with version info
- > We can see codes here.
Maybe, version info should be belongs to generator only to generate past version.
I will create redmine plugin to overwrite rake yard task(in lib/tasks/yardoc.rake) and maintain it if this suggestion will be ... -
03:02 Feature #30230: Redmine reference with version info
- #28996 is related with this ticket.
-
02:10 Feature #30230 (New): Redmine reference with version info
- I was generated Redmine reference with version infomation. See below.
* http://sho-h.github.io/redmine/3.3/index.html
* http://sho-h.github.io/redmine/3.4/index.html
* http://sho-h.github.io/redmine/4.0/index.html
This was genera...
2018-12-15
-
22:40 Patch #2635 (Resolved): Display notice on forum updates
- Committed.
-
15:29 Patch #2635: Display notice on forum updates
- +1
I think the notices will improve usability. The attached patch adds notices on create/update/delete operation on forum messages. -
16:30 Feature #13803: Implement grouping issues by date (start, due, creation, update, closing dates)
- Made a small improvement.
-
10:12 Patch #30168: Wrap "splitcontentright" and "splitcontentleft" containers with a flexbox
- One more thing, Max, please replace in your patch the tab characters with spaces.
-
10:10 Patch #30168: Wrap "splitcontentright" and "splitcontentleft" containers with a flexbox
- I like the idea to replace float left/right rules with some more modern CSS rules.
I've added as watchers the guys from plan.io who worked a lot on UI changes in the last years, maybe they can help us with reviewing the proposed patch. -
06:57 Patch #30168: Wrap "splitcontentright" and "splitcontentleft" containers with a flexbox
- I think flexbox is not bad at all if it works with IE 11. Thank you for checking the compatibility with IE.
IMHO it is OK to include the patch in Redmine 4.1.0. -
06:43
Patch #30168: Wrap "splitcontentright" and "splitcontentleft" containers with a flexbox
- Go MAEDA, works just fine for me on my IE 11.741.17134.0 which is bundled with Windows 10. According to known issues list, it doesn't seem like I used any of the flexbox related CSS rules which should cause problems on that browser. IE 1...
-
04:32 Patch #30168: Wrap "splitcontentright" and "splitcontentleft" containers with a flexbox
- Thanks for the patch.
Max, do you know if the patch works fine with Internet Explorer 11? The website "Can I use":https://caniuse.com/#search=flex states that there are many flexbox bugs in IE 11. -
10:07 Defect #27246 (Closed): UI bug on the main category page- comment area
-
07:12 Feature #6680 (Closed): add other users as follower to forum thread
- Closing as a duplicate of #3390.
-
04:00 Patch #30177 (Closed): Thumbnail lifecycle: reuse thumbs from identical files, delete thumbs when diskfile is deleted
- Committed the patches. Thank you for improving Redmine.
-
02:41 Defect #30211: Crash with the message "undefined method `alias_method_chain'" when connecting to Microsoft SQL Server
- We have to wait for the release of the latest version of activerecord-sqlserver-adapter that supports Rails 5.2 to resolve this issue.
https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/issues/636 -
02:15 Defect #30211 (Confirmed): Crash with the message "undefined method `alias_method_chain'" when connecting to Microsoft SQL Server
- Confirmed the problem. Redmine crashes during startup.
{{collapse
2018-12-14
-
22:42 Feature #13803: Implement grouping issues by date (start, due, creation, update, closing dates)
- I think the attached patch should do the trick for MySQL as well.
Tests pass without skipping the tests added for this feature: https://gitlab.com/marius-balteanu/redmine/-/jobs/134925443 -
14:40 Defect #30211: Crash with the message "undefined method `alias_method_chain'" when connecting to Microsoft SQL Server
- Hi Go MAEDA,
I will try to get you a crash log for this in a day or two. Note that this error (undefined method `alias_method_chain') occurred when trying to install Redmine v4 from git master as an upgrade from v2.5.2. Requirements (... -
02:24 Defect #30211 (Closed): Crash with the message "undefined method `alias_method_chain'" when connecting to Microsoft SQL Server
- The problem has been reported in #30209#note-1 by "Nigel Wilson":https://www.redmine.org/users/374936.
> I ran into this issue as well. I made the following changes in the GemFile to meet all the dependencies. However, I am using MS S... -
14:31 Defect #30210: Application crash when deleting an issue from issue list with SQLServer
- Hi Go MAEDA, this issue isn't related (in my opinion) to Defect #30211.
This issue occurs once Redmine is up and running. Users were accessing the website and creating/updating tickets as normal. The error reported only occurred when ... -
10:27
Feature #28595: Please remove font definition from the body element.
- +1, but not going to happen... likely not in this century... sadly.
-
07:02 Feature #28595: Please remove font definition from the body element.
- +1 for customizing that parameter
or at least make it based on screen size, I guess changing 12px => 1rem would be nice -
10:09 Defect #30171: Decrypting LDAP and SCM passwords fail if the plaintext password is longer than 31 bytes
- This issue also affected "Vault Plugin":http://www.redmine.org/plugins/vault and was fixed in "Issue 43":https://github.com/noshutdown-ru/vault/commit/4c03b8df04ab21619661b637b6f1c4a64b3ac162
Since Vault uses Redmine's encryption, per... -
10:05 Patch #30177: Thumbnail lifecycle: reuse thumbs from identical files, delete thumbs when diskfile is deleted
- LGTM. We can save disk space with this patch. Setting the target version to 4.1.0.
-
08:31 Defect #30209: undefined method `alias_method_chain' for ActionView::Base:Class (NoMethodError)
- Jean-Philippe Lang wrote:
> render_parent is not loaded by Redmine core but by your redmine_latex_mathjax plugin. You should try to upgrade your plugin.
Thanks a lot for the quick feedback. I shared this with the plugin developer. -
02:27 Defect #30209: undefined method `alias_method_chain' for ActionView::Base:Class (NoMethodError)
- Nigel Wilson, thank you for reporting the problem regarding MS SQL Server. I have created another issue #30211.
Could you paste the crash log which includes "undefined method `alias_method_chain'" on #30211? -
00:21 Defect #30209 (Closed): undefined method `alias_method_chain' for ActionView::Base:Class (NoMethodError)
- render_parent is not loaded by Redmine core but by your redmine_latex_mathjax plugin. You should try to upgrade your plugin.
-
04:33 Patch #13688 (Needs feedback): Chosen thumbnail has to be bigger than requested one and not smaller
- The following error occurred while running tests. Jens, could you check the patch?
-
03:34 Defect #30067 (Closed): About installation
- Please describe more details. We can not identify the problem because you provided too little information.
-
00:24 Feature #30208 (Closed): Custom assignee list per project
- Nathan Dattler wrote:
> It seems that if the "Issues can be assigned to this role" is checked off for a role, any users within that role shows as an assignee in every project. Am I just missing something or is that the default behavio...