Project

General

Profile

Activity

From 2019-01-18 to 2019-01-20

2019-01-20

14:34 Patch #30435: Replace float rules with flexbox for content and sidebar block
There is a gridbox design suggestion now pending for further discussion, so this ticket will be affected if we will decide to move #main-menu inside #main container, ultimately making this patch obsolete, because it will then become a 3 ... Anonymous
13:54 Patch #30466: Remove unused i18n key "label_all_time"
Setting the target version to 4.1.0. Go MAEDA
13:45 Patch #30168 (Closed): Wrap "splitcontentright" and "splitcontentleft" containers with a flexbox
Committed Max's splitcontent_responsive_fixed_fix.patch. Thanks. Go MAEDA
13:45 Revision 17835 (svn): Fix the styles for the responsive (#30168).
Patch by Max Johansson. Go MAEDA
11:09 Defect #30467: Footer is not placed at the bottom on pages with little content
Jean-Philippe, apologies for vague description, what I mean by setting footer sticky, is for it to stick to the bottom of the page, while always expanding the #main block (or a wrapper) in 100% of available vertical height, unless the pa... Anonymous
08:18 Defect #30467: Footer is not placed at the bottom on pages with little content
What is the purpose of making the footer sticky? I don't see anything in the footer that needs to be always visible. Jean-Philippe Lang
08:41 Feature #3848 (Closed): Permission to log time for another user
Done. Jean-Philippe Lang
08:41 Revision 17834 (svn): Update en-GB locale (#3848).
Jean-Philippe Lang
08:40 Defect #30411 (Closed): Filesystem adapter does not show correct size for large files
Jean-Philippe Lang
08:06 Defect #30411: Filesystem adapter does not show correct size for large files
Thanks! Jean-Philippe Lang
08:40 Revision 17833 (svn): Merged r17831 to 3.4-stable (#30411).
Jean-Philippe Lang
08:40 Revision 17832 (svn): Merged r17831 to 4.0-stable (#30411).
Jean-Philippe Lang
08:39 Revision 17831 (svn): Filesystem adapter does not show correct size for large files (#30411).
Jean-Philippe Lang
08:35 Defect #30236 (Resolved): Accidentally clicking next to the checkbox breaks issue selection
I've committed a fix similar to the one proposed by Mizuki but that does not require to add labels on every checkboxes. Jean-Philippe Lang
08:34 Revision 17830 (svn): Accidentally clicking next to the checkbox breaks issue selection (#30236).
Jean-Philippe Lang
08:14 Redmine 4.0.1 and 3.4.8 released
These maintenance releases are available for [[download]].
You can review the changes in the [[Changelog]].
Happy New Year 2019!
Jean-Philippe Lang
07:57 Revision 17829 (svn): tagged version 4.0.1
Jean-Philippe Lang
07:57 Revision 17828 (svn): tagged version 3.4.8
Jean-Philippe Lang
07:56 Revision 17827 (svn): Updates for 3.4.8.
Jean-Philippe Lang
07:55 Revision 17826 (svn): Merged r17825.
Jean-Philippe Lang
07:54 Revision 17825 (svn): Updates for 4.0.1 release.
Jean-Philippe Lang

2019-01-19

17:40 Patch #30451: Move #main-menu outside of the #header to follow directly after the #header insetad
Bernhard, I was able to get concept for your proposal fixed by using grid box instead, I'm thinking if gridbox could actually be something better now, rule definitions for it are also more straight forward imho :) Anonymous
16:13 Defect #30411: Filesystem adapter does not show correct size for large files
I can confirm the patch still shows the correct file size for the file that caused problems in our case.
The error the patch in r1509 addresses intrigued me though to I went looking if maybe this was due to a bug in Ruby that was sinc...
Felix Schäfer
11:54 Defect #30411: Filesystem adapter does not show correct size for large files
Felix, can you confirm the fix is OK? Jean-Philippe Lang
15:44 Patch #30465 (Closed): Deadlock when assigning custom values
Committed, thanks. Jean-Philippe Lang
15:42 Revision 17824 (svn): Merged r17823 to 4.0-stable (#30465).
Jean-Philippe Lang
13:29 Defect #30467 (Closed): Footer is not placed at the bottom on pages with little content
I'm opening this as a placeholder for now to upload the patch later.
If the decision to remove wrappers will be accepted in #30448, then there will need to be changes to the #main, else if all the wrappers will stay, then there will nee...
Anonymous
13:02 Patch #30448: Remove wrapper2 and wrapper3 wrapping containers
Update: while developing quick html concept layouts for #30451 (#30451#note-3 and #30451#note-5), I came to conclusion that maybe we don't need even the first #wrapper as well, things could just be rerouted to *body* tag and sticky foote... Anonymous
12:57 Revision 17823 (svn): Deadlock when assigning custom values (#30465).
Patch by Pavel Rosický. Jean-Philippe Lang
12:52 Defect #30287 (Closed): The tooltip layout of the calendar is broken
Patch committed, thanks.
Marius BALTEANU wrote:
> What do you think if we refactor the tooltip and use a list or div elements (like in the issue page) to render the issue attributes instead of the current implementation and proposed ...
Jean-Philippe Lang
12:51 Revision 17822 (svn): Merged r17821 to 4.0-stable (#30287).
Jean-Philippe Lang
12:50 Revision 17821 (svn): The tooltip layout of the calendar is broken (#30287).
Patch by Mizuki ISHIKAWA. Jean-Philippe Lang
12:49 Feature #30118 (Closed): Ruby 2.6 support
Jean-Philippe Lang
12:49 Revision 17820 (svn): Merged r17706 to 4.0-stable (#30118).
Jean-Philippe Lang
12:04 Patch #30115 (Closed): Move Version#fixed_issues extension to a module
Jean-Philippe Lang
12:04 Revision 17819 (svn): Merged r17754 to 4.0-stable (#30115).
Jean-Philippe Lang
12:00 Defect #30455 (Closed): Adding an issue note via email fails due to NoMethodError
Committed, thanks. Jean-Philippe Lang
12:00 Revision 17818 (svn): Merged r17817 to 4.0-stable (#30455).
Jean-Philippe Lang
11:59 Revision 17817 (svn): Adding an issue note via email fails due to NoMethodError (#30455).
Patch by Go MAEDA. Jean-Philippe Lang
11:58 Defect #30353 (Closed): Installing rails with Bundler 2.0 fails in 3.x
Jean-Philippe Lang
11:51 Defect #30161 (Closed): Incorrect supported Ruby version in doc/INSTALL
Patch committed. We can't drop support for a ruby version in a minor version, so we keep 2.2 for now. Jean-Philippe Lang
11:50 Revision 17816 (svn): Merged r17815 to 4.0-stable (#30161).
Jean-Philippe Lang
11:49 Revision 17815 (svn): Incorrect supported Ruby version in doc/INSTALL (#30161).
Patch by Go MAEDA. Jean-Philippe Lang
11:48 Patch #29951 (Closed): Quick design fix/proposals for projects index page
Patch committed, thanks. Jean-Philippe Lang
11:48 Revision 17814 (svn): Merged r17812 to 3.4-stable (#29951).
Jean-Philippe Lang
11:47 Revision 17813 (svn): Merged r17812 to 4.0-stable (#29951).
Jean-Philippe Lang
11:46 Revision 17812 (svn): Do not break inside columns (#29951).
Patch by Marius BALTEANU. Jean-Philippe Lang
11:29 Feature #30464: Show estimated hours on the overview page as well as spent hours
+1 Yes, could be useful.
I would also be great to have this information in a nice bar chart. But this is a future topic. ;-)
Bernhard Rohloff
10:52 Patch #4502: New date filter operators: tomorrow, next week, next month
The current date of my PC is 2019-01-18 HST (2019-01-19 UTC).
QueryTest#test_operator_tomorrow expects that there are some issues whose due date is tomorrow (2019-01-19). However, there are issues whose due date is the day after the t...
Go MAEDA
09:33 Patch #4502 (Reopened): New date filter operators: tomorrow, next week, next month
QueryTest#test_operator_tomorrow fails depending on timezone.
I could reproduce the problem at 22:21 HST (Hawaii Standard Time -1000, 08:21 UTC). Maybe the problem occurs if the local date is different from the UTC date.
Go MAEDA
08:43 Patch #4502 (Closed): New date filter operators: tomorrow, next week, next month
Committed the patch. Thank you for improving Redmine.
I changed the order or operators and added Japanese translation.
Go MAEDA
10:47 Patch #30168: Wrap "splitcontentright" and "splitcontentleft" containers with a flexbox
Remade this patch against very recent trunk, should be working, if not, please inform me (it looks the same as last one, though :( ) :)
I reverted and tested to apply it, it worked for me to apply it cleanly to the most recent developme...
Anonymous
04:31 Patch #30168: Wrap "splitcontentright" and "splitcontentleft" containers with a flexbox
Marius BALTEANU wrote:
> Patches to be committed:
> ...
Committed use_splitcontent_in_my_page.patch.
Max, could you update splitcontent_responsive_fix.diff so that it can be applied cleanly?
Go MAEDA
09:06 Feature #4815 (Closed): More criteria for filtering tickets
Recent versions of Redmine supports "none" and "any" operators for most type of filters. Go MAEDA
08:48 Patch #18868 (Closed): Add support for queries with 'next week' filter
New operators including "next week" was added to date filters by #4502. The feature will be delivered in Redmine 4.1.0. Go MAEDA
08:42 Revision 17811 (svn): New date filter operators: tomorrow, next week, next month (#4502).
Patch by Mizuki ISHIKAWA. Go MAEDA
07:43 Patch #30466 (Closed): Remove unused i18n key "label_all_time"
label_all_time in config/locales/*.yml is no longer unsed after r13741. Go MAEDA
06:28 Defect #30255: This site can’t provide a secure connection www.redmine.org uses an unsupported protocol. ERR_SSL_VERSION_OR_CIPHER_MISMATCH
There has been an issue #29202, but it was marked as duplicate of an internal issue. Franklin Yu
04:26 Revision 17810 (svn): Add the splitcontent* classes to my page layout (#30168).
Patch by Marius BALTEANU. Go MAEDA
03:39 Patch #30463 (Closed): Japanese translation update (r17762)
Committed. Go MAEDA
03:39 Revision 17809 (svn): Japanese translation update (#30463).
Patch by Go MAEDA. Go MAEDA

2019-01-18

20:46 Patch #30465 (Closed): Deadlock when assigning custom values
There's been some changes in the new Rails version. It looks like deleting records from association is now scope aware.
After upgrading to Redmine 4.0, I've encountered several deadlocks under heavy load. Note that my DB has 30M+ reco...
Pavel Rosický
20:36 Feature #30464: Show estimated hours on the overview page as well as spent hours
+1, yes please! !{width:20px}https://cdn.discordapp.com/emojis/471854100984758274.png! Anonymous
14:03 Feature #30464 (Closed): Show estimated hours on the overview page as well as spent hours
Currently, you can see total spent hours on the project overview page.
I think it is useful for project managers if total estimated hours are shown as well.
!{width: 682px; border: 1px solid #ccc;}.time-tracking-box@2x.png!
Go MAEDA
15:47 Patch #30451: Move #main-menu outside of the #header to follow directly after the #header insetad
Yep, that's why in the subject of this ticket I propose something like this (see the attachment), as a temporary solution until we will find how to move #main-menu into the #main block without additional wrappers if possible.
But both c...
Anonymous
06:40 Patch #30451: Move #main-menu outside of the #header to follow directly after the #header insetad
Yes, unfortunately you are right. This doesn't seem to be achievable at the moment. I had a hard time yesterday getting your concept fixed and succeeded... well... on Firefox, Chrome was a f***in b****. It seems like flexbox isn't that f... Bernhard Rohloff
14:16 Feature #30462: Update Developer Guide for Redmine 4
Yep, I also think this should be fixed.
In the meantime you can look at my pull request for Redmine 4.0 compatibility of the plantUML plugin. After all, the fix for the deprecated alias_method_chain wasn't a big deal.
https://github.co...
Bernhard Rohloff
09:58 Feature #30462 (New): Update Developer Guide for Redmine 4
The current Developer Guide references using the @alias_method_chain@ pattern to wrap an existing method. This no longer works with Redmine 4 as Rails 5 doesn't support it (Refer to #30209). This is breaking a number of plugins including... Syntactic Vexation
11:53 Feature #30459: Switch edit/preview tabs with keyboard shortcuts
Bernhard Rohloff wrote:
> I remember this topic was also discussed in the original feature. The problem was that there can be multiple editors on a single view and the implemented accesskeys are not able to determine which editor is in ...
Marius BĂLTEANU
06:54 Feature #30459: Switch edit/preview tabs with keyboard shortcuts
I remember this topic was also discussed in the original feature. The problem was that there can be multiple editors on a single view and the implemented accesskeys are not able to determine which editor is in focus at the moment. We wou... Bernhard Rohloff
03:02 Feature #30459 (Closed): Switch edit/preview tabs with keyboard shortcuts
In Redmine 3.4 and earlier, you could update the preview with keybord shortcuts.
[[RedmineKeyboardNavigation]]:
|Key|Description|
|r|Updates the preview in editor mode|
I want to switch Edit/Preview tabs with keybord shortcuts.
G...
Mizuki ISHIKAWA
10:31 Patch #30463 (Closed): Japanese translation update (r17762)
Translated the following strings:
* error_spent_on_future_date
* setting_timelog_accept_future_dates
* error_not_allowed_to_log_time_for_other_users
* permission_log_time_for_other_users
Go MAEDA
10:08 Patch #30435: Replace float rules with flexbox for content and sidebar block
I think *width: 22%* will anyway often exceed it's maximum limitation of max-width, maybe we could try min-width: 220px and max-width: 280px or 300px?
In theory sidebar's content should then expand the sidebar in width within these marg...
Anonymous
10:08 Defect #30426 (Closed): Table rows are not highlighted on mouseover on some pages
Go MAEDA
09:34 Defect #30426 (Resolved): Table rows are not highlighted on mouseover on some pages
Marius BALTEANU wrote:
> Attached a better fix. I've checked both scenarios and it works well.
Committed. Thanks!
> ...
I must not forget this, too.
Go MAEDA
10:08 Revision 17808 (svn): Merged r17806 from trunk to 3.4-stable (#30426).
Go MAEDA
10:06 Revision 17807 (svn): Merged r17806 from trunk to 4.0-stable (#30426).
Go MAEDA
09:31 Revision 17806 (svn): Table rows are not highlighted on mouseover on some pages (#30426).
Patch by Marius BALTEANU. Go MAEDA
09:18 Patch #30421: Issue tracking table on user profile page
I am suggesting delivering this feature in 4.1.0. Go MAEDA
08:24 Feature #12521 (Reopened): Improve tracker deletion error message to display projects containing issues under the tracker
mr gosh wrote:
> You're right - but this is not possible if you have closed or archived projects - but this can be achieved by re-opening these projects - perhaps we reconsider our "projects don't get deleted" philosophy at this point. ...
Marius BĂLTEANU
08:17 Feature #30460 (Closed): This project is closed and read-only so please hidden all issue on mypage
Redmine 4.0 hides issues from closed projects in My page blocks. Please consider upgrading your Redmine instance to 4.0. Go MAEDA
08:03 Feature #30460 (Closed): This project is closed and read-only so please hidden all issue on mypage
When a project was closed and read-only, all my issues assigned to me still display on my page (Issues assigned to me). I think that not necessary for this case gralias gralias
01:56 Feature #30086: Use HTTP status code 403 instead of 401 when REST API is disabled
Returning 403 in the situation is consistent. In incoming emails API, MailHandlerController returns 403 if "WS for incoming emails" is disabled. Please see source:tags/4.0.0/app/controllers/mail_handler_controller.rb#L41.
Go MAEDA
 

Also available in: Atom