Project

General

Profile

Activity

From 2019-03-14 to 2019-03-16

2019-03-16

09:32 Feature #20497: Markdown formatting supporting HTML
Some time ago I've made a plugin to add a macro for that purpose as proposed in message#56105-56105. The syntax is quite easy and there's no need for an extra setting. I can attach it here on Monday if there's demand for it. Bernhard Rohloff
09:16 Defect #26691 (Closed): N + 1 queries when rendering the Gantt
Go MAEDA
07:27 Patch #31034 (Closed): Remove encoding magic comments
Committed. Go MAEDA
06:21 Patch #31034 (Closed): Remove encoding magic comments
The magic comment "encoding: utf-8" is no longer necessary. It was necessary only in Ruby 1.9 in which default script encoding was ASCII-8BIT. The default is UTF-8 after Ruby 2.0.
Since Redmine 4.0 or later don't support Ruby 1.9 (#25...
Go MAEDA

2019-03-15

20:04 Feature #20497: Markdown formatting supporting HTML
This has been mentioned in others issues pointing at this one, but my #1 reason for wanting HTML would currently be the resizing of images or using thumbnails. Coming from JIRA where thumbnails are quite easy.
See here
https://sta...
Anonymous
15:44 Defect #29625: application.css imported by themes not covered by cache control versioning
+1
I think this information should be known more.
Yuuki NARA
14:55 Feature #10264: Add a check/uncheck all button to search
My recommendation is to deliver this in version:"4.0.3" (is not such a big change). Marius BĂLTEANU
14:51 Feature #10264: Add a check/uncheck all button to search
Alexander Meindl wrote:
> This issue shows target version 4.0.2 and "changelog":https://www.redmine.org/projects/redmine/wiki/Changelog_4_0 shows it, too. But the related commit currently only exists in trunk. I think, this issue should...
Marius BĂLTEANU
13:20 Feature #10264: Add a check/uncheck all button to search
This issue shows target version 4.0.2 and "changelog":https://www.redmine.org/projects/redmine/wiki/Changelog_4_0 shows it, too. But the related commit currently only exists in trunk. I think, this issue should changed to target version ... Alexander Meindl
12:52 Feature #12796 (Closed): Display user's groups on profile
I understand the issue. The request was about viewing its own groups so a safer solution is to display the groups for administrators and the current user only. I've updated Marius' patch accordingly, thanks. Jean-Philippe Lang
10:27 Feature #12796: Display user's groups on profile
Hinako Tajima wrote:
> The patch written by Marius BALTEANU shows all the groups which the user belongs appears on the user's profile page, but I wondered it may cause security problems.
> ...
I'm not sure that I fully understand your ...
Marius BĂLTEANU
00:47 Feature #12796: Display user's groups on profile
The patch written by Marius BALTEANU shows all the groups which the user belongs appears on the user's profile page, but I wondered it may cause security problems.
Group names include important information such as organization names, ...
Hinako Tajima
12:04 Feature #29725 (Closed): Show recent documents first when sorting documents by date
Committed, thanks. Jean-Philippe Lang
11:45 Feature #442 (Closed): Add a description for trackers
Feature committed, thank you Marius for your patches. Jean-Philippe Lang
11:23 Feature #31032: Display details about inheritance when editing a member roles
Nice addition! Marius BĂLTEANU
11:11 Feature #31032 (Closed): Display details about inheritance when editing a member roles
Jean-Philippe Lang
11:09 Feature #31032 (Closed): Display details about inheritance when editing a member roles
Inherited roles of project members cannot be edited, they can be inherited from the parent projet or from the belonging to any group.
It would be usefull to know how a given role was inherited.
Jean-Philippe Lang
10:45 Defect #29209 (Closed): Long text custom fields don't accept values longer than 64KB if backend database is MySQL
Fixed in r17965. Jean-Philippe Lang
10:37 Defect #28502 (Closed): Support issue[assigned_to_id]=me when prefilling issues
Committed, thanks! Jean-Philippe Lang
10:30 Defect #27101 (Closed): Project identifier model constraint doesn't match with text_project_identifier_info and JS-generated identifiers
Thanks for pointing this out. I've updated the information messages that were obviously wrong.
OTOH, I think it's OK to keep the JS code as it is. Even if not mandatory, it's better to default to an identifier that starts with a lower c...
Jean-Philippe Lang
10:16 Defect #26691: N + 1 queries when rendering the Gantt
jwjw yy wrote:
> Rails 4.2.7.1
> ...
These queries are executed once per project, not for each one of your 20k issues. I think that having hundreds of projects on the gantt chart is pretty uncommon, I'd prefer to keep it simple and not...
Jean-Philippe Lang
10:09 Defect #30988: Preformatted text overflows the preview area
The proposed patch is not enough, it only fixes the issue in the notes block.
The description is also affected, please the below screenshot:
!description.png!
The old fix before Edit/Preview tabs was the rule @'min-width': inher...
Marius BĂLTEANU
10:00 Defect #30988: Preformatted text overflows the preview area
Marius BALTEANU wrote:
> Go MAEDA wrote:
> ...
Thanks. Setting the target version to 4.0.3.
Go MAEDA
09:53 Defect #30988: Preformatted text overflows the preview area
Go MAEDA wrote:
> Marius, could you review this fix?
Looking right now, maybe we can include the fix for this issue in the next release (version:"4.0.3").
Marius BĂLTEANU
03:30 Defect #30988: Preformatted text overflows the preview area
Marius, could you review this fix? Go MAEDA
09:54 Defect #30850 (Resolved): Unified diff link broken on specific file/revision diff view
Fix committed in r17962 by restoring @:format => false@ just like it was in 3.4.
This was changed when upgrading to Rails 5 because @:format => false@ was no longer working a sexpected, I suspect that a Rails regression was fixed lately...
Jean-Philippe Lang
09:22 Defect #30850: Unified diff link broken on specific file/revision diff view
Mizuki ISHIKAWA wrote:
> By changing to the following, the diff format is allowed.
> ...
This change doesn't work when trying to get the diff of a single file of a revision, eg:
/projects/projet-a/repository/svn2/revisions/10/diff/sub...
Jean-Philippe Lang
09:01 Patch #31030 (Closed): Include plugin name in the exception when the plugin required by requires_redmine_plugin is not found
Committed, thanks. Jean-Philippe Lang
04:25 Patch #31030: Include plugin name in the exception when the plugin required by requires_redmine_plugin is not found
Setting the target version to 4.0.3. Go MAEDA
03:27 Patch #31030: Include plugin name in the exception when the plugin required by requires_redmine_plugin is not found
I think it should catch only PluginNotFound exception. Go MAEDA
08:59 Defect #30753 (Closed): Plugins auto_load and eager_load paths
Committed, thanks. Jean-Philippe Lang
08:54 Defect #26836 (Closed): Filtering issues via context menu should not reset selected columns
Patch committed, thanks. I made a slight change after that in order not to manually parse the back_url. Jean-Philippe Lang
08:38 Defect #30872 (Closed): Copyright is outdated
Updated to 2019. Jean-Philippe Lang
08:30 Defect #29055 (Closed): Searching for issue number with REST API redirects to issue HTML page
Fix committed, thanks. Test moved to the API tests. Jean-Philippe Lang
04:14 Patch #31022 (Closed): Always use HTTPS when accessing gravatar.com
Committed. Go MAEDA

2019-03-14

16:06 Patch #31030: Include plugin name in the exception when the plugin required by requires_redmine_plugin is not found
Here is the patch. Jérôme BATAILLE
16:03 Patch #31030 (Closed): Include plugin name in the exception when the plugin required by requires_redmine_plugin is not found
The exception is : Jérôme BATAILLE
14:33 Patch #4502 (Closed): New date filter operators: tomorrow, next week, next month
Go MAEDA
09:28 Defect #31028: Get 200 response even when specifying an id value that does not exist.
I checked again with Redmine 4.0.2.
I got 422 response when specifying an id value that does not exist in 'priority_id'
I got 200 response even when specifying an id value that does not exist in 'project_id, tracker_id, status_id, cate...
ume san
08:46 Defect #31028: Get 200 response even when specifying an id value that does not exist.
#19276 may also be related ume san
08:43 Defect #31028 (New): Get 200 response even when specifying an id value that does not exist.
At Redmine 4.0.1,
I get 422 response when specifying an id value that does not exist in 'assigned_to_id'
However I get 200 response even when specifying an id value that does not exist in 'project_id, tracker_id, status_id, priority_id...
ume san
08:09 Patch #31022: Always use HTTPS when accessing gravatar.com
This updated patch is frozen string literals ready. Go MAEDA
06:19 Feature #30975: New My page block: Updated issues
Added a "Updated issues" block to the My page.
I attached a patch.
!{width:50%;border:1px solid #ccc;}updated_issues_block_on_mypage.png!
Yuichi HARADA
05:44 Defect #30925: Concerns about the credit in the footer of Redmine
This issue was owned by @Max J.@ from the Discord chat. I have no clue why he deleted his account... Bernhard Rohloff
00:42 Defect #30925 (Closed): Concerns about the credit in the footer of Redmine
I am closing this issue because the person who requested this change deleted his own account. Go MAEDA
03:50 Defect #30988: Preformatted text overflows the preview area
The following changes solves this problem. Mizuki ISHIKAWA
01:49 Feature #31026 (Closed): Upgrade to Rails 5.2.2.1
Thank you for sharing the news. I have upgraded the Rails version in each branch.
Go MAEDA
01:44 Feature #31027 (Closed): Upgrade to Rails 4.2.11.1
Committed. Go MAEDA
00:24 Feature #31027 (Closed): Upgrade to Rails 4.2.11.1
Copied from #31026.
---
https://weblog.rubyonrails.org/2019/3/13/Rails-4-2-5-1-5-1-6-2-have-been-released/
> Rails 4.2.11.1, 5.0.7.2, 5.1.6.2, 5.2.2.1, and 6.0.0.beta3 have been released! These contain the following important se...
Go MAEDA
 

Also available in: Atom