Project

General

Profile

Activity

From 2019-08-19 to 2019-08-21

2019-08-21

21:07 Feature #23997: Per role visibility settings for version custom fields
@Marius - From the looks of it I would say I did that to prevent a user from setting the values of fields they cannot see through a crafted request. The same logic is present in the issue model. strictly speaking the same should be done ... Jens Krämer
18:57 Feature #26846: Ability to Add Members to the Child Project of the Parent
Thank you for the feedback, this one can now be closed. Razmig Varsam
18:22 Defect #31932 (Closed): Add Sponsor in the Group Results By Drop Down for Custom Queries
Is it possible to add the Sponsor in the Group Results By drop down section in the custom query section? Right now, that option is not there and I find that it's beneficial to sort tickets by Sponsor by not having to export to Excel or G... Razmig Varsam
15:30 Defect #19786: '%' and '_' are treated as SQL wildcards in issue filter
'%' works as wildcard for me, but '_' does not always work.
I was looking for the wildcard character and found your defect, please do not fix it :)
Stéphane Frath
14:16 Feature #3972: Translation for field values
Preferably this should be built-in feature..
+1
So both field-names, and field-values should be translatable...
In order to make it work with Redmine 4, (localizable 0.4.0) you must lock i18n gem to 0.7.0 instead
of 1.6 which ...
Aleksandar Pavic
13:42 Feature #13347: Filtering by issue subject with wildcard
For anyone looking for an answer: the % character works as wildcard in the subject text field
Tested on Redmine 4.0.4
Stéphane Frath
03:16 Patch #31556: Update Rouge to 3.12.0
Updated Rouge to 3.9.0 in r18382. Go MAEDA
03:16 Revision 18382 (svn): Update Rouge to 3.9.0 (#31556).
Go MAEDA
02:38 Defect #31929 (Closed): MarkdownFormatterTest#test_should_support_underlined_text is declared as private
Committed the patch. Thanks.
I don't think we have to backport this change to 4.0-stable because the issue does not affect users.
Go MAEDA
00:30 Defect #31929: MarkdownFormatterTest#test_should_support_underlined_text is declared as private
Setting the target version to 4.0.5. Go MAEDA
02:31 Revision 18381 (svn): MarkdownFormatterTest#test_should_support_underlined_text is declared as private (#31929).
Patch by Marius BALTEANU. Go MAEDA

2019-08-20

22:37 Feature #31930 (New): REST API for Versions (roadmap) Relationship and percentage
It would be great to have versions relationship and percentage available via the REST API.
Example: GET /versions/172/relations.xml
Will Tsus
22:30 Feature #23997: Per role visibility settings for version custom fields
Attached the patch for version custom fields.
@Jens, do you remember why did you override the @safe_attributes=@ method in your proposed patch for @Version@?
Tests pass: https://gitlab.com/redmine-org/redmine/pipelines/77404580
Marius BĂLTEANU
20:33 Defect #31929 (Confirmed): MarkdownFormatterTest#test_should_support_underlined_text is declared as private
It was introduced by me in #28169. Attached a patch with the fix. Marius BĂLTEANU
19:37 Defect #31929 (Closed): MarkdownFormatterTest#test_should_support_underlined_text is declared as private
#28169 introduced @Redmine::WikiFormatting::MarkdownFormatterTest#test_should_support_underlined_text@. However, this test seems to be unintentionally declared as private instead of being public due to the existence of the private method... Mischa The Evil
19:39 Defect #22323: Markdown newline rendering broken
Martin Cizek wrote:
> P.S. The tests at the end of @MarkdownFormatterTest@ seem to be commented out by @private@? Not sure why, but the tests work even after commenting it out to @#private@.
I have reported this in a separate issue, ...
Mischa The Evil
16:29 Defect #22323: Markdown newline rendering broken
On one hand, calling this a defect might not be fair, as it is apparently kind-of decision made in @lib/redmine/wiki_formatting/markdown/formatter.rb@ with the setting @:hard_wrap => true@. Indeed, we do not know how intentional the deci... Martin Cizek
15:12 Feature #5953: Copy RSS/REST API keys to clipboard
Thank you for posting the patch. I tried out it and noticed the following points:
* There is no feedback when you click the Copy link. Users may confused and click the link again and again
* In Redmine, copy.png and the label "Copy" ...
Go MAEDA
10:57 Defect #31900: Problem with tickets issued by rdm-mailhandler on redmine 4.0.4
Gerhard Kronstorfer wrote:
> I've sent the mail as requested.
Thank you, I have received the email. I will look into this issue.
Go MAEDA
08:46 Feature #1237: Add support for two-factor authentication
Updated first patch that adds a require statement necessary for the patch to work in production. Jens Krämer
05:27 Revision 18380 (svn): Code cleanup: RuboCop: Fix Style/IdenticalConditionalBranches in app/models/project.rb
Go MAEDA
04:48 Defect #31924 (Needs feedback): Paging misses some entries
Could you try the following patch extracted from #29581? Go MAEDA
03:48 Feature #31925 (Closed): Per role visibility settings for project custom fields
Committed the patch. Thank you for adding a nice feature! Go MAEDA
03:44 Revision 18379 (svn): Per role visibility settings for project custom fields (#31925).
Patch by Jens Krämer and Marius BALTEANU. Go MAEDA
03:19 Defect #28133: Controller patch causes Helper Patch down
Hi, Stephan!
The version of Redmine that everyone mainly use will soon be 4.x, then 3.x.
Since I always struggle with plug-in combinations, so your information above is helpful.
Stephan Wiehr wrote:
> Found this during investigat...
Akiko Takano

2019-08-19

22:54 Feature #31505: Mark edited journal notes as "Edited"
Updated the patch to apply cleanly on the current trunk. Should include this in version:"4.1.0"? Marius BĂLTEANU
22:18 Feature #31925: Per role visibility settings for project custom fields
Tests pass: https://gitlab.com/redmine-org/redmine/pipelines/77163012 Marius BĂLTEANU
22:18 Feature #31925 (Closed): Per role visibility settings for project custom fields
Extracted the patch from #23997.
Marius BĂLTEANU
18:06 Defect #31900: Problem with tickets issued by rdm-mailhandler on redmine 4.0.4
I've sent the mail as requested. Gerhard Kronstorfer
15:59 Defect #31900: Problem with tickets issued by rdm-mailhandler on redmine 4.0.4
Gerhard Kronstorfer wrote:
> When I send a mail with a picture the picture is lost and the rest of the mail produceses a ticket with the same problems like with the original rdm-mailhandler.rb:
I will try to debug the issue. Could yo...
Go MAEDA
11:14 Defect #31900: Problem with tickets issued by rdm-mailhandler on redmine 4.0.4
The latest version of rdm-mailhandler.rb solves only a part of the problem.
When I send a normel mail (with no picture) the new version works perfect:
Gerhard Kronstorfer
05:16 Defect #31900: Problem with tickets issued by rdm-mailhandler on redmine 4.0.4
Could you try using the latest rdm-mailhandler.rb?: https://www.redmine.org/projects/redmine/repository/revisions/18317/entry/trunk/extra/mail_handler/rdm-mailhandler.rb
Perhaps the problem you are experiencing is related to #31549.
Go MAEDA
17:18 Defect #31924: Paging misses some entries
Gah, not markdown and I can't edit the original...
Also the example code was broken:
Attie Grande
17:15 Defect #31924 (Closed): Paging misses some entries
I've just been using the API to batch-update a large number of time entries (moving toggl ID from a comment into a custom field), and I noticed that a handful of records were not retrieved via `time_entries.json` (and thus weren't update... Attie Grande
16:42 Feature #31881: Add "behind-schedule" CSS class to issues
Here is a patch. Go MAEDA
08:17 Feature #23997: Per role visibility settings for version custom fields
Looks good to me! Jens Krämer
07:16 Feature #23997: Per role visibility settings for version custom fields
Marius BALTEANU wrote:
> Working on it, I've observed an inconsistent behaviour (which I consider it a defect/security issue), the project custom fields not visible for normal users are still visible in project settings for those users ...
Go MAEDA
02:14 Feature #30419: Drop support for MySQL 5.5
I think it is premature to drop support for MySQL 5.5.
* CentOS 7 bundles MariaDB 5.5.60. The support for CentOS ends on 2024-06-30
* The latest version of ActiveRecord 6.0.0 still supports MySQL 5.5.8: https://github.com/rails/rails...
Go MAEDA
 

Also available in: Atom