Activity
From 2019-09-12 to 2019-09-14
2019-09-14
-
21:03 Revision 18470 (svn): code cleanup: rubocop: fix Layout/IndentationConsistency in test/functional/repositories_mercurial_controller_test.rb
-
20:45 Revision 18469 (svn): code cleanup: rubocop: fix Layout/EmptyLinesAroundMethodBody in test/functional/repositories_git_controller_test.rb
-
06:24 Defect #31946: No log message when MailHandler ignored a reply to a nonexistent issue, journal, or message
- Go MAEDA wrote:
> The patch cannot be cleanly applied due to r18404.
Updated the patch. -
03:03 Patch #31640 (Closed): Add clear query icon next to selected query in sidebar
- Committed the patch. Thank you for improving Redmine.
-
02:33 Revision 18468 (svn): Add clear query icon next to selected query in sidebar (#31640).
- Patch by Marius BALTEANU.
-
01:44 Defect #31708 (Closed): Not able to add member to a project
- Fixed in r18467. Closing.
2019-09-13
-
23:44 Feature #8016: Drag-and-drop issue (ticket) ordering
- +1
-
20:41 Defect #31708: Not able to add member to a project
- libjs-jquery-ui updated itself after upgrade from Ubuntu 17.10 Artful while doing dist-upgrade... Even tried to get back to v1.11, but couldn't find it anywhere in the previous releases (1.10 at Xenial, but downgrade wasn't working). Any...
-
16:51 Defect #31708: Not able to add member to a project
- Paweł Szmigiel wrote:
> I figured out that this problem is connected to the jquery-ui version 1.12, which has Deprecated .zIndex() function. You can manually edit application.js like here:
> ...
Thank you for reporting the detail.
P... -
14:43 Defect #31708: Not able to add member to a project
- I figured out that this problem is connected to the jquery-ui version 1.12, which has Deprecated .zIndex() function. You can manually edit application.js like here:
https://bugs.launchpad.net/ubuntu/+source/redmine/+bug/1838407
-
16:44 Revision 18467 (svn): Merged r18377 from trunk to 4.0-stable (#31870).
-
15:46 Revision 18466 (svn): code cleanup: rubocop: fix Layout/IndentationConsistency in test/functional/repositories_git_controller_test.rb
-
15:09 Feature #3224: Better project list
- related to #29482
-
11:27 Defect #32003: Project copy always send email notifications ignoring "Send email notifications during the project copy" option
- this method is problematic and should be deprecated because it can't reliably work with async deliveries https://github.com/redmine/redmine/blob/master/app/models/mailer.rb#L611
it might be better not to generate emails at all if you ... -
08:01 Defect #32003 (Confirmed): Project copy always send email notifications ignoring "Send email notifications during the project copy" option
- The option does not work since Redmine 4.0.0. Probably it is caused by #26791. Replacing @deliver_later@ with @deliver@ in @app/models/mailer.rb@ can be a quick-and-dirty workaround.
-
10:52 Patch #32025 (Closed): mail_body method in test/test_helper.rb raises an exception if the message is not multipart
- Committed the fix. Thank you for catching the issue.
-
03:58 Patch #32025: mail_body method in test/test_helper.rb raises an exception if the message is not multipart
- Go MAEDA wrote:
> The root cause of the issue is that @mail_body@ method in test/test_helper.rb supports only multi-part messages and does not support plaintext messages.
> ...
+1
I agree. Setting of @Setting.plain_text_mail@ is not d... -
02:47 Patch #32025: mail_body method in test/test_helper.rb raises an exception if the message is not multipart
- Thank you for catching and investigating the issue.
The root cause of the issue is that @mail_body@ method in test/test_helper.rb supports only multi-part messages and does not support plaintext messages.
I think it is better to ch... -
10:51 Revision 18465 (svn): mail_body method in test/test_helper.rb raises an exception if the message is not multipart (#32025).
- This change fixes random test failures.
-
07:00 Revision 18464 (svn): code clean up test/functional/repositories_mercurial_controller_test.rb
-
07:00 Revision 18463 (svn): code clean up test/functional/repositories_git_controller_test.rb
-
07:00 Revision 18462 (svn): code cleanup: rubocop: fix Style/MethodCallWithoutArgsParentheses in test/functional/repositories_git_controller_test.rb
-
05:17 Feature #14300: E-mail notification for things I am assigned to or I am owner of
- I am against this change.
Watchers are supposed to receive email notifications. When a user adds another user as a watcher, they think they can notify updates to the user. The proposed change breaks this assumption.
-
04:25 Revision 18461 (svn): rubocop: disable Naming/PredicateName
-
00:56 Defect #32046 (Closed): SQL to get counts when using created_on in MySQL to group issues does not work correctly
- Committed the fix as a part of #13803. Thank you all for working on fixing the issue.
-
00:55 Revision 18460 (svn): Fix that date grouping for MySQL is not working (#32046, #13803).
- Patch by Mizuki ISHIKAWA.
-
00:17 Feature #1448: Add tags to issues
- I would like to discuss this for the next major release, it is one of the most requested feature.
-
00:16 Feature #1448: Add tags to issues
- Updated the patch to apply cleanly on the current trunk.
2019-09-12
-
23:54 Patch #32054 (Closed): Add test for 4 byte characters (emoji) support
- In #31921 was added proper support for 4 byte characters (emoji) for new installations with MySQL as database.
I proposed to have a test for this case, but we're worried that the test will broke the CI server.
The scope of this ti... -
23:53 Feature #31910 (Closed): Add additional mail headers for issue tracker
- Committed the patch. Thank you for suggesting this improvement.
-
23:52 Revision 18459 (svn): Add additional mail headers for issue tracker (#31910).
- Patch by Go MAEDA.
-
23:46 Defect #32046: SQL to get counts when using created_on in MySQL to group issues does not work correctly
- Go MAEDA wrote:
> Marius, could you review this patch? It updates MySQL support for the date grouping filter option committed in r17745.
The fix works well, thanks for catching and fixing this issue. -
19:25 Defect #31986: Error selecting issues between dates after upgrading redmine 2.3.2 to 4.0.x
- Adauto Serpa wrote:
> Hi,
> ...
I tested with a normal Redmine installation and the bug did not occur. This bug is occurring in a docker installation. -
18:23 Revision 18458 (svn): code cleanup: rubocop: fix Lint/HandleExceptions in lib/redmine/scm/adapters/mercurial_adapter.rb
-
18:23 Revision 18457 (svn): rubocop: use Lint/HandleExceptions AllowComments true
-
18:18 Feature #31300: Automatically switch between native date picker and custom date picker based on mobile or not mobile devices
- I vote for this. We recently updated to 3.4.11 from 3.2.? and discovered that our corporate standard date format (yyyy-mm-dd) is not available in Redmine Date pickers. I have read the W3 consortium's implementation notes and cannot bel...
-
17:08 Revision 18456 (svn): code cleanup: rubocop: fix Lint/AmbiguousOperator in lib/redmine/scm/adapters/mercurial_adapter.rb
-
14:51 Patch #13468 (Closed): REST API for News
- Go MAEDA wrote:
> The test fails due to a missing fixture.
Committed in r18455.
-
14:48 Patch #13468 (Reopened): REST API for News
- The test fails due to a missing fixture.
-
14:51 Revision 18455 (svn): Add missing fixture (#13468).
-
12:08 Feature #32052: Auto-complete issues #id in search form
- I think this small but great improvement should be delivered together with #31989. Setting the target version to 4.1.0.
-
09:09 Feature #32052: Auto-complete issues #id in search form
- I attached a patch.
* The change to inlineAutoComplete is to disable the autocomplete built-in Firefox browser.
!{width: 300px; border: 1px solid #ccc}firefox-screen.png!
* Issue id(#nnnnn) keyword can search for issues in other ... -
08:59 Feature #32052 (Closed): Auto-complete issues #id in search form
- I think it would be useful to be able to autocomplete #id in the search form.
Example:
!{width: 500px; border: 1px solid #ccc}search1.png!
!{width: 500px; border: 1px solid #ccc}search2.png! -
12:02 Feature #31921 (Closed): Changes to properly support 4 byte characters (emoji) when database is MySQL
- Committed the updated patch in #31921#note-33. Thanks.
-
12:02 Revision 18454 (svn): Update default database config for MySQL to support 4 byte characters (emoji) (#31921).
- Patch by Marius BALTEANU and Go MAEDA.
-
09:39 Defect #32047: Do not delete parent issues that have child issues
- Go Maeda,good!
I would like to request the same way
-
07:27 Revision 18453 (svn): code cleanup: scm: cvs: remove unused branchPoint method from CvsRevisionHelper class
-
04:39 Patch #31640: Add clear query icon next to selected query in sidebar
- Marius BALTEANU wrote:
> Regarding the patch, you have attached a wrong one.
Sorry, here is the correct patch.
-
01:36 Patch #31994 (Closed): Allow issue auto complete to return 10 issues when there is not search term provided
- Mischa The Evil wrote:
> Shouldn't this change be reflected in the name of the test that is committed (@test_auto_complete_without_term_should_return_last_10_updated_issues@)?
Thank you for pointing it out. Committed the fix posted i... -
01:31 Revision 18452 (svn): Fix the test name different from the actual behavior (#31994).
- Patch by Marius BALTEANU.