Project

General

Profile

Activity

From 2019-09-09 to 2019-09-11

2019-09-11

22:19 Feature #13919: Mention user on issues and wiki pages using @user with autocomplete
Mizuki ISHIKAWA wrote:
>
> ...
Thanks for you quick feedback. Do you like to continue from here? I would be very happy to review the patch.
Marius BĂLTEANU
02:24 Feature #13919: Mention user on issues and wiki pages using @user with autocomplete
Marius BALTEANU wrote:
> Please let me know what do you think about this.
Thank you for your activity on this Issue(feature)!
The implementation using the "acts_as_mentionable" plugin looks more beautiful than the patch implementati...
Mizuki ISHIKAWA
21:44 Patch #31994 (Reopened): Allow issue auto complete to return 10 issues when there is not search term provided
Mischa The Evil wrote:
> Marius BALTEANU wrote:
> ...
Indeed, it should, sorry for it.
Marius BĂLTEANU
19:36 Patch #31994: Allow issue auto complete to return 10 issues when there is not search term provided
Marius BALTEANU wrote:
> Go MAEDA wrote:
> ...
Shouldn't this change be reflected in the name of the test that is committed (@test_auto_complete_without_term_should_return_last_10_updated_issues@)?
Mischa The Evil
09:18 Patch #31994 (Closed): Allow issue auto complete to return 10 issues when there is not search term provided
Committed the patches. Thank you for your contribution. Go MAEDA
09:16 Patch #31994: Allow issue auto complete to return 10 issues when there is not search term provided
Marius BALTEANU wrote:
> Second patch removes a view that is not used from my checks (code cleanup).
app/views/auto_completes/issues.html.erb is no longer used after r17881 (@render :layout => false@ was replaced with @render :json =...
Go MAEDA
13:00 Defect #32047: Do not delete parent issues that have child issues
+1
Sounds like a great idea and prevents the user from unforeseen side effects.
Bernhard Rohloff
11:24 Defect #32047: Do not delete parent issues that have child issues
+1
How about showing a confirmation dialog like the following instead of disallowing to delete a parent issue? In the current versions, a similar dialog is shown when deleting an issue which has spent time logs.
!{width: 580px; borde...
Go MAEDA
09:19 Defect #32047 (New): Do not delete parent issues that have child issues
Do not delete parent issues that have child issues please
--jp--
子チケットがあるチケットを削除した場合、子チケット含めて消えてしまいます
子チケットがある親チケットを削除できないような制限をかけてもらえませんか?
ーーー
Hirofumi Kadoya
12:57 Defect #32049 (Closed): Redmine allows same user to login from different machines simulteniously
Using Redmine 4.0.4
Able to Login using same user credentials from different machines at same time.
Expected :- If user is already logged in on 1 machine then it should not allow user to log-in on other machine.
Thanks
Amit Mehendale
10:08 Revision 18451 (svn): Code cleanup: RuboCop: Fix Performance/RedundantMatch and Rails/DynamicFindBy in app/controllers/auto_completes_controller.rb
Go MAEDA
09:18 Revision 18450 (svn): Remove 'app/views/auto_completes/issues.html.erb' which is not used (#31994).
Patch by Marius BALTEANU. Go MAEDA
08:39 Revision 18449 (svn): Issue auto complete should return last 10 issues (#31994).
Patch by Marius BALTEANU. Go MAEDA
08:05 Defect #32046: SQL to get counts when using created_on in MySQL to group issues does not work correctly
Marius, could you review this patch? It updates MySQL support for the date grouping filter option committed in r17745. Go MAEDA
02:37 Defect #32046: SQL to get counts when using created_on in MySQL to group issues does not work correctly
You have to make changes like the diff below. Mizuki ISHIKAWA
02:36 Defect #32046 (Closed): SQL to get counts when using created_on in MySQL to group issues does not work correctly
Reproduction procedure
* Use MySQL
* "Time zone data":https://dev.mysql.com/doc/refman/5.6/en/mysql-tzinfo-to-sql.html is loaded(If it is not loaded, time zone conversion will fail.)
* Change user language from UTC to something else
...
Mizuki ISHIKAWA
07:51 Revision 18448 (svn): code cleanup: rubocop: fix Layout/SpaceInsideReferenceBrackets in test/unit/lib/redmine/scm/adapters/git_adapter_test.rb
Toshi MARUYAMA
07:50 Revision 18447 (svn): code cleanup: rubocop: fix Layout/SpaceInsideReferenceBrackets in lib/redmine/scm/adapters/subversion_adapter.rb
Toshi MARUYAMA
07:15 Patch #13468: REST API for News
Sorry, I should have run tests locally before commenting.
Thanks for fixing.
vzvu 3k6k
03:53 Patch #13468: REST API for News
Yuichi HARADA wrote:
> @Redmine::ApiTest::NewsTest#test_GET_/news/:id.xml@ fails if config.time_zone is set.
Committed the fix in r18445. Thank you for reporting and fixing it.
Go MAEDA
04:07 Defect #30467 (Closed): Footer is not placed at the bottom on pages with little content
Marius BALTEANU wrote:
> I think it's safer to target the wrapper elements by their id instead of using "starting with":
> ...
Committed the fix in r18446. Thanks.
Go MAEDA
04:06 Revision 18446 (svn): Don't use ^= operator to target the wrapper elements (#30467).
Patch by Marius BALTEANU. Go MAEDA
03:53 Revision 18445 (svn): Fix that Redmine::ApiTest::NewsTest fails when config.time_zone is set (#13468).
Patch by Yuichi HARADA. Go MAEDA
02:49 Defect #31972: An empty group_count badge is displayed when grouped with created_on
I forgot to attach the patch.
Change the same as "timelog":http://www.redmine.org/projects/redmine/repository/entry/trunk/app/views/timelog/_list.html.erb#L25 .
Mizuki ISHIKAWA

2019-09-10

21:52 Defect #32041: Unable to reuse project name after delete
James Byrne wrote:
> invalid. New repo simply took a long time to load.
Thanks for your feedback.
Marius BĂLTEANU
21:52 Defect #32041 (Closed): Unable to reuse project name after delete
Marius BĂLTEANU
21:17 Defect #32041 (Resolved): Unable to reuse project name after delete
invalid. New repo simply took a long time to load. James Byrne
19:07 Feature #13919: Mention user on issues and wiki pages using @user with autocomplete
@Mizuki ISHIKAWA, what do you think if we try to implement this feature using a new plugin named "acts_as_mentionable" which will be able to look for mentioned users (for now, it can be extended to another entities in the future) only on... Marius BĂLTEANU
18:28 Patch #31994: Allow issue auto complete to return 10 issues when there is not search term provided
Go MAEDA wrote:
> The subject says "return last 10 updated issues" but actually the patch returns last 10 created issues. Is it OK?
> ...
Indeed, my initial intention was to return the last 10 updated issues, but during the implementat...
Marius BĂLTEANU
00:00 Patch #31994: Allow issue auto complete to return 10 issues when there is not search term provided
The subject says "return last 10 updated issues" but actually the patch returns last 10 created issues. Is it OK? Go MAEDA
15:07 Defect #30467: Footer is not placed at the bottom on pages with little content
Marius BALTEANU wrote:
> I think it's safer to target the wrapper elements by their id instead of using "starting with":
> ...
No, you're right. wrapper is quite generic and could be used in more places.
I think it should be changed t...
Bernhard Rohloff
13:08 Defect #13781: CJK(Chinese/Japanese/Korean) characters are not shown in PDF on non CJK locales
Hello i found solution for this issue:
1. you need to create mysql database with utf8 parameter.
2. go to /redmine/app/models/user.rb and replace this line and comment the default one
#validates_format_of :login, :with => /\A[a-z0-9...
nikunj begda
12:33 Defect #25207: Cannot assign users to project of projects to user
Hi, I have the same issue on Redmine 4.0.4, but I don't have CSP enabled. It happens on all the browsers. Can't find the resolution anywhere. Would appreciate any hints. It is happening after upgrade from 3.4 to 4.0. Paweł Szmigiel
12:29 Defect #31708: Not able to add member to a project
Carmelo Pansera wrote:
> Hello
> ...
Hi, I have the same issue on Redmine 4.0.4, don't have CSP enabled, can't find any solution to this, would appreciate any help.
Paweł Szmigiel
11:23 Feature #32042 (New): Show in summary
Add "Show in summary" when creating/editing custom field.
Show in summary would show custom field in summary (report) which is accessible via issues sidebar.
Aleksandar Pavic
08:16 Patch #13468: REST API for News
@Redmine::ApiTest::NewsTest#test_GET_/news/:id.xml@ fails if config.time_zone is set.
Set config.time_zone in config/additional_environment.rb.
Yuichi HARADA

2019-09-09

23:50 Feature #31989 (Closed): Inline issue auto complete (#) in fields with text-formatting enabled
Committed the patch. Thank you for contributing such a great enhancement! Go MAEDA
20:04 Feature #31989: Inline issue auto complete (#) in fields with text-formatting enabled
I've removed the user autocomplete feature from the patch.
Go MAEDA wrote:
> I think it is better to add @requireLeadingSpace: true@ in order to prevent the auto-complete menu from being displayed while typing the second "#" in "#123...
Marius BĂLTEANU
23:49 Revision 18444 (svn): Inline auto complete for issue (#) in wiki-edit fields (#31989).
Patch by Marius BALTEANU. Go MAEDA
22:31 Feature #21808: Make the Sidebar collapsible, stateful
I've reworked a little bit the patch posted by Jens Krämer in order to show 20px from the sidebar in state collapsed and to expand the sidebar on hover. The patch is not ready, it is only for demo purposes.
*1. State collapsed:*
!.co...
Marius BĂLTEANU
22:21 Feature #12032 (Closed): Collapsible Sidebar
Closing this in favour of #21808 which has multiple patches and a feedback from Jean-Philippe. Marius BĂLTEANU
22:20 Feature #10525 (Closed): A new button to hide/show the sidebar
Closing this in favour of #21808 which has multiple patches and a feedback from Jean-Philippe. Marius BĂLTEANU
21:50 Defect #30467 (Reopened): Footer is not placed at the bottom on pages with little content
I think it's safer to target the wrapper elements by their id instead of using "starting with": Marius BĂLTEANU
21:41 Feature #31353: Replace user related links in the top menu bar with a proper user menu.
You can test the attached patch, I'm not very happy with the implementation, but for a first round of feedback, it should be good enough. Marius BĂLTEANU
21:39 Patch #31441 (Closed): Show elements titles using jQuery UI tooltips
Go MAEDA wrote:
> Marius BALTEANU wrote:
> ...
I'll open a new issue to discuss this change (I should have done it from the beginning).
Marius BĂLTEANU
21:35 Patch #31640: Add clear query icon next to selected query in sidebar
Go MAEDA wrote:
> Marius BALTEANU wrote:
> ...
Indeed, close_hl.png is better.
Regarding the patch, you have attached a wrong one.
Marius BĂLTEANU
20:23 Patch #28138: Add link to add a new issue on the version page
Jean-Philippe Lang wrote in #5005#note-8:
> Actually, this patch is problematic. There are many cases where these links wouldn't work, eg. the target version field is read-only for the user (just like here on redmine.org), or not availa...
Marius BĂLTEANU
19:44 Feature #31921: Changes to properly support 4 byte characters (emoji) when database is MySQL
Go MAEDA wrote:
> I updated Marius's patch:
> ...
Thanks for updating my patch, I agree with your changes. Regarding the test, I'll create a new ticket assigned to Jean-Philippe to update the CI server. Until then, I propose to deliver...
Marius BĂLTEANU
19:16 Defect #32041 (Closed): Unable to reuse project name after delete
I created a test project (testgit) and an associated git repo (testgit.git). I then deleted the project and created a new project with a different name (testgit2) using the same repo. I then deleted the second project and added the fir... James Byrne
19:03 Feature #32040 (New): Create LDAP Type Custom Field
We use Redmine with our LDAP server. The on-the-fly user creation is a great feature.
I am wondering if we could also add an LDAP format custom field.
The problem we are encountering, is that in order for us to connect an issue with ...
Joshua Jobin
13:30 Feature #11963: Hide the estimated times on issues for certain roles
+1 Manuel Bernhardt
11:06 Patch #13468 (Closed): REST API for News
Committed the patches. Thank you for your contribution. And vzvu 3k6k, thank you for reviewing the patches. Your review is very helpful to me. Go MAEDA
07:15 Patch #13468: REST API for News
+1, Takaki's patches look good to me. vzvu 3k6k
11:03 Revision 18443 (svn): REST API for updating news (#13468).
Patch by Takenori TAKAKI. Go MAEDA
10:57 Revision 18442 (svn): REST API for deleting news (#13468).
Patch by Takenori TAKAKI. Go MAEDA
10:55 Revision 18441 (svn): REST API for retrieving news (#13468).
Patch by Takenori TAKAKI. Go MAEDA
10:52 Revision 18440 (svn): REST API for creating news (#13468).
Patch by Takenori TAKAKI. Go MAEDA
04:29 Patch #32037: Constrain sidebar width on different resolutions
I would like to add widths for 960px and 1152px as follows. What do you think? I usually use the web browser around 1024px to 1100px wide. The sidebar width set by attachment:responsive-multiresolution-sidebar.patch is wider than the cur... Go MAEDA
 

Also available in: Atom