Project

General

Profile

Activity

From 2019-09-19 to 2019-09-21

2019-09-21

22:52 Patch #32105 (New): Context menu to match the rest of the flyout styling
This patch:
- Sets fly-out context menu to have border radius of 3px (instead of formerly 2px)
- Removes some unnecessary styling rules from *ul* and *li* elements, instead moving them to their far inner *a* children elements instead w...
Anonymous
18:45 Patch #32100: Fixed and added roundiness to the "plus" (+) flyout menu and it's child elements
Marius BALTEANU wrote:
> but I don’t see a real benefit for making also the hover element rounded in the fly-out menu.
Hence why I also added the _fix-roundiness-on-plus-menu-without-menuchild-roundiness.patch_, in case menu child roun...
Anonymous
10:55 Patch #32100: Fixed and added roundiness to the "plus" (+) flyout menu and it's child elements
I like the rounded tabs for the main menu, but I don’t see a real benefit for making also the hover element rounded in the fly-out menu. That menu is more like a select/dropdown. Marius BĂLTEANU
01:44 Patch #32100: Fixed and added roundiness to the "plus" (+) flyout menu and it's child elements
Alternative, simpler patch which only adds roundness to the bottom of the fly-out menu and removes on-hover roundness from children elements inside it. Anonymous
17:16 Patch #31971: Change the color of the input field frame when in focus
I tried out the patch with Firefox. It made the appearance nicer but I round a problem. Input fields have rounded corners, but the corners of the outline are not rounded.
!{border: 1px solid #ccc;}.corners-not-rounded.png!
How ab...
Go MAEDA
10:38 Patch #31971: Change the color of the input field frame when in focus
kim kk wrote:
> Subjectの部分を一回目クリックした場合は、
> ...
Do you mean that the patch breaks the auto-complete feature? I could not reproduce the problem. The patch changes only the appearance of elements, so I think it does not affect auto-comple...
Go MAEDA
16:41 Feature #31879: "starts with" and "ends with" filter operators for string values
Marius BALTEANU wrote:
> Why not just @^@/@$@ which are used in regex syntax or Lucene syntax? Using CSS selector syntax for text searching is not common.
Nice idea. I have updated the patch.
Go MAEDA
11:06 Feature #31879: "starts with" and "ends with" filter operators for string values
Yuichi HARADA wrote:
> I added "starts with" and "ends with" filter operators. These filter operator symbols mimics the CSS selectors.
> ...
Why not just @^@/@$@ which are used in regex syntax or Lucene syntax? Using CSS selector synta...
Marius BĂLTEANU
15:06 Defect #32063: 'use strict' in inlineAutoComplete causes error on Poltergeist
Marius BALTEANU,
Thank you for explanation, and I agree your opinion.
I don't know other browser with the problem. I think this issue shall be rejected.
Tatsuya Saito
11:48 Defect #32063 (Needs feedback): 'use strict' in inlineAutoComplete causes error on Poltergeist
I don’t think we should write old JS syntax only to make the code compatible with PhantomJS which is no longer under active development. Also, Redmine is using Selenium with Chrome driver for system tests starting with version 4.
Reg...
Marius BĂLTEANU
13:10 Feature #27314: Remove the 'Administration' index page and jump right into settings
Go MAEDA wrote:
> I don't prefer the proposed change. The index is intuitive for users, and they don't always want to create a project.
I don't think that the index page is intuitive at all. It's an empty white page with only a few c...
Bernhard Rohloff
07:53 Feature #27314: Remove the 'Administration' index page and jump right into settings
I don't prefer the proposed change. The index is intuitive for users, and they don't always want to create a project. Go MAEDA
11:58 Feature #23954: Shows the date of the last activity on Projects administration
I think we should add this column on top of #29482. Marius BĂLTEANU
06:02 Feature #23954: Shows the date of the last activity on Projects administration
It worked on Redmine trunk with the same changes. note-11
Attach a screen copy of my environment.
Last activity is not displayed for projects with 0 tickets.
However, as it can be seen from the Created column, I think that it is en...
Yuuki NARA
09:52 Feature #32052 (Closed): Auto-complete issues #id in search form
Committed the patch. Thank you for your contribution. Go MAEDA
09:11 Defect #32104: Calendar layout doesn't fit with the width
!cal_overflow.png! Taine Woo
09:08 Defect #32104 (Closed): Calendar layout doesn't fit with the width
On Redmine4.0.3, If i set the display resolution as a smaller mode such as 1280*720, the layout of Calendar will overflow.
This issue pass on 4.0.2
Taine Woo
08:12 Feature #17907: Give 'version' another meaning
redmine_message_customize plugin has been created.
You can use this to override the term from the administration screen.
https://github.com/ishikawa999/redmine_message_customize
http://www.redmine.org/issues/29164#note-5
Yuuki NARA
07:23 Feature #3099: Last activity time window.
+1
Thanks for great patches
I don't want to repeat the blank history.
Note.
If the following patches have been applied, only two files need to be changed.
https://www.redmine.org/issues/23954#note-11
controllers/activities_...
Yuuki NARA

2019-09-20

21:14 Patch #32100 (New): Fixed and added roundiness to the "plus" (+) flyout menu and it's child elements
This patch is a follow up to #32013 and fixes the look of the "plus" fly-out menu.
!plus-menu1.PNG! !plus-menu2.PNG! !plus-menu3.PNG!
Anonymous
18:08 Patch #32099 (New): Fix inconsistent gap sizes on My page
Very small patch, but fixes gaps on my page to be the same.
!gapfixmypage.png!
Anonymous
03:31 Patch #32094 (Closed): Remove unnecessary call to set_tmp_attachments_directory
Committed the fix. Go MAEDA
02:58 Patch #32013 (Closed): Rounded corners of the main menu
Committed the patch. Thank you for the nice improvement. Go MAEDA

2019-09-19

18:08 Patch #31556: Update Rouge to 3.12.0
Updated Rouge to 3.11.0 in r18482. Go MAEDA
17:38 Feature #32090: REST API: users: add support for status=*
Hm, there is one other issue I've stumbled over - @users.json?name=foobar&status=@ won't return the status of the matched users. I either have to query the statuses separately (@users.json?name=foobar&status=1@ and so on) so I know that ... Martin von Wittich
14:11 Feature #32090 (Resolved): REST API: users: add support for status=*
Go MAEDA wrote:
> You can get users with any status by adding 'status=' parameter.
That does exactly what I wanted, thanks! I've updated the wiki accordingly.
Martin von Wittich
03:46 Feature #32090: REST API: users: add support for status=*
You can get users with any status by adding 'status=' parameter. Go MAEDA
17:37 Patch #32013: Rounded corners of the main menu
LGTM. Setting the target version to 4.1.0.
Bernhard Rohloff wrote:
> It fits nicely into the design of the other tab menus.
Indeed. Tabs in the project settings page and the administration page already have rounded corner. Tabs in...
Go MAEDA
17:05 Patch #32094 (Closed): Remove unnecessary call to set_tmp_attachments_directory
In test/integration/api_test/attachments_test.rb and test/functional/attachments_controller_test.rb, calling the method @set_tmp_attachments_directory@ at the tail of a method is unnecessary because the method is called in the @teardown@... Go MAEDA
13:05 Feature #13767: Export permissions report to CSV
+1 on this feature request Tina M.
12:14 Feature #16098: On relation change/add notification setting
Just change the one line below and email will not be sent when setting the relation.
This is just a workaround.
Of course, it is best to select a check box for email notification. #note-18
I confirmed the operation with Redmine...
Yuuki NARA
02:28 Feature #16098: On relation change/add notification setting
I think it can be resolved if "Relation updated" checkbox is added to "Administration" > "Settings" > "Email notifications" tab. IMHO, the checkbox should have been added when #1005 was implemented in Redmine 2.4.0.
!{width: 408px; bo...
Go MAEDA
00:24 Feature #16098: On relation change/add notification setting
+1
Yuuki NARA
11:39 Defect #31946 (Closed): No log message when MailHandler ignored a reply to a nonexistent issue, journal, or message
Committed the patch. Go MAEDA
11:26 Feature #28492: Option not to block closing a parent issue when it has open subtask(s)
Toshi MARUYAMA, thank you for your contribution to writing the patch.
I agree with Go MAEDA to change the setting name to "Allow closing parent issue whose subtasks are open".
Hinako Tajima
04:04 Feature #31879: "starts with" and "ends with" filter operators for string values
I added "starts with" and "ends with" filter operators. These filter operator symbols mimics the CSS selectors.
https://developer.mozilla.org/en-US/docs/Web/CSS/Attribute_selectors#Syntax
* starts with : ^=
* ends with : $=
I attac...
Yuichi HARADA
03:35 Defect #32088 (Closed): Redmine crashes in attempt to install Redmine Mylyn Connector
Please contact the author of the plugin. Perhaps the plugin does not support the latest version of Redmine. Go MAEDA
 

Also available in: Atom