Project

General

Profile

Activity

From 2019-10-19 to 2019-10-21

2019-10-21

23:07 Feature #31505: Mark edited journal notes as "Edited"
Updated to apply cleanly on the current trunk. Marius BĂLTEANU
23:05 Feature #29482: Query system for Projects page
Bernhard Rohloff wrote:
> There is a small flaw in the query save form. The labels on the @Display results@ section ...
Marius BĂLTEANU
18:31 Feature #29482 (Reopened): Query system for Projects page
There is a small flaw in the query save form. The labels on the @Display results@ section are overlapping each other.... Bernhard Rohloff
09:33 Feature #29482: Query system for Projects page
Go MAEDA wrote:
> Marius BALTEANU wrote:
> > Please commit the below change in order to prevent a random test failu...
Marius BĂLTEANU
09:21 Feature #29482 (Closed): Query system for Projects page
Marius BALTEANU wrote:
> Please commit the below change in order to prevent a random test failure:
Committed in r...
Go MAEDA
09:11 Feature #29482 (Reopened): Query system for Projects page
Please commit the below change in order to prevent a random test failure:... Marius BĂLTEANU
22:12 Defect #32315: Impossible to validate API key without modifying anything
Try, for example: ... Nathan Cutler
22:09 Defect #32315 (Closed): Impossible to validate API key without modifying anything
AFAICT the Redmine API has no way of validating whether a given API key is valid, short of actually attempting a writ... Nathan Cutler
22:10 Feature #5977: "check status" feature to verify validity of Redmine installation and API access key
Related ticket: #32315 Nathan Cutler
22:07 Feature #5977: "check status" feature to verify validity of Redmine installation and API access key
AFAICT the Redmine API has no way of validating whether a given API key is valid, short of actually attempting a writ... Nathan Cutler
20:26 Feature #27988: Option to configure which trackers can be set as subtasks for each tracker
Hi Marius,
Thank you for the great patch! But I encounter a bug. I have the following setup: Tracker "Parent" has ...
Dong Phan
19:15 Defect #32314 (Closed): Notification for "Only for things I watch or I'm involed in" not works
I have updated my redmine installation from 3.4.2 release to last 4.0.5. After this update, I no longer receive e-mai... pasquale [:dedalus]
17:26 Feature #24766: Custom fields grouping
+1
Vassilis Chryssos
15:47 Feature #32311: Filter Issues by multiple issue_id doesn't support space character or semicolon/dash as the separator
/\A[+-]?\d+(\D[+-]?\d+)*\z/
digit separated by one non-digit
/\A[+-]?\d+(\D*\d+)*\z/
digit separated by any no...
Taine Woo
15:25 Feature #32311: Filter Issues by multiple issue_id doesn't support space character or semicolon/dash as the separator
app/models/query.rb
line 417, replace the "," as "\D" can use any non-numeric characters as separator.
Taine Woo
09:35 Feature #32311: Filter Issues by multiple issue_id doesn't support space character or semicolon/dash as the separator
If the value of the issue_id is "1,2,3" in the filter, the query executes successfully.
If the value of the issue_id...
Taine Woo
09:20 Feature #32311 (New): Filter Issues by multiple issue_id doesn't support space character or semicolon/dash as the separator
Issues -> Filter -> Issue
statement "is", input the filter value as multiple ids, such as "1,2,3".
It only suppor...
Taine Woo
13:57 Defect #25130: support of agglutinative languages like Hungarian/Magyar
Will you ever accept my patches, please?
Greg T wrote:
> When _x_hours_ and _x_days_ are *not* used for a referen...
Greg T
13:32 Patch #32308: Rubocop: Performance/RedundantBlockCall: Use yield instead of block.call.
there are a few other cases Pavel Rosický
08:40 Patch #32308: Rubocop: Performance/RedundantBlockCall: Use yield instead of block.call.
All tests pass: https://gitlab.com/redmine-org/redmine/pipelines/90121225 Marius BĂLTEANU
01:32 Patch #32308: Rubocop: Performance/RedundantBlockCall: Use yield instead of block.call.
Caused by r18777. Go MAEDA
09:53 Feature #32312 (New): Disable auto selecting in top right Project filter
Add configuration point to be able to disable autoswitching project while viewing issue Yury Vashinko
09:20 Revision 18787 (svn): Fix random test failure of ProjectQueryTest (#29482).
Patch by Marius BALTEANU. Go MAEDA
08:24 Defect #32309 (Needs feedback): settings error in 4.0.5.devel.18786
@libs/js/iframe.js@ is not part of Redmine core. Marius BĂLTEANU
06:19 Defect #32309: settings error in 4.0.5.devel.18786
I was not able to reproduce the problem with Redmine 4.0.5.devel.18786.
Could you describe details of how to repro...
Go MAEDA
05:52 Defect #32309 (Closed): settings error in 4.0.5.devel.18786
Hello,
Just get the lastest version from subversion and the settings page is broken....
ChunChang (Nagaharu) Lo
03:19 Feature #32302: Filter projects after bookmarks
The patch works fine and passed all tests.
Marius BALTEANU wrote:
> Here is the patch, I think we can commit it a...
Go MAEDA
02:58 Patch #32297: Remove code for unsupported versions of Rails from open_id_authentication
Setting the target version to 4.1.0. Go MAEDA

2019-10-20

17:25 Patch #32308 (Closed): Rubocop: Performance/RedundantBlockCall: Use yield instead of block.call.
... Marius BĂLTEANU
17:04 Feature #32302: Filter projects after bookmarks
Here is the patch, I think we can commit it as part of #29482 and #31355. Marius BĂLTEANU
01:13 Feature #32302: Filter projects after bookmarks
Since we already have "<< my projects >>" in Project filter, the filter seems the right place to add "<< my bookmarks... Go MAEDA
15:14 Defect #32307 (Closed): AttachmentsControllerTest#test_thumbnail_for_pdf_should_be_png fails if ImageMagick convert is not available
To reproduce it, set invalid value to imagemagick_convert_command in configuration.yml and run attachments_controller... Go MAEDA
14:26 Feature #32306 (Closed): Add a link to projects administration page on projects page
This patch adds a link to the projects administration page (/admin/projects) on the projects page in order to improve... Go MAEDA
14:23 Defect #32223: Disable sprockets to avoid Sprockets::Railtie::ManifestNeededError raised by sprockets 4.0.0
Mischa The Evil wrote:
> Pavel Rosický wrote:
> > [...]
>
> How do you generate these numbers? On what system? C...
Pavel Rosický
11:16 Defect #32223: Disable sprockets to avoid Sprockets::Railtie::ManifestNeededError raised by sprockets 4.0.0
Mischa The Evil wrote:
> Go MAEDA wrote:
> > Mischa The Evil wrote:
> > > # Are you sure everything needed by the ...
Go MAEDA
09:56 Defect #32223: Disable sprockets to avoid Sprockets::Railtie::ManifestNeededError raised by sprockets 4.0.0
Pavel Rosický wrote:
> [...]
How do you generate these numbers? On what system? Can you remove @active_storage@ a...
Mischa The Evil
09:21 Defect #32223: Disable sprockets to avoid Sprockets::Railtie::ManifestNeededError raised by sprockets 4.0.0
Go MAEDA your patch improves startup time and memory consumtion.... Pavel Rosický
07:09 Defect #32223: Disable sprockets to avoid Sprockets::Railtie::ManifestNeededError raised by sprockets 4.0.0
Go MAEDA wrote:
> Mischa The Evil wrote:
> > # Are you sure everything needed by the core is indeed loaded with thi...
Mischa The Evil
11:10 Feature #973: Assign different status sets and workflows for separate projects
+1 Luis Blasco
10:52 Patch #32303 (Closed): Japanese translation update (r18784)
Committed the patch. Go MAEDA
02:25 Patch #32303 (Closed): Japanese translation update (r18784)
Translated strings added by #29482.... Go MAEDA
10:52 Revision 18786 (svn): Japanese translation update (#32303).
Patch by Go MAEDA. Go MAEDA
07:29 Defect #32305 (New): Use of notextile tag disables Redmine revision links
As observed [yet] only on redmine.org (see #29482#note-90 and #29482#note-91), comments (in this case issue notes) ha... Mischa The Evil
06:52 Defect #32293: Redmine does not start if optional openid gems are not installed
I don't think that this low priority issue alone justifies dropping OpenID support in Redmine altogether. I think tha... Mischa The Evil
06:35 Feature #29482 (Closed): Query system for Projects page
Mischa The Evil wrote:
> <notextile>@</notextile>Go MAEDA: Can you also remove the remaining @label_show_closed_proj...
Go MAEDA
06:21 Feature #29482 (Reopened): Query system for Projects page
<notextile>@</notextile>Go MAEDA: Can you also remove the remaining @label_show_closed_projects@ strings from the oth... Mischa The Evil
06:32 Revision 18785 (svn): Remove label_show_closed_projects from all translation files (#29482).
The string has been removed from en.yml in r18761. Go MAEDA
01:32 Revision 18784 (svn): Update locales (#29482).
Go MAEDA

2019-10-19

22:43 Feature #32302 (Closed): Filter projects after bookmarks
I think it will be useful to allow users to filter the projects (#29482) after bookmarks (#31355) and I see two optio... Marius BĂLTEANU
18:27 Feature #24841 (Closed): Hide projects user is only admin but not has assigned any role in the project overview (as it is already done in the project dropdown)
You can filter now the projects list after "my projects":
!{width:60%;border:1px solid grey;}my_projects.png!
Marius BĂLTEANU
15:34 Revision 18783 (svn): code cleanup: rubocop: fix Style/WhileUntilModifier in app/models/attachment.rb
Toshi MARUYAMA
15:34 Revision 18782 (svn): code cleanup: rubocop: fix Lint/IneffectiveAccessModifier in app/models/mail_handler.rb
Toshi MARUYAMA
15:33 Revision 18781 (svn): code cleanup: rubocop: fix Lint/IneffectiveAccessModifier in app/models/attachment.rb
Toshi MARUYAMA
15:33 Revision 18780 (svn): code cleanup: rubocop: fix Lint/IneffectiveAccessModifier in app/models/issue.rb
Toshi MARUYAMA
15:33 Revision 18779 (svn): code cleanup: rubocop: fix Lint/IneffectiveAccessModifier in app/models/user.rb
Toshi MARUYAMA
15:33 Revision 18778 (svn): code cleanup: rubocop: fix Lint/IneffectiveAccessModifier in app/models/mailer.rb
Toshi MARUYAMA
15:33 Revision 18777 (svn): code cleanup: rubocop: fix Lint/IneffectiveAccessModifier in lib/redmine/scm/adapters/abstract_adapter.rb
Toshi MARUYAMA
15:32 Revision 18776 (svn): code cleanup: rubocop: fix Lint/IneffectiveAccessModifier in lib/redmine/helpers/gantt.rb
Toshi MARUYAMA
15:32 Revision 18775 (svn): rubocop: enable Lint/IneffectiveAccessModifier
Toshi MARUYAMA
15:32 Revision 18774 (svn): code cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/controllers/context_menus_controller.rb
Toshi MARUYAMA
14:25 Revision 18773 (svn): code cleanup: rubocop: fix Layout/CommentIndentation in lib/redmine/wiki_formatting/textile/redcloth3.rb
Toshi MARUYAMA
14:25 Revision 18772 (svn): code cleanup: rubocop: fix Layout/CommentIndentation in app/models/mailer.rb
Toshi MARUYAMA
14:25 Revision 18771 (svn): code cleanup: rubocop: fix Layout/SpaceBeforeComma in test/unit/lib/redmine/helpers/calendar_test.rb
Toshi MARUYAMA
14:25 Revision 18770 (svn): code layout clean up test/unit/time_entry_test.rb
Toshi MARUYAMA
14:24 Revision 18769 (svn): code cleanup: rubocop: fix Layout/SpaceBeforeComma in lib/redmine/utils.rb
Toshi MARUYAMA
14:18 Feature #29482 (Closed): Query system for Projects page
Patches committed, thanks! Jean-Philippe Lang
14:18 Revision 18768 (svn): Test failure (#29482).
Jean-Philippe Lang
14:14 Revision 18767 (svn): Use radio buttons to choose display type (#29482).
Jean-Philippe Lang
13:53 Feature #29663: Select a JavaScript library to handle tags
Jean-Philippe, can you help us with a feedback on this? I would like to finish my work on the tags solution for 4.2.0. Marius BĂLTEANU
13:43 Revision 18766 (svn): Set default columns for the projects list (#29482).
Patch by Marius BALTEANU. Jean-Philippe Lang
13:42 Revision 18765 (svn): Option to switch between table list and board list (#29482).
Patch by Marius BALTEANU. Jean-Philippe Lang
13:39 Revision 18764 (svn): Filter after project custom fields (#29482).
Patch by Marius BALTEANU. Jean-Philippe Lang
13:38 Revision 18763 (svn): Filter after parent project (#29482).
Patch by Marius BALTEANU. Jean-Philippe Lang
13:37 Revision 18762 (svn): Filter after projects (#29482).
Patch by Marius BALTEANU. Jean-Philippe Lang
13:36 Revision 18761 (svn): Filters for Projects page (#29482).
Patch by Marius BALTEANU. Jean-Philippe Lang
13:16 Revision 18760 (svn): code cleanup: rubocop: fix Style/WhileUntilModifier in lib/redmine/utils.rb
Toshi MARUYAMA
13:15 Revision 18759 (svn): code cleanup: rubocop: fix Style/WhileUntilModifier in lib/redmine/unified_diff.rb
Toshi MARUYAMA
13:15 Revision 18758 (svn): code cleanup: rubocop: fix Style/WhileUntilModifier in app/models/project.rb
Toshi MARUYAMA
13:15 Revision 18757 (svn): fix stderr_log_file and strip_credential of Redmine::Scm::Adapters::AbstractAdapter are not private
Toshi MARUYAMA
13:01 Patch #32296: Ignore rubocop offense
Sorry, BUNDLE_DISABLE_EXEC_LOAD was not related with this behavior.
Please execute rubocop command with "--cache f...
Masahiro IUCHI
11:04 Patch #32296: Ignore rubocop offense
Thank you for the feedback. But I still cannot see the warning.... Go MAEDA
10:00 Patch #32296: Ignore rubocop offense
Reproduced it with BUNDLE_DISABLE_EXEC_LOAD=1 when using bundler.... Masahiro IUCHI
05:53 Patch #32296: Ignore rubocop offense
I run RuboCop against r18732 but was not able to reproduce the warning.... Go MAEDA
12:23 Patch #28138 (Closed): Add link to add a new issue on the version page
Committed, thanks. Jean-Philippe Lang
12:23 Revision 18756 (svn): Return to version page after the issue is created (#28138).
Patch by Marius BALTEANU. Jean-Philippe Lang
12:22 Revision 18755 (svn): Display new issue link in version page (#28138).
Patch by Marius BALTEANU. Jean-Philippe Lang
12:13 Patch #25265 (Closed): QueriesController can not handle subclass of IssueQuery
Jean-Philippe Lang
12:13 Revision 18754 (svn): Fixed that QueriesController can not handle subclass of IssueQuery (#25265).
Jean-Philippe Lang
11:41 Redmine 4.0.5 and 3.4.12 released
These 2 maintenance releases are available for [[download]], you can review the changes in the [[Changelog]].
*Sec...
Jean-Philippe Lang
11:31 Revision 18753 (svn): tagged version 4.0.5
Jean-Philippe Lang
11:31 Revision 18752 (svn): tagged version 3.4.12
Jean-Philippe Lang
11:30 Revision 18751 (svn): Updates for 3.4.12 release.
Jean-Philippe Lang
11:29 Revision 18750 (svn): Merged r18749 to 4.0-stable.
Jean-Philippe Lang
11:29 Revision 18749 (svn): Updates for 4.0.5 release.
Jean-Philippe Lang
11:18 Patch #32294 (Closed): Update ruby-openid to 2.9.2
Committed, thanks. Jean-Philippe Lang
11:18 Revision 18748 (svn): Merged r18746 to 3.4-stable (#32294).
Jean-Philippe Lang
11:18 Revision 18747 (svn): Merged r18746 to 4.0-stable (#32294).
Jean-Philippe Lang
11:17 Revision 18746 (svn): Update ruby-openid to 2.9.2 (#32294).
Patch by Go MAEDA. Jean-Philippe Lang
10:37 Defect #31779 (Closed): Total estimated time column shown even when estimated time field is deactivated
Committed, thanks. Jean-Philippe Lang
10:37 Revision 18745 (svn): Merged r18743 to 3.4-stable (#31779).
Jean-Philippe Lang
10:37 Revision 18744 (svn): Merged r18743 to 4.0-stable (#31779).
Jean-Philippe Lang
10:30 Revision 18743 (svn): Fixed that total estimated time column is shown even when estimated time field is deactivated (#31779).
Patch by Felix Schäfer and Yuichi HARADA. Jean-Philippe Lang
10:27 Defect #32300 (Closed): Don't use sprockets 4.0.0 in order to avoid Sprockets::Railtie::ManifestNeededError
sprockets 3.7.2 pinned. Jean-Philippe Lang
10:25 Defect #32300 (Closed): Don't use sprockets 4.0.0 in order to avoid Sprockets::Railtie::ManifestNeededError
Jean-Philippe Lang
09:27 Revision 18742 (svn): code cleanup: rubocop: fix Layout/EmptyLines in lib/redmine/wiki_formatting/textile/redcloth3.rb
Toshi MARUYAMA
09:27 Revision 18741 (svn): code cleanup: rubocop: fix Layout/EmptyLines in test/unit/query_test.rb
Toshi MARUYAMA
09:27 Revision 18740 (svn): code cleanup: rubocop: fix Layout/EmptyLines in test/functional/project_enumerations_controller_test.rb
Toshi MARUYAMA
09:27 Revision 18739 (svn): code cleanup: rubocop: fix Layout/EmptyLines in test/functional/activities_controller_test.rb
Toshi MARUYAMA
09:26 Revision 18738 (svn): code cleanup: rubocop: fix Style/WhileUntilModifier in lib/redmine/wiki_formatting/textile/redcloth3.rb
Toshi MARUYAMA
09:26 Revision 18737 (svn): code cleanup: rubocop: fix Style/UnlessElse in lib/redmine/wiki_formatting/textile/redcloth3.rb
Toshi MARUYAMA
06:30 Revision 18736 (svn): code cleanup: rubocop: fix Layout/EmptyLines in app/models/issue.rb
Toshi MARUYAMA
06:30 Revision 18735 (svn): code cleanup: rubocop: fix Layout/EmptyLines in app/models/issue.rb
Toshi MARUYAMA
06:30 Revision 18734 (svn): code cleanup: rubocop: fix Style/MultilineTernaryOperator in lib/redmine/utils.rb
Toshi MARUYAMA
06:29 Revision 18733 (svn): code cleanup: rubocop: fix Style/WhileUntilModifier in app/helpers/queries_helper.rb
Toshi MARUYAMA
05:05 Defect #32223: Disable sprockets to avoid Sprockets::Railtie::ManifestNeededError raised by sprockets 4.0.0
Updated the patch. Just replaced double quotation marks with single quotation marks. Go MAEDA
 

Also available in: Atom