Project

General

Profile

Activity

From 2019-11-30 to 2019-12-02

2019-12-02

23:06 Feature #4939: List of tasks filtered as OR and not AND
Hi,
Can you put some screen captures to be able to see how it works and how it changes the native behavior ?
Jérôme BATAILLE
23:00 Feature #4939: List of tasks filtered as OR and not AND
Is anybody in contact with Jean-Philippe Lang so this has a change to get merged?
The filter options need to be much more poerfull...
Jochen Kuehner
10:53 Defect #32546 (Closed): Issue relations filter lacks "is not"
It seems the "is not" operator was omitted in the :relation definition of query operators.
The actual implementation seems to have it, though.
The attached patch adds the operator to the list (applied to Redmine 4.0.5).
Alexander Achenbach
10:39 Feature #5893: Filter issues by notes
As a follow-up to #5893#note-7, here's a revised patch of the notes query against Redmine 4.0.5.
It fixes logic problems in operator handling that were in the original patch.
Alexander Achenbach
10:08 Feature #32545 (New): Plugin API for adding a new notification
In lib/redmine/notifiable.rb, there is a TODO: Plugin API for adding a new notification?.
I found out that, one can provide this API via Redmine Hooks, although I dont know if this is the correct approach.
The patch below seems to be ...
Hong Cheu Lim
09:54 Defect #32536 (Closed): Certain issue description leads to HTTP 504
Thank you for the feedback. Closing. Go MAEDA
09:44 Defect #32536 (Resolved): Certain issue description leads to HTTP 504
You are right.
Something seems wrong with the reverse proxy.
Sorry for the fuss, please close the issue.
Vasili Korol
09:30 Feature #32543: Ability to choose home page after login
Ref.: message#2902. Mischa The Evil
08:42 Feature #32543 (New): Ability to choose home page after login
Some users don't want to use default page after login.
They want users to be redirected to "my page", or some other page like news or wiki of some project.
Preferably there should be ability to choose default redirect page in admin ...
Aleksandar Pavic
09:08 Patch #32542: Fix ruby 2.7 warning: The last argument is used as the keyword parameter
I updated the patch.
Change @**options.merge(other: opt)@ to @**options, other: opt@.
Seiei Miyagi
08:56 Patch #32542: Fix ruby 2.7 warning: The last argument is used as the keyword parameter
Just my two cents on this: given all the reverts in the 2.7 pre-releases, I'd suggest to wait with the commit of this patch until a 2.7 final release. Mischa The Evil
08:25 Patch #32542 (Closed): Fix ruby 2.7 warning: The last argument is used as the keyword parameter
I run rake test on ruby 2.7, there are several warnings about keyword argument.
I fix it by adding `**`.
Seiei Miyagi
08:51 Defect #32544 (Closed): Merge commits adding test fixtures for 4.1 features to 4.1-stable branch.
The following commits fixes tests, which are missing fixtures, for features that are (going to be) introduced in Redmine version#127:
* r19327 for #32540 (for #31954 & #23997 with r18402)
* r19071 for #32444 (for #29489 with r18297)
*...
Mischa The Evil
05:48 Feature #31500: Ruby 2.7 support
With ruby 2.7, following tests failed. Seiei Miyagi
03:36 Patch #32540 (Closed): Add missing fixtures to VersionTest
Committed the fix. Thank you for your contribution. Go MAEDA
01:36 Patch #32540 (Closed): Add missing fixtures to VersionTest
VersionTest has failed. Yuichi HARADA
02:42 Feature #31355 (Closed): Bookmarks and recently used projects for the project jump box
Go MAEDA wrote:
> An issue caused by this feature is reported as #32503.
Fixed in r19325. The issue was that bookmarked and recently used projects are unexpectedly filtered by a search keyword after full-text search.
Go MAEDA
02:39 Defect #32503 (Closed): Project jump box options are not extracted correctly after searching
Committed the patch in #32503#note-2 as a part of #31355. Thank you for catching and fixing it before the release of 4.1.0. Go MAEDA

2019-12-01

11:27 Defect #32529: The end of the URL is replaced with "undefined" in IE11 and Edge
Go MAEDA wrote:
> Marius, could you review this fix?
Yea, I’ll do it as soon I can.
Marius BĂLTEANU
08:59 Feature #32538 (Closed): Tags with DMS
Please don't use this tracker for (questions about) third-party add-ons. I suggest you take a look at the extensive DMSF-manual that can be found via https://github.com/danmunn/redmine_dmsf#additional-documentation. Mischa The Evil
08:56 Feature #32030: Show Gravatar icons in the Members tab in the project setting
I understand the rationale behind this change, but I think it is slightly problematic as the group icon is indicative for the differentiation of groups from users on the project members list tab. With the change proposed in this issue it... Mischa The Evil
05:28 Feature #32030: Show Gravatar icons in the Members tab in the project setting
I have updated the patch. It fixes Performance/RedundantMerge RuboCop warning. Go MAEDA

2019-11-30

06:41 Patch #32527 (Closed): Fix ruby 2.7 warning: given argument is nil; this will raise a TypeError in the next release
Committed the patch in #32527#note-7 as a part of #31500.
Thank you for reporting this issue.
Go MAEDA
03:47 Patch #32527: Fix ruby 2.7 warning: given argument is nil; this will raise a TypeError in the next release
Go MAEDA wrote:
> Seiei Miyagi wrote:
> ...
Looks great!
My code is calling request.env[] twice, thus your code is better.
Seiei Miyagi
02:52 Patch #32527: Fix ruby 2.7 warning: given argument is nil; this will raise a TypeError in the next release
Seiei Miyagi wrote:
> Updated the patch.
What do you think about the following code? It is simpler and very slightly efficient.
Go MAEDA
02:42 Feature #32538 (Closed): Tags with DMS
We are using DMS 2.0.0 which should have the tagging feature for the documents as per https://github.com/danmunn/redmine_dmsf
I can't find a way to configure it via Admin settings.
Is there a way to enable tags for documents in DMS?
Prateek Gera
02:06 Defect #32194 (Closed): Calendar page lacks buttons to manage custom queries
Committed the patch. Thank you for your contribution. Go MAEDA
00:12 Defect #32537: Rake taks works on redmine 3.4 but does not work on 4 while for Redmine 4 it works in console
Eventually I was able to make the following code work with Redmine 4 Aleksandar Pavic
 

Also available in: Atom