Activity
From 2019-12-06 to 2019-12-08
2019-12-08
-
23:48 Feature #32424: CommonMark Markdown Text Formatting
- h2. Textile to Markdown migration
Pandoc is actually bad at this job. We tried Jens'es "redmine_convert_textile_to_markdown":https://github.com/planio-gmbh/redmine_convert_textile_to_markown (thanks for that!), we ran rendering compar... -
23:48 Feature #32424: CommonMark Markdown Text Formatting
- h2. HTML sanitizing
HTML sanitizing is currently embedded in the commonmark formatter in the patch. That's a good start.
As #807 suggests, sanitizing should rather be a shared concept, eventually with small differences for differen... -
23:47 Feature #32424: CommonMark Markdown Text Formatting
- h2. commonmarker configuration
"These are the options used by GitLab":https://gitlab.com/gitlab-org/gitlab-foss/blob/master/lib/banzai/filter/markdown_engines/common_mark.rb#L12. The options in the patch are the same (thumbs up!).
... -
23:46 Feature #32424: CommonMark Markdown Text Formatting
- h2. Temporary workaround before the patch is merged
At the moment, it is possible to use "redmine_common_mark":https://github.com/clear-code/redmine_common_mark plugin. It also allows for configuring commonmarker, but it has no HTML s... -
23:43 Feature #32424: CommonMark Markdown Text Formatting
- Love you guys! We are playing with markup format conversions and preparing bulletproof arguments to integrate commonmarker + HTML sanitization for almost half a year. :) Jens did this job perfectly and the only unused argument regarding...
-
17:29 Patch #32555: Update Puma (~> 4.3.1)
- Redmine gem version policy is not defined except Ruby version incompatibility.
And puma is test group, so I think version is not needed.
-
14:48 Defect #22323: Markdown newline rendering broken
- > Target version set to Candidate for next major release
Now, when there is #32424, I'd vote for keeping the markdown format as is and deprecate it. This would be actually a cleaner solution for users who rely on its current behavior,... -
14:20 Defect #32563 (Closed): Redmine 4 crashing with SEGFAULT under stress test when Markdown is used
- Disclosure: my real motivation is to provide even more ammunition for #32424. But this issue is still valid and represents also a DOS and possibly other security vulnerability.
The Redcarpet-based wiki formatter is shared in Redmine, ... -
07:48 Defect #30164 (Confirmed): Missing images in a wiki page are not visualized
-
07:34 Defect #31550: Project "Version" view's "Wiki page" field is still shown, although "Wiki" module is disabled on the project
- The patch only disables "Wiki page" field in version forms, but I think showing wiki content in the roadmap and version page also should be disabled.
Currently, even if Wiki module is switched to disabled after setting the version's w... -
07:16 Defect #31587 (Needs feedback): Time Entries REST API user_id parameter doesn't work
- I cannot reproduce the issue with Redmine 4.0.5.devel.19345. The following request returns time entries of user_id 2.
-
06:58 Defect #31595 (Closed): Error allowing assigning a task to a user when his role does not allow it
- This issue is identical to #31466. Please don't open an issue with the same content with another issue.
-
06:43 Defect #31624 (Needs feedback): Query clear button does not clear sort options if using a custom query
- I cannot reproduce. Could you describe detailed steps to reproduce the issue?
The steps I tried were:
# Sort issues by status
# Save as a query named "Sort by status"
# Apply "Sort by status" query
# Click "Clear"
The issues ... -
06:11 Feature #29935: Edit authored issues and Edit assigned issues in issue tracking permission
- "Edit own issue" permission was implemented for upcoming Redmine 4.1.0 (#1248).
-
05:39 Defect #30052 (Closed): GET Project List with Rest API XML call
- Maybe the number of visible projects for the account is 5. You can get all projects if your account has admin priviledge.
-
05:20 Feature #31340 (Closed): Allow restrict auto create accounts for sender domains by list
- Thank you for suggesting a new feature but I am closing this issue as a duplicate of #14341.
-
02:54 Defect #32422 (Resolved): Textile indentation does not work in the preview tab
- Committed the patch. Thank you for catching and fixing the issue.
-
01:43 Feature #32526 (Resolved): Update Rails to 5.2.4.1
- Committed.
-
01:10 Defect #32525 (Closed): CSV related tests fail with Rails 5.2.4
- Committed as a part of #32526.
2019-12-07
-
16:33 Feature #3058: Show issue history using tabs
- Go MAEDA wrote:
> A cross-Browser compatibility issue caused by the changes has been reported as #32529.
I've posted a fix which is good enough for now, but I'm still looking for a better solution for the future. The problem is cause... -
16:19 Defect #32529: The end of the URL is replaced with "undefined" in IE11 and Edge
- Sorry for my late reply, please apply the below fix for now:
-
11:30 Patch #32435: Change Russian translation for "Submit"
- Okay, i see your point.
But I don't have a strong opinion here. Personally, I don't find the current translation confusing. -
05:49 Patch #32238: Improvement of the German translation
- How is the current status of the patch? Could someone provide a final patch?
-
05:44 Defect #32422 (Confirmed): Textile indentation does not work in the preview tab
- Confirmed that the issue is reproduceble and the patch in #32422#note-1 fixes it.
Setting the target version to 4.0.6. -
05:30 Feature #32424: CommonMark Markdown Text Formatting
- I agree that Redcarpet is not active anymore. The number of commits made in this year is only 3. And I think many Markdown users expect Redmine to behave as CommonMark/GFM compliant because many apps/services that support it.
Let's st... -
02:59 Defect #32430 (Closed): Can't delete project in Redmine 4.0.3
- Closing this issue because it seems to be caused by a third-party plugin.
2019-12-06
-
18:46 Defect #32562 (Closed): Issue Private Journals deleted when accessed from api
- Jérôme BATAILLE wrote:
> The problem does not come from a Redmine Core issue.
> ...
Thanks. -
18:30 Defect #32562 (Resolved): Issue Private Journals deleted when accessed from api
- The problem does not come from a Redmine Core issue.
This issue can be closed ! -
17:32 Defect #32562 (Closed): Issue Private Journals deleted when accessed from api
- * An example request to trigger the issue : @/issues.json?assigned_to_id=me&include[]=journals@
The journals are deleted because a select! is done on model objects retrieved from a relation with the issues table.
A fix for *app/mod... -
16:23 Feature #32561 (New): feature: add support to add multiple instance for a single filter
- If i want to filter issues with filter of a multiple value allowed field, named "OS", it contains some of predefined values such as OS1, OS2, OS3...
If i want to filter issues has value OS1 AND OS2, with the feature, I can:
first add... -
16:21 Defect #32479: Issue filter: operator not support "is + AND"
- this is very important and useful for issues with fields multiple value allowed.
please help consider this implementation. -
14:36 Feature #32399: Drop support for migrating from Trac or Mantins
- I have a whole series of patches to make trac import work with latest redmine if anybody is interested....
-
06:14 Defect #32556 (Closed): Cannot create project version
-
04:07 Defect #32558 (New): Distinct can be removed
- In apps/redmine/app/models/project.rb, there is `User.active.joins(:members).where("#{Member.table_name}.project_id = ?", id).distinct`. which will be translated to `SELECT DISTINCT users.* FROM users INNER JOIN members ON members.user_...
-
01:28 Defect #32500 (Closed): Spent time report csv shows translation missing text if custom fields are involved
- Committed the fix. Thank you all for your contribution.
-
01:08 Defect #32477 (Confirmed): Right-aligned TOC tag is displayed in exported PDF if the text formatting setting is Markdown
-
00:39 Defect #30074: Puma shouldn't be included in the Gemfile
- The version of puma is not fixed after r19338.
-
00:35 Patch #32552 (Closed): Clarify that pasting images from clipboard does not support Internet Explorer
- Committed the patch as a part of #31169.