Project

General

Profile

Activity

From 2019-12-08 to 2019-12-10

2019-12-10

21:28 Patch #32599 (Closed): Galician translation update
Added 20 untranslated strings for current trunk. Guillermo ML
18:51 Patch #30739: Project Custom Fields configuration : split by tracker
I suppose we can close this issue as it was integrated in the following plugin :
http://www.redmine.org/plugins/redmine_smile_project_enumerations_custom_field_format
Jérôme BATAILLE
12:41 Patch #32596 (Closed): fix image pasting for Edge
The attached patch courtesy of "Planio":https://plan.io/hosted-redmine fixes image pasting for Edge (without breaking it for other browsers) by constructing a @Blob@ instead of a @File@ in the paste handler.
I also amended the detail...
Jens Krämer
10:54 Defect #17555: Mandatory condition for 'Category' & 'Assignee' is not working according to workflow defined
Yea, I'm having troubles with making assegnee field mandatory. And another user reported exactly the same problem here: https://www.redmine.org/boards/2/topics/54055 Peter Volkov
08:55 Feature #32526 (Closed): Update Rails to 5.2.4.1
Go MAEDA
08:52 Defect #32546: Issue relations filter lacks "is not"
Setting the target version to 4.2.0. Go MAEDA
08:38 Revision 19354 (svn): Merged r19345 from trunk to 4.0-stable (#32526).
Go MAEDA
08:33 Patch #32592 (Closed): Require 'mocha/minitest' instead of deprecated 'mocha/setup'
The following deprecation warning is shown when running tests if mocha 1.10.0 or later is installed.
> Mocha deprecation warning at /path/to/gems/ruby/2.3.0/gems/activesupport-5.2.3/lib/active_support/dependencies.rb:291:in `require':...
Go MAEDA
05:36 Revision 19353 (svn): Merged r19344 from trunk to 4.0-stable (#32526, #32525).
Go MAEDA
05:03 Revision 19352 (svn): Merged r19345 from trunk to 4.1-stable (#32526).
Go MAEDA
05:00 Revision 19351 (svn): Merged r19344 from trunk to 4.1-stable (#32526, #32525).
Go MAEDA
04:20 Patch #32523: Replace `for` loops with `forEach` in buildFilterRow function
I changed the @for@ statements of attachment:javascript-perf2.diff to @forEach@.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/forEach
I think @forEach@ is better because the loop counter vari...
Yuichi HARADA
03:18 Feature #32424: CommonMark Markdown Text Formatting
Hi, thanks for the feedback!
Nice catch about the rendering of Markdown files, that indeed should be switched to commonmark as well. Also great work on the Migrator :)
*General use of HTML Pipeline*
It would really make sense ...
Jens Krämer
02:36 Defect #32422 (Closed): Textile indentation does not work in the preview tab
Go MAEDA
02:35 Revision 19350 (svn): Merged r19346 from trunk to 4.0-stable (#32422).
Go MAEDA
02:34 Revision 19349 (svn): Merged r19346 from trunk to 4.1-stable (#32422).
Go MAEDA

2019-12-09

19:31 Defect #27319: Impossible to create a new version
Thank you, the alter cmd worked. Is there more db migrations steps missing? I'm worried about other tables missing fields/data... Luciano Fantuzzi
13:40 Feature #3058 (Closed): Show issue history using tabs
Jean-Philippe Lang
13:40 Defect #32529 (Closed): The end of the URL is replaced with "undefined" in IE11 and Edge
Committed, thanks. Jean-Philippe Lang
07:41 Defect #32529: The end of the URL is replaced with "undefined" in IE11 and Edge
Marius BALTEANU wrote:
> Sorry for my late reply, please apply the below fix for now:
> ...
Marius, I confirmed that "undefined" is not displayed using IE11 and Edge. Thank you for fixing the issue.
Yuichi HARADA
13:39 Revision 19348 (svn): Merged r19347 to 4.1-stable (#32529).
Jean-Philippe Lang
13:38 Revision 19347 (svn): Fixed that URL is replaced with "undefined" in IE11 and Edge (#32529).
Patch by Marius BALTEANU. Jean-Philippe Lang
11:55 Feature #32583 (New): Not able to generate ticket through mail using crontab
I have configure crontab for generating ticket through mail
Below is entry
* * * * * rake -f /var/www/redmine/Rakefile redmine:email:receive_imap RAILS_ENV="production" host=email.***.com username=connect@com password=*****
When...
Ninad Patil
08:42 Defect #32546: Issue relations filter lacks "is not"
Go MAEDA wrote:
> It is useful when it is used with the combination with other filters. [...]
Admittedly we have not had a need for this in years of using Redmine, but projects have become somewhat more complex, and now our use case ...
Alexander Achenbach
07:52 Defect #32546: Issue relations filter lacks "is not"
Here is a test for the patch. Go MAEDA
06:01 Defect #32546: Issue relations filter lacks "is not"
Go MAEDA wrote:
> I started to wonder whether the "is not" filter is practical.
> ...
Sorry, I have changed my mind. Please forget what I wrote in #32546#note-4.
Although I wrote "is not" filter is not so useful, it is wrong. It is ...
Go MAEDA
04:10 Defect #32546: Issue relations filter lacks "is not"
Go MAEDA wrote:
> The implementation for "is not" operator is at source:tags/4.0.5/app/models/issue_query.rb#L568. I think "!" operator was not included by mistake and this should be fixed.
I started to wonder whether the "is not" fi...
Go MAEDA

2019-12-08

23:48 Feature #32424: CommonMark Markdown Text Formatting
h2. Textile to Markdown migration
Pandoc is actually bad at this job. We tried Jens'es "redmine_convert_textile_to_markdown":https://github.com/planio-gmbh/redmine_convert_textile_to_markown (thanks for that!), we ran rendering compar...
Martin Cizek
23:48 Feature #32424: CommonMark Markdown Text Formatting
h2. HTML sanitizing
HTML sanitizing is currently embedded in the commonmark formatter in the patch. That's a good start.
As #807 suggests, sanitizing should rather be a shared concept, eventually with small differences for differen...
Martin Cizek
23:47 Feature #32424: CommonMark Markdown Text Formatting
h2. commonmarker configuration
"These are the options used by GitLab":https://gitlab.com/gitlab-org/gitlab-foss/blob/master/lib/banzai/filter/markdown_engines/common_mark.rb#L12. The options in the patch are the same (thumbs up!).
...
Martin Cizek
23:46 Feature #32424: CommonMark Markdown Text Formatting
h2. Temporary workaround before the patch is merged
At the moment, it is possible to use "redmine_common_mark":https://github.com/clear-code/redmine_common_mark plugin. It also allows for configuring commonmarker, but it has no HTML s...
Martin Cizek
23:43 Feature #32424: CommonMark Markdown Text Formatting
Love you guys! We are playing with markup format conversions and preparing bulletproof arguments to integrate commonmarker + HTML sanitization for almost half a year. :) Jens did this job perfectly and the only unused argument regarding... Martin Cizek
17:29 Patch #32555: Update Puma (~> 4.3.1)
Redmine gem version policy is not defined except Ruby version incompatibility.
And puma is test group, so I think version is not needed.
Toshi MARUYAMA
14:48 Defect #22323: Markdown newline rendering broken
> Target version set to Candidate for next major release
Now, when there is #32424, I'd vote for keeping the markdown format as is and deprecate it. This would be actually a cleaner solution for users who rely on its current behavior,...
Martin Cizek
14:20 Defect #32563 (Closed): Redmine 4 crashing with SEGFAULT under stress test when Markdown is used
Disclosure: my real motivation is to provide even more ammunition for #32424. But this issue is still valid and represents also a DOS and possibly other security vulnerability.
The Redcarpet-based wiki formatter is shared in Redmine, ...
Martin Cizek
07:48 Defect #30164 (Confirmed): Missing images in a wiki page are not visualized
Go MAEDA
07:34 Defect #31550: Project "Version" view's "Wiki page" field is still shown, although "Wiki" module is disabled on the project
The patch only disables "Wiki page" field in version forms, but I think showing wiki content in the roadmap and version page also should be disabled.
Currently, even if Wiki module is switched to disabled after setting the version's w...
Go MAEDA
07:16 Defect #31587 (Needs feedback): Time Entries REST API user_id parameter doesn't work
I cannot reproduce the issue with Redmine 4.0.5.devel.19345. The following request returns time entries of user_id 2. Go MAEDA
06:58 Defect #31595 (Closed): Error allowing assigning a task to a user when his role does not allow it
This issue is identical to #31466. Please don't open an issue with the same content with another issue. Go MAEDA
06:43 Defect #31624 (Needs feedback): Query clear button does not clear sort options if using a custom query
I cannot reproduce. Could you describe detailed steps to reproduce the issue?
The steps I tried were:
# Sort issues by status
# Save as a query named "Sort by status"
# Apply "Sort by status" query
# Click "Clear"
The issues ...
Go MAEDA
06:11 Feature #29935: Edit authored issues and Edit assigned issues in issue tracking permission
"Edit own issue" permission was implemented for upcoming Redmine 4.1.0 (#1248). Go MAEDA
05:39 Defect #30052 (Closed): GET Project List with Rest API XML call
Maybe the number of visible projects for the account is 5. You can get all projects if your account has admin priviledge. Go MAEDA
05:20 Feature #31340 (Closed): Allow restrict auto create accounts for sender domains by list
Thank you for suggesting a new feature but I am closing this issue as a duplicate of #14341. Go MAEDA
02:54 Defect #32422 (Resolved): Textile indentation does not work in the preview tab
Committed the patch. Thank you for catching and fixing the issue. Go MAEDA
02:53 Revision 19346 (svn): Textile indentation does not work in the preview tab (#32422).
Patch by Yuichi HARADA. Go MAEDA
01:43 Feature #32526 (Resolved): Update Rails to 5.2.4.1
Committed. Go MAEDA
01:42 Revision 19345 (svn): Update Rails to 5.2.4 (#32526).
Go MAEDA
01:10 Defect #32525 (Closed): CSV related tests fail with Rails 5.2.4
Committed as a part of #32526. Go MAEDA
01:10 Revision 19344 (svn): CSV related tests fail with Rails 5.2.4 (#32526, #32525).
Patch by Go MAEDA. Go MAEDA
 

Also available in: Atom