Project

General

Profile

Activity

From 2020-01-10 to 2020-01-12

2020-01-12

23:51 Defect #32774: Creating time tracking entry for other user through rest API fails with 403
@authorize_logging_time_for_other_users@ returns false because @@project@ is not set yet. Both methods @find_optional_issue@ and @find_optional_project@ from @TimelogController@ expects @:issue_id@ and @:project_id@ only as root params, ... Marius BĂLTEANU
23:08 Defect #32774 (Confirmed): Creating time tracking entry for other user through rest API fails with 403
Marius BĂLTEANU
21:08 Defect #32765: ##123 syntax for linking to issues: Title cannot be distinguished from following text
I agree that we should have different styles.
Attached two screenshots:
1. Subject as link (as Robert proposed)
!link.png!
2. Highlight the entire text using the style from inline code:
!highlight.png!
Marius BĂLTEANU
20:42 Defect #32770 (Needs feedback): Text formating on Redmine Home page does not work
Where did you input that text?
In Home page, I tried 2 scenarios:
1. Set as "Welcome text" and it works.
2. Set as News summary and it doesn't work.
!home.png!
It will be helpful to provide the steps to reproduce the problem.
Marius BĂLTEANU
20:36 Defect #32772 (Needs feedback): Tabs are displayed on two lines when the total width of the tabs is greater than 2000px
I cannot reproduce, tried on OS Catalina with Chrome (latest) and Windows with Chrome (latest), Edge 17 and 18. Attached some screenshots.
Can you try a hard reload in Chrome or incognito?
Marius BĂLTEANU
20:25 Feature #31589: Show warning and the reason when the issue cannot be closed because of open subtasks or blocking open issue(s)
Attached the updated patch based on my previous note, all "tests":https://gitlab.com/redmine-org/redmine/pipelines/108734385 pass. Marius BĂLTEANU
17:34 Feature #31589: Show warning and the reason when the issue cannot be closed because of open subtasks or blocking open issue(s)
Mischa, thank you for your deep analysis on this, it's really useful.
Mischa The Evil wrote:
> Marius BALTEANU wrote:
> ...
You're right, this issue should cover all three cases.
> Some additional notes:
> ...
I agree, what about...
Marius BĂLTEANU
20:06 Feature #32781 (Closed): [Mail Notifications] (feature back) allow mails to be sent to multiple recipients at once
nicolas felix wrote:
> Hi everybody,
> ...
Indeed, this is the context for everyone who migrated to Redmine 4.*, but the drawback is not such a huge problem comparing with the problems generated by the initial implementation.
> We d...
Marius BĂLTEANU
16:55 Defect #32771 (Closed): Editing issues does not send notifications to previous assignee
Daniel Petat wrote:
>
> ...
#2716 should cover this request by adding the assignees as watchers. In this way, user B will receive the notifications.
Marius BĂLTEANU
13:23 Defect #32754 (Reopened): Fix missing arrow icon of collapse macro
Go MAEDA
12:26 Defect #32754: Fix missing arrow icon of collapse macro
Go MAEDA wrote:
> Committed the patch. Thank you for detecting and fixing the issue.
I think it hasn’t been backported, yet.
Michael Gerz
10:17 Patch #32788: Specify supported Ruby version in Gemfile and doc/INSTALL
Jean-Philippe Lang wrote:
> A probably better option would be to set this as a dependency in the Gemfile: https://bundler.io/v1.12/gemfile_ruby.html
> ...
I’m in favor of this option.
Marius BĂLTEANU
10:02 Patch #32788: Specify supported Ruby version in Gemfile and doc/INSTALL
A probably better option would be to set this as a dependency in the Gemfile: https://bundler.io/v1.12/gemfile_ruby.html
That would ensure that a compatible ruby version is used.
What do you think?
Jean-Philippe Lang
06:29 Patch #32788 (Closed): Specify supported Ruby version in Gemfile and doc/INSTALL
Currently, source:tags/4.1.0/doc/INSTALL says that Redmine 4.1.0 supports Ruby 2.3 or later. However, Redmine 4.1.0 does not yet support Ruby 2.7 (#31500).
The document should list all supported Ruby versions to prevent users from usi...
Go MAEDA
08:18 Patch #32782 (Closed): Update pg gem (~> 1.2.2)
Committed the patch. Thank you for your contribution. Go MAEDA
08:17 Revision 19423 (svn): Update pg gem (~> 1.2.2) (#32782).
Patch by Pavel Rosický. Go MAEDA
08:04 Defect #32769 (Closed): Unable to sort projects table by custom field
Committed the fix. Thank you. Go MAEDA
08:04 Revision 19422 (svn): Merged r19421 from trunk to 4.1-stable (#32769).
Patch by Marius BALTEANU. Go MAEDA
08:03 Revision 19421 (svn): Fix sort projects table by custom field (#32769).
Patch by Marius BALTEANU. Go MAEDA
07:41 Defect #32768 (Closed): Internal Error when issue text custom field is shown in Spent time query results
Committed the fix. Thank you. Go MAEDA
07:39 Revision 19420 (svn): Merged r19419 from trunk to 4.1-stable (#32768).
Go MAEDA
07:37 Revision 19419 (svn): Fix Internal Error when issue text custom field is shown in Spent time query results (#32768).
Patch by Marius BALTEANU. Go MAEDA
07:17 Defect #32785 (Closed): X-Sendfile header field is not set if rack 2.1.0 is installed
Committed the fix. Go MAEDA
05:19 Defect #32785: X-Sendfile header field is not set if rack 2.1.0 is installed
Pavel Rosický wrote:
> @GO MAEDA take a look at https://github.com/rack/rack/pull/1463 for the potential fix
Thank you, I have read the page and confirmed that the following patch fixes this issue.
Go MAEDA
07:17 Revision 19418 (svn): Merged r19416 from trunk to 4.0-stable (#32785).
Go MAEDA
07:14 Revision 19417 (svn): Merged r19416 from trunk to 4.1-stable (#32785).
Go MAEDA
07:12 Revision 19416 (svn): X-Sendfile header field is not set if rack 2.1.0 is installed (#32785).
Go MAEDA
05:45 Patch #32787 (Closed): Redmine 4.0 no longer supports Ruby 2.2
After updating Rails to 5.2.4.1 (#32526), Redmine cannot be run with Ruby 2.2 because of the following change in Rails that uses @&.@ operator which has been introduced in Ruby 2.3.
https://github.com/rails/rails/commit/92ec9f270d696a17...
Go MAEDA

2020-01-11

18:53 Defect #32785: X-Sendfile header field is not set if rack 2.1.0 is installed
this is related to https://www.redmine.org/issues/24646
@GO MAEDA take a look at https://github.com/rack/rack/pull/1463 for the potential fix
Pavel Rosický
07:16 Defect #32785: X-Sendfile header field is not set if rack 2.1.0 is installed
Temporary fix for this issue: Go MAEDA
07:02 Defect #32785 (Closed): X-Sendfile header field is not set if rack 2.1.0 is installed
Go MAEDA
15:11 Patch #32747: Fix wrong translation for "time entries" in redmine 4.1.0
Go MAEDA wrote:
> Would you explain why the existing translations are wrong? Since I don't understand Italian, I can't determine if the changes are valid.
Hi Go MAEDA. The translation Is wrong because actual italian text sound like '...
pasquale [:dedalus]
08:45 Defect #32752: Ruby 2.7: Remove deprecated URI.escape/unescape
Here is a patch to remove URI.escape and URI.unescape.
The patch adds Addressable gem to Gemfile, but actually it does not mean that the patch adds a new gem dependency because Addressable gem is required by Roadie and is already in G...
Go MAEDA
05:06 Patch #32782: Update pg gem (~> 1.2.2)
Setting the target version to 4.2.0. Go MAEDA
03:00 Patch #26030: Like issues and news comments, want to specify the display order of the forum's reply.
Popoki Tom (@cat_in_136) wrote:
> Opps, Thank you for checking my patch. I've removed the duplicated @MessageTest@.
My patch has still a some degrade bug where @r=xx@ parameter may not be expanded correctly. This patch should not be ...
Popoki Tom (@cat_in_136)

2020-01-10

18:17 Defect #32768: Internal Error when issue text custom field is shown in Spent time query results
Here is the fix. Marius BĂLTEANU
16:42 Feature #32783 (Closed): Redirect to index page instead of edit page after creating a new custom field
Current behavior:
1. Click o Create new custom field from some tab like Users
2. Create custom field and click save
3. You are staying on the same form
Desired behavior
step 3: Go back to Users tab and display new field there ...
Aleksandar Pavic
15:55 Patch #32782 (Closed): Update pg gem (~> 1.2.2)
https://github.com/ged/ruby-pg/blob/master/History.rdoc Pavel Rosický
15:29 Feature #32781 (Closed): [Mail Notifications] (feature back) allow mails to be sent to multiple recipients at once
Hi everybody,
if I clearly understood, following #26791, mails are now sent *individually*.
I agree, this behavior enables to to get around some problems (as mentioned into the #26791 ticket).
But, in my context (after migrating f...
nicolas felix
14:18 Feature #1739: Add ability to change issue author
We are using this plugin with 4.1.0 without any issues.
https://github.com/rgtk/redmine_editauthor.git
Valdir Stiebe Junior
14:03 Feature #1739: Add ability to change issue author
+1
Any plugins confirmed working for redmine 4.X?
Stewart Ferguson
03:39 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading
Yes. I hope so.
Enziin System wrote:
> Rails 6?
> ...
Tigergm Wu
03:37 Defect #22281 (Closed): http://redmine.org results in a 403 Forbidden
Now "GET http://redmine.org" returns "302 Found" instead of "403 Forbidden". In addition, HTTP is redirected to HTTPS.
| http://redmine.org | 302 Found (Location: https://redmine.org/) |
| http://www.redmine.org | 302 Found (Location...
Go MAEDA
03:27 Defect #20556 (Closed): Redirect to HTTPS
The server now redirects HTTP traffic to HTTPS. Go MAEDA
03:22 Defect #30255 (Closed): This site can’t provide a secure connection www.redmine.org uses an unsupported protocol. ERR_SSL_VERSION_OR_CIPHER_MISMATCH
www.redmine.org now supports TLS 1.2. Go MAEDA
03:19 Defect #32776 (Closed): Redmine website using a deprecated TLS version for encryption
www.redmine.org now supports TLS 1.2. Go MAEDA
 

Also available in: Atom