Project

General

Profile

Activity

From 2020-01-07 to 2020-01-09

2020-01-09

19:10 Defect #32769: Unable to sort projects table by custom field
Here is the patch. Marius BĂLTEANU
18:43 Defect #11277: Production log not recording "Real IP" when passed X_Real_IP and/or X-Forwarded-For Header
hello!
the patch is now in rails upstream [1]
it still would be nice to know where to put the trusted_ips - directive in redmine so I can see real IPs instead of localhost in the log.
I tried following inside config/application...
Matt V
12:30 Defect #32314 (Closed): Notification for "Only for things I watch or I'm involed in" not works
pasquale [:dedalus] wrote:
> Marius BALTEANU wrote:
> ...
Great!
Marius BĂLTEANU
10:05 Defect #32314: Notification for "Only for things I watch or I'm involed in" not works
Marius BALTEANU wrote:
> pasquale [:dedalus] wrote:
> ...
Using Sidekiq all works fine.
Thanks, this issue can be closed as resolved.
pasquale [:dedalus]
10:17 Feature #14727: Display pretty notification email sender name
I would say this is a workaround, it's confusing for users to enter AppName together with email, in all email client configurations/settings it's logical to have sender name, and sender email address (which is used as replyTo address).
...
Aleksandar Pavic
10:07 Feature #32628: Notify users about high issues (only)
Go MAEDA wrote:
> I changed my mind after reading the following sentences in https://support.plan.io/news/162. I understood that this feature is not intended to get more emails but to reduce the total amount of emails.
I think one co...
Jan from Planio www.plan.io
09:54 Feature #32628: Notify users about high issues (only)
Setting the target version to 4.2.0.
Go MAEDA
09:28 Defect #32771: Editing issues does not send notifications to previous assignee
Mischa The Evil wrote:
> Daniel Petat wrote:
> ...
Oh, I am sorry.
I thought "previous assignee" would mean everybody, to whom the issue has *ever* been assigned to.
Would it make sense, to add such an option?
Daniel Petat
06:28 Defect #32771 (Needs feedback): Editing issues does not send notifications to previous assignee
Daniel Petat wrote:
> [...]
> ...
I think that this is an incorrect expectation. After step 2. the previous assignee is user A, not user B as the assignee set in step 2. is user A. So when the assignee is set to user C in step 3. the p...
Mischa The Evil
09:11 Defect #32768: Internal Error when issue text custom field is shown in Spent time query results
The problem in @timelog/_list.html.erb@ was introduced by #16843, but until #26081 was implemented, there were no inline columns for @TimeEntryQuery@.
I'll post soon the fix.
Marius BĂLTEANU
06:40 Feature #32764: Make form validation errors more obvious for users
Marius BALTEANU wrote:
> What do you think if we make those fields with errors more obvious?
I think that would be a nice improvement indeed. Though I'm not sure if the field label should be changed too or if the highlighting of the ...
Mischa The Evil
06:30 Feature #3369: Allowed/Disallowed email domains settings to restrict users' email addresses
+1
This feature can prevent potential information leakage.
If an employee has changed the email address of their Redmine account from the organization's email address to their personal email address, notifications are delivered to th...
Go MAEDA
06:13 Feature #31322: Provide a way to automatically close all open subtasks too when a parent issue is being closed
FWIW: This issue is not related/being superseded by either #28492 or #31589. See my explanation in #31589#note-21. Mischa The Evil
06:01 Feature #28492: Option not to block closing a parent issue when it has open subtask(s)
FWIW: This issue is not related/being superseded by either #31322 or #31589. See my explanation in #31589#note-21.
Regarding this feature: I tend to agree with Mitsuyoshi Kawabata that I'm not seeing clear use-cases where it is logica...
Mischa The Evil
05:49 Feature #31589: Show warning and the reason when the issue cannot be closed because of open subtasks or blocking open issue(s)
Marius BALTEANU wrote:
> [...] I tried to use another approach in order to avoid keeping the logic in multiple places. I'm attaching the results, feedback is welcome!
I like this approach. Very neat. It also got me thinking about wha...
Mischa The Evil
04:06 Feature #31589: Show warning and the reason when the issue cannot be closed because of open subtasks or blocking open issue(s)
Marius BALTEANU wrote:
> Toshi MARUYAMA wrote:
> ...
I think it is very strange warning icon *always* shows.
I think it should be in only following cases.
* User can change parent isses status to *closed* nevertheless parent issue ...
Toshi MARUYAMA
04:46 Patch #32746 (Closed): Italian translation update for 4.1-stable
Committed the patch. Thank you. Go MAEDA
04:45 Revision 19415 (svn): Merged r19414 from trunk to 4.1-stable (#32746).
Go MAEDA
04:43 Revision 19414 (svn): Italian translation update (#32746).
Patch by pasquale [:dedalus]. Go MAEDA
02:06 Defect #12759 (Closed): createIssue API call return 404 and not error response
Since there has been no feedback for 7 years, I am closing this issue. Go MAEDA

2020-01-08

17:49 Feature #32766: Remove the URI limitation from external markdown links
As a note: for us we have solved the problem with a "fix" plugin (https://github.com/laborb/redmine_lab_uri_schemes).
Nevertheless I would consider a solution in the core to be useful.
Simon Busse
09:36 Feature #32766 (Closed): Remove the URI limitation from external markdown links
*Problem (usecase)*
The Markdown Module of Redmine limits the possible URIs in markdown written links ([[RedmineTextFormattingMarkdown#External-links]]). But for us it is a very important feature to be able to link directly from Redmine...
Simon Busse
16:15 Defect #32776 (Closed): Redmine website using a deprecated TLS version for encryption
Firefox 73 (beta) started to deprecate TLS 1.0 and TLS 1.1 versions.
Accessing Redmine Website with FF 73, generates the following warning
!image.png!
For now user can choose to use deprecated versions, but next releases will pe...
Fernando Hartmann
14:07 Defect #32774 (Closed): Creating time tracking entry for other user through rest API fails with 403
Trying to create a time tracking entry for another user through rest API with admin user without a role not a member on the project.
I'm getting a forbidden 403 return.
Maybe this is related to #3848.
However, through the user inte...
Valdir Stiebe Junior
13:59 Feature #32773 (New): Filter for showing subproject childrens on Projects page
On the filter system created on #29482 it would be helpful to have a filter similar to _Subproject of_ but with all children subprojects on the result.
Or an option to bring all subprojects in the results.
Valdir Stiebe Junior
12:28 Defect #32772 (Closed): Tabs are displayed on two lines when the total width of the tabs is greater than 2000px
New tab based history has issue with drawing tab frames.
!frame_issue.png!
Tested on Chrome and IE.
Sebastian Paluch
11:35 Defect #32771 (Closed): Editing issues does not send notifications to previous assignee
Hello,
we are using
Daniel Petat
11:14 Defect #32769 (Confirmed): Unable to sort projects table by custom field
Marius BĂLTEANU
10:53 Defect #32769 (Closed): Unable to sort projects table by custom field
Hi,
On main project page, I'm able to display all projects and subprojects in a table format with filters on Custom Fields. However, I cannot sort project on this fields.
I can click the column title, it displays the arrow indicating...
Yann Rambourg
11:13 Defect #32768 (Confirmed): Internal Error when issue text custom field is shown in Spent time query results
Marius BĂLTEANU
10:48 Defect #32768 (Closed): Internal Error when issue text custom field is shown in Spent time query results
On Spent Time tab, when selecting, under Options->Show, a custom field of long text type, I get internal error: Sebastian Paluch
11:04 Defect #32770 (Needs feedback): Text formating on Redmine Home page does not work
On Home page following text formatting is not working anymore (was working in 3.4.4) Sebastian Paluch
10:33 Feature #5195: edit_own_issues and delete_own_issues permissions
"Edit own issues" permission has been added in Redmine 4.1.0 (#1248). Go MAEDA
09:09 Feature #32628: Notify users about high issues (only)
Jan from Planio www.plan.io wrote:
> > * How about enabling @notify_about_high_priority_issues@ by default? To do so, users will be able to expect that notifications about issues with higher priorities are sent to most members
> ...
I ...
Go MAEDA
07:17 Feature #32628: Notify users about high issues (only)
And a german translation. Jan from Planio www.plan.io
04:57 Feature #32628: Notify users about high issues (only)
Minor update to patch 0004 which downcases the priority name in the setting label as it is part of a sentence. Jan from Planio www.plan.io
08:58 Defect #32765 (Closed): ##123 syntax for linking to issues: Title cannot be distinguished from following text
Relates to #29488.
The displayed title of the linked issue has the same style as the normal text, what could lead to confusing information. A minimal fix would be to add the link color also to the title (bold or not bold).
Robert Schneider
08:36 Feature #32757 (Closed): Show warning when an issue cannot be closed because of blocking issue relations
Closing this in favour of #31589. Marius BĂLTEANU
08:33 Feature #31589: Show warning and the reason when the issue cannot be closed because of open subtasks or blocking open issue(s)
Go MAEDA wrote:
> Marius, thank you for posting the patch that also implements #32757. I liked it.
> ...
Oh, sorry for the typo. I've fixed it in the attached patch.
Marius BĂLTEANU
01:46 Feature #31589: Show warning and the reason when the issue cannot be closed because of open subtasks or blocking open issue(s)
Marius, thank you for posting the patch that also implements #32757. I liked it.
I think it can be a part of the core if ":notive_issue_not_closable_by_*" in the patch is replaced with ":notice_issue_not_closable_by_*".
Go MAEDA
03:24 Feature #32764: Make form validation errors more obvious for users
Marius BALTEANU wrote:
> What do you think if we make those fields with errors more obvious?
+1
It is a very common interface. And the issue form tends to have many fields, so Redmine should definitely have this feature.
Go MAEDA

2020-01-07

23:33 Feature #32757: Show warning when an issue cannot be closed because of blocking issue relations
I've proposed a patch which implements this in #31589. Marius BĂLTEANU
23:32 Feature #31589: Show warning and the reason when the issue cannot be closed because of open subtasks or blocking open issue(s)
Toshi MARUYAMA wrote:
> Yes, this is very very simple.
> ...
Thanks Toshi for the POC, but I tried to use another approach in order to avoid keeping the logic in multiple places. I'm attaching the results, feedback is welcome!
All t...
Marius BĂLTEANU
23:26 Feature #32764 (Closed): Make form validation errors more obvious for users
Currently, the validation errors are shown only on top of the page:
!validation_errors.png!
which makes very hard for the user to find those fields with errors, especially when there are multiple fields (how is in the case of an i...
Marius BĂLTEANU
23:07 Patch #32747: Fix wrong translation for "time entries" in redmine 4.1.0
Would you explain why the existing translations are wrong? Since I don't understand Italian, I can't determine if the changes are valid. Go MAEDA
15:57 Defect #32754 (Closed): Fix missing arrow icon of collapse macro
Committed the patch. Thank you for detecting and fixing the issue. Go MAEDA
15:08 Defect #32754: Fix missing arrow icon of collapse macro
Go MAEDA wrote:
> Go MAEDA wrote:
> ...
Please use this one, all tests pass: https://gitlab.com/redmine-org/redmine/pipelines/107443098
Marius BĂLTEANU
15:02 Defect #32754: Fix missing arrow icon of collapse macro
Go MAEDA wrote:
> Thank you for posting the patch #32754#note-2 but it breaks some tests.
> ...
It can be fixed by applying attachment:32754-update-test.patch.
Go MAEDA
03:18 Defect #32754: Fix missing arrow icon of collapse macro
Thank you for posting the patch #32754#note-2 but it breaks some tests. Go MAEDA
15:56 Revision 19413 (svn): Fix missing arrow icon of collapse macro (#32754).
Patch by Marius BALTEANU. Go MAEDA
14:55 Patch #32763 (Closed): Update mini_magick to 4.11
Updated Gemfile. Go MAEDA
14:27 Patch #32763 (Closed): Update mini_magick to 4.11
MiniMagick 4.10.0 has been released on 2018-01-06.
https://github.com/minimagick/minimagick/releases/tag/v4.10.0
Go MAEDA
14:55 Revision 19412 (svn): Update mini_magick to 4.10 (#32763).
Go MAEDA
14:53 Patch #32530: Update RuboCop to 1.12
Updated to 0.79 in r19411. Go MAEDA
14:49 Revision 19411 (svn): Update RuboCop to 0.79 (#32530).
Go MAEDA
13:28 Feature #30492: Replace RMagick with MiniMagick
If one could update the wiki regarding installation and upgrade, please. Are the devel packages of Image/GraphicsMagick required? Is there anything special to keep in mind on upgrade? I do not know enough about Ruby stuff. Robert Schneider
11:54 Defect #32762: Unicode character fails edit Issue
I think is the same as #21398. People posted some workarounds there. Guillermo ML
11:04 Defect #32762: Unicode character fails edit Issue
Try to add a thumbs up character. The version installed at my company will give an error page. The version on this website will show nothing.
https://emojipedia.org/thumbs-up-sign/
Ruud Poutsma
11:03 Defect #32762 (Closed): Unicode character fails edit Issue
Ruud Poutsma
06:25 Feature #32628: Notify users about high issues (only)
Thank you for your feedback!
> * Even if "I don't want to be notified of changes that I make myself" is enabled, notifications about issues with higher priorities are sent. In my opinion, @no_self_notified@ should be prioritized than @n...
Jan from Planio www.plan.io
02:51 Revision 19410 (svn): Reverts r19409 that breaks some tests (#32754).
Go MAEDA
02:37 Feature #27831: ATOM Feed for repository changes
I fixed Felix's patch attachment:27831-master.patch (mainly config/routes.rb). I attached a fixed patch.
Go MAEDA wrote:
> I tested the patch with Redmine's bundled test fixtures and repositories. I get "404 The entry or revision wa...
Yuichi HARADA
02:34 Revision 19409 (svn): Fix that arrow icon for {{collapse}} macro is not shown (#32754).
Patch by Marius BALTEANU. Go MAEDA
 

Also available in: Atom