Redmine

2020-02-11

21:16 Defect #32985 (Closed): Remove unnecessary use of instance variables in CSV and Atom response handlers

I set "10000" as "Issues export limit" (instead of default "500") for some reasons,
but I noticed that exporting aro... Ko Nagase

16:14 Patch #32847: Ability to add custom css classes to body tag

The changed @body_css_classes@ method is unfortunately not idempotent. Each call of the changed method will add the "... Holger Just

15:40 Feature #12794: Member groups not listed in project page

+1
I think this feature is needed.
In Lotus Notes, each DB could have role-based access rights specified by group... Yuuki NARA

14:34 Defect #29838 (Closed): Time logging via commit message does not work when the configured activity has been overridden on the project level

Committed the patches. Thank you for detecting and fixing this issue. Go MAEDA

09:21 Defect #29838 (New): Time logging via commit message does not work when the configured activity has been overridden on the project level

Jens Krämer wrote:
> turns out it did not have anything to do with the MySQL version, it was just a race condition i... Marius BĂLTEANU

07:45 Defect #29838: Time logging via commit message does not work when the configured activity has been overridden on the project level

turns out it did not have anything to do with the MySQL version, it was just a race condition in the Changeset test s... Jens Krämer

13:56 Defect #32983 (Closed): Filter for "Blocked by" "no open issues" not working

If I add a filter for "Blocked by" and select "no open issues", then hit "save" and "Apply", the newly added filter j... Martin Hierholzer

07:03 Defect #32977: Remove references to deleted user from "user"-Format CustomFields

The patch cannot be committed for minor releases because it has a migration. Go MAEDA

06:29 Defect #32977: Remove references to deleted user from "user"-Format CustomFields

here's a new patch including a migration to delete already existing orphaned values.
Jens Krämer

05:56 Defect #5354 (Reopened): Updating custom fields does not trigger update to "updated_on" field in the customized object

The patch breaks an existing test.... Go MAEDA

05:06 Defect #5354 (Closed): Updating custom fields does not trigger update to "updated_on" field in the customized object

Committed the patch. Thank you. Go MAEDA

04:53 Feature #32945 (Resolved): Show module names in bold in permission report

Committed the patch. Go MAEDA

01:34 Feature #32945: Show module names in bold in permission report

Since the patch only changes CSS, so no problem to deliver in 4.1.1. Go MAEDA

03:35 Feature #16006 (Closed): Include attachments in forum post notifications

Go MAEDA

03:34 Feature #16006: Include attachments in forum post notifications

Committed the patch. Thank you for your contribution. Go MAEDA

02:22 Defect #32981 (Closed): Unable to distinguish disabled input fields

Although it is a text box with disabled set, it is difficult to identify because the background color does not change... Hirokazu Onozato

02:11 Feature #32818 (Closed): Add a system setting for default results display format of project query

Committed the patch. Thank you for improving Redmine. Go MAEDA

2020-02-10

20:23 Feature #6851: Change PDF page size

Just did this with redmine 4.1.0. Went to:
/usr/share/redmine/lib/redmine/export/pdf.rb
Found the following ... Ted Felix

16:25 Feature #32818: Add a system setting for default results display format of project query

Thanks to Marius for reviewing the patch and suggesting improvements!
I think attached code is better, because the p... Takenori TAKAKI

15:16 Defect #29838: Time logging via commit message does not work when the configured activity has been overridden on the project level

Jens Krämer wrote:
> thats really interesting as I ran my tests against MySQL (5.6) as well. can i see the exact env... Marius BĂLTEANU

14:59 Defect #29838: Time logging via commit message does not work when the configured activity has been overridden on the project level

thats really interesting as I ran my tests against MySQL (5.6) as well. can i see the exact environment in terms of r... Jens Krämer

10:41 Defect #29838: Time logging via commit message does not work when the configured activity has been overridden on the project level

Jens Krämer wrote:
> I just applied both patches to current master and all changeset tests pass. Could you please re... Marius BĂLTEANU

10:19 Defect #29838: Time logging via commit message does not work when the configured activity has been overridden on the project level

I just applied both patches to current master and all changeset tests pass. Could you please retry / post some logs? Jens Krämer

14:56 Defect #32977: Remove references to deleted user from "user"-Format CustomFields

we should indeed do that. I'll take care of that tomorrow. Jens Krämer

10:48 Defect #32977: Remove references to deleted user from "user"-Format CustomFields

We shouldn't add a migration to remove the existing orphaned values? Marius BĂLTEANU

10:11 Defect #32977 (Closed): Remove references to deleted user from "user"-Format CustomFields

When a user record is destroyed, custom field values for custom fields with @field_format == 'user'@ referencing the ... Jens Krämer

12:18 Feature #22483: Show PDF attachments and repo entries instead of downloading them

Gregor Schmidt wrote:
> Updated patches to r15404.
Thank you! Gần Sôi Nước

11:43 Feature #32424: CommonMark Markdown Text Formatting

Well Gitlab is a hosted platform with paying customers, so they had to be extra careful. I don't know if/how that gra... Jens Krämer

10:53 Feature #32424: CommonMark Markdown Text Formatting

Jens Krämer wrote:
> I agree regarding complexity / confusion of users. So in order to move this forward, should I p... Marius BĂLTEANU

09:18 Feature #32424: CommonMark Markdown Text Formatting

I agree regarding complexity / confusion of users. So in order to move this forward, should I proceed to change the p... Jens Krämer

10:21 Feature #32978 (New): Option to show "Associated revisions" in Notes or History Tab

Hello there, after updating Redmine to version 4.1, I found not usable moment - I need to click on the tab "Associate... Kirill Trofimov

06:56 Feature #32976 (Closed): Display avatar on add watcher dialog

By changing the user icon to avatar in the Add Watchers dialog, we will be able to intuitively select the users we wa... Takenori TAKAKI

01:17 Defect #32896 (Closed): Totals not working in projects list view

Marius BALTEANU wrote:
> My patch introduced a new Stylelint violation, please commit the attached fix.
>
> [...]... Go MAEDA

2020-02-09

23:21 Feature #32818: Add a system setting for default results display format of project query

Thanks Takenori TAKAKI for writing the patch.
I propose few changes in the attached patch in order to keep the ex... Marius BĂLTEANU

18:30 Feature #32818: Add a system setting for default results display format of project query

I would like to review this patch. Marius BĂLTEANU

16:37 Defect #32889: Responsive layout for issue tree and issue relation on issue page is broken

We can revert the old behaviour by hiding the start date and due date or we can show all other columns on 5 columns l... Marius BĂLTEANU

16:10 Defect #32896 (Reopened): Totals not working in projects list view

My patch introduced a new Stylelint violation, please commit the attached fix.... Marius BĂLTEANU

15:32 Defect #32973: Editing a time entry for a locked user changes the user to the current user

Here is the fix for the second option, but I would like a double check on the solution. The second patch renames and ... Marius BĂLTEANU

01:04 Defect #32973: Editing a time entry for a locked user changes the user to the current user

Marius BALTEANU wrote:
> I see two options to fix this:
>
> 1. We don't allow changing the user when the time ent... Go MAEDA

01:27 Defect #32959 (Closed): Fix selected user on log time edit page when user has permissions to log time for another user

Committed the patch. Thank you. Go MAEDA