Project

General

Profile

Activity

From 2020-03-31 to 2020-04-02

2020-04-02

23:27 Patch #33244 (Closed): Replace "**" method with bitwise left shift in Tracker#disabled_core_fields and Tracker#core_fields
this patch replaces a power function with a less expensive shift Pavel Rosický
22:23 Feature #13919: Mention user on issues and wiki pages using @user with autocomplete
Mizuki ISHIKAWA wrote:
> I am developing a patch based on 0001-Demo-for-acts_as_mentionable.patch, but I thought that there are some problems by sharing the process with acts_as_mentionable.
> ...
Thanks Mizuki for the work made on top...
Marius BĂLTEANU
17:00 Defect #33240 (Closed): Issue subjects in gantt are broken in Internet Explorer if the avatar server is inaccessible
Focus on issue 3 and 2 in the screenshots below. Issue subjects are not correctly displayed. This can be reproduced when the avatar server is not accessible and your browser is Internet Explorer.
*BAD:*
!{border: 1px solid grey;}.bad...
Go MAEDA
10:04 Patch #33226 (Closed): Skip thumbnail tests if ImageMagick convert command is not available
Committed the patch. Thank you. Go MAEDA
10:04 Revision 19640 (svn): Skip thumbnail tests if ImageMagick convert command is not available (#33226).
Patch by Pavel Rosický. Go MAEDA
09:59 Defect #32737 (Closed): Duplicate sort keys for issue query cause SQL error with SQL Server
Committed the patch. Thank you to everyone involved in testing and fixing the issue. Go MAEDA
05:02 Defect #32737: Duplicate sort keys for issue query cause SQL error with SQL Server
Pavel Rosický wrote:
> for reference #29581 caused the issue
> ...
That's great. All tests completed successfully by combining 32737-remove-duplicate-keys.patch and gantt.rb.patch.
However, since the relative path of @gantt.rb@ was un...
Yuichi HARADA
09:56 Revision 19639 (svn): Merged r19637 from trunk to 4.1-stable (#32737).
Go MAEDA
09:55 Revision 19638 (svn): Merged r19636 from trunk to 4.1-stable (#32737).
Go MAEDA
09:52 Revision 19637 (svn): Fix that viewing gantt causes SQL error with SQL Server (#32737).
Patch by Pavel Rosický. Go MAEDA
08:22 Revision 19636 (svn): Remove duplicate keys from sort criteria (#32737).
Patch by Go MAEDA. Go MAEDA
07:52 Revision 19635 (svn): Replace File#readable? with Attachment#readable? (#7056).
Go MAEDA
05:05 Defect #33234 (Closed): Vertical scroll bar in some browsers hide content
The vertical scrollbar in some browser may be displayed over the content, hiding text or making it difficult to click buttons.
The screenshot below is taken when using Firefox 74.0 on macOS 10.15.4.
!{width: 220px; border: 1px soli...
Go MAEDA
01:17 Defect #33232 (Closed): Hard-coded error messages in ApplicationController
uninternationalized hard-coded string exists in source:trunk/app/controllers/application_controller.rb@19553#L686 Kam Nazir
01:11 Defect #33220: Parent task subject column in gantt is not fully displayed when the column is widened
Good job! :-) Jaebok Oh

2020-04-01

18:28 Defect #33169 (Closed): Issues CSV export does not include custom fields with "Full width layout" enabled
Committed attachment:0001-Fix-issues-and-spent-time-CSV-export-does-not-includ.patch and attachment:0002-Option-to-Check-Uncheck-all-block-columns-in-export.patch. Thank you. Go MAEDA
18:27 Revision 19634 (svn): Merged r19632 and r19633 from trunk to 4.1-stable (#33169).
Go MAEDA
18:21 Revision 19633 (svn): Option to Check/Uncheck all block columns in export (#33169).
Patch by Marius BALTEANU. Go MAEDA
18:20 Revision 19632 (svn): Fix issues and spent time CSV export does not include custom fields with "Full width layout" enabled (#33169).
Patch by Marius BALTEANU. Go MAEDA
17:44 Feature #33126: Support custom fields when exporting users to CSV
Setting the target version to 4.2.0. Go MAEDA
14:38 Feature #2636: Feature Request: Wiki ACLs (Access control for individual pages)
Heiko Robert wrote:
> +1
> ...
Well actually one of the plugin actually works with Redmine 4.1.0
https://www.redmine.org/plugins/manage_wiki_view_page_permission
Tuan-Tu Tran
11:14 Revision 19631 (svn): Replace File#readable? with Attachment#readable? (#7056).
Go MAEDA
10:52 Defect #28506 (Closed): Error Setup Redmine with Win10
The issue is going to be fixed in the upcoming Redmine 4.1.1 and 4.0.7 (#30285). Go MAEDA
10:51 Defect #30210 (Closed): Application crash when deleting an issue from issue list with SQLServer
The issue is going to be fixed in the upcoming Redmine 4.1.1 and 4.0.7 (#30285). Go MAEDA
10:50 Defect #30211 (Closed): Crash with the message "undefined method `alias_method_chain'" when connecting to Microsoft SQL Server
The issue is going to be fixed in the upcoming Redmine 4.1.1 and 4.0.7 (#30285). Go MAEDA
10:49 Defect #30284 (Closed): Internal Server Error When Deleting a User
The issue is going to be fixed in the upcoming Redmine 4.1.1 and 4.0.7 (#30285). Go MAEDA
10:46 Defect #30285 (Closed): Microsoft SQL server support is broken
Merged r19628 to stable branches. Go MAEDA
10:35 Defect #30285: Microsoft SQL server support is broken
Go MAEDA wrote:
> Pavel Rosický wrote:
> ...
Sure, good idea. I don't know why I thought that only 4.1 is affected.
Marius BĂLTEANU
10:19 Defect #30285 (Resolved): Microsoft SQL server support is broken
Pavel Rosický wrote:
> activerecord-sqlserver-adapter 5.2.1 has been released on 31.3.2020. We should update the Gemfile.
Committed the patch. Thank you for working hard on fixing activerecord-sqlserver-adapter.
Marius, I think we...
Go MAEDA
09:49 Defect #30285: Microsoft SQL server support is broken
Pavel Rosický wrote:
> activerecord-sqlserver-adapter 5.2.1 has been released on 31.3.2020. We should update the Gemfile.
+1
I think it's good. I confirmed using the Docker image "mcr.microsoft.com/mssql/server:2017-latest-ubuntu".
Yuichi HARADA
10:44 Revision 19630 (svn): Merged r19628 from trunk to 4.0-stable (#30285).
Go MAEDA
10:43 Revision 19629 (svn): Merged r19628 from trunk to 4.1-stable (#30285).
Go MAEDA
10:12 Revision 19628 (svn): Update tiny_tds to 1.0.5 and activecord-sqlserver-adapter to 5.2.1 (#30285).
Patch by Pavel Rosický. Go MAEDA
10:04 Defect #32737: Duplicate sort keys for issue query cause SQL error with SQL Server
We should fix this in version:"4.1.1" together with #30285. Marius BĂLTEANU
08:04 Defect #33220: Parent task subject column in gantt is not fully displayed when the column is widened
Jaebok Oh wrote:
> Changing ID as shown below will resolve the issue.
> ...
+1
I think so, too. In the attached patch, the Parent task subject can be stretched properly.
!{width:600px;border:1px solid #ccc;}gantt-column-stretched.png!
Yuichi HARADA
02:14 Defect #33220: Parent task subject column in gantt is not fully displayed when the column is widened
Changing ID as shown below will resolve the issue.
parent.subject -> parent_subject
Jaebok Oh
06:46 Feature #18669: Ability to remove Wiki (page) history
good post i like it. Bernad Campbell
06:14 Feature #33174: Show groups in members box on project overview page
Go MAEDA wrote:
> Not to break third-party plugins, I think it is safer to keep @users_by_role@ method and log a deprecation warning like source:tags/3.4.9/app/models/project.rb#L839 than removing the method in Redmine 4.2.0.
Changed...
Mizuki ISHIKAWA
03:49 Patch #33225 (Closed): Czech translation update
Committed the patch. Thank you. Go MAEDA
03:48 Revision 19627 (svn): Czech translation update (#33225).
Patch by Pavel Rosický. Go MAEDA
03:03 Patch #33226: Skip thumbnail tests if ImageMagick convert command is not available
Thank you for the fix. I found that @gantts_controller_test.rb@ should also be fixed. Attached the updated patch. Go MAEDA

2020-03-31

19:21 Patch #33226 (Closed): Skip thumbnail tests if ImageMagick convert command is not available
Pavel Rosický
19:15 Patch #33225 (Closed): Czech translation update
Pavel Rosický
18:32 Defect #32737: Duplicate sort keys for issue query cause SQL error with SQL Server
for reference #29581 caused the issue
patches 32737-remove-duplicate-keys.patch and gantt.rb.patch should be applied
Pavel Rosický
17:44 Patch #33219: Persian translation update for 4.1-stable
I'v added new translation in a new patch file. but about other changes in old one:
* most changes related to difference of number representation in English and Persian. (e.g. 1 => ۱) [15 changes]
* some about changes in English transla...
Kam Nazir
04:29 Patch #33219: Persian translation update for 4.1-stable
Thank you for submitting the patch but the patch cannot be committed immediately because it contains changes to existing translations. Could you explain the need for each change or remove the changes from the patch and open a separate is... Go MAEDA
01:12 Patch #33219 (Closed): Persian translation update for 4.1-stable
I have added some missing translation for Persian language. related #28493
Thanks.
Kam Nazir
17:43 Defect #30285: Microsoft SQL server support is broken
Great! When will 4.1.1 be released? Bob Binary
16:39 Defect #30285: Microsoft SQL server support is broken
activerecord-sqlserver-adapter 5.2.1 has been released on 31.3.2020. We should update the Gemfile. Pavel Rosický
16:57 Defect #33224 (Closed): SQL Server: A column has been specified more than once
Pavel Rosický wrote:
> ahh sry, it is a duplicate.
Don't worry, thanks for your quick response.
Marius BĂLTEANU
16:56 Defect #33224: SQL Server: A column has been specified more than once
ahh sry, it is a duplicate. Pavel Rosický
16:53 Defect #33224: SQL Server: A column has been specified more than once
Is not the same issue from #32737? Marius BĂLTEANU
16:49 Defect #33224 (Closed): SQL Server: A column has been specified more than once
there seems to be a new failure on master Pavel Rosický
11:57 Defect #32471: Layout of the custom field edit page is different between the single edit page and the batch edit page
I think full-width custom fields need to be considered in the bulk edit page.
*Editing a single issue:*
!{border: 1px solid grey; width: 747px;}.single-edit-layout@2x.png!
*Bulk edit:*
!{border: 1px solid grey; width: 924px;}.bul...
Go MAEDA
11:31 Feature #32976 (Closed): Display avatar on add watcher dialog
Committed the patch. Thank you. Go MAEDA
11:30 Revision 19626 (svn): Display avatar on add watchar dialog (#32976).
Patch by Takenori TAKAKI. Go MAEDA
10:57 Defect #33110: Sort does not work with group by datetime columns
Hi Marius,
thanks for the patch! This solved the problem. Create work and not easy to address the problem.
Alexander Meindl
10:11 Feature #33216: /my/account: Prevent users from changing their Email [redmine 4.1.0 stable]
Thank you, Go MAEDA.
> Would it be helpful to you if #3369 was implemented?
In certain ways, yes. It could help in a scenario where only one organization (or a small set thereof) is served. It would not prevent address changes in...
James Barrante
09:18 Feature #33216: /my/account: Prevent users from changing their Email [redmine 4.1.0 stable]
James Barrante wrote:
> Having an Administration setting to "lock" only the Email address of an account would be great. It could help enforce policy of only using the organization's e-mail addresses.
In #3369, a feature is proposed...
Go MAEDA
09:28 Feature #3876 (Resolved): ldap authentification without binding ?
Anonymous
08:39 Patch #33208 (Closed): `--without rmagick` option for bundle command is no longer necessary
Committed the patch. Go MAEDA
08:39 Revision 19625 (svn): `--without rmagick` option for `bundle install` is no longer necessary (#33208).
Patch by Go MAEDA. Go MAEDA
08:08 Feature #33210: Add "Filters" category to redmine.org
If "Filters" is created, doesn't that make the "Issues list" category unnecessary? Many issues in the "Issues list" category are related to filters. Go MAEDA
08:04 Patch #33209 (Closed): Japanese translation update (r19621)
Committed the patch. Go MAEDA
08:03 Revision 19624 (svn): Japanese translation update (#33209).
Patch by Go MAEDA. Go MAEDA
07:04 Defect #32765: ##123 syntax for linking to issues: Title cannot be distinguished from following text
Marius BALTEANU wrote:
> but I think that we should change the title as well because right now we show the entire subject and the title shows the subject truncated at 100 characters and the status. Maybe it is enough to show "label_stat...
Go MAEDA
06:39 Defect #33116: Successful deletion notice is not displayed after deleting some types of content
Setting the target version to 4.2.0. Go MAEDA
03:47 Defect #33220 (Closed): Parent task subject column in gantt is not fully displayed when the column is widened
The Parent task subject is broken when the width of the column is wider.
!gantt_column_error.png!
Jaebok Oh
 

Also available in: Atom