Activity
From 2020-04-03 to 2020-04-05
2020-04-05
-
21:28 Revision 19678 (svn): Don't use User.current in TimeEntryImport model but #user instead (#32774).
-
21:24 Revision 19677 (svn): Set time entry author in controller (#32774).
-
21:17 Feature #13919: Mention user on issues and wiki pages using @user with autocomplete
- I've updated the patch in order to:
# ignore the users mentioned in quoted text or pre tags.
# add in the email template the sentence "You have been mentioned in it." (for now only when adding/editing issue)
!{width:50%; border: 1px... -
20:39 Revision 19676 (svn): Creating time tracking entry for other user through rest API fails with 403 (#32774).
-
20:15 Defect #32774: Creating time tracking entry for other user through rest API fails with 403
- Jean-Philippe Lang wrote:
> I've reverted the change and will work on another fix.
> ...
Ok, please let me know if you need my help on this. -
19:33 Defect #32774 (New): Creating time tracking entry for other user through rest API fails with 403
- I've reverted the change and will work on another fix.
We should not respond with 403 when submitting the form at /time_entries/new with an project or issue that is not OK. -
16:29 Defect #32774 (Resolved): Creating time tracking entry for other user through rest API fails with 403
- Committed, thanks.
Marius BALTEANU wrote:
> Also, we should do the same change for @find_optional_issue@ as well?
Good point, I've fixed @find_optional_issue@ in r19670. -
19:29 Revision 19675 (svn): Reverted r19669 and r19670 (#32774).
-
18:14 Feature #17460: MySQL 5.7 support
- Toshi MARUYAMA wrote:
> Marius BALTEANU wrote:
> ...
Yes, but the CI uses MySQL 5.7 so is quite strange to say we do not support MySQL 5.7, but we run the tests against MySQL 5.7.
-
18:07 Feature #17460: MySQL 5.7 support
- Marius BALTEANU wrote:
> Even if the problem with deadlocks still exists on MySQL 5.7, I think that it is safe to say that Redmine 4.0 officially supports MySQL 5.7 and to close this issue.
> ...
Tests skip on MySQL (r16926).
-
17:15 Revision 19674 (svn): Merged r19672 to 4.0-stable (#32934).
-
17:02 Revision 19673 (svn): Merged r19672 to 4.1-stable (#32934).
-
17:01 Defect #33253: Failed to upgrade to v4.1
- I have attached the screenshot of the info page of my installation.
-
16:43 Defect #33253: Failed to upgrade to v4.1
- Yes, i have following plugins installed
Redmine Dashboard plugin : https://github.com/jgraichen/redmine_dashboard
Redmine Pivot Table plugin: https://github.com/deecay/redmine_pivot_table
-
09:03 Defect #33253 (Needs feedback): Failed to upgrade to v4.1
- Did you have any patch applied or plugin installed on version:"4.0.3"? I'm asking because the column is added in version:"4.1.0".
-
16:41 Revision 19672 (svn): XSS vulnerabilities in textile links (#32934).
- Patch by Holger Just.
-
16:35 Revision 19671 (svn): Reverts r19489 (#32934).
-
16:28 Revision 19670 (svn): Creating time tracking entry for other user through rest API fails with 403 (#32774).
-
16:26 Defect #33257 (New): Bulk edit for time entries does not support User filed
- In Redmine 4.1, time entry has a new User field that allows entering another user's spent time (#3848).
However, the User field is missing on the bulk edit screen for time entries. I think it is better to have the User field in bulk e... -
16:23 Revision 19669 (svn): Creating time tracking entry for other user through rest API fails with 403 (#32774).
- Patch by Marius BALTEANU.
-
16:13 Defect #32765 (Closed): ##123 syntax for linking to issues: Title cannot be distinguished from following text
- Merged.
-
12:52 Defect #32765 (Resolved): ##123 syntax for linking to issues: Title cannot be distinguished from following text
- Patch committed, thanks!
-
11:07 Defect #32765: ##123 syntax for linking to issues: Title cannot be distinguished from following text
- Go MAEDA wrote:
> Marius BALTEANU wrote:
> ...
Updated the patch. -
16:13 Revision 19668 (svn): Merged r19663 to 4.1-stable (#32765).
-
16:08 Feature #33256: Show wiki toolbar for spent time custom fields with text formatting enabled
- Go MAEDA wrote:
> Thank you for submitting the patch, but I found an issue that the Preview tab always displays "undefined" when bulk editing time entries. See attachment:33256-undefined-in-preview.png.
Oh, I forgot to mention that i... -
16:07 Feature #33256: Show wiki toolbar for spent time custom fields with text formatting enabled
- Thank you for submitting the patch, but I found an issue that the Preview tab always displays "undefined" when bulk editing time entries. See attachment:33256-undefined-in-preview.png.
-
11:52 Feature #33256: Show wiki toolbar for spent time custom fields with text formatting enabled
- Tests pass: https://gitlab.com/redmine-org/redmine/pipelines/132973534 (the one that fails is caused by another issue).
-
11:51 Feature #33256: Show wiki toolbar for spent time custom fields with text formatting enabled
- This patch implements the wiki toolbar in the following pages:
# timelog#new
# timelog#edit
# timelog#bulk_edit.
-
11:45 Feature #33256 (Closed): Show wiki toolbar for spent time custom fields with text formatting enabled
- Before:
!{width:70%; border: 1px solid grey}.before.png!
Using this patch:
!{width:70%; border: 1px solid grey}.after.png!
-
14:20 Feature #33254: Show open/closed badge on issue page
- Marius BALTEANU wrote:
> What do you think if we combine this with #33153 and show the status as a dropdown badge with a quick way to change the status?
I think it is really nice! My original request will be met if closed statuses ha... -
13:29 Feature #33254: Show open/closed badge on issue page
- I like the idea!
What do you think if we combine this with #33153 and show the status as a dropdown badge with a quick way to change the status?
!{width: 50%; border: 1px solid grey;}.dropdown_badge.png! -
09:52 Feature #33254 (Closed): Show open/closed badge on issue page
- #29391 added a useful badge that shows the status of the version. I think it would be nice to have the badge on Issue pages as well.
Currently, it is a bit hard to tell at a glance whether an issue is closed. Adding the badge can reso... -
13:48 Feature #33153: UI feature to quickly change issue status
- I have added a new proposal based on #33254.
pasquale [:dedalus] wrote:
> Have you evalueted the jira edit approach implemented by this plugin "Dynamic edit":https://www.redmine.org/plugins/redmine_issue_dynamic_edit?
Yes, I know ... -
13:27 Feature #29470: Possibility to mark tracker as "Subtask only"
- Updated again to apply cleanly.
-
13:23 Defect #32793 (Closed): Email address with Punycode top-level domain is not accepted
- Merged.
-
12:01 Defect #32793 (Resolved): Email address with Punycode top-level domain is not accepted
- Committed and test added, thanks.
-
13:23 Revision 19667 (svn): Merged r19660 and r19661 to 4.1-stable (#32793).
-
13:22 Defect #32889 (Closed): Responsive layout for issue tree and issue relation on issue page is broken
- Merged.
-
11:53 Defect #32889 (Resolved): Responsive layout for issue tree and issue relation on issue page is broken
- Committed, thanks.
-
13:22 Revision 19666 (svn): Merged r19658 and r19659 to 4.1-stable (#32889).
-
13:21 Defect #33110 (Closed): Sort does not work with group by datetime columns
- Merged.
-
11:43 Defect #33110 (Resolved): Sort does not work with group by datetime columns
- Committed, thanks.
-
13:20 Revision 19665 (svn): Merged r19655 to 4.1-stable (#33110).
-
13:20 Feature #3800 (Closed): Editing time entries should show the person involved
- Merged.
-
11:49 Feature #3800: Editing time entries should show the person involved
- Test fails:
-
10:36 Feature #3800 (Resolved): Editing time entries should show the person involved
- Both patches committed, thanks.
Just a slight change to Kevin's patch to prevent calling #name on nil. -
13:19 Revision 19664 (svn): Merged r19653, r19654 and r19662 to 4.1-stable (#3800).
-
12:57 Feature #31505: Mark edited journal notes as "Edited"
- New version to apply cleanly.
-
12:51 Revision 19663 (svn): ##123 syntax for linking to issues: Title cannot be distinguished from following text (#32765).
- Patch by Marius BALTEANU.
-
12:51 Feature #32424: CommonMark Markdown Text Formatting
- Jens Krämer wrote:
> Well Gitlab is a hosted platform with paying customers, so they had to be extra careful. I don't know if/how that gradual release of commonmark also happened for users of their opensource version on their own server... -
12:20 Patch #29830: Issue CSV export options: checkboxes have no effect for columns activated in query
- If #33211 is implemented, this change will no longer be required.
-
12:17 Feature #23954: Shows the date of the last activity on Projects administration
- Updated the patch to apply cleanly on the current trunk.
-
12:14 Revision 19662 (svn): Fixed assertion broken by r19654 (#3800).
-
12:00 Revision 19661 (svn): Adds a test for r19660 (#32793).
-
11:55 Revision 19660 (svn): Email address with Punycode top-level domain is not accepted (#32793).
- Patch by Go MAEDA.
-
11:52 Revision 19659 (svn): Split subtasks/relations information into 5 columns (#32889).
- Patch by Marius BALTEANU.
-
11:51 Revision 19658 (svn): Move style to css (#32889).
- Patch by Marius BALTEANU.
-
11:47 Defect #32973 (Closed): Editing a time entry for a locked user changes the user to the current user
- Committed and merged, thanks!
-
11:47 Revision 19657 (svn): Merged r19651 and r19652 to 4.1-stable (#32973).
-
11:44 Defect #32891 (Closed): Bookmark link on project page should not use full path with hostname
- Merged.
-
11:44 Revision 19656 (svn): Merged r19530 to 4.1-stable (#32891).
-
11:43 Revision 19655 (svn): Fix sort does not work with group by datetime columns (#33110).
- Patch by Marius BALTEANU.
-
11:40 Defect #33255: Issue auto complete doesn't work for custom fields with text formatting enabled on issue bulk edit page
- This patch can be applied on top of #32471.
-
10:48 Defect #33255 (Closed): Issue auto complete doesn't work for custom fields with text formatting enabled on issue bulk edit page
-
10:58 Defect #32471: Layout of the custom field edit page is different between the single edit page and the batch edit page
- All tests pass: https://gitlab.com/redmine-org/redmine/pipelines/132967327
-
10:46 Defect #32471: Layout of the custom field edit page is different between the single edit page and the batch edit page
- I've attached 3 patches that fix the problem reported here and also, adds the JS toolbar in this page for full width custom fields with text formatting enabled. Should some fixes made here backported to minor versions?
-
10:35 Revision 19654 (svn): Show user name in time entry bulk edit (#3800).
- Patch by Kevin Fischer.
-
10:29 Revision 19653 (svn): Editing time entries should show the time entry user (#3800).
- Patch by Marius BALTEANU.
-
10:22 Revision 19652 (svn): Reorder and rename test added in r19651 (#32973).
- Patch by Marius BALTEANU.
-
10:21 Revision 19651 (svn): Editing a time entry for a locked user changes the user to the current user (#32973).
- Patch by Marius BALTEANU.
-
10:15 Revision 19650 (svn): Merged r19646 to 4.0-stable (#33075).
-
10:12 Revision 19649 (svn): Merged r19646 to 4.1-stable (#33075).
-
10:06 Revision 19648 (svn): Merged r19486 to 19488 to 4.0-stable (#32850).
-
10:04 Revision 19647 (svn): Merged r19486 to 19488 to 4.1-stable (#32850).
-
09:39 Revision 19646 (svn): Time entries csv export should check issue visibility (#33075).
- Patch by Mizuki ISHIKAWA.
-
09:12 Patch #32530: Update RuboCop to 1.12
- Marius BALTEANU wrote:
> After r19643, we can remove some to dos from @rubocop_todo.yml@. Patch attached.
I think they were removed in r19644. -
08:58 Patch #32530 (Reopened): Update RuboCop to 1.12
- After r19643, we can remove some to dos from @rubocop_todo.yml@. Patch attached.
-
07:45 Patch #32530: Update RuboCop to 1.12
- Updated to RuboCop 0.81 in r19645.
-
07:45 Revision 19645 (svn): Update RuboCop to 0.81 (#32530).
-
07:14 Revision 19644 (svn): RuboCop: Update .rubocop_todo.yml
-
06:30 Feature #33126 (Closed): Support custom fields when exporting users to CSV
- Marius BALTEANU wrote:
> Go MAEDA wrote:
> ...
Done in r19643. Thank you. -
06:29 Revision 19643 (svn): RuboCop: Add "EnforcedStyle: sprintf" (#33126).
2020-04-04
-
19:31 Feature #15520: Markdown formatting
- Hiroo Hayashi wrote:
> I updated [[RedmineTextFormattingMarkdown]].
> ...
In [[RedmineTextFormattingMarkdown]] there are examples of HTML code, but they are not working. Is this a problem in the documentation, do they not work, or do I... -
17:48 Defect #33253 (Closed): Failed to upgrade to v4.1
- I am trying to upgrade to 4.1.0 from 4.0.3.stable and its failing to upgrade. I am using docker. I have included the log below:
-
16:57 Feature #33126: Support custom fields when exporting users to CSV
- Go MAEDA wrote:
> The following code fixes the Rubocop offence:
> ...
Yes, this is an option, but @format@ is just an alias of @sprintf@ and it's not used anywhere else in the code. I propose to stick to @sprintf@ and fix this using th... -
15:06 Feature #33126: Support custom fields when exporting users to CSV
- The following code fixes the Rubocop offence:
-
15:00 Feature #33126 (Reopened): Support custom fields when exporting users to CSV
-
03:42 Feature #33126 (Closed): Support custom fields when exporting users to CSV
- Committed the patch. Thank you for improving Redmine.
-
10:59 Defect #17809: wrong syntax highlighting "---" header and "--" footer of git diff
- It can be fixed with the following code:
-
08:29 Defect #33250 (Closed): Useless white box appears over the the tooltip in EdgeHTML
- When you use the non-chromium Edge browser, tooltips are not displayed correctly. A white box overlaps with the tooltip.
!tooltip-in-edge.png! -
05:41 Feature #1984: Ability to obsolete an uploaded file
- The attached image is a screenshot of Bugzilla's show/hide obsolete button.
-
05:15 Feature #32493 (Closed): Add capability to make an attachment\s obsolete and to collapse all obsolete attachments and focus only the necessary ones (like bugzilla)
- Closing as a duplicate of #1984. Thank you for suggesting a new feature.
-
04:43 Patch #31230 (Closed): Fix: migration fails in MS SQL-Server
- The issue that Redmine 4.0 and 4.1 don't work with SQL Server will be fixed in the upcoming 4.1.1 and 4.0.8. Since those versions use activecord-sqlserver-adapter 5.2.1, the error never occurs.
Redmine 3.4 will not be fixed because 3.... -
03:42 Revision 19642 (svn): Support custom fields when exporting users to CSV (#33126).
- Patch by Mizuki ISHIKAWA.
-
02:53 Patch #32146 (Closed): Add more supported mimetypes
- Many of the extension and MIME type combinations added by this patch are already covered by mini_magic.
-
02:43 Defect #33116 (Closed): Successful deletion notice is not displayed after deleting some types of content
- Committed the patch. Thank you.
-
02:43 Revision 19641 (svn): Fix that "Successful deletion" notice is not displayed after deleting some types of content (#33116).
- Patch by Yuichi HARADA.
2020-04-03
-
00:26 Patch #33244: Replace "**" method with bitwise left shift in Tracker#disabled_core_fields and Tracker#core_fields
- Setting the target version to 4.2.0.