Project

General

Profile

Activity

From 2021-03-29 to 2021-03-31

2021-03-31

22:33 Feature #29285: Add "Assign to me" shortcut to issue edit form
Michael Michalewicz wrote:
> Hi all.
> ...
Thank you a lot for this function...
I would also suggest and prefer to have it at the menu bar as well as mentioned by Michael.
It's quite common to have it there in other systems like JI...
Jenda Benda
15:41 Feature #32898 (New): PDF thumbnails support on Windows
Steve Zhou, thank you for your feedback.
Could you try the attached patch *without* setting imagemagick_convert_command in configuration.yml? I think it should successfully show PDF thumbnails on Windows.
After applying the patch, ...
Go MAEDA
11:56 Feature #32898: PDF thumbnails support on Windows
Go MAEDA wrote:
> Redmine 4.1.2 will support a new setting @gs_command@ in config/configuration.yml (#33283). You can set the command name such as "gswin64c" and "gswin32c".
I checked this new setting again, please find the result as...
Steve Zhou
15:18 Defect #34995 (New): Running redmine in docker getting ssl error, any ideas what might be the issue?
Im having an issue with SSL. Im getting pretty crazy currently. Got the feeling that I miss something really simple :D
Would be very thankful for any help.
Maybe I should add rufus to a Dockerfile like its done here: https://github.c...
rafaelteb rafaelteb
11:31 Feature #34981: Allow to change a project identifier
+1
I think this feature is needed.
The identifier change itself can simply be done in SQL.
I've done it dozens of times in the past.
sample SQL script
Yuuki NARA
11:00 Patch #34969 (Closed): Remove dependency on MimeMagic
Backported to 4.1-stable in r20877 and r20878. Go MAEDA
10:59 Revision 20878 (svn): Merged r20862 from trunk to 4.1-stable (#34969).
Go MAEDA
10:42 Revision 20877 (svn): Merged r20861 from trunk to 4.1-stable (#34969).
Go MAEDA
10:39 Revision 20876 (svn): Merged r20875 from trunk to 4.2-stable (#34982).
Go MAEDA
10:39 Defect #34982 (Closed): Cannot change the default version and default assignee under settings
Go MAEDA
10:28 Defect #34982 (Resolved): Cannot change the default version and default assignee under settings
Committed the fix. Thank you. Go MAEDA
06:26 Defect #34982: Cannot change the default version and default assignee under settings
I've checked/tested the patch, too. I can confirm that it fixes the issue. Bernhard Rohloff
02:57 Defect #34982: Cannot change the default version and default assignee under settings
The patch verified and the defect was FIXED, thanks for your guys quick & selfless contributions! Sunding Wei
10:28 Revision 20875 (svn): Fix cannot change the default version under settings (#34982).
Patch by Marius BALTEANU. Go MAEDA
10:13 Feature #11543: Sort attachments by name
I implemented sorting in the attachments list of Issue and Wiki (I referred to #1718). Name, Description, Author, Created can be sorting.
I have attached a patch.
Issue
!{width:600px;border:1px solid grey;}issue.png!
Wiki
!{wid...
Yuichi HARADA
08:44 Feature #32424: CommonMark Markdown Text Formatting
Marius BALTEANU wrote:
> What do you think about the following plan for this issue?
> ...
I really like this approach. IMHO making the transition while getting usual stuff done in production is a good option for many users.
Bernhard Rohloff
08:39 Feature #32424: CommonMark Markdown Text Formatting
What do you think about the following plan for this issue?
* We introduce this as third text formatting option in version:"5.0.0".
* We mark the existing Markdown as deprecated in the same version.
* We remove the existing Markdown ve...
Marius BĂLTEANU
08:40 Feature #34992 (Closed): Ruby 3.0 support
Ruby 3.0.0 has been released on 25 Dec 2020.
https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/
Go MAEDA
04:59 Defect #33941: Do not use timezone unaware methods
Here is the result of the following command: Go MAEDA
04:31 Feature #34974: Change the default value for "Preferred part of multipart (HTML) emails" from "Text" to "HTML"
Thank you for your feedback.
In our environment, some of the emails we received did not have a proper text part, and often creating issues that did not have the proper content. This is why I needed this feature and suggesting the defa...
Go MAEDA
02:29 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading
Thank you all for working on this.
Marius BALTEANU wrote:
> My proposal is to have these patches committed as soon as possible in order to have enough time to catch and fix other issues caused by this update (this apply also for plug...
Go MAEDA

2021-03-30

18:42 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading
Batch 2. Marius BĂLTEANU
18:42 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading
I'm attaching a patch series (19) that updates Rails to 6.1.3.1 and fixes all the tests on "MySQL":https://gitlab.com/redmine-org/redmine/-/jobs/1140003736 and "PostgreSQL":https://gitlab.com/redmine-org/redmine/-/jobs/1140003740. MS SQL... Marius BĂLTEANU
17:53 Defect #34982: Cannot change the default version and default assignee under settings
I've attached a fix with tests included. Marius BĂLTEANU
16:21 Defect #34982: Cannot change the default version and default assignee under settings
The issue is caused by r20766 which was done for #34032. The form parameter (project_issue_tracking) was changed without processing it in the controller.
The other values for custom fields and trackers are set correctly as the name of t...
Bernhard Rohloff
13:30 Defect #34982 (Confirmed): Cannot change the default version and default assignee under settings
Yes, you are right. I've tested it again.
The issue is not that the versions are not shown but that it flips back to its prior value if you click the save button.
Bernhard Rohloff
12:25 Defect #34982: Cannot change the default version and default assignee under settings
Hi Bernhard,
Thanks for your quick response, I checked out the latest 4.2-stable branch from github, the problem persists, the versions are neither closed or locked, see screenshot below
!versions.png!
I checked the production.l...
Sunding Wei
10:37 Defect #34982 (Needs feedback): Cannot change the default version and default assignee under settings
I cannot reproduce the issue on my production system. Please make sure that the not shown versions are neither locked nor closed. Bernhard Rohloff
08:44 Defect #34982 (Closed): Cannot change the default version and default assignee under settings
Cannot change the default version under settings Sunding Wei
16:18 Feature #34988: Add new notification settings for priority based notification to the user guide
Commented wrong issue... Bernhard Rohloff
14:04 Feature #34988 (New): Add new notification settings for priority based notification to the user guide
Bernhard Rohloff
14:13 Feature #34981: Allow to change a project identifier
> The problem with changing the project identifier is that the identifier is used as part of URLs, so links from outside Redmine will be invalid.
https://gitlab.com/gitlab-org/gitlab-foss has a very similar feature.
1/ a project iden...
Pavel Rosický
14:01 Feature #34981: Allow to change a project identifier
The concept of separate project name and identifier is a useless construct which irritates the user more than it helps him.
I would rather prefer to put more effort in helping the user to find the right identifier for their project. In ...
Bernhard Rohloff
13:46 Feature #34981: Allow to change a project identifier
Many repository integrations (including the bundled @Redmine.pm@ and @reposman.rb@) assume that the repository on the file system is named after the project identifier. These integrations will likely break if the project identifier can b... Holger Just
04:42 Feature #34981 (New): Allow to change a project identifier
Currently, it is not possible to change the identifier of a project. However, you may want to change the project identifier if, for example, you come up with a better identifier later, or if the purpose of the project changes.
The pro...
Go MAEDA
13:54 Feature #32628: Notify users about high issues (only)
If you have a default priority defined, we assume high priority issues to have any priority higher than the defined default. Only of there is no default priority defined, we consider priorities above the "middle" priority to be high.
...
Holger Just
11:58 Feature #32628: Notify users about high issues (only)
Bernhard Rohloff wrote:
> As I understand it the state "higher than ..." is determined by the position of the status in the enumeration list. If it's position is the in higher half of the list it's treated as "higher than ...". So it de...
Mikhail Oleynik
10:54 Feature #32628: Notify users about high issues (only)
As I understand it the state "higher than ..." is determined by the position of the status in the enumeration list. If it's position is the in higher half of the list it's treated as "higher than ...". So it depends on how you sort your ... Bernhard Rohloff
07:47 Feature #32628: Notify users about high issues (only)
Hi!
Could you please help me with using this really cool feature?
We use custom grained issue priorities list in our project. How can I change priority fro this new setting for it to be not "higher than high" but "higher than [some...
Mikhail Oleynik
13:23 Defect #32935: Rails 6: fix set role_ids
Pavel Rosický wrote:
> you're welcome, the last failure is related to https://www.redmine.org/issues/32936
> ...
Sorry, I was blind and I didn't see that I've disabled the test adapter on the @ActiveJob@ and not on the @ActionMailer@. ...
Marius BĂLTEANU
13:02 Defect #32935: Rails 6: fix set role_ids
you're welcome, the last failure is related to #32936
the class attribute isn't inherited to subclasses, that's why your change doesn't work
https://gitlab.com/redmine-org/redmine/-/commit/f0afce30b79c8d54af9d082e4b3883ef8d672c44
...
Pavel Rosický
12:19 Defect #32935: Rails 6: fix set role_ids
Pavel Rosický wrote:
> @marius - I see you've finally started working on this. Just to let you know, there's a mistake in this patch. The removed part simply shouldn't be removed, the rest is ok. I'll send you a few other patches becaus...
Marius BĂLTEANU
12:10 Defect #32935: Rails 6: fix set role_ids
@marius - I see you've finally started working on this. Just to let you know, there's a mistake in this patch. The removed part simply shouldn't be removed, the rest is ok. I'll send you a few other patches because there was a new major ... Pavel Rosický
13:06 Feature #34987 (New): Rails 6.1 destroy async
Rails 6.1 has a new feature that allows associations to be destroyed asynchronously.
https://bigbinary.com/blog/rails-6-1-allows-associations-to-support-destroy_async-option-with-dependent-key
Pavel Rosický
12:30 Defect #34983 (Confirmed): Roadmap tab is missing if there are only inherited from parent project versions
It's caused by #7956.
Marius BĂLTEANU
11:33 Defect #34983 (Closed): Roadmap tab is missing if there are only inherited from parent project versions
It was fine before 4.2.0 so I suppose there were some changes in 4.2.0.
There is a project 'Project Big', it has versions created in settings (every version has 'inherited by subprojects' selected). There is its subproject 'Project Sm...
Mikhail Oleynik
12:22 Defect #34986 (Closed): Ruby 3.0 fix super calls
https://github.com/rails/rails/blob/f855139f3d2bb9b032613279d0adfbd6a77a2d07/activerecord/lib/active_record/persistence.rb#L487
https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/
...
Pavel Rosický
12:14 Defect #34985: Rails 6.1 replace ActiveModel::Errors #<< with #add
refs #29914 Pavel Rosický
12:13 Defect #34985 (Closed): Rails 6.1 replace ActiveModel::Errors #<< with #add
fixes
DEPRECATION WARNING: Calling `<<` to an ActiveModel::Errors message array in order to add an error is deprecated. Please call `ActiveModel::Errors#add` instead.
Pavel Rosický
12:12 Defect #34984 (Closed): Rails 6.1 Rendering actions with '.' in the name is deprecated
refs #29914 Pavel Rosický
11:17 Feature #34974: Change the default value for "Preferred part of multipart (HTML) emails" from "Text" to "HTML"
When receiving a mail, we extract the text part in order to add a journal node or issue description as a Textile or Markdown document. Right now, when there is no plain text part, we use the HTML parsing as a fallback and to try to extra... Holger Just
10:12 Feature #34715: Filter issues by file description
Go MAEDA wrote:
> I think it would be even useful if it is possible to filter issues by attachment file description.
+1
Added "File description" to the Issues Filters.
I have attached a patch.
Yuichi HARADA
01:42 Patch #34969 (Reopened): Remove dependency on MimeMagic
I think it is better to merge the change to older versions for the following reason. Keep using MimeMagic may cause installation trouble in some environments.
Go MAEDA wrote:
> * Simplifies the installation process: Due to "a licensi...
Go MAEDA

2021-03-29

22:15 Defect #34980 (Closed): Fix "undefined method `represent_boolean_as_integer=' for nil:NilClass" in Rails 6.1
Method @config.active_record.sqlite3.represent_boolean_as_integer@ was deprecated in "Rails 6.0":https://guides.rubyonrails.org/6_0_release_notes.html#active-record-deprecations and removed in "Rails 6.1":https://guides.rubyonrails.org/6... Marius BĂLTEANU
10:42 Feature #8965 (Closed): Formatting buttons for edit controls for e-mail headers and footers
Implemented by #8343 (version:4.1.0). Go MAEDA
10:26 Patch #34979 (Closed): French translation update for 4.2-stable
Hello,
Few translations for fr :
- Old labels with no translation
- "Email" > "Courriel"
- Error in translation
- New labels
Brice Beaumesnil
08:31 Feature #34974: Change the default value for "Preferred part of multipart (HTML) emails" from "Text" to "HTML"
Setting the target version to 5.0.0. Go MAEDA
07:53 Defect #34921 (Closed): Do not journalize attachments that are added during a "Copy Issue" operation
Go MAEDA
05:34 Defect #34921 (Resolved): Do not journalize attachments that are added during a "Copy Issue" operation
Committed the fix. Thank you. Go MAEDA
07:52 Revision 20874 (svn): Merged r20872 from trunk to 4.1-stable (#34921).
Go MAEDA
07:50 Revision 20873 (svn): Merged r20872 from trunk to 4.2-stable (#34921).
Go MAEDA
06:05 Feature #31128: Drop Ruby < 2.5 support
The attached patches drop Ruby 2.4 support.
As Marius wrote, Rails 6 requires Ruby 2.5 or later. We have to migrate to Rails 6 in Redmine 5.0 because the support for Rails 5.2 which we are currently using will end when Rails 7.0 (the ...
Go MAEDA
05:32 Revision 20872 (svn): Do not journalize attachments that are added during a "Copy Issue" operation (#34921).
Patch by Jens Krämer. Go MAEDA
05:00 Feature #34337 (Closed): Remove jQuery Migrate
Marius BALTEANU wrote:
> Let's remove this as soon as possible.
Done in r20871.
Go MAEDA
05:00 Revision 20871 (svn): Remove jQuery Migrate (#34337).
Go MAEDA
02:40 Feature #34978: Add the list of supported browsers to docs and drop support for IE 11
I think it is too early to end support for Internet Explorer 11 because not a few people are accessing Redmine with IE11.
I just grep'd our company's Redmine hosting access log and found that 15% of the accesses last week were using I...
Go MAEDA
 

Also available in: Atom