Project

General

Profile

Actions

Patch #23546

open

Issue visibility "watched by, created by or assigned to" for roles

Added by Felix Schäfer over 7 years ago. Updated about 2 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Issues permissions
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:

Description

There's been a bit of discussion (parts of #8488 and other) and some patches already for this or similar (#14318#note-22) and others.

We wanted to contribute our "minimal" solution for this. This is a new ticket to avoid discussing ever more diverging patches on for example #8488.


Files


Related issues

Related to Redmine - Feature #8488: Create an 'Involve' mechanism to private issuesNew

Actions
Related to Redmine - Patch #14318: Watchers Alerted To Changes But Cannot See Issues (potentially)Closed

Actions
Has duplicate Redmine - Feature #27028: Issue's visibility for the watchersClosed

Actions
Has duplicate Redmine - Feature #28223: Lack of access for Watchers if visibility=Issues created by or assigned toClosed

Actions
Has duplicate Redmine - Feature #28614: Issue Watcher view Issue when not in project groupClosed

Actions
Has duplicate Redmine - Feature #32491: Watcher can see tickets independent from issue visibilityClosed

Actions
Actions #2

Updated by Jan from Planio www.plan.io over 7 years ago

  • Related to Feature #8488: Create an 'Involve' mechanism to private issues added
Actions #3

Updated by Jan from Planio www.plan.io over 7 years ago

  • Related to Patch #14318: Watchers Alerted To Changes But Cannot See Issues (potentially) added
Actions #4

Updated by Marius BĂLTEANU over 7 years ago

I tested the patch and seems to work fine only for public projects. If I set the project as private, I can't see the issue anymore as watcher. This is the expected behavior?

Actions #5

Updated by Holger Just over 7 years ago

The patch should work for private projects too. However, in this case, you need to be a member of the project with a role which gives you:

  • the permission to view issues,
  • and the appropriate issue visibility
Actions #6

Updated by Jens Krämer over 7 years ago

Or, in other words - this new issue visibility option (like any of the other issue visiblity options) is not expected to give access to issues in projects where you don't have access to issues through your role's permissions. The goal is just to provide a slightly broader scope compared to the 'issues created by or assigned to the user' option.

Actions #7

Updated by Marius BĂLTEANU over 7 years ago

Jens Krämer wrote:

Or, in other words - this new issue visibility option (like any of the other issue visiblity options) is not expected to give access to issues in projects where you don't have access to issues through your role's permissions. The goal is just to provide a slightly broader scope compared to the 'issues created by or assigned to the user' option.

Thanks, now is clear for me how should work.

Actions #8

Updated by Toshi MARUYAMA over 7 years ago

  • Target version set to 3.4.0
Actions #9

Updated by David Sleeman over 7 years ago

I tested this with MySQL12 and Redmine 3.3.0 and I received a parsing error for users with watched permission for some projects and all issue for other projects. The apache logs claimed a parsing error SQL and the front end showed error 500 when trying to view all issues for all projects. Any suggestions on how to proceed? I'm very keen to see this implemented but my SQL knowledge is quite low.

Actions #10

Updated by Jean-Philippe Lang over 7 years ago

  • Target version deleted (3.4.0)
Actions #11

Updated by Bruno Medeiros about 7 years ago

You may be interested in my last comment on #8488 about this patch.

Actions #12

Updated by Marius BĂLTEANU over 6 years ago

Felix Schäfer, I've started to update the patches used in our instance to apply cleanly to Redmine 3.4.1 and a test from this patch fails (ActiveRecord::RecordInvalid: Validation failed: Assignee is invalid).

I've updated your patch to pass the tests, please take a look on my changes to confirm that are ok (of course, if you want and have the time :) ).

Actions #13

Updated by Go MAEDA over 6 years ago

  • Has duplicate Feature #27028: Issue's visibility for the watchers added
Actions #14

Updated by Mischa The Evil about 6 years ago

  • Has duplicate Feature #28223: Lack of access for Watchers if visibility=Issues created by or assigned to added
Actions #15

Updated by Lara R almost 6 years ago

I am unable to install it.
I tried with these command:
patch -p0 < 23546-watched_or_created_or_assigned_issue_visibility_3.4.1.patch.

I got this error:

can't find file to patch at input line 4_ Perhaps you used the wrong -p or --strip option? The text leading up to this was:

|*** diff Naur app/models/issue.rb ---- File to patch: –

Any ideas?

Actions #16

Updated by Go MAEDA almost 6 years ago

  • Has duplicate Feature #28614: Issue Watcher view Issue when not in project group added
Actions #17

Updated by Marius BĂLTEANU over 5 years ago

  • Has duplicate Defect #29911: [Email Notification] _involved in_ clarification added
Actions #18

Updated by Marius BĂLTEANU over 5 years ago

  • Has duplicate deleted (Defect #29911: [Email Notification] _involved in_ clarification)
Actions #19

Updated by Holger Just over 4 years ago

  • Has duplicate Feature #32491: Watcher can see tickets independent from issue visibility added
Actions #20

Updated by Tomasz Witke about 2 years ago

Hi, any chance for updating this patch for Redmine 4.2? WIth new visibility feature userrs are seeing no tasks

Actions

Also available in: Atom PDF