Project

General

Profile

Actions

Feature #29894

closed

View watchers on the issue list

Added by Go MAEDA over 5 years ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Category:
Issues list
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed

Description

Currently, you have to go to the detail page of an issue if you want to see the list of watchers.

I think it would be nice if Redmine shows watchers for each issue on the issues list. With this feature. This feature is a bit similar to #25515.


Files

watchers.png (229 KB) watchers.png Mizuki ISHIKAWA, 2018-11-16 03:00
feature-29894.patch (7.33 KB) feature-29894.patch Mizuki ISHIKAWA, 2018-11-16 03:12
29894v1.patch (7.39 KB) 29894v1.patch Felix Schäfer, 2024-03-15 19:34
29894-fix-random-test-failure.patch (1006 Bytes) 29894-fix-random-test-failure.patch Go MAEDA, 2024-05-02 11:59

Related issues

Related to Redmine - Feature #36848: API allow display "watchers" when listing several issuesNew

Actions
Related to Redmine - Feature #37973: Enable to display watches count on issues listNew

Actions
Has duplicate Redmine - Feature #12766: Enable arrays and watcher in query column_contentClosed

Actions
Has duplicate Redmine - Feature #6299: Add "watched" as possible column in issues listClosed2010-09-05

Actions
Actions #1

Updated by Mizuki ISHIKAWA over 5 years ago

Looking at watchers at index is useful for knowing issues that users are interested in.

Applying this patch will allow you to add a watchers column with issues / index.
Issue#visible_watchers checks the :view_issue_watchers permission and displays only watchers that can be viewed.

Actions #2

Updated by Bernhard Rohloff over 5 years ago

I think this column gets really messy if you have 10 or more watchers on the list.
I'd also argue that this information isn't useful by any means. Perhaps the count of watchers but not the entire list.

Actions #3

Updated by Yuuki NARA over 5 years ago

+1

Actions #4

Updated by Jens Krämer over 5 years ago

+1

that's indeed useful (and if not, well then do not add this column to your issues list :)

Actions #5

Updated by Go MAEDA over 5 years ago

  • Target version set to Candidate for next major release
Actions #6

Updated by Anonymous over 5 years ago

+1 but I agree with Bernhard

I think this column gets really messy if you have 10 or more watchers on the list.
I'd also argue that this information is useful by any means. Perhaps the count of watchers but not the entire list.

Maybe watcher count, but to show list of watchers in the tool-tip whenever rolling over the number of watchers. The same tool-tip which is used in the gantt or calendar.

Actions #7

Updated by Go MAEDA almost 5 years ago

  • Related to Feature #12644: Display watch status in ticket list added
Actions #8

Updated by Nipun Tharuka about 3 years ago

How to add the patch to Redmine? I'm getting these errors. I'm using Redmine from Bitanmi.

C:\Bitnami\redmine-4.2.1-0\apps\redmine\htdocs>patch p0 < 123.patch
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
-------------------------
|diff --git a/app/helpers/queries_helper.rb b/app/helpers/queries_helper.rb |index 01d10d883c..1d721d7528 100644 |--- a/app/helpers/queries_helper.rb |+++ b/app/helpers/queries_helper.rb
--------------------------
File to patch:

Version Information
---------------------
Environment:
Redmine version 4.2.1.stable
Ruby version 2.6.7-p197 (2021-04-05) [x64-mingw32]
Rails version 5.2.5
Environment production
Database adapter Mysql2
Mailer queue ActiveJob::QueueAdapters::AsyncAdapter
Mailer delivery smtp
SCM:
Git 2.31.1
Filesystem
Redmine plugins:
no plugin installed

Actions #9

Updated by Mizuki ISHIKAWA about 3 years ago

Nipun Tharuka wrote:

How to add the patch to Redmine? I'm getting these errors. I'm using Redmine from Bitanmi.

You can apply the patch with a command like this:

patch -p1 < feature-29894.patch

However, since this patch was written two years ago, I'm not sure if it will work for the current Redmine.

Actions #10

Updated by Go MAEDA about 3 years ago

  • Related to deleted (Feature #12644: Display watch status in ticket list)
Actions #11

Updated by Go MAEDA about 3 years ago

  • Related to Feature #6299: Add "watched" as possible column in issues list added
Actions #12

Updated by Go MAEDA about 2 years ago

  • Related to Feature #36848: API allow display "watchers" when listing several issues added
Actions #13

Updated by Go MAEDA over 1 year ago

  • Related to Feature #37973: Enable to display watches count on issues list added
Actions #14

Updated by Go MAEDA 5 months ago

  • Has duplicate Feature #12766: Enable arrays and watcher in query column_content added
Actions #15

Updated by Holger Just 4 months ago

  • Related to deleted (Feature #6299: Add "watched" as possible column in issues list)
Actions #16

Updated by Holger Just 4 months ago

  • Has duplicate Feature #6299: Add "watched" as possible column in issues list added
Actions #17

Updated by Felix Schäfer 3 months ago

We have tried working on this feature but have noticed different behaviours regarding especially watchers and watcher groups regarding different parts of the UI. We will create additional tickets for these issues.

Regarding the attached patch, we have decided to currently follow exactly the model of the watcher list in the sidebar of a single issue view: If you have the view_issue_watchers permission for a project you can see all watchers, if you do not have the permission you cannot see any watchers. This decision was made to avoid introducing an additional different behaviour from other places handling watchers, and because you can already check which issues you watch yourself using the "Watcher: me" filter.

Actions #18

Updated by Felix Schäfer 3 months ago

Felix Schäfer wrote in #note-17:

We will create additional tickets for these issues.

Other issues that might be relevant to this discussion:
- #40411 users currently cannot always see if they watch an issue because of a group membership
- #40412 users currently cannot filter by watched by group membership if they do not have the view_issue_watchers permission

Actions #19

Updated by Go MAEDA 3 months ago

  • Target version changed from Candidate for next major release to 6.0.0

Felix, thank you for working on this.
I am setting the target version for this issue to 6.0.0.

Actions #20

Updated by Marius BĂLTEANU about 2 months ago

  • Subject changed from View watchers on the issue list to View watchers on the issue list
  • Status changed from New to Resolved
  • Assignee set to Marius BĂLTEANU
  • Resolution set to Fixed

Committed the patch, thanks!

Actions #21

Updated by Go MAEDA about 2 months ago

The test IssuesControllerTest#test_index_with_watchers_column_as_csv randomly fails.
Please review the patch 29894-fix-random-test-failure.patch that fixes the issue.

Failure:
IssuesControllerTest#test_index_with_watchers_column_as_csv [test/functional/issues_controller_test.rb:1984]:
""Redmine Admin
Dave Lopper"" not found in "#,Subject,Watchers
1,Cannot print recipes,"" 
2,Add ingredients categories,"Dave Lopper
Redmine Admin" 
3,Error 281 when updating a recipe,"" 
4,Issue on project 2,"" 
5,Subproject issue,"" 
6,Issue of a private subproject,"" 
7,Issue due today,"" 
9,Blocked Issue,"" 
10,Issue Doing the Blocking,"" 
13,Subproject issue two,"" 
14,Private issue on public project,"" 
" 

bin/rails test test/functional/issues_controller_test.rb:1971
Actions #22

Updated by Marius BĂLTEANU about 2 months ago

  • Status changed from Resolved to Closed

super.sorted triggers lots of queries on my environment. I've committed a different fix in r22808.

Actions

Also available in: Atom PDF