Project

General

Profile

Activity

From 2017-08-14 to 2017-08-16

2017-08-16

22:49 Defect #26708: Diff formatting results empty lines if they contains HTML tags
Live example: Robert Korulczyk
22:48 Defect #26708 (Closed): Diff formatting results empty lines if they contains HTML tags
h2. Steps to reproduce:
In issue description write something like (need to remove space in @< /pre>@):
Robert Korulczyk
18:28 Defect #26705 (Closed): Unable to download file if custom field is not defined as visible to any users
Even if my user account has all available roles (and is also an administrator), i am not able to download custom field file, unless custom field is configured as visible to any users.
I am getting a "403 - You are not authorized to ac...
Thibault Deregnaucourt
17:30 Defect #26702: Getting an internal error when I tried to open up a project.
Just want to apologize.... The database was "initialized" with an earlier version of Redmine. There were so many things that happened in between that I didn't even remember it. Chung Ley
09:01 Defect #26702 (Closed): Getting an internal error when I tried to open up a project.
Check your schema_migrations table. Toshi MARUYAMA
12:35 Defect #26544: SQL-Error occurs sometimes when clicking on "calendar" tab
I am also having this issue: https://www.screencast.com/t/J1ajHPH6fnP Jitendra Chandani
10:29 Patch #26703 (Closed): German translations in 3.4-stable
Hi,
I'm missing some German translations in 3.4.2.
I've made the translations.
Attached is a patch for config/locales/de.yml
Peter Pfläging
04:56 Patch #26682 (New): URL-escape the ! character in generated markup for dropped uploads
I have tested the updated patch (#26682#note-3). Now it works fine in both Markdown and Textile.
Thank you for updating the patch so quickly.
Go MAEDA
02:55 Patch #26655: Additional icon for contextmenu
FYI:
"Mastodon":https://github.com/tootsuite/mastodon (social network server) uses horizontal three dots button for context menu.
!{width: 312px;}.mastodon-context-menu-button@2x.png!
Go MAEDA

2017-08-15

23:39 Defect #26702: Getting an internal error when I tried to open up a project.
This is strange... The "projects" table has the following columns: name, description, homepage, is_public, parent_id, created_on, updated_on, identifier, status, lft, rgt, interit_members and default_version_id.
I swore that I didn't...
Chung Ley
23:09 Defect #26702 (Needs feedback): Getting an internal error when I tried to open up a project.
Make sure projects table has default_assigned_to_id column. Toshi MARUYAMA
22:40 Defect #26702 (Reopened): Getting an internal error when I tried to open up a project.
This is not an upgrade from an earlier release of Redmine...
I installed Redmine 3.4.1; it was working and it stopped working "suddenly" in the sense that I don't recall any changes except that one change with copying the public/dispa...
Chung Ley
22:04 Defect #26702 (Closed): Getting an internal error when I tried to open up a project.
See #26485. Toshi MARUYAMA
21:01 Defect #26702 (Closed): Getting an internal error when I tried to open up a project.
Currently, if I logged on as regular user to my redmine installation of 3.4.1; I can see the list of projects, but when I tried to open any "Project", I got the following: Chung Ley
21:48 Defect #26544: SQL-Error occurs sometimes when clicking on "calendar" tab
I cannot reproduce on my CentOS 7 and Redmine 3.4.2. Toshi MARUYAMA
18:18 Defect #26691: N + 1 queries when rendering the Gantt
Another thing is that, if the issue is updated, then the GanttsController.index action page needs to be refresh, which will reconstruct the project_tree, so there will no problem for the rendering. jwjw yy
17:56 Defect #26691: N + 1 queries when rendering the Gantt
If there is only problem, then some updated issue can be applied to project with the update of issue, such as: jwjw yy
07:20 Defect #26691 (New): N + 1 queries when rendering the Gantt
Thank you for providing the patch.
It is interesting but IMHO, the cache should be invalidated when an issue or a version in the project is updated. With the patch applied, @Project#start_date@ and @Project#due_date@ returns a wrong v...
Go MAEDA
06:12 Defect #26691: N + 1 queries when rendering the Gantt
here is the patch, what I have done is to calculate the start date and due date in a group queries. jwjw yy
04:05 Defect #26691 (Needs feedback): N + 1 queries when rendering the Gantt
Thank you for pointing out the problem and sharing your work.
Could you provide a patch file instead of @project.rb@?
See also:
* [[Patch]]
* [[Contribute]]
Go MAEDA
03:27 Defect #26691 (Closed): N + 1 queries when rendering the Gantt
Rails 4.2.7.1
20000 issues in the database
When rendering the GanttsController.show action, it will issue a lot of queries to get the the start_date and due_date of an project like:
jwjw yy
17:52 Defect #26699: Anonymous user should have their icon
Updated tests. Go MAEDA
17:01 Defect #26699 (Closed): Anonymous user should have their icon
@ApplicationHelper#avatar@ method returns blank string instead of @img@ tag for the anonymous user. The behavior causes disordered layout in IssuesController#show page.
This patch adds an icon for the anonymous user and fixes the brok...
Go MAEDA
14:03 Patch #26655: Additional icon for contextmenu
I am attaching an updated patch, that sets correct colspan when grouping issue lists. Felix Gliesche
12:11 Patch #26682: URL-escape the ! character in generated markup for dropped uploads
Thank you for the review Maeda-san. I had a look at the Markdown generation but completely missed the parenthesis. In addition to that, it turns out that in my previous patch, only the first instance of an exclamation mark would have be... Holger Just
05:05 Patch #26682 (Needs feedback): URL-escape the ! character in generated markup for dropped uploads
'(' and ')' have to be escaped for Markdown formatter.
Holger, would you update the patch to escape those characters?
!{width: 167px; border: 1px solid #ccc;}.parentheses@2x.png!
Go MAEDA
04:34 Patch #26682: URL-escape the ! character in generated markup for dropped uploads
Confirmed the problem. Setting target version to 3.4.3.
Thank you for sharing the patch.
*Before:*
!{width: 280px; border: 1px solid #ccc;}.26682-before@2x.png!
*After:*
!{width: 280px; border: 1px solid #ccc;}.26682-after@2x.png!
Go MAEDA
11:08 Defect #26508: excel have wrong column name at custom field
Randa Bustami wrote:
> thank you for your feedback , but what is the relation between plugins and the custom fields ?
As I said, Redmine core does not provide i18n custom fields feature.
So custom field name should not be translated...
Toshi MARUYAMA
08:06 Feature #26409: Show assignee on gantt
Go MAEDA wrote:
> Marius BALTEANU wrote:
> ...
Sorry for the mistake, it seems that my local repository didn't have the latest changes from the trunk. Now the second patch applies cleanly.
Marius BĂLTEANU
02:34 Feature #26409: Show assignee on gantt
Marius BALTEANU wrote:
> 1. the patch doesn't apply cleanly on the current trunk (r16948).
The patch depends on another patch #20481. Could you try again after applying it?
> ...
I agree with you. Gravatar icon should be shown for...
Go MAEDA
02:20 Patch #26689: Add title to author's and assignee's icon
Marius BALTEANU wrote:
> I'm thinking that adding a title to that icons could help users to understand better the functionality.
You are right, thank you for improving the feature.
Setting target version to 3.4.3 (next minor release...
Go MAEDA

2017-08-14

22:51 Patch #26655: Additional icon for contextmenu
Marius BALTEANU wrote:
> From my knowledge, the drag and drop handlers have a green arrow as icon.
You are right, I am sorry, the 3 dots are used in a theme, and vertical dots are used as drag and drop handlers in Gmail for example too.
Felix Schäfer
22:33 Patch #26655: Additional icon for contextmenu
Felix Schäfer wrote:
> Marius BALTEANU wrote:
> ...
From my knowledge, the drag and drop handlers have a green arrow as icon. Anyway, it is not so important how the dots are displayed, both options look good to me and also, the dots ca...
Marius BĂLTEANU
22:17 Patch #26655: Additional icon for contextmenu
Marius BALTEANU wrote:
> It looks good also with a vertical three dotted icon.
This would be confusing as the vertical dots are already used as drag and drop handlers for trackers, enumerations, statuses and so on.
Felix Schäfer
22:01 Patch #26655: Additional icon for contextmenu
Very nice feature, especially that it will make the context menu available on the mobile.
It looks good also with a vertical three dotted icon.
!vertical.png!
Marius BĂLTEANU
22:48 Patch #26689 (Closed): Add title to author's and assignee's icon
After the release of Redmine 3.4.2 in our company, we received some complains regarding the author and assignee icons (feature added in #25775). Some users thought that is a bug (especially when the author = assignee).
I'm thinking th...
Marius BĂLTEANU
22:13 Feature #26409: Show assignee on gantt
I've tested the patch and I've two observations:
1. the patch doesn't apply cleanly on the current trunk (r16948).
2. it'll be nice to have also gravatar shown for the assignee.
Marius BĂLTEANU
17:01 Patch #26685 (New): Check of child classes of all levels is added for Redmine::SubclassFactory::ClassMethods
SubQuery < Query
NewSubQuery < SubQuery
And I will see "Undefined method new for nil class"
Vladimir Litov
15:52 Feature #26677: HTTP code 401 on login failure
This is not what I obtain with other services (e.g. with Jenkins CI instances), where a 401 code is returned, and presents the usual HTML login form (not through the browser, as the authentication is made through the application, not the... Rémi Saurel
15:42 Feature #26677: HTTP code 401 on login failure
The 401 status code is specifically used for Basic or Digest authentication. It has no value when using form authentication as done with Redmine.
If Redmine would return a 401 here, your browser would ask for authentication with a Bas...
Holger Just
14:05 Feature #26677 (Closed): HTTP code 401 on login failure
When purposely causing a login error on Redmine, I can see (using web inspector and/or logfiles) that the HTTP return code is 200, i.e. "everything is ok", for the page that presents the error to the user.
It would be great if Redmine...
Rémi Saurel
15:46 Feature #23119: Hook for deleted issues
You can already use the basic ActiveRecord callbacks on the @Issue@ model, which include @before_destroy@ and @after_destroy@ callbacks. Please check the "Documentation":http://api.rubyonrails.org/classes/ActiveRecord/Callbacks.html for ... Holger Just
15:44 Defect #26681 (Closed): disk_filename of attachment when issue is created via mail
Toshi MARUYAMA
15:34 Defect #26681: disk_filename of attachment when issue is created via mail
As you can see in the code, we are using the original filename, as long as it follows some strict rules (i.e. only contains ascii characters, numbers, underscore, hyphen and dot). If any other character (including a space) is included in... Holger Just
15:25 Defect #26681 (Closed): disk_filename of attachment when issue is created via mail
Hello,
when an issue with attachment is created via mail, the disk_filename of this attachment get created with an hash-function.
I think this is the code.
\xampp\Redmine\app\models\attachment.rb line 369:
Felix Muster
15:39 Defect #26679 (Needs feedback): Edit Journal - Can't verify CSRF token authenticity
Toshi MARUYAMA
15:37 Defect #26679: Edit Journal - Can't verify CSRF token authenticity
See [[Submissions]]. What exactly are you doing when the error occurs? Please at least show the log entries.
How are you triggering the error? With a browser or with an API client? Which URL are you querying?
Holger Just
14:52 Defect #26679 (Closed): Edit Journal - Can't verify CSRF token authenticity
From View: 402 - Invalid form authenticity token.
Possible solution:
add: config/application.rb
config.action_controller.allow_forgery_protection = false
Adriano Baptistella
15:26 Patch #26682 (Closed): URL-escape the ! character in generated markup for dropped uploads
In #26071, we introduced the ability to just drag an image into a textbox and have Redmine generate the correct image markup for the uploaded file for easy inclusion.
Unfortunately, the @!@ character in the filename is not escaped he...
Holger Just
14:55 Feature #26680 (New): Show default assignee when creating new issue
With new redmine version, 3.4, a default assignee can be specified (which is great).
However, contrary to a stipulated default target version, the stipluated default assignee does show up when creating a new ticket:
!DefaultAssigne...
Andreas Deininger
14:32 Defect #26678 (Closed): Custom field required not work with 3.4.2
I cannot reproduce.
Please use forum for question.
Toshi MARUYAMA
14:17 Defect #26678 (Closed): Custom field required not work with 3.4.2
I created a custom field and setup in the workflow as required during some status and not worked.
But Setting default field as required worked.
I also tried 3.3.2 and still same.
James Wang
14:29 Defect #26665: comment button in wiki editing page not work
I had thought this comment is like "comment_form from this plugin":https://www.r-labs.org/projects/r-labs/wiki/Wiki_Extensions_en.
Sorry waist your time!Thanks.
James Wang
08:34 Defect #26665 (Closed): comment button in wiki editing page not work
You can see "comment" in wiki history.
https://www.redmine.org/projects/redmine/wiki/Overview/history
Toshi MARUYAMA
07:39 Defect #26665: comment button in wiki editing page not work
After inputting test like below
!{width:500px}inputting.png!
I got nothing like below
!{width:500px}submitted.png!
James Wang
12:09 Feature #4511: Allow adding user groups as watchers for issues
Stephane Lapie wrote:
> The fix is committed to my github.
Stephane, thanks for your efforts.
> ...
I just installed the master of your github project on an fresh Redmine 3.4.2 instance, and yes, I can confirm that the plugin is...
Andreas Deininger
11:38 Patch #26674 (Closed): Add CSS classes to column headers of issues and timelogs list
For now there no any chances to style table headers for several columns becouse there no any css classes (it just <th> with column caption)
In patch I offer to add two classes: @query-column-header@ and @query-column-header-#{column.name}@
Dmitry Lisichkin
07:58 Patch #26671 (Closed): Use the new pagination style in gantt
This patch applies the new pagination style introduced by #21258.
I think it would be better to use this style in gantt to improve consistency and usability.
**Before:**
!{width: 785px;border: 1px solid #ccc;}.pagination-before@2x....
Go MAEDA
03:17 Feature #26648: Show transparency grid when previewing images
Let's deliver this feature in 4.1.0. Go MAEDA
 

Also available in: Atom