Project

General

Profile

Activity

From 2018-09-29 to 2018-10-01

2018-10-01

22:54 Feature #26791: Send individual notification mails per mail recipient
Jean-Philippe Lang wrote:
> Thanks Marius, your patch applies cleanly but I get a few test failures: IP address is blank in security notifications.
Sorry Jean-Philippe, I'm not sure how to fix the failing test and I need more time to...
Marius BĂLTEANU
21:35 Feature #26791: Send individual notification mails per mail recipient
Thanks Marius, your patch applies cleanly but I get a few test failures: IP address is blank in security notifications. Jean-Philippe Lang
17:25 Feature #26791: Send individual notification mails per mail recipient
Holger, can you take a look to my updated patch or update your first patch to apply cleanly? Marius BĂLTEANU
21:49 Defect #29708 (Closed): Wrong use of refute_includes in tests
The "@refute_includes@ assertion":https://www.rubydoc.info/gems/minitest/5.11.3/Minitest/Assertions#refute_includes-instance_method expects the @collection@ first and the @object@ to test for after. The test in source:/trunk/test/functio... Felix Schäfer
21:39 Defect #26023: Category filter only shows categories of current project
Takaki-san thank you very much for your tests, I have been able to integrate them in my patch. I hope you will be mentioned as author of this patch too.
I have reworked two small syntax details in the patch. I have also noticed a visi...
Felix Schäfer
17:31 Feature #29660: Add Referrer-Policy header to prevent browsers from sending private data to external sites
The most secure variant would probably be @strict-origin-when-cross-origin@ which seems to be supported by the same current set of commonly used browsers which support @origin-when-cross-origin@. Compared to the shorter option, the stric... Holger Just
10:05 Feature #29660: Add Referrer-Policy header to prevent browsers from sending private data to external sites
This seems to be a sensible improvement. It does not impact the behavior for users on IE/Edge, but it improves privacy for users of Chrome, Firefox, Safari.
I also agree, that using an HTTP header is the better option.
However, I a...
Gregor Schmidt
16:59 Defect #29686 (Closed): Date format in issues pages
This interface is rendered by your webbrowser (where available) and thus usually follows the interface conventions of your operating system.
In the case of Firefox, the browser seems to use settings based on the locale of your operati...
Holger Just
16:39 Defect #29706 (Needs feedback): Unable to setup filter for query
When filtering issues, Redmine by default shows all open issues (i.e. all issues with a status which is not defined as closed) This should look like this:
!filter@2x.png!
To chose a specific status, yu can select *is* and define th...
Holger Just
13:26 Defect #29706 (Closed): Unable to setup filter for query
We have Redmine 3.4.6.
When trying to create a custom query, cannot setup a filter for a query.
For example, if I wanted to create a query that showed all open issues, you would choose a filter on the field 'Status' and then criteria w...
mark f
13:52 Patch #29696 (Closed): Japanese translation update (r17530)
Committed. Go MAEDA
13:52 Revision 17558 (svn): Japanese translation update (#29696).
Patch by Go MAEDA. Go MAEDA
12:02 Patch #29702 (Closed): Brazilian wiki help translation update
Committed the patch translated by Patrick Kaminski.
Thank you for your contribution.
Go MAEDA
05:42 Patch #29702 (Closed): Brazilian wiki help translation update
Copied from #29698. Go MAEDA
12:00 Revision 17557 (svn): Brazilian wiki help translation update for 3.3-stable (#29702).
Patch by Patrick Kaminski. Go MAEDA
11:54 Revision 17556 (svn): Brazilian wiki help translation update for 3.4-stable (#29702).
Patch by Patrick Kaminski. Go MAEDA
11:43 Feature #2770: Display of inline attached images in email notification
+1. Is there an update about this issue? Erich Balan
11:43 Patch #28509: hu.yml for Redmine 3.4
It is the only sane order so that we can use tools like _vimdiff -o hu.yml en.yml_ and see the related strings together so that we can guess the context and use a consistent style.
It's a huge work: complete (at the time) translation (a...
Greg T
11:09 Defect #29581: Issues in paginated views may be lost because sorting criteria are not unique
Setting target version to 4.1.0. Go MAEDA
11:00 Patch #29395: Pagination between repository entries and attachments of the same container
Felix Gliesche wrote:
> Here is an update to the patch, that should fix the before mentioned case.
Thank you for updating the patch. But I could not find differences between before and after applying 0004-Let-pagination-always-be-vis...
Go MAEDA
07:31 Revision 17555 (svn): Brazilian wiki help translation update (#29702).
Patch by Patrick Kaminski. Go MAEDA
05:58 Patch #29703 (Closed): Brazilian translation (jstoolbar-pt-br.js) update
Go MAEDA
05:56 Patch #29703: Brazilian translation (jstoolbar-pt-br.js) update
Committed the patch translated by Patrick Kaminski.
Thank you for your contribution.
Go MAEDA
05:44 Patch #29703 (Closed): Brazilian translation (jstoolbar-pt-br.js) update
Copied from #29698. Go MAEDA
05:55 Revision 17554 (svn): Merged r17552 from trunk to 3.3-stable (#29703).
Go MAEDA
05:54 Revision 17553 (svn): Merged r17552 from trunk to 3.4-stable (#29703).
Go MAEDA
05:52 Revision 17552 (svn): Brazilian translation (jstoolbar-pt-br.js) update (#29703).
Patch by Patrick Kaminski. Go MAEDA
04:15 Defect #29701 (Closed): Custom queries are broken by updating with nil parameter values
Steps to reproduce:
1. Open the issues list and move some columns to "Selected Columns" list box in the filter options. In the screenshot below, "Start date" and "Due date" is the column. You will see those 2 columns in the issues lis...
Go MAEDA
00:30 Defect #28609 (Closed): Error 404 on configure plugin
Please contact the author of those plugins. Go MAEDA

2018-09-30

21:07 Revision 17551 (svn): Padding needs to be removed too
Jean-Philippe Lang
21:06 Revision 17550 (svn): Remove margin before and after preview
Jean-Philippe Lang
18:46 Patch #29698 (Closed): Brazilian translation update
Hello everyone!
I'm sending 4 patches with updates for the Brazilian Portuguese translation...
* pt-BR
* jstoolbar
* wiki markdown
* wiki textile
Patrick Kaminski
18:42 Revision 17549 (svn): Removes unneeded background.
Jean-Philippe Lang
18:41 Feature #26237: Support wiki_page_title attribute in Versions REST API
Is it possible to get this in 4.0.0? It's a small fix, so I guess it's not a problem to change the target release. Kenan Dervisevic
18:33 Revision 17548 (svn): Fixed that changing tabs in project settings unselect "Write" tab of project description textarea (#27758).
Jean-Philippe Lang
18:32 Feature #24681 (Closed): Syntax highlighter: replace CodeRay with Rouge
I'm closing this because the unwanted change was reverted by r17537. Marius BĂLTEANU
18:27 Revision 17547 (svn): Reduces margin between buttons.
Jean-Philippe Lang
18:12 Revision 17546 (svn): Removes space between tabs and textarea (#27758).
Jean-Philippe Lang
17:51 Revision 17545 (svn): Added the list of supported languages on redmine.org (#24681).
Go MAEDA
15:33 Patch #29697 (Closed): Czech translation fixes
Committed. Thank you for improving Redmine. Go MAEDA
15:22 Patch #29697 (Closed): Czech translation fixes
Separated translation change from #28372. Go MAEDA
15:33 Revision 17544 (svn): Czech translation fixes (#29697).
Patch by Karel Pičman. Go MAEDA
15:29 Patch #28372 (Closed): Czech translation update
Committed. Thank you for your contribution. Go MAEDA
15:27 Patch #28372: Czech translation update
Separated translation changes to #29697.
This issue handles a newly translated string.
Go MAEDA
15:29 Revision 17543 (svn): Czech translation update (#28372).
Patch by Karel Pičman. Go MAEDA
14:34 Patch #28509: hu.yml for Redmine 3.4
Thank you for your contribution. But the file is hard to check because translation keys are reordered. Please don't reorder keys in the file and could you provide a diff file? Go MAEDA
14:16 Patch #29696 (Closed): Japanese translation update (r17530)
Translated the following strings.
* label_ldaps_verify_none
* label_ldaps_warning
* label_nothing_to_preview
Go MAEDA
11:58 Feature #8016: Drag-and-drop issue (ticket) ordering
+1 Nadav Kavalerchik
11:47 Revision 17542 (svn): Moves style to jstoolbar.css (#27758).
Jean-Philippe Lang
11:45 Revision 17541 (svn): Adds style to the empty preview message (#27758).
Jean-Philippe Lang
11:39 Defect #29695 (New): Duplicated assignee option when selecting a category with default assignee
1. Go to a project with a default category assignee
2. Go to new issue page
3. Select the category with the default assignee
4. Open the Assignee dropdown
5. Observe that the default category assignee is duplicated in the dropdown.
...
Marius BĂLTEANU
11:33 Revision 17540 (svn): Update french translation.
Jean-Philippe Lang
11:32 Revision 17539 (svn): Update the style of JQuery dropdown menu (#24681).
Jean-Philippe Lang
11:24 Feature #26791: Send individual notification mails per mail recipient
My last shot. Marius BĂLTEANU
11:14 Feature #26791: Send individual notification mails per mail recipient
Jean-Philippe Lang wrote:
> Thank you Marius, but still I get many conflicts when trying to apply your patch on current trunk.
Let me take a look, maybe I missed something.
Marius BĂLTEANU
11:13 Feature #26791: Send individual notification mails per mail recipient
Thank you Marius, but still I get many conflicts when trying to apply your patch on current trunk. Jean-Philippe Lang
11:20 Revision 17538 (svn): Add a checkbox to create the wiki page with or without parent (#26043).
Jean-Philippe Lang
11:13 Defect #29694 (New): Some buttons in wiki toolbar are hidden in responsive layout
#27758#note-8 by Marius BALTEANU:
> on responsive mode, when the screen resolution width in less than the total width of the js toolbar (tabs + buttons), some buttons become hidden. I'm not happy with the current solution, but is not a ...
Go MAEDA
11:10 Revision 17537 (svn): Reverts unwanted change.
Jean-Philippe Lang
11:01 Feature #27758 (Closed): Adds preview option to the wiki toolbar
Marius BALTEANU wrote:
> IMHO, we can deliver this as it is and we'll fix it in the next minor release when for sure we will have other small improvements to be done for this feature.
I agree with you. Since it is a small issue, it s...
Go MAEDA
09:19 Feature #27758: Adds preview option to the wiki toolbar
Go MAEDA wrote:
> Takeshi Nakamura wrote:
> ...
I know the issue, I've mentioned about this in note-8 ("- on responsive mode, when the screen resolution width in less than the total width of the js toolbar (tabs + buttons), some button...
Marius BĂLTEANU
06:11 Feature #27758 (Reopened): Adds preview option to the wiki toolbar
Takeshi Nakamura wrote:
> Toolbar buttons are not wrapped when the screen is narrow.
Marius, could you look into this?
Go MAEDA
06:06 Feature #27758: Adds preview option to the wiki toolbar
Toolbar buttons are not wrapped when the screen is narrow.
*Redmine 4.0*
!toolbar-4.0.png!
*Redmine 3.4*
!toolbar-3.4.png!
Takeshi Nakamura
06:01 Defect #29259: Attachment preview does not work for some source files such as JavaScript and Go
Since we have moved from CodeRay to Rouge, we cannot use the proposed @is_code@ method. Go MAEDA
05:57 Defect #20758 (Closed): Ampersand+keyword in code highlighting
The bug that "&" is changed to "x%x%" in the text passed to the syntax highlighter has been fixed in r17532. Please see source:trunk/lib/redmine/wiki_formatting/textile/formatter.rb@17532#L128
Please note that Redmin...
Go MAEDA
04:45 Revision 17536 (svn): Updated the "Code highlighting" section in wiki help as the syntax highlighter was replaced with Rouge (#24681).
Go MAEDA

2018-09-29

23:53 Defect #26708 (Closed): Diff formatting results empty lines if they contains HTML tags
Fixed by the migration to Rouge (#24681).
using CodeRay:
!before.png!
after migration to Rouge:
!after.png!
Marius BĂLTEANU
23:46 Feature #26791: Send individual notification mails per mail recipient
I took the liberty to update the first patch to apply cleanly on the current trunk just in case of Holger Just or some else from Plan.io team do not have the time to do it until the new release. All tests pass and the rest of the patches... Marius BĂLTEANU
09:55 Feature #26791: Send individual notification mails per mail recipient
Because of r17269, the patch does not apply cleanly. Could you update it so we can commit this change? Thanks. Jean-Philippe Lang
19:59 Feature #24681 (Reopened): Syntax highlighter: replace CodeRay with Rouge
r17532 comments out the gem 'puma', please see source:trunk/Gemfile#L92 and I don't think that it is a desired change. Marius BĂLTEANU
18:18 Feature #24681: Syntax highlighter: replace CodeRay with Rouge
Thank you Go MAEDA for not giving up this feature and everyone else who contributed to the patch being merged. Adrien Crivelli
08:57 Feature #24681 (Closed): Syntax highlighter: replace CodeRay with Rouge
Thanks for fixing this issue, patch is committed. Jean-Philippe Lang
12:47 Patch #29692: Bosnian localization update
Additional typos fixed Kenan Dervisevic
12:33 Patch #29692 (Closed): Bosnian localization update
Patch to update Bosnian translation is attached
* All untranslated text translated
* Typos fixed
* Standardize different namings of the values
Kenan Dervisevic
11:22 Revision 17535 (svn): Removed message to stdout (#28934).
Jean-Philippe Lang
11:19 Revision 17534 (svn): SQLite3::ConstraintException
Jean-Philippe Lang
11:06 Revision 17533 (svn): Update the list with popular languages (#24681).
Jean-Philippe Lang
10:28 Patch #1651 (Closed): Hack to make redmine use pygmentize instead of CodeRay
In the upcoming Redmine 4.0, such a hack is no longer necessary because the new syntax highlighter supports a large number of programming languages. Please see #24681 for details. Go MAEDA
10:17 Feature #28094 (Closed): Kotlin code highlight support
Implemented in #24681 for upcoming Redmine 4.0.0. Go MAEDA
10:12 Feature #1313 (Closed): Optionally use ultraviolet for syntax highlighting
The syntax highlighter has been replaced with Rouge in #24681 and it supports most popular languages.
https://github.com/jneen/rouge/wiki/List-of-supported-languages-and-lexers
Go MAEDA
10:06 Feature #3032 (Closed): Use google Prettify for syntax highlighting instead of CodeRay
The syntax highlighter has been replaced with Rouge in #24681 and it supports most popular languages.
https://github.com/jneen/rouge/wiki/List-of-supported-languages-and-lexers
Go MAEDA
09:29 Feature #2623 (Closed): C# syntax highlighting
Implemented in #24681 for upcoming Redmine 4.0.0. Go MAEDA
08:57 Revision 17532 (svn): Syntax highlighter: replace CodeRay with Rouge (#24681).
Patch by Go MAEDA. Jean-Philippe Lang
04:16 Feature #29660: Add Referrer-Policy header to prevent browsers from sending private data to external sites
Maybe adding Referrer-Policy header is preferable rather than adding a meta-tag for the following reasons.
* We can ensure that the header is always set
* Sysadmins can easily override the header by configuring web servers if necessary
Go MAEDA
03:14 Feature #2529: Extend Issue Summary to include subprojects
I have looked the patch attachment:feature_2529_v2.patch.
The patch passes an array of subprojects to @with_subprojects@ parameter in @Issue.count_and_group_by@, but the parameter is supposed to be true or false. I suggest updating th...
Go MAEDA
01:45 Feature #23392: Link to remove a subtask from its parent task
Here is a screenshot of the patch.
!{width: 797px; border: 1px solid #ccc;}.remove-subtask-button@2x.png!
Go MAEDA
00:47 Feature #23392: Link to remove a subtask from its parent task
The patch adds a button to remove subtask in the "Subtasks" section of an issue. Since the button looks consistent with existing buttons in "Related issues" section, I am in favor of merging the patch.
But I am not sure if it is OK wi...
Go MAEDA
 

Also available in: Atom