Project

General

Profile

Activity

From 2019-09-21 to 2019-09-23

2019-09-23

22:01 Patch #30999: Datepicker javascript files locale in uppercase not found
Hi,
This issue happens in one of my plugins : https://github.com/Smile-SA/redmine_datetime_custom_field/issues/1
To be clear, all the localized versions of this file are lowercase, except for *en-GB*.
This is the reason it fails jus...
Jérôme BATAILLE
19:03 Defect #32121: Create a new user via REST api Users by adding Projects and roles in the same way
Thanks to Serge PACCALIN for his help on the POSTMAN software and for the php script ! :-) Emmanuel PRIZZI
18:53 Defect #32121 (Closed): Create a new user via REST api Users by adding Projects and roles in the same way
Hello,
I want to create a new user in redmine via REST API Users and add him into a project and role.
How to do that with the REST API Users ? http://www.redmine.org/projects/redmine/wiki/Rest_Users
DO i have to use memberships REST A...
Emmanuel PRIZZI
16:10 Feature #32119 (Closed): Add TOC to wiki formatting help
Wiki formatting help contains a lot of information but it does not have a TOC at the beginning of the page. So, it is a bit difficult to find the information what you want.
Adding TOC can solve the problem. The attached patch is just ...
Go MAEDA
11:20 Defect #32104: Calendar layout doesn't fit with the width
Fails on IE11 even after zoom out, while Chrome only fails after zoom in. Taine Woo
09:25 Patch #32013: Rounded corners of the main menu
Antonio McDeal wrote:

> ... I already did a fix to this in #32100 but I guess Bernhard's version of this patch here is a bit better, so I will update the second patch in #32100 to bounce off the new circumstances as well :D
Oh sor...
Bernhard Rohloff
07:58 Patch #32013: Rounded corners of the main menu
Bernhard Rohloff wrote:
> I've discovered a little flaw in the patch. It sets the border radius for the items in the dropdown menu, too. I don't think this was intended by Antonio. Attached is a patch to fix it. It also refactors the pr...
Anonymous
06:52 Patch #32013 (Reopened): Rounded corners of the main menu
I've discovered a little flaw in the patch. It sets the border radius for the items in the dropdown menu, too. I don't think this was intended by Antonio. Attached is a patch to fix it. It also refactors the previous patch as the border ... Bernhard Rohloff
08:49 Feature #32116 (Closed): Add configured theme to Redmine::Info
*Administration | Information*
Displays various info about system, but doesn't display which theme is currently being used.
Aleksandar Pavic
05:52 Patch #32115: Move search bar and project selector to the top bar
Go MAEDA wrote:
> Thank you for posting the patch.
> ...
Thanks for the feedback, but as I mentioned, this patch is a "preparation for #31353" which means, no way will it not look crowded in medium-sized windows until something like la...
Anonymous
03:23 Patch #32115: Move search bar and project selector to the top bar
Thank you for posting the patch.
But it does not look so nice in medium-sized windows. At 1024px width, the top menu is very crowded.
!{width: 1024px; border: 1px splid #ccc;}.1024px.png!
Go MAEDA
04:35 Patch #32015 (Closed): Rounded corners of "my page" blocks
Committed the patch. Thank you. Go MAEDA
04:14 Patch #32015: Rounded corners of "my page" blocks
LGTM. It makes styles consistent. I think the change should have done in r14631.
Setting the target version to 4.1.0.
Go MAEDA
04:35 Revision 18505 (svn): Rounded corners of "my page" blocks (#32015).
Patch by Antonio McDeal. Go MAEDA
04:08 Patch #32099: Fix inconsistent gap sizes on My page
Thank you for the explanation.
The current style may be an intended one, so I am assigning this issue to JPL.
Go MAEDA
00:03 Feature #31353: Replace user related links in the top menu bar with a proper user menu.
Marius BALTEANU wrote:
> You can test the attached patch, I'm not very happy with the implementation, but for a first round of feedback, it should be good enough.
I don't know why you re not very happy with current implementation, bu...
Anonymous

2019-09-22

23:51 Patch #32115 (New): Move search bar and project selector to the top bar
I made this quick patch more as some kind of preparation for #31353 (you may also add to this ticket to #31353 as related).
I think search bar and project selector elements will make more sense in the top bar, if avatar with user option...
Anonymous
23:04 Patch #32114: Give project list cards the same background like grid cells in many other views
I made a typo in the title-> it must be "grid cells in many *+other+* views" someone please correct :D Anonymous
23:03 Patch #32114 (New): Give project list cards the same background like grid cells in many other views
The color #f6f6f6 is used in other grid cells nearly everywhere else now.
IMHO by giving that same background to project cards as well, they start to feel a little bit less hollow than before.
!projectcardsbg.png!
Anonymous
10:49 Defect #32110: "already initialized constant Redmine::Scm::Adapters::SubversionAdapter::SVN_BIN" warning when executing rake tasks
I found that the following change fixes the warning. Go MAEDA
08:31 Defect #32110 (Closed): "already initialized constant Redmine::Scm::Adapters::SubversionAdapter::SVN_BIN" warning when executing rake tasks
Go MAEDA
08:41 Patch #31971: Change the color of the input field frame when in focus
Setting the target version to 4.1.0. Go MAEDA
07:33 Defect #30431: Useless "Delete issues" tracker permission is shown on the role page for Anonymous and Non-member
LGTM but I propose a slight change as follows. Using @&@ operator is simpler and much faster than using @delete_if@. Go MAEDA
07:33 Patch #32109: Obey sub-task sharing settings on new issue creation
Attaching the patch as file as description got screwed. Andrey Galkin
07:31 Patch #32109 (New): Obey sub-task sharing settings on new issue creation
There have been previous efforts to improve sub-task management, but they lack support for cross-project sharing setting.
Below is a patch which has been tested manually. Some extra test case are desired, but I would be unable to hel...
Andrey Galkin
06:04 Feature #29482: Query system for Projects page
Yuuki NARA wrote:
> +1
+1 because Yuuki NARA +1ed ;D
Anonymous
05:09 Feature #29482: Query system for Projects page
+1
Yuuki NARA
05:57 Patch #32099: Fix inconsistent gap sizes on My page
Go MAEDA wrote:
> I tried the patch but could not find the difference. Could you describe what the patch improves?
Current trunk without this patch will have 3 kinds of differently sized gaps between blocks on My page
!unpatchedga...
Anonymous
03:33 Patch #32099: Fix inconsistent gap sizes on My page
I tried the patch but could not find the difference. Could you describe what the patch improves? Go MAEDA
05:29 Patch #32106: Slightly restyled ajax loading indicator
Go MAEDA wrote:
> I think it is better to show the indicator at the center of the page than at the top of the page.
> ...
Your re absolutely right, and it's how it mostly used to be done back then I believe, but -IMHO- IMHXP (in my hum...
Anonymous
03:55 Patch #32106: Slightly restyled ajax loading indicator
I think it is better to show the indicator at the center of the page than at the top of the page.
Suppose that the user right-clicks the issues list. Since the indicator is now positioned at the center of the page, it stands out well....
Go MAEDA
00:20 Patch #32106 (New): Slightly restyled ajax loading indicator
This patch sticks indicator to the very top and adds some new styling to it.
!ajax-indicator.PNG!
Anonymous
01:43 Feature #32108 (New): Option in core or plugin which convert file from MS Excel or LibreOffice to redmine table
Hi,
Where can I find some plugin which convert files ods (LibreOffice) or xls (Microsoft Office) to redmine table?
For now, I and my friends are using my own tool (https://www.s2rc.miszczyk.dev) but it is very old (about 4 years) a...
Tadeusz Miszczyk
00:55 Defect #32107 (New): Stuck tool-tips on My page when attempting to reposition widgets
When attempting to drag and reposition widgets on My page, the new tool-tips with "Move" caption added by #31441 get stuck. Anonymous

2019-09-21

22:52 Patch #32105 (New): Context menu to match the rest of the flyout styling
This patch:
- Sets fly-out context menu to have border radius of 3px (instead of formerly 2px)
- Removes some unnecessary styling rules from *ul* and *li* elements, instead moving them to their far inner *a* children elements instead w...
Anonymous
18:45 Patch #32100: Fixed and added roundiness to the "plus" (+) flyout menu and it's child elements
Marius BALTEANU wrote:
> but I don’t see a real benefit for making also the hover element rounded in the fly-out menu.
Hence why I also added the _fix-roundiness-on-plus-menu-without-menuchild-roundiness.patch_, in case menu child roun...
Anonymous
10:55 Patch #32100: Fixed and added roundiness to the "plus" (+) flyout menu and it's child elements
I like the rounded tabs for the main menu, but I don’t see a real benefit for making also the hover element rounded in the fly-out menu. That menu is more like a select/dropdown. Marius BĂLTEANU
01:44 Patch #32100: Fixed and added roundiness to the "plus" (+) flyout menu and it's child elements
Alternative, simpler patch which only adds roundness to the bottom of the fly-out menu and removes on-hover roundness from children elements inside it. Anonymous
17:54 Revision 18504 (svn): code cleanup: rubocop: fix Performance/Casecmp in lib/redmine/scm/adapters/bazaar_adapter.rb
Toshi MARUYAMA
17:54 Revision 18503 (svn): code cleanup: rubocop: fix Performance/Casecmp in lib/redmine/codeset_util.rb
Toshi MARUYAMA
17:16 Patch #31971: Change the color of the input field frame when in focus
I tried out the patch with Firefox. It made the appearance nicer but I round a problem. Input fields have rounded corners, but the corners of the outline are not rounded.
!{border: 1px solid #ccc;}.corners-not-rounded.png!
How ab...
Go MAEDA
10:38 Patch #31971: Change the color of the input field frame when in focus
kim kk wrote:
> Subjectの部分を一回目クリックした場合は、
> ...
Do you mean that the patch breaks the auto-complete feature? I could not reproduce the problem. The patch changes only the appearance of elements, so I think it does not affect auto-comple...
Go MAEDA
16:41 Feature #31879: "starts with" and "ends with" filter operators for string values
Marius BALTEANU wrote:
> Why not just @^@/@$@ which are used in regex syntax or Lucene syntax? Using CSS selector syntax for text searching is not common.
Nice idea. I have updated the patch.
Go MAEDA
11:06 Feature #31879: "starts with" and "ends with" filter operators for string values
Yuichi HARADA wrote:
> I added "starts with" and "ends with" filter operators. These filter operator symbols mimics the CSS selectors.
> ...
Why not just @^@/@$@ which are used in regex syntax or Lucene syntax? Using CSS selector synta...
Marius BĂLTEANU
16:14 Revision 18502 (svn): code cleanup: rubocop: fix Style/RedundantConditional in app/helpers/issues_helper.rb
Toshi MARUYAMA
16:11 Revision 18501 (svn): rubocop: disable Naming/BinaryOperatorParameterName
Toshi MARUYAMA
16:11 Revision 18500 (svn): rubocop: disable Rails/HelperInstanceVariable
Toshi MARUYAMA
16:10 Revision 18499 (svn): rubocop: remove app/helpers/issues_helper.rb from Style/NestedTernaryOperator fixed by r18496
Toshi MARUYAMA
15:06 Defect #32063: 'use strict' in inlineAutoComplete causes error on Poltergeist
Marius BALTEANU,
Thank you for explanation, and I agree your opinion.
I don't know other browser with the problem. I think this issue shall be rejected.
Tatsuya Saito
11:48 Defect #32063 (Needs feedback): 'use strict' in inlineAutoComplete causes error on Poltergeist
I don’t think we should write old JS syntax only to make the code compatible with PhantomJS which is no longer under active development. Also, Redmine is using Selenium with Chrome driver for system tests starting with version 4.
Reg...
Marius BĂLTEANU
13:10 Feature #27314: Remove the 'Administration' index page and jump right into settings
Go MAEDA wrote:
> I don't prefer the proposed change. The index is intuitive for users, and they don't always want to create a project.
I don't think that the index page is intuitive at all. It's an empty white page with only a few c...
Bernhard Rohloff
07:53 Feature #27314: Remove the 'Administration' index page and jump right into settings
I don't prefer the proposed change. The index is intuitive for users, and they don't always want to create a project. Go MAEDA
11:58 Feature #23954: Shows the date of the last activity on Projects administration
I think we should add this column on top of #29482. Marius BĂLTEANU
06:02 Feature #23954: Shows the date of the last activity on Projects administration
It worked on Redmine trunk with the same changes. note-11
Attach a screen copy of my environment.
Last activity is not displayed for projects with 0 tickets.
However, as it can be seen from the Created column, I think that it is en...
Yuuki NARA
09:52 Feature #32052 (Closed): Auto-complete issues #id in search form
Committed the patch. Thank you for your contribution. Go MAEDA
09:52 Revision 18498 (svn): Auto-complete issues #id in the search form (#32052).
Patch by Mizuki ISHIKAWA. Go MAEDA
09:11 Defect #32104: Calendar layout doesn't fit with the width
!cal_overflow.png! Taine Woo
09:08 Defect #32104 (Closed): Calendar layout doesn't fit with the width
On Redmine4.0.3, If i set the display resolution as a smaller mode such as 1280*720, the layout of Calendar will overflow.
This issue pass on 4.0.2
Taine Woo
08:39 Revision 18497 (svn): code cleanup: rubocop: fix Rails/Blank in app/helpers/issues_helper.rb
Toshi MARUYAMA
08:39 Revision 18496 (svn): code cleanup: rubocop: fix Style/MultilineTernaryOperator in app/helpers/issues_helper.rb
Toshi MARUYAMA
08:32 Revision 18495 (svn): code cleanup: rubocop: fix Layout/MultilineArrayBraceLayout in test/unit/repository_bazaar_test.rb
Toshi MARUYAMA
08:12 Feature #17907: Give 'version' another meaning
redmine_message_customize plugin has been created.
You can use this to override the term from the administration screen.
https://github.com/ishikawa999/redmine_message_customize
http://www.redmine.org/issues/29164#note-5
Yuuki NARA
07:23 Feature #3099: Last activity time window.
+1
Thanks for great patches
I don't want to repeat the blank history.
Note.
If the following patches have been applied, only two files need to be changed.
https://www.redmine.org/issues/23954#note-11
controllers/activities_...
Yuuki NARA
 

Also available in: Atom