Activity
From 2019-10-18 to 2019-10-20
2019-10-20
-
17:25 Patch #32308 (Closed): Rubocop: Performance/RedundantBlockCall: Use yield instead of block.call.
-
17:04 Feature #32302: Filter projects after bookmarks
- Here is the patch, I think we can commit it as part of #29482 and #31355.
-
01:13 Feature #32302: Filter projects after bookmarks
- Since we already have "<< my projects >>" in Project filter, the filter seems the right place to add "<< my bookmarks >>".
-
15:14 Defect #32307 (Closed): AttachmentsControllerTest#test_thumbnail_for_pdf_should_be_png fails if ImageMagick convert is not available
- To reproduce it, set invalid value to imagemagick_convert_command in configuration.yml and run attachments_controller_test.rb.
-
14:26 Feature #32306 (Closed): Add a link to projects administration page on projects page
- This patch adds a link to the projects administration page (/admin/projects) on the projects page in order to improve usability.
The current projects page has "New project" button, but does not have any other administrative buttons su... -
14:23 Defect #32223: Disable sprockets to avoid Sprockets::Railtie::ManifestNeededError raised by sprockets 4.0.0
- Mischa The Evil wrote:
> Pavel Rosický wrote:
> ...
benchmark included -
11:16 Defect #32223: Disable sprockets to avoid Sprockets::Railtie::ManifestNeededError raised by sprockets 4.0.0
- Mischa The Evil wrote:
> Go MAEDA wrote:
> ...
Sorry for the misreading.
I believe the config loads all libraries needed to run a Rails app. Actually, the set of "require" methods was not written by me but generated by `@rails new a... -
09:56 Defect #32223: Disable sprockets to avoid Sprockets::Railtie::ManifestNeededError raised by sprockets 4.0.0
- Pavel Rosický wrote:
> [...]
How do you generate these numbers? On what system? Can you remove @active_storage@ and @action_cable@ too and benchmark those configs too? I'm curious what difference it makes in your case. -
09:21 Defect #32223: Disable sprockets to avoid Sprockets::Railtie::ManifestNeededError raised by sprockets 4.0.0
- Go MAEDA your patch improves startup time and memory consumtion.
-
07:09 Defect #32223: Disable sprockets to avoid Sprockets::Railtie::ManifestNeededError raised by sprockets 4.0.0
- Go MAEDA wrote:
> Mischa The Evil wrote:
> ...
What I meant was not about what else we can remove; just about what Redmine needs to function correctly.
> > FWIW: given r18635, this issue's target version should probably be set to 3.... -
11:10 Feature #973: Assign different status sets and workflows for separate projects
- +1
-
10:52 Patch #32303 (Closed): Japanese translation update (r18784)
- Committed the patch.
-
02:25 Patch #32303 (Closed): Japanese translation update (r18784)
- Translated strings added by #29482.
-
10:52 Revision 18786 (svn): Japanese translation update (#32303).
- Patch by Go MAEDA.
-
07:29 Defect #32305 (New): Use of notextile tag disables Redmine revision links
- As observed [yet] only on redmine.org (see #29482#note-90 and #29482#note-91), comments (in this case issue notes) having the following structure does not render the revision as a link:
-
06:52 Defect #32293: Redmine does not start if optional openid gems are not installed
- I don't think that this low priority issue alone justifies dropping OpenID support in Redmine altogether. I think that is something that should be discussed in a separate, dedicated issue.
-
06:35 Feature #29482 (Closed): Query system for Projects page
- Mischa The Evil wrote:
> <notextile>@</notextile>Go MAEDA: Can you also remove the remaining @label_show_closed_projects@ strings from the other translation files? The string is removed from _en.yml_ in r18761.
Done in r18785. Thank ... -
06:21 Feature #29482 (Reopened): Query system for Projects page
- <notextile>@</notextile>Go MAEDA: Can you also remove the remaining @label_show_closed_projects@ strings from the other translation files? The string is removed from _en.yml_ in r18761.
-
06:32 Revision 18785 (svn): Remove label_show_closed_projects from all translation files (#29482).
- The string has been removed from en.yml in r18761.
-
01:32 Revision 18784 (svn): Update locales (#29482).
2019-10-19
-
22:43 Feature #32302 (Closed): Filter projects after bookmarks
- I think it will be useful to allow users to filter the projects (#29482) after bookmarks (#31355) and I see two options:
1. "Bookmarks" filter with yes and no
!{border: 1px solid grey; width: 50%;}.bookmarks_fiter.png!
2. "<< my b... -
18:27 Feature #24841 (Closed): Hide projects user is only admin but not has assigned any role in the project overview (as it is already done in the project dropdown)
- You can filter now the projects list after "my projects":
!{width:60%;border:1px solid grey;}my_projects.png! -
15:34 Revision 18783 (svn): code cleanup: rubocop: fix Style/WhileUntilModifier in app/models/attachment.rb
-
15:34 Revision 18782 (svn): code cleanup: rubocop: fix Lint/IneffectiveAccessModifier in app/models/mail_handler.rb
-
15:33 Revision 18781 (svn): code cleanup: rubocop: fix Lint/IneffectiveAccessModifier in app/models/attachment.rb
-
15:33 Revision 18780 (svn): code cleanup: rubocop: fix Lint/IneffectiveAccessModifier in app/models/issue.rb
-
15:33 Revision 18779 (svn): code cleanup: rubocop: fix Lint/IneffectiveAccessModifier in app/models/user.rb
-
15:33 Revision 18778 (svn): code cleanup: rubocop: fix Lint/IneffectiveAccessModifier in app/models/mailer.rb
-
15:33 Revision 18777 (svn): code cleanup: rubocop: fix Lint/IneffectiveAccessModifier in lib/redmine/scm/adapters/abstract_adapter.rb
-
15:32 Revision 18776 (svn): code cleanup: rubocop: fix Lint/IneffectiveAccessModifier in lib/redmine/helpers/gantt.rb
-
15:32 Revision 18775 (svn): rubocop: enable Lint/IneffectiveAccessModifier
-
15:32 Revision 18774 (svn): code cleanup: rubocop: fix Style/ParenthesesAroundCondition in app/controllers/context_menus_controller.rb
-
14:25 Revision 18773 (svn): code cleanup: rubocop: fix Layout/CommentIndentation in lib/redmine/wiki_formatting/textile/redcloth3.rb
-
14:25 Revision 18772 (svn): code cleanup: rubocop: fix Layout/CommentIndentation in app/models/mailer.rb
-
14:25 Revision 18771 (svn): code cleanup: rubocop: fix Layout/SpaceBeforeComma in test/unit/lib/redmine/helpers/calendar_test.rb
-
14:25 Revision 18770 (svn): code layout clean up test/unit/time_entry_test.rb
-
14:24 Revision 18769 (svn): code cleanup: rubocop: fix Layout/SpaceBeforeComma in lib/redmine/utils.rb
-
14:18 Feature #29482 (Closed): Query system for Projects page
- Patches committed, thanks!
-
14:18 Revision 18768 (svn): Test failure (#29482).
-
14:14 Revision 18767 (svn): Use radio buttons to choose display type (#29482).
-
13:53 Feature #29663: Select a JavaScript library to handle tags
- Jean-Philippe, can you help us with a feedback on this? I would like to finish my work on the tags solution for 4.2.0.
-
13:43 Revision 18766 (svn): Set default columns for the projects list (#29482).
- Patch by Marius BALTEANU.
-
13:42 Revision 18765 (svn): Option to switch between table list and board list (#29482).
- Patch by Marius BALTEANU.
-
13:39 Revision 18764 (svn): Filter after project custom fields (#29482).
- Patch by Marius BALTEANU.
-
13:38 Revision 18763 (svn): Filter after parent project (#29482).
- Patch by Marius BALTEANU.
-
13:37 Revision 18762 (svn): Filter after projects (#29482).
- Patch by Marius BALTEANU.
-
13:36 Revision 18761 (svn): Filters for Projects page (#29482).
- Patch by Marius BALTEANU.
-
13:16 Revision 18760 (svn): code cleanup: rubocop: fix Style/WhileUntilModifier in lib/redmine/utils.rb
-
13:15 Revision 18759 (svn): code cleanup: rubocop: fix Style/WhileUntilModifier in lib/redmine/unified_diff.rb
-
13:15 Revision 18758 (svn): code cleanup: rubocop: fix Style/WhileUntilModifier in app/models/project.rb
-
13:15 Revision 18757 (svn): fix stderr_log_file and strip_credential of Redmine::Scm::Adapters::AbstractAdapter are not private
-
13:01 Patch #32296: Ignore rubocop offense
- Sorry, BUNDLE_DISABLE_EXEC_LOAD was not related with this behavior.
Please execute rubocop command with "--cache false" option. -
11:04 Patch #32296: Ignore rubocop offense
- Thank you for the feedback. But I still cannot see the warning.
-
10:00 Patch #32296: Ignore rubocop offense
- Reproduced it with BUNDLE_DISABLE_EXEC_LOAD=1 when using bundler.
-
05:53 Patch #32296: Ignore rubocop offense
- I run RuboCop against r18732 but was not able to reproduce the warning.
-
12:23 Patch #28138 (Closed): Add link to add a new issue on the version page
- Committed, thanks.
-
12:23 Revision 18756 (svn): Return to version page after the issue is created (#28138).
- Patch by Marius BALTEANU.
-
12:22 Revision 18755 (svn): Display new issue link in version page (#28138).
- Patch by Marius BALTEANU.
-
12:13 Patch #25265 (Closed): QueriesController can not handle subclass of IssueQuery
-
12:13 Revision 18754 (svn): Fixed that QueriesController can not handle subclass of IssueQuery (#25265).
-
11:41 Redmine 4.0.5 and 3.4.12 released
- These 2 maintenance releases are available for [[download]], you can review the changes in the [[Changelog]].
*Security*: these 2 releases include an upgrade to the latest ruby-openid gem that fixes a security vulnerability (see #3229... -
11:31 Revision 18753 (svn): tagged version 4.0.5
-
11:31 Revision 18752 (svn): tagged version 3.4.12
-
11:30 Revision 18751 (svn): Updates for 3.4.12 release.
-
11:29 Revision 18750 (svn): Merged r18749 to 4.0-stable.
-
11:29 Revision 18749 (svn): Updates for 4.0.5 release.
-
11:18 Patch #32294 (Closed): Update ruby-openid to 2.9.2
- Committed, thanks.
-
11:18 Revision 18748 (svn): Merged r18746 to 3.4-stable (#32294).
-
11:18 Revision 18747 (svn): Merged r18746 to 4.0-stable (#32294).
-
11:17 Revision 18746 (svn): Update ruby-openid to 2.9.2 (#32294).
- Patch by Go MAEDA.
-
10:37 Defect #31779 (Closed): Total estimated time column shown even when estimated time field is deactivated
- Committed, thanks.
-
10:37 Revision 18745 (svn): Merged r18743 to 3.4-stable (#31779).
-
10:37 Revision 18744 (svn): Merged r18743 to 4.0-stable (#31779).
-
10:30 Revision 18743 (svn): Fixed that total estimated time column is shown even when estimated time field is deactivated (#31779).
- Patch by Felix Schäfer and Yuichi HARADA.
-
10:27 Defect #32300 (Closed): Don't use sprockets 4.0.0 in order to avoid Sprockets::Railtie::ManifestNeededError
- sprockets 3.7.2 pinned.
-
10:25 Defect #32300 (Closed): Don't use sprockets 4.0.0 in order to avoid Sprockets::Railtie::ManifestNeededError
-
09:27 Revision 18742 (svn): code cleanup: rubocop: fix Layout/EmptyLines in lib/redmine/wiki_formatting/textile/redcloth3.rb
-
09:27 Revision 18741 (svn): code cleanup: rubocop: fix Layout/EmptyLines in test/unit/query_test.rb
-
09:27 Revision 18740 (svn): code cleanup: rubocop: fix Layout/EmptyLines in test/functional/project_enumerations_controller_test.rb
-
09:27 Revision 18739 (svn): code cleanup: rubocop: fix Layout/EmptyLines in test/functional/activities_controller_test.rb
-
09:26 Revision 18738 (svn): code cleanup: rubocop: fix Style/WhileUntilModifier in lib/redmine/wiki_formatting/textile/redcloth3.rb
-
09:26 Revision 18737 (svn): code cleanup: rubocop: fix Style/UnlessElse in lib/redmine/wiki_formatting/textile/redcloth3.rb
-
06:30 Revision 18736 (svn): code cleanup: rubocop: fix Layout/EmptyLines in app/models/issue.rb
-
06:30 Revision 18735 (svn): code cleanup: rubocop: fix Layout/EmptyLines in app/models/issue.rb
-
06:30 Revision 18734 (svn): code cleanup: rubocop: fix Style/MultilineTernaryOperator in lib/redmine/utils.rb
-
06:29 Revision 18733 (svn): code cleanup: rubocop: fix Style/WhileUntilModifier in app/helpers/queries_helper.rb
-
05:05 Defect #32223: Disable sprockets to avoid Sprockets::Railtie::ManifestNeededError raised by sprockets 4.0.0
- Updated the patch. Just replaced double quotation marks with single quotation marks.
2019-10-18
-
10:53 Feature #15180: Start date on versions
- Sebastian Paluch wrote:
> ... Setting first an option/checkbox and then date in every version is two times more operations... and you get no benefit out of it, same behavior gives you 3rd proposal.
Are we talking about changing dates... -
09:27 Feature #15180: Start date on versions
- Bernhard Rohloff wrote:
> +1 for the 2nd proposal
> ...
You have answered your question already. Setting first an option/checkbox and then date in every version is two times more operations... and you get no benefit out of it, same beh... -
06:40 Feature #15180: Start date on versions
- +1 for the 2nd proposal
Sebastian Paluch wrote:
> I don't like 2. as this is too much work to set this for every version. We have hundreds of them.
> ...
What's the point? You have to set your start and end dates for each version, a... -
10:41 Defect #32299 (New): Cannot add some filters in Gantt if Issue tracking module is disabled for the project
- You cannot use the following filters in Gantt if Issue tracking module is disabled for the project. But other issue related filters such as Tracker, Priority, Subject, and Description can be used.
* Author
* Assignee
* Target versio... -
10:34 Feature #31804: May I get sub projects via REST API
- I think Alexandr Horbatiuk means the reverse: "get the subproject from its parent", as redmine shows in the project web page.
-
09:23 Defect #32293: Redmine does not start if optional openid gems are not installed
- Go MAEDA wrote:
> To be honest, I think it is better to drop OpenID support than fixing this issue. In my observation, OpenID is getting obsolete. Many services have stopped being an OpenID provider.
I agree with you. -
09:16 Defect #32293: Redmine does not start if optional openid gems are not installed
- To be honest, I think it is better to drop OpenID support than fixing this issue. In my observation, OpenID is getting obsolete. Many services have stopped being an OpenID provider.
-
09:00 Defect #32293 (Confirmed): Redmine does not start if optional openid gems are not installed
- This has been the case for many years in fact.
I once started work on this, fixed it but never got to posting the polished patch.
I am willing to see if I can lookup this branch if there really is interest in fixing this issue given ... -
04:15 Defect #32293 (Closed): Redmine does not start if optional openid gems are not installed
- At source:tags/4.0.4/Gemfile#L28, openid gems are stated as optional.
-
09:00 Patch #32297 (Closed): Remove code for unsupported versions of Rails from open_id_authentication
- Redmine migrated to Rails 3 in Redmine 2.0 (released in 2012). We no longer support such older versions of Rails, so we can remove the code for Rails less than 3.0.
-
08:42 Patch #32296 (Closed): Ignore rubocop offense
- I found a rubocop offense is remaining.
-
05:46 Patch #32294 (Closed): Update ruby-openid to 2.9.2
- We have to update ruby-openid to the latest version because a vulnerability CVE-2019-11027 has been reported. The attached patch updates ruby-openid to 2.9.2.
https://nvd.nist.gov/vuln/detail/CVE-2019-11027
https://github.com/openid/... -
02:31 Feature #24013: Firebird and RedDatabase support
- Any news about this patch? is it stable? integrated?
It would be nice to use Firebird with Redmine too :)
Thanks!