Activity
From 2019-10-19 to 2019-10-21
2019-10-21
-
23:07 Feature #31505: Mark edited journal notes as "Edited"
- Updated to apply cleanly on the current trunk.
-
23:05 Feature #29482: Query system for Projects page
- Bernhard Rohloff wrote:
> There is a small flaw in the query save form. The labels on the @Display results@ section are overlapping each other.
Thanks Bernhard for catching this issue, it's caused by r18767.
Attached two new patch... -
18:31 Feature #29482 (Reopened): Query system for Projects page
- There is a small flaw in the query save form. The labels on the @Display results@ section are overlapping each other.
!overlapping_display_options.png! -
09:33 Feature #29482: Query system for Projects page
- Go MAEDA wrote:
> Marius BALTEANU wrote:
> ...
Thanks! -
09:21 Feature #29482 (Closed): Query system for Projects page
- Marius BALTEANU wrote:
> Please commit the below change in order to prevent a random test failure:
Committed in r18787. -
09:11 Feature #29482 (Reopened): Query system for Projects page
- Please commit the below change in order to prevent a random test failure:
-
22:12 Defect #32315: Impossible to validate API key without modifying anything
- Try, for example:
-
22:09 Defect #32315 (Closed): Impossible to validate API key without modifying anything
- AFAICT the Redmine API has no way of validating whether a given API key is valid, short of actually attempting a write operation (POST, PUT, DELETE).
With the GitHub API, you can do: -
22:10 Feature #5977: "check status" feature to verify validity of Redmine installation and API access key
- Related ticket: #32315
-
22:07 Feature #5977: "check status" feature to verify validity of Redmine installation and API access key
- AFAICT the Redmine API has no way of validating whether a given API key is valid, short of actually attempting a write operation (POST, PUT, DELETE).
With the GitHub API, you can do: -
20:26 Feature #27988: Option to configure which trackers can be set as subtasks for each tracker
- Hi Marius,
Thank you for the great patch! But I encounter a bug. I have the following setup: Tracker "Parent" has 2 possible subtasks "Child 1" and "Child 2".
When I add subtask from a "Parent" issue, the subtask's tracker automatica... -
19:15 Defect #32314 (Closed): Notification for "Only for things I watch or I'm involed in" not works
- I have updated my redmine installation from 3.4.2 release to last 4.0.5. After this update, I no longer receive e-mail notification. In my settings, e-mail notification is set to _Only for things I watch or I'm involed in_, but I receive...
-
17:26 Feature #24766: Custom fields grouping
- +1
-
15:47 Feature #32311: Filter Issues by multiple issue_id doesn't support space character or semicolon/dash as the separator
- /\A[+-]?\d+(\D[+-]?\d+)*\z/
digit separated by one non-digit
/\A[+-]?\d+(\D*\d+)*\z/
digit separated by any non-digit, easier for users. -
15:25 Feature #32311: Filter Issues by multiple issue_id doesn't support space character or semicolon/dash as the separator
- app/models/query.rb
line 417, replace the "," as "\D" can use any non-numeric characters as separator. -
09:35 Feature #32311: Filter Issues by multiple issue_id doesn't support space character or semicolon/dash as the separator
- If the value of the issue_id is "1,2,3" in the filter, the query executes successfully.
If the value of the issue_id is "1 2 3" or "1 2 3" or "1, 2, 3", the query fails with message "•Issue is invalid" -
09:20 Feature #32311 (New): Filter Issues by multiple issue_id doesn't support space character or semicolon/dash as the separator
- Issues -> Filter -> Issue
statement "is", input the filter value as multiple ids, such as "1,2,3".
It only supports comma "," as the separator of issue ids.
It doesn't support other common separators, such as space, semicolon, dash.... -
13:57 Defect #25130: support of agglutinative languages like Hungarian/Magyar
- Will you ever accept my patches, please?
Greg T wrote:
> When _x_hours_ and _x_days_ are *not* used for a reference to a past point in time relative to the present moment then datetime.distance_in_words must not be used as it's impos... -
13:32 Patch #32308: Rubocop: Performance/RedundantBlockCall: Use yield instead of block.call.
- there are a few other cases
-
08:40 Patch #32308: Rubocop: Performance/RedundantBlockCall: Use yield instead of block.call.
- All tests pass: https://gitlab.com/redmine-org/redmine/pipelines/90121225
-
01:32 Patch #32308: Rubocop: Performance/RedundantBlockCall: Use yield instead of block.call.
- Caused by r18777.
-
09:53 Feature #32312 (New): Disable auto selecting in top right Project filter
- Add configuration point to be able to disable autoswitching project while viewing issue
-
08:24 Defect #32309 (Needs feedback): settings error in 4.0.5.devel.18786
- @libs/js/iframe.js@ is not part of Redmine core.
-
06:19 Defect #32309: settings error in 4.0.5.devel.18786
- I was not able to reproduce the problem with Redmine 4.0.5.devel.18786.
Could you describe details of how to reproduce the problem? Does "settings page" means /projects/IDENTIFIER/settings/* or /admin ? -
05:52 Defect #32309 (Closed): settings error in 4.0.5.devel.18786
- Hello,
Just get the lastest version from subversion and the settings page is broken. -
03:19 Feature #32302: Filter projects after bookmarks
- The patch works fine and passed all tests.
Marius BALTEANU wrote:
> Here is the patch, I think we can commit it as part of #29482 and #31355.
Indeed. This feature should be delivered in 4.1.0. -
02:58 Patch #32297: Remove code for unsupported versions of Rails from open_id_authentication
- Setting the target version to 4.1.0.
2019-10-20
-
17:25 Patch #32308 (Closed): Rubocop: Performance/RedundantBlockCall: Use yield instead of block.call.
-
17:04 Feature #32302: Filter projects after bookmarks
- Here is the patch, I think we can commit it as part of #29482 and #31355.
-
01:13 Feature #32302: Filter projects after bookmarks
- Since we already have "<< my projects >>" in Project filter, the filter seems the right place to add "<< my bookmarks >>".
-
15:14 Defect #32307 (Closed): AttachmentsControllerTest#test_thumbnail_for_pdf_should_be_png fails if ImageMagick convert is not available
- To reproduce it, set invalid value to imagemagick_convert_command in configuration.yml and run attachments_controller_test.rb.
-
14:26 Feature #32306 (Closed): Add a link to projects administration page on projects page
- This patch adds a link to the projects administration page (/admin/projects) on the projects page in order to improve usability.
The current projects page has "New project" button, but does not have any other administrative buttons su... -
14:23 Defect #32223: Disable sprockets to avoid Sprockets::Railtie::ManifestNeededError raised by sprockets 4.0.0
- Mischa The Evil wrote:
> Pavel Rosický wrote:
> ...
benchmark included -
11:16 Defect #32223: Disable sprockets to avoid Sprockets::Railtie::ManifestNeededError raised by sprockets 4.0.0
- Mischa The Evil wrote:
> Go MAEDA wrote:
> ...
Sorry for the misreading.
I believe the config loads all libraries needed to run a Rails app. Actually, the set of "require" methods was not written by me but generated by `@rails new a... -
09:56 Defect #32223: Disable sprockets to avoid Sprockets::Railtie::ManifestNeededError raised by sprockets 4.0.0
- Pavel Rosický wrote:
> [...]
How do you generate these numbers? On what system? Can you remove @active_storage@ and @action_cable@ too and benchmark those configs too? I'm curious what difference it makes in your case. -
09:21 Defect #32223: Disable sprockets to avoid Sprockets::Railtie::ManifestNeededError raised by sprockets 4.0.0
- Go MAEDA your patch improves startup time and memory consumtion.
-
07:09 Defect #32223: Disable sprockets to avoid Sprockets::Railtie::ManifestNeededError raised by sprockets 4.0.0
- Go MAEDA wrote:
> Mischa The Evil wrote:
> ...
What I meant was not about what else we can remove; just about what Redmine needs to function correctly.
> > FWIW: given r18635, this issue's target version should probably be set to 3.... -
11:10 Feature #973: Assign different status sets and workflows for separate projects
- +1
-
10:52 Patch #32303 (Closed): Japanese translation update (r18784)
- Committed the patch.
-
02:25 Patch #32303 (Closed): Japanese translation update (r18784)
- Translated strings added by #29482.
-
07:29 Defect #32305 (New): Use of notextile tag disables Redmine revision links
- As observed [yet] only on redmine.org (see #29482#note-90 and #29482#note-91), comments (in this case issue notes) having the following structure does not render the revision as a link:
-
06:52 Defect #32293: Redmine does not start if optional openid gems are not installed
- I don't think that this low priority issue alone justifies dropping OpenID support in Redmine altogether. I think that is something that should be discussed in a separate, dedicated issue.
-
06:35 Feature #29482 (Closed): Query system for Projects page
- Mischa The Evil wrote:
> <notextile>@</notextile>Go MAEDA: Can you also remove the remaining @label_show_closed_projects@ strings from the other translation files? The string is removed from _en.yml_ in r18761.
Done in r18785. Thank ... -
06:21 Feature #29482 (Reopened): Query system for Projects page
- <notextile>@</notextile>Go MAEDA: Can you also remove the remaining @label_show_closed_projects@ strings from the other translation files? The string is removed from _en.yml_ in r18761.
2019-10-19
-
22:43 Feature #32302 (Closed): Filter projects after bookmarks
- I think it will be useful to allow users to filter the projects (#29482) after bookmarks (#31355) and I see two options:
1. "Bookmarks" filter with yes and no
!{border: 1px solid grey; width: 50%;}.bookmarks_fiter.png!
2. "<< my b... -
18:27 Feature #24841 (Closed): Hide projects user is only admin but not has assigned any role in the project overview (as it is already done in the project dropdown)
- You can filter now the projects list after "my projects":
!{width:60%;border:1px solid grey;}my_projects.png! -
14:18 Feature #29482 (Closed): Query system for Projects page
- Patches committed, thanks!
-
13:53 Feature #29663: Select a JavaScript library to handle tags
- Jean-Philippe, can you help us with a feedback on this? I would like to finish my work on the tags solution for 4.2.0.
-
13:01 Patch #32296: Ignore rubocop offense
- Sorry, BUNDLE_DISABLE_EXEC_LOAD was not related with this behavior.
Please execute rubocop command with "--cache false" option. -
11:04 Patch #32296: Ignore rubocop offense
- Thank you for the feedback. But I still cannot see the warning.
-
10:00 Patch #32296: Ignore rubocop offense
- Reproduced it with BUNDLE_DISABLE_EXEC_LOAD=1 when using bundler.
-
05:53 Patch #32296: Ignore rubocop offense
- I run RuboCop against r18732 but was not able to reproduce the warning.
-
12:23 Patch #28138 (Closed): Add link to add a new issue on the version page
- Committed, thanks.
-
12:13 Patch #25265 (Closed): QueriesController can not handle subclass of IssueQuery
-
11:18 Patch #32294 (Closed): Update ruby-openid to 2.9.2
- Committed, thanks.
-
10:37 Defect #31779 (Closed): Total estimated time column shown even when estimated time field is deactivated
- Committed, thanks.
-
10:27 Defect #32300 (Closed): Don't use sprockets 4.0.0 in order to avoid Sprockets::Railtie::ManifestNeededError
- sprockets 3.7.2 pinned.
-
10:25 Defect #32300 (Closed): Don't use sprockets 4.0.0 in order to avoid Sprockets::Railtie::ManifestNeededError
-
05:05 Defect #32223: Disable sprockets to avoid Sprockets::Railtie::ManifestNeededError raised by sprockets 4.0.0
- Updated the patch. Just replaced double quotation marks with single quotation marks.