Activity
From 2019-11-26 to 2019-11-28
2019-11-28
-
23:38 Patch #32527: Fix ruby 2.7 warning: given argument is nil; this will raise a TypeError in the next release
- Pavel Rosický wrote:
> The patch looks good, but you have to use Regex#match? instead of String#match?, because Redmine still supports Ruby 2.3. -
19:23 Patch #32527: Fix ruby 2.7 warning: given argument is nil; this will raise a TypeError in the next release
- There're already tons of deprecation warnings on Ruby 2.7. The patch looks good, but you have to use Regex#match? instead of String#match?, because Redmine still supports Ruby 2.3.
-
18:21 Patch #32527 (Closed): Fix ruby 2.7 warning: given argument is nil; this will raise a TypeError in the next release
- the `request.env['HTTP_USER_AGENT']` may `nil`.
e.g. `curl -A '' http://localhost:3000`
Quote from ruby 2.7 preview3 NEWS file:
> Regexp#match and Regexp#match? with a nil argument are deprecated and will raise a TypeError in th... -
14:29 Defect #32525: CSV related tests fail with Rails 5.2.4
- We changed the tests to expect the content type as "text/csv" instead of "text/csv; header=present" in r18028 in order to follow the change https://github.com/rails/rails/pull/35549, but the change in Rails was reverted by https://github...
-
10:36 Defect #32525 (Closed): CSV related tests fail with Rails 5.2.4
- 22 CSV related tests fail with Rails 5.2.4.
-
11:07 Feature #32520 (Closed): Issues activity gnats calendar tabs - too much real estate in high hand panel
- Donald Martin wrote:
>
> ...
Thanks for you feedback, closing this one.
-
11:05 Feature #32520: Issues activity gnats calendar tabs - too much real estate in high hand panel
- Thanks for the update Marius
* Sidebar collapse/expand is an old discussion, see #21808 and all the related discussions. An option is to apply the patch on your instance or to look for a plugin.
This option you referenced works ... -
10:40 Feature #32526 (Closed): Update Rails to 5.2.4.1
- Rails 5.2.4 has been released on 2019-11-27.
https://weblog.rubyonrails.org/2019/11/27/Rails-5-2-4-has-been-released/ -
03:07 Patch #32522: Add Project.find_by_name to target_project
- Since project names may not be unique, I think we cannot add the suggested code.
-
00:40
Feature #28471: Query links for subtasks on issue page
- +1, it's a green light from me ;-)
-
00:37
Defect #32153: Repository browser does not render previews for audio/video files
- Update: this seems to be working with no problems so far, if somebody else could double check it for security sake, it would be a really cool fix to commit ;-)
2019-11-27
-
18:09 Feature #32520: Issues activity gnats calendar tabs - too much real estate in high hand panel
- Donald Martin wrote:
> Hi Marius
> ...
The sidebar is not rendered when there is no content, so if you don't have custom queries, it won't be the case.
Also:
* Sidebar width depends on screen size starting from same 4.1.0 version, ... -
18:01 Feature #32520: Issues activity gnats calendar tabs - too much real estate in high hand panel
- Hi Marius
Thanks for the reply.
While I think its a good idea to move the links, (as where they are doesn't provide any value- and we never use them) the fact will remain that the side bar takes up a lot of real estate on the web p... -
17:49 Feature #32520 (Needs feedback): Issues activity gnats calendar tabs - too much real estate in high hand panel
- Those links are moved under a dropdown in Redmine version:"4.1.0", please see #30294.
But the sidebar will still be available for users with access to custom queries.
Can I close this issue? -
12:03 Feature #32520: Issues activity gnats calendar tabs - too much real estate in high hand panel
- Attached better picture to show what I mean
-
10:22 Feature #32520: Issues activity gnats calendar tabs - too much real estate in high hand panel
- Subject line should read "Issues activity gnats calendar tabs - too much real estate in right hand panel"
-
10:21 Feature #32520 (Closed): Issues activity gnats calendar tabs - too much real estate in high hand panel
- Hi
Just a thought - the right hand panel in the views mentioned above are given far too much real estate for the data they contains.
For example when I'm in the Issues view 1/3 of the screen is given to the right hand panel yet it ... -
16:52 Patch #32523 (Closed): Replace `for` loops with `forEach` in buildFilterRow function
- Hi,
When building a query on the /issues page, if you use a filter on users (assigned to, author, etc.) and you have a lot of them, the browser freezes for a few moments. This can be improved by slightly modifying the JavaScript runni... -
13:35 Patch #32522 (New): Add Project.find_by_name to target_project
- Consider issue #6694, fix is trivial. Think about all those reporters who struggle to memorizing all that ID stuff.
File app/models/mail_handler.rb
Line 410
target = get_project_from_receiver_addresses
target ||= Project.find_by_... -
10:33 Patch #32435: Change Russian translation for "Submit"
- Vasili Korol wrote:
> If this is about the “Accept” button (@btn_submit@), then the current translation «Принять» is correct. I can't find any “Apply” buttons in my Redmine 3.4.11, that are translated wrongly to Russian.
Thanks for the... -
09:51 Patch #32435: Change Russian translation for "Submit"
- If this is about the "Accept" button (@btn_submit@), then the current translation "Принять" is correct.
I can't find any "Apply" buttons in my Redmine 3.4.11, that are translated wrongly to Russian. -
08:58 Feature #13244: Restrict log time for old days
- Corrected spelling for "time logs"
-
08:43 Feature #13244: Restrict log time for old days
- I have created a patch based on the master git branch for this feature. This patch allows
1. Global configuration in the "Time Tracking" tab in the settings that allows setting how many days in the past time logs can be added. Default... -
04:23 Patch #31987: Add rake task which synchronize all revisions in repositories related with all active projects
- I re-upload the patch.
Fix a bug: Repository history synchronize will be ignored when issue keywords count in changeset N to 0.
2019-11-26
-
17:37 Feature #32519 (New): Report more precise error in failed requests (bounced emails) from incoming emails
- When a user sends an invalid e-mail to rdm-mailhandler.rb, for instance with invalid project
id or missing mandatory fields, the bounced e-mail is not helpful, as it just says:
"Request was denied by your Redmine server. "
"Possible... -
17:21 Defect #32518: Incoming mails handled by MailHandler sometimes logs with the wrong locale
- A precision: the users that trigger this wrong locale for sure do not have their own language or anything set to Japanese.
They typically use English.
-
17:18 Defect #32518 (New): Incoming mails handled by MailHandler sometimes logs with the wrong locale
- It happens from time to time that MailHandler logs errors related to incoming email messages
with the wrong locale (for instance in Japanese while my system is set to English by default).
For instance:
Nov 26 08:20:33 [ERROR] MailHa... -
16:37 Feature #22913: Auto-select fields mapping in Importing
- Yuichi HARADA wrote:
> I fixed attachment:auto_select_fields.patch and attachment:20160606_auto_select_fields_test.patch to work with the current trunk(r19312).
> ...
This is great. Thank you!
Do you find that if custom fields are abs... -
07:00 Feature #22913: Auto-select fields mapping in Importing
- I fixed attachment:auto_select_fields.patch and attachment:20160606_auto_select_fields_test.patch to work with the current trunk(r19312).
I attach a fixed patch. -
14:42 Defect #32471: Layout of the custom field edit page is different between the single edit page and the batch edit page
- Setting the target version to 4.2.0.
-
07:31 Revision 19319 (svn): replace multi line block "{}" to "do end" in app/controllers/issues_controller.rb
-
07:30 Revision 19318 (svn): cleanup: rubocop: fix Layout/SpaceInsideBlockBraces in app/controllers/issues_controller.rb
-
07:30 Revision 19317 (svn): cleanup: rubocop: fix Layout/SpaceInsideHashLiteralBraces in app/controllers/issues_controller.rb
-
07:30 Revision 19316 (svn): cleanup: rubocop: fix Layout/SpaceInsideBlockBraces in test/unit/principal_test.rb
-
07:30 Revision 19315 (svn): cleanup: rubocop: fix Layout/SpaceInsideBlockBraces in test/unit/token_test.rb
-
07:30 Revision 19314 (svn): cleanup: rubocop: fix Layout/SpaceInsideBlockBraces in test/unit/watcher_test.rb
-
07:30 Revision 19313 (svn): cleanup: rubocop: fix Layout/ClosingParenthesisIndentation in app/models/journal.rb
-
07:14 Defect #32515 (New): locales: the "task" should be named as "issue"
- Such as "Parent task", "Subtask".
Actually they are all issues, and sometimes they are really tasks, but sometimes they are only some lists in this world.
So let's just leave them as "issue". -
07:10 Feature #23448: Allow updating existing issues via CSV import when their ID's are the same
- +1