Activity
From 2019-11-29 to 2019-12-01
2019-12-01
-
11:27 Defect #32529: The end of the URL is replaced with "undefined" in IE11 and Edge
- Go MAEDA wrote:
> Marius, could you review this fix?
Yea, I’ll do it as soon I can. -
08:59 Feature #32538 (Closed): Tags with DMS
- Please don't use this tracker for (questions about) third-party add-ons. I suggest you take a look at the extensive DMSF-manual that can be found via https://github.com/danmunn/redmine_dmsf#additional-documentation.
-
08:56 Feature #32030: Show Gravatar icons in the Members tab in the project setting
- I understand the rationale behind this change, but I think it is slightly problematic as the group icon is indicative for the differentiation of groups from users on the project members list tab. With the change proposed in this issue it...
-
05:28 Feature #32030: Show Gravatar icons in the Members tab in the project setting
- I have updated the patch. It fixes Performance/RedundantMerge RuboCop warning.
2019-11-30
-
06:41 Patch #32527 (Closed): Fix ruby 2.7 warning: given argument is nil; this will raise a TypeError in the next release
- Committed the patch in #32527#note-7 as a part of #31500.
Thank you for reporting this issue. -
03:47 Patch #32527: Fix ruby 2.7 warning: given argument is nil; this will raise a TypeError in the next release
- Go MAEDA wrote:
> Seiei Miyagi wrote:
> ...
Looks great!
My code is calling request.env[] twice, thus your code is better. -
02:52 Patch #32527: Fix ruby 2.7 warning: given argument is nil; this will raise a TypeError in the next release
- Seiei Miyagi wrote:
> Updated the patch.
What do you think about the following code? It is simpler and very slightly efficient. -
06:40 Revision 19324 (svn): Ruby 2.7: Regexp#match and Regexp#match? with a nil argument are deprecated (#32527, #31500).
-
02:42 Feature #32538 (Closed): Tags with DMS
- We are using DMS 2.0.0 which should have the tagging feature for the documents as per https://github.com/danmunn/redmine_dmsf
I can't find a way to configure it via Admin settings.
Is there a way to enable tags for documents in DMS? -
02:06 Defect #32194 (Closed): Calendar page lacks buttons to manage custom queries
- Committed the patch. Thank you for your contribution.
-
02:05 Revision 19323 (svn): Fix indentation in app/views/queries/_form.html.erb (#32194).
- Patch by Mizuki ISHIKAWA.
-
01:58 Revision 19322 (svn): Add buttons to save/edit/delete a custom query to calendar view (#32194).
- Patch by Mizuki ISHIKAWA.
-
00:12 Defect #32537: Rake taks works on redmine 3.4 but does not work on 4 while for Redmine 4 it works in console
- Eventually I was able to make the following code work with Redmine 4
2019-11-29
-
23:40 Defect #32537 (New): Rake taks works on redmine 3.4 but does not work on 4 while for Redmine 4 it works in console
- I have described problem here:
https://stackoverflow.com/questions/59104015/saving-issue-custom-field-values-via-rake-task-in-redmine?noredirect=1#comment104442404_59104015
So, same code works in console on Redmine 4, and on Redmin... -
16:32 Feature #23632: Requirements for the attachment field in issues
- +1 ability to make core fields mandatory...
-
16:30 Defect #32536: Certain issue description leads to HTTP 504
- Considering the fact that the HTTP status code was 504 (Gateway Timeout) and nothing was written in the log, I think the error occurred in the proxy server or some device between the Redmine server and your PC.
-
15:54 Defect #32536: Certain issue description leads to HTTP 504
- Further investigation reveals that the problem is actually with the following construction:
-
14:38 Defect #32536: Certain issue description leads to HTTP 504
- The version of Redmine used on this website accepted the issue description...
-
14:36 Defect #32536 (Closed): Certain issue description leads to HTTP 504
- I an experiencing a weird issue with Redmine not accepting some certain text in the issue description. The server returns HTTP 504 both when I attempt to create a new issue, or to change the description of an existing one.
The problemat... -
16:29 Patch #32527: Fix ruby 2.7 warning: given argument is nil; this will raise a TypeError in the next release
- Go MAEDA wrote:
> Seiei Miyagi wrote:
> ...
I fully understand. thank you!
Updated the patch. -
02:30 Patch #32527: Fix ruby 2.7 warning: given argument is nil; this will raise a TypeError in the next release
- Seiei Miyagi wrote:
> I will update the patch. By the way, in ruby 2.3, both “String # match?” and “Regexp # match?” do not exist.
> ...
@Regexp#match?@ is defined by ActiveSupport for older versions of Ruby. Please see #28940 for deta... -
02:19 Patch #32527: Fix ruby 2.7 warning: given argument is nil; this will raise a TypeError in the next release
- I will update the patch. By the way, in ruby 2.3, both “String # match?” and “Regexp # match?” do not exist.
https://docs.ruby-lang.org/en/2.3.0/Regexp.html -
16:11 Defect #32525: CSV related tests fail with Rails 5.2.4
- The code after applying the attached patch supports both Rails 5.2.3 and Rails 5.2.4.
-
14:48 Defect #32194: Calendar page lacks buttons to manage custom queries
- Thank you for updating the patch. Setting the target version to 4.2.0.
-
03:09 Defect #32194: Calendar page lacks buttons to manage custom queries
- I modified the patch so that it can be applied cleanly to the current trunk.
-
14:06 Patch #32522: Add Project.find_by_name to target_project
- Well, it's a good point. But then we have two options:
1. Mark Project.find_by_name as a deprecated/potentially-dangerous method and eliminate it in future versions of RM "Since project names may not be unique".
2. Implement some syste... -
10:57 Patch #32523: Replace `for` loops with `forEach` in buildFilterRow function
- There is a typo in the previous patch. Here is the corrected version.
-
09:09 Defect #32532: SQL to get count does not work correctly when grouping issues using created_on when setting config.time_zone
- I have attached a patch that fixes the problem.
I'm not very familiar with SQL, so I'd like someone to check if the change is correct. -
08:59 Defect #32532 (New): SQL to get count does not work correctly when grouping issues using created_on when setting config.time_zone
- * config.time_zone = 'Tokyo' # Other than UTC
* User time zone is nil
In the case of the above settings, the count when grouped with created_on may not be displayed correctly.
!{width: 500px; border: 1px solid #ccc}screenshot.png!
... -
08:57 Patch #32531 (Closed): Update RuboCop Rails to 2.9
- Committed the patch.
-
08:56 Patch #32531 (Closed): Update RuboCop Rails to 2.9
-
08:57 Revision 19321 (svn): Update RuboCop Rails to 2.4 (#32531).
-
08:46 Patch #32530 (Closed): Update RuboCop to 1.12
- Committed the patch.
-
08:31 Patch #32530 (Closed): Update RuboCop to 1.12
- The attached patch updates RuboCop to 0.77.
-
08:36 Revision 19320 (svn): Update RuboCop to 0.77 (#32530).
-
08:17 Defect #32529: The end of the URL is replaced with "undefined" in IE11 and Edge
- Marius, could you review this fix?
-
04:11 Defect #32529 (Closed): The end of the URL is replaced with "undefined" in IE11 and Edge
- Clicking "Administration > Users > [dlopper]" redirects to "/users/3/edit", however address bar shows "/users/3/undefined".
!{border:1px solid #ccc;}url_changed_to_undefined.png!
Reproduce with trunk and 4.1-stable. (Does not repro... -
07:47 Feature #11361: Custom Field Groups, and User Specific Fields
- +1
-
06:42 Feature #24766: Custom fields grouping
- +1
-
06:41 Feature #31355 (Reopened): Bookmarks and recently used projects for the project jump box
- An issue caused by this feature is reported as #32503.
-
06:40 Defect #32503: Project jump box options are not extracted correctly after searching
- Confirmed the issue is reproducible and the patch in #32503#note-2 fixes it.
-
06:03 Defect #32503: Project jump box options are not extracted correctly after searching
- The following minor changes will fix this issue.
-
06:21 Feature #3058 (Reopened): Show issue history using tabs
- A cross-Browser compatibility issue caused by the changes has been reported as #32529.
-
03:26 Feature #32528: Make languages in Highlighted code button in toolbar customizable
- I attached a patch.
After applying this patch to the development environment, you need to restart Redmine.
* user setting
!{width: 70%; border: 1px solid #ccc}example1.png!
* wiki toolbar
!{width: 500px; border: 1px solid #ccc}e... -
03:24 Feature #32528 (Closed): Make languages in Highlighted code button in toolbar customizable
- Languages often used in code highlights differ from person to person.
I think it would be convenient if the language set in the user setting is given as a candidate. -
03:10 Defect #32430: Can't delete project in Redmine 4.0.3
- Marius BALTEANU wrote:
> @redmine.easy_settings@ table is not part of the Redmine core, please try without any plugin.
I found a similar issue in this page https://github.com/danmunn/redmine_dmsf/issues/856.
It seems occurred by dm...