Project

General

Profile

Activity

From 2019-12-02 to 2019-12-04

2019-12-04

14:04 Revision 19332 (svn): code layout clean up test/unit/workflow_test.rb
Toshi MARUYAMA
09:40 Feature #24277: Introducing Remaining Time field as method to track the remaining time to complete an issue
Anders Thomsen wrote:
> Marius, are you still determined to have this feature added? I'm evaluating if we should should apply the patch to our own instance but will avoid if we have to maintain it for all future versions.
Yes, I stil...
Marius BĂLTEANU
09:18 Feature #24277: Introducing Remaining Time field as method to track the remaining time to complete an issue
Marius, are you still determined to have this feature added? I'm evaluating if we should should apply the patch to our own instance but will avoid if we have to maintain it for all future versions.
If so, do you plan to provide a patc...
Anders Thomsen
01:00 Feature #32528: Make languages in Highlighted code button in toolbar customizable
Thank you for your feedback.
I updated the patch.
Mizuki ISHIKAWA

2019-12-03

20:03 Patch #32548: Add new hook in projects/settings/_issues.html.erb for custom fields
This description can be edited to change the pre code class to ruby, thanks. Jérôme BATAILLE
20:02 Patch #32548 (New): Add new hook in projects/settings/_issues.html.erb for custom fields
This would be very helpful to add new features from plugins related to custom fields.
Thanks a lot to take in accout this very small patch
Jérôme BATAILLE
15:43 Feature #32528: Make languages in Highlighted code button in toolbar customizable
Thank you for writing the patch. But I think that filling the textarea in "My account" with the default languages is better. The reason is that it makes easier to customize the default values.
Suppose that you are about to add "sonco...
Go MAEDA
15:22 Patch #31169: Wiki syntax help for document image pasting and drag/drop embedding
Anyone knows when this is going to be released? Dainis Abols
15:08 Patch #32527: Fix ruby 2.7 warning: given argument is nil; this will raise a TypeError in the next release
fyi, the change will be probably reverted in the final release, see https://bugs.ruby-lang.org/issues/13083 Pavel Rosický
15:07 Defect #32546: Issue relations filter lacks "is not"
Alexander Achenbach wrote:
> The actual implementation seems to have it, though.
The implementation for "is not" operator is at source:tags/4.0.5/app/models/issue_query.rb#L568. I think "!" operator was not included by mistake and th...
Go MAEDA
10:53 Feature #4939: List of tasks filtered as OR and not AND
+1 Jérôme BATAILLE
10:53 Feature #4939: List of tasks filtered as OR and not AND
Thanks Emanuel Jérôme BATAILLE
10:13 Feature #4939: List of tasks filtered as OR and not AND
h2. All issues
All issues to compare the examples:
!screencapture_matchop_all-issues.jpg!
h2. Or filter example
One of the or filter (AND any following) in action. In the Add filter dropdown they are grouped in section _OR filt...
Emanuel Reisinger
10:17 Defect #32450 (Closed): Attempts to get "tribute.min.js.map" by Chrome DevTool causes RoutingError.
Merged to 4.1-stable. And clearing the target version because the fix is considered as a part of #31989. Go MAEDA
10:03 Defect #32450: Attempts to get "tribute.min.js.map" by Chrome DevTool causes RoutingError.
Go MAEDA wrote:
> I thought that the change does not have to be merged to 4.1-stable because the issue only affects developers and they usually use the trunk. But I don't object to merging into 4.1-stable.
I'm in favour of merging th...
Marius BĂLTEANU
09:57 Defect #32450: Attempts to get "tribute.min.js.map" by Chrome DevTool causes RoutingError.
I thought that the change does not have to be merged to 4.1-stable because the issue only affects developers and they usually use the trunk. But I don't object to merging into 4.1-stable. Go MAEDA
09:36 Defect #32450 (Reopened): Attempts to get "tribute.min.js.map" by Chrome DevTool causes RoutingError.
This seems eligible to merge into 4.1-stable too IMHO (considering the inclusion of #31989 for version#127). If so, then this issue doesn't have to be included on the changelog either too (thus the target version of this issue could then... Mischa The Evil
10:15 Revision 19331 (svn): Merged r19221 from trunk to 4.1-stable (#32450, #31989).
Go MAEDA
08:49 Defect #32544: Merge commits adding test fixtures for 4.1 features to 4.1-stable branch.
Mischa The Evil wrote:
> Thanks for taking care of it. Just a quick note though: it might be best to remove target version version#152 from the related issues #32444, #32478 and #32540 as:
> ...
You are absolutely right. I have just re...
Go MAEDA
08:31 Defect #32544: Merge commits adding test fixtures for 4.1 features to 4.1-stable branch.
Go MAEDA wrote:
> Merged the three commits to 4.1-stable branch. Thank you for pointing it out.
No problem. Thanks for taking care of it. Just a quick note though: it might be best to remove target version version#152 from the relate...
Mischa The Evil
07:15 Defect #32544 (Closed): Merge commits adding test fixtures for 4.1 features to 4.1-stable branch.
Merged the three commits to 4.1-stable branch. Thank you for pointing it out. Go MAEDA
08:48 Patch #32444: Add missing fixture to Redmine::WikiFormatting::MacrosTest
Cleared the target version because the fix is a part of #29489. Go MAEDA
08:47 Patch #32478: Add missing fixture to TimelogControllerTest
Cleared the target version because the fix is a part of #30346. Go MAEDA
08:46 Patch #32540: Add missing fixtures to VersionTest
Cleared the target version because the fix is a part of #31954 and #23997. Go MAEDA
07:14 Revision 19330 (svn): Merged r19088 from trunk to 4.1-stable (#32478, #30346).
Go MAEDA
07:11 Revision 19329 (svn): Merged r19071 from trunk to 4.1-stable (#32444, #29489).
Go MAEDA
07:08 Revision 19328 (svn): Merged r19327 from trunk to 4.1-stable ( #32540, #31954, #23997).
Go MAEDA

2019-12-02

23:06 Feature #4939: List of tasks filtered as OR and not AND
Hi,
Can you put some screen captures to be able to see how it works and how it changes the native behavior ?
Jérôme BATAILLE
23:00 Feature #4939: List of tasks filtered as OR and not AND
Is anybody in contact with Jean-Philippe Lang so this has a change to get merged?
The filter options need to be much more poerfull...
Jochen Kuehner
10:53 Defect #32546 (Closed): Issue relations filter lacks "is not"
It seems the "is not" operator was omitted in the :relation definition of query operators.
The actual implementation seems to have it, though.
The attached patch adds the operator to the list (applied to Redmine 4.0.5).
Alexander Achenbach
10:39 Feature #5893: Filter issues by notes
As a follow-up to #5893#note-7, here's a revised patch of the notes query against Redmine 4.0.5.
It fixes logic problems in operator handling that were in the original patch.
Alexander Achenbach
10:08 Feature #32545 (New): Plugin API for adding a new notification
In lib/redmine/notifiable.rb, there is a TODO: Plugin API for adding a new notification?.
I found out that, one can provide this API via Redmine Hooks, although I dont know if this is the correct approach.
The patch below seems to be ...
Hong Cheu Lim
09:54 Defect #32536 (Closed): Certain issue description leads to HTTP 504
Thank you for the feedback. Closing. Go MAEDA
09:44 Defect #32536 (Resolved): Certain issue description leads to HTTP 504
You are right.
Something seems wrong with the reverse proxy.
Sorry for the fuss, please close the issue.
Vasili Korol
09:30 Feature #32543: Ability to choose home page after login
Ref.: message#2902. Mischa The Evil
08:42 Feature #32543 (New): Ability to choose home page after login
Some users don't want to use default page after login.
They want users to be redirected to "my page", or some other page like news or wiki of some project.
Preferably there should be ability to choose default redirect page in admin ...
Aleksandar Pavic
09:08 Patch #32542: Fix ruby 2.7 warning: The last argument is used as the keyword parameter
I updated the patch.
Change @**options.merge(other: opt)@ to @**options, other: opt@.
Seiei Miyagi
08:56 Patch #32542: Fix ruby 2.7 warning: The last argument is used as the keyword parameter
Just my two cents on this: given all the reverts in the 2.7 pre-releases, I'd suggest to wait with the commit of this patch until a 2.7 final release. Mischa The Evil
08:25 Patch #32542 (Closed): Fix ruby 2.7 warning: The last argument is used as the keyword parameter
I run rake test on ruby 2.7, there are several warnings about keyword argument.
I fix it by adding `**`.
Seiei Miyagi
08:51 Defect #32544 (Closed): Merge commits adding test fixtures for 4.1 features to 4.1-stable branch.
The following commits fixes tests, which are missing fixtures, for features that are (going to be) introduced in Redmine version#127:
* r19327 for #32540 (for #31954 & #23997 with r18402)
* r19071 for #32444 (for #29489 with r18297)
*...
Mischa The Evil
05:48 Feature #31500: Ruby 2.7 support
With ruby 2.7, following tests failed. Seiei Miyagi
03:36 Patch #32540 (Closed): Add missing fixtures to VersionTest
Committed the fix. Thank you for your contribution. Go MAEDA
01:36 Patch #32540 (Closed): Add missing fixtures to VersionTest
VersionTest has failed. Yuichi HARADA
03:36 Revision 19327 (svn): Add missing fixtures to VersionTest (#32540).
Patch by Yuichi HARADA. Go MAEDA
03:21 Revision 19326 (svn): Merged r19325 from trunk to 4.1-stable (#31355, #32503).
Go MAEDA
02:42 Feature #31355 (Closed): Bookmarks and recently used projects for the project jump box
Go MAEDA wrote:
> An issue caused by this feature is reported as #32503.
Fixed in r19325. The issue was that bookmarked and recently used projects are unexpectedly filtered by a search keyword after full-text search.
Go MAEDA
02:39 Defect #32503 (Closed): Project jump box options are not extracted correctly after searching
Committed the patch in #32503#note-2 as a part of #31355. Thank you for catching and fixing it before the release of 4.1.0. Go MAEDA
02:37 Revision 19325 (svn): Fix that bookmarked and recently used projects are unexpectedly filtered by a search keyword after full-text search (#31355, #32503).
Patch by Mizuki ISHIKAWA. Go MAEDA
 

Also available in: Atom