Project

General

Profile

Activity

From 2020-02-09 to 2020-02-11

2020-02-11

21:16 Defect #32985 (Closed): Remove unnecessary use of instance variables in CSV and Atom response handlers
I set "10000" as "Issues export limit" (instead of default "500") for some reasons,
but I noticed that exporting around 10,000 issues CSV causes out of memory issue.
I thought that the cause is inside some plugins, but it seems to be...
Ko Nagase
16:14 Patch #32847: Ability to add custom css classes to body tag
The changed @body_css_classes@ method is unfortunately not idempotent. Each call of the changed method will add the "normal" classes to the @@css@ instance variable. Thus, if you call the method two times, the list of classes be doubled. Holger Just
15:40 Feature #12794: Member groups not listed in project page
+1
I think this feature is needed.
In Lotus Notes, each DB could have role-based access rights specified by group or user,
and the group name and role were displayed as attributes of the DB.
With this information, the user was a...
Yuuki NARA
14:34 Defect #29838 (Closed): Time logging via commit message does not work when the configured activity has been overridden on the project level
Committed the patches. Thank you for detecting and fixing this issue. Go MAEDA
09:21 Defect #29838 (New): Time logging via commit message does not work when the configured activity has been overridden on the project level
Jens Krämer wrote:
> turns out it did not have anything to do with the MySQL version, it was just a race condition in the Changeset test suite due to the @commit_logtime_activity_id@ setting sometimes being set from a previous test case...
Marius BĂLTEANU
07:45 Defect #29838: Time logging via commit message does not work when the configured activity has been overridden on the project level
turns out it did not have anything to do with the MySQL version, it was just a race condition in the Changeset test suite due to the @commit_logtime_activity_id@ setting sometimes being set from a previous test case. The attached combine... Jens Krämer
14:33 Revision 19512 (svn): Fix logging time via a commit message for project specific activities (#29838).
Patch by Jens Krämer. Go MAEDA
13:56 Defect #32983 (Closed): Filter for "Blocked by" "no open issues" not working
If I add a filter for "Blocked by" and select "no open issues", then hit "save" and "Apply", the newly added filter just vanishes. The filter never gets applied. The same seems to be true for "any open issues". All the other options for ... Martin Hierholzer
07:03 Defect #32977: Remove references to deleted user from "user"-Format CustomFields
The patch cannot be committed for minor releases because it has a migration. Go MAEDA
06:29 Defect #32977: Remove references to deleted user from "user"-Format CustomFields
here's a new patch including a migration to delete already existing orphaned values.
Jens Krämer
05:56 Defect #5354 (Reopened): Updating custom fields does not trigger update to "updated_on" field in the customized object
The patch breaks an existing test. Go MAEDA
05:06 Defect #5354 (Closed): Updating custom fields does not trigger update to "updated_on" field in the customized object
Committed the patch. Thank you. Go MAEDA
05:56 Revision 19511 (svn): Reverts r19510 that breaks IssueTest#test_closed_on_should_be_set_when_closing_an_open_issue (#5354).
Go MAEDA
05:06 Revision 19510 (svn): Updating custom fields does not trigger update to "updated_on" field in the customized object (#5354).
Patch by Yuichi HARADA. Go MAEDA
04:53 Feature #32945 (Resolved): Show module names in bold in permission report
Committed the patch. Go MAEDA
01:34 Feature #32945: Show module names in bold in permission report
Since the patch only changes CSS, so no problem to deliver in 4.1.1. Go MAEDA
04:52 Revision 19509 (svn): Show module names in bold in permission report (#32945).
Patch by Go MAEDA. Go MAEDA
04:48 Revision 19508 (svn): Reverts r19507 (#4511).
Go MAEDA
04:33 Revision 19507 (svn): Add a missing fixture for IssuesControllerTest#test_post_create_with_watchers (#4511).
Go MAEDA
03:35 Feature #16006 (Closed): Include attachments in forum post notifications
Go MAEDA
03:34 Feature #16006: Include attachments in forum post notifications
Committed the patch. Thank you for your contribution. Go MAEDA
03:34 Revision 19506 (svn): Include attachments in forum post notifications (#16006).
Patch by Yuichi HARADA. Go MAEDA
02:22 Defect #32981 (Closed): Unable to distinguish disabled input fields
Although it is a text box with disabled set, it is difficult to identify because the background color does not change.
(The cursor changes when you mouse over, so we can identify it.)
Below is the [Settings] > [Incoming emails] tab.
...
Hirokazu Onozato
02:11 Feature #32818 (Closed): Add a system setting for default results display format of project query
Committed the patch. Thank you for improving Redmine. Go MAEDA
02:10 Revision 19505 (svn): Add system setting for default results display format of project query (#32818).
Patch by Takenori TAKAKI and Marius BALTEANU. Go MAEDA

2020-02-10

20:23 Feature #6851: Change PDF page size
Just did this with redmine 4.1.0. Went to:
/usr/share/redmine/lib/redmine/export/pdf.rb
Found the following line:
super(orientation, 'mm', 'A4')
Changed the 'A4' to 'letter'. Had to restart redmine, and now my pdf's are...
Ted Felix
16:25 Feature #32818: Add a system setting for default results display format of project query
Thanks to Marius for reviewing the patch and suggesting improvements!
I think attached code is better, because the patch will be more DRY.
Takenori TAKAKI
15:16 Defect #29838: Time logging via commit message does not work when the configured activity has been overridden on the project level
Jens Krämer wrote:
> thats really interesting as I ran my tests against MySQL (5.6) as well. can i see the exact environment in terms of ruby / mysql version somewhere on gitlab?
Yes, you can see in @.gitlab-ci.yml@:
* ruby version:...
Marius BĂLTEANU
14:59 Defect #29838: Time logging via commit message does not work when the configured activity has been overridden on the project level
thats really interesting as I ran my tests against MySQL (5.6) as well. can i see the exact environment in terms of ruby / mysql version somewhere on gitlab? Jens Krämer
10:41 Defect #29838: Time logging via commit message does not work when the configured activity has been overridden on the project level
Jens Krämer wrote:
> I just applied both patches to current master and all changeset tests pass. Could you please retry / post some logs?
I've added your patches to my Gitlab CI instance used by me to run the tests and it fails only ...
Marius BĂLTEANU
10:19 Defect #29838: Time logging via commit message does not work when the configured activity has been overridden on the project level
I just applied both patches to current master and all changeset tests pass. Could you please retry / post some logs? Jens Krämer
14:56 Defect #32977: Remove references to deleted user from "user"-Format CustomFields
we should indeed do that. I'll take care of that tomorrow. Jens Krämer
10:48 Defect #32977: Remove references to deleted user from "user"-Format CustomFields
We shouldn't add a migration to remove the existing orphaned values? Marius BĂLTEANU
10:11 Defect #32977 (Closed): Remove references to deleted user from "user"-Format CustomFields
When a user record is destroyed, custom field values for custom fields with @field_format == 'user'@ referencing the destroyed user are left unchanged.
This leads to problems with queries on such a custom field when using either the @...
Jens Krämer
12:18 Feature #22483: Show PDF attachments and repo entries instead of downloading them
Gregor Schmidt wrote:
> Updated patches to r15404.
Thank you!
Gần Sôi Nước
11:43 Feature #32424: CommonMark Markdown Text Formatting
Well Gitlab is a hosted platform with paying customers, so they had to be extra careful. I don't know if/how that gradual release of commonmark also happened for users of their opensource version on their own servers. From reading that a... Jens Krämer
10:53 Feature #32424: CommonMark Markdown Text Formatting
Jens Krämer wrote:
> I agree regarding complexity / confusion of users. So in order to move this forward, should I proceed to change the patch so it directly replaces Redcarpet with CommonMarker for the @markdown@ formatting?
I'm my ...
Marius BĂLTEANU
09:18 Feature #32424: CommonMark Markdown Text Formatting
I agree regarding complexity / confusion of users. So in order to move this forward, should I proceed to change the patch so it directly replaces Redcarpet with CommonMarker for the @markdown@ formatting? Jens Krämer
10:21 Feature #32978 (New): Option to show "Associated revisions" in Notes or History Tab
Hello there, after updating Redmine to version 4.1, I found not usable moment - I need to click on the tab "Associated revisions" to show all revisions in task. It's completely not usable (for me and my team), when I or somebody else wat... Kirill Trofimov
06:56 Feature #32976 (Closed): Display avatar on add watcher dialog
By changing the user icon to avatar in the Add Watchers dialog, we will be able to intuitively select the users we want to watch the isue.
After the trunk r19498, we can change the user icon to avatar by applying the following patch.
...
Takenori TAKAKI
01:18 Revision 19504 (svn): Merged r19503 from trunk to 4.1-stable (#32896).
Go MAEDA
01:17 Defect #32896 (Closed): Totals not working in projects list view
Marius BALTEANU wrote:
> My patch introduced a new Stylelint violation, please commit the attached fix.
> ...
Committed the patch.
Go MAEDA
01:17 Revision 19503 (svn): Fix a Stylelint violation (#32896).
Patch by Marius BALTEANU. Go MAEDA

2020-02-09

23:21 Feature #32818: Add a system setting for default results display format of project query
Thanks Takenori TAKAKI for writing the patch.
I propose few changes in the attached patch in order to keep the existing logic, please let me know what do you think.
Tests pass: https://gitlab.com/redmine-org/redmine/pipelines/1163...
Marius BĂLTEANU
18:30 Feature #32818: Add a system setting for default results display format of project query
I would like to review this patch. Marius BĂLTEANU
16:37 Defect #32889: Responsive layout for issue tree and issue relation on issue page is broken
We can revert the old behaviour by hiding the start date and due date or we can show all other columns on 5 columns layout instead of 3.
*Old layout with 3 columns and start date and due date hide:*
!{border:1px solid grey; width: 6...
Marius BĂLTEANU
16:10 Defect #32896 (Reopened): Totals not working in projects list view
My patch introduced a new Stylelint violation, please commit the attached fix. Marius BĂLTEANU
15:32 Defect #32973: Editing a time entry for a locked user changes the user to the current user
Here is the fix for the second option, but I would like a double check on the solution. The second patch renames and reorders the test added in #32959.
All tests pass: https://gitlab.com/redmine-org/redmine/pipelines/116292306
Marius BĂLTEANU
01:04 Defect #32973: Editing a time entry for a locked user changes the user to the current user
Marius BALTEANU wrote:
> I see two options to fix this:
> ...
I think the second option is better because the limitation suggested in option 1 may confuse users. In my opinion, there is no reason to disallow changing the user when the ...
Go MAEDA
01:27 Defect #32959 (Closed): Fix selected user on log time edit page when user has permissions to log time for another user
Committed the patch. Thank you. Go MAEDA
01:27 Revision 19502 (svn): Merged r19501 from trunk to 4.1-stable (#32959).
Go MAEDA
01:23 Revision 19501 (svn): Fix that selected user on timelog#edit is incorrect (#32959).
Patch by Marius BALTEANU. Go MAEDA
 

Also available in: Atom