Redmine

2020-04-27

14:47 Defect #33334: bump i18n for advisory: CVE-2014-10077

The version of @Hash#slice@ in the i18n gem (which was vulnerable to CVE-2014-10077) is only used if there is not alr... Holger Just

13:39 Patch #33361 (Closed): Polish translation update

Robert Korulczyk

12:19 Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left

Go MAEDA wrote:
> [...]
> The reason I have been hesitating to commit the fix is that I am afraid of changing the c... Mischa The Evil

11:38 Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left

Bernhard Rohloff wrote:
> Since the current fix really seems to affect existing plugins I tend to go with Marius on ... Go MAEDA

11:17 Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left

Bernhard Rohloff wrote:
> Marius BALTEANU wrote:
> > Go Maeda, why we don't revert the change committed and apply t... Marius BĂLTEANU

11:14 Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left

Marius BALTEANU wrote:
> Go Maeda, why we don't revert the change committed and apply to safer fix which targets onl... Bernhard Rohloff

08:21 Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left

Go Maeda, why we don't revert the change committed and apply to safer fix which targets only the @p@ element from set... Marius BĂLTEANU

07:41 Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left

Alexander Meindl wrote:
> I added a patch for this possible change. It would be very helpful, also for other situati... Go MAEDA

06:38 Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left

Hi Go MAEDA,
I would suggest, that we stick to your solution. But it should be a possibility for plugin developers... Alexander Meindl

03:26 Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left

I am not sure if it is the right way to change the code of Redmine in order to fix RedmineUP plugins.
I will leav... Go MAEDA

08:36 Defect #33341 (Closed): Time entry user is shown twice in the User drop-down when editing spent time

Committed the fix. Thank you. Go MAEDA

04:07 Feature #3369: Allowed/Disallowed email domains settings to restrict users' email addresses

I have updated the patch:
* Changed the domain name matching to support subdomains. Now *"example.com"* matches ... Go MAEDA

03:43 Defect #17809: wrong syntax highlighting "---" header and "--" footer of git diff

Toshi MARUYAMA wrote:
> Go MAEDA wrote:
> > It can be fixed with the following code:
>
> No.
>
> I have creat... Toshi MARUYAMA

03:41 Defect #33357: rendering extra "--" footer of git patch attachment

#17809#note-5 is not solution in this case.... Toshi MARUYAMA

03:12 Defect #33357: rendering extra "--" footer of git patch attachment

Fixed title. Toshi MARUYAMA

2020-04-26

23:12 Feature #12222: SLA Integration (Service Level Agreement)

+1 for this feature Sebastián Labonia

23:11 Feature #15152: SLA Feature

+1 for this feature Sebastián Labonia

23:11 Feature #15021: Service Level Agreement (SLA), more user-friendly email configuration, add any other notifications

+1 for this feature Sebastián Labonia

18:52 Defect #33341: Time entry user is shown twice in the User drop-down when editing spent time

The fix looks good to me. The attached patch contains the fix and an assertion.
Tests pass: https://gitlab.com/red... Marius BĂLTEANU

18:14 Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left

Let's use for now this safer fix:... Marius BĂLTEANU

17:12 Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left

I attached another example screen with incorrect label lenght. Alexander Meindl

17:06 Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left

The labels of the settings are cut. There should be more space for it and moved to the right. On the picture the fort... Alexander Meindl

16:36 Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left

Alexander Meindl wrote:
> The related css code is used by plugins. If css code changes in Redmine, all plugin develo... Go MAEDA

16:10 Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left

Are there any non third-party Plugins?
At the moment in template plugin.html.erb is set... Alexander Meindl

16:01 Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left

Alexander Meindl wrote:
> The problem only exist, if tabs are used in settings, e.g. with most of redmineup plugins.... Go MAEDA

15:35 Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left

The problem only exist, if tabs are used in settings, e.g. with most of redmineup plugins. Alexander Meindl

15:33 Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left

Alexander Meindl wrote:
> sure, e.g. redmineup CRM settings. See my attachment.
To my eyes, it appears to be norm... Go MAEDA

15:28 Defect #33339 (Reopened): Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left

Go MAEDA

15:22 Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left

Hi,
sure, e.g. redmineup CRM settings. See my attachment.
!redminecrm_settings.png! Alexander Meindl

15:04 Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left

Alexander Meindl wrote:
> Hi,
>
> r19720 breaks alignment with lots of plugin settings, because this padding left... Bernhard Rohloff

13:14 Defect #33339: Broken layout of the preview tab of "Welcome text" setting due to unexpectedly applied padding-left

Hi,
r19720 breaks alignment with lots of plugin settings, because this padding left is used in "plugin.html.erb":/... Alexander Meindl

17:22 Feature #33352: Enable inline issue autocomplete in issue id query filter fields

+1
I think we should implement #32168 that allows entering issue ids with "#" prefix to the filters to move this i... Go MAEDA

17:14 Defect #17809 (Closed): wrong syntax highlighting "---" header and "--" footer of git diff

3.4
!3.4.png!
4.1
!4.1.png! Toshi MARUYAMA

17:03 Defect #17809: wrong syntax highlighting "---" header and "--" footer of git diff

Go MAEDA wrote:
> It can be fixed with the following code:
No.
I have created new #33357.
Toshi MARUYAMA

17:02 Defect #33357 (Closed): rendering extra "--" footer of git patch attachment

From #17809.
For example #4511 0002-Use-Principal-to-get-users-and-groups-for-watchers-i.patch.
!git-diff.png!
... Toshi MARUYAMA

11:27 Feature #28471: Query links for subtasks on issue page

IMHO, it looks like a nice improvement. :-) Bernhard Rohloff

09:54 Defect #33355 (Closed): TypeError when attempting to update a user with a blank email address

... Go MAEDA

2020-04-25

19:44 Feature #22425: Allow "style" tag in Redcarpet Markdown formatter

+1
I also want to set the text color on markdown.
There was a related discussion at the URL below.
https://www... Yuuki NARA

11:23 Feature #28471: Query links for subtasks on issue page

I reworked a little bit the patch proposed by Bernhard:
!subtasks.png!
What do you think? Marius BĂLTEANU

10:27 Feature #32085: Allow newline as a separator in "Allowed extensions", "Disallowed extensions", "Exclude attachments by name" field in Administration

I have removed some refactorings because they are not directly related to this issue and should be a separate patch.
... Go MAEDA

10:12 Feature #33352 (New): Enable inline issue autocomplete in issue id query filter fields

The query filters on issues and related issues accept issue ids. I see several use-cases/benefits of enabling the inl... Mischa The Evil

10:05 Feature #4511: Allow adding user groups as watchers for issues

Regarding first problem (N+1), we don’t do anything? Marius BĂLTEANU

10:03 Feature #4511 (Closed): Allow adding user groups as watchers for issues

Committed the patches attached in #4511#note-73. Thank you. Go MAEDA

09:31 Feature #4511: Allow adding user groups as watchers for issues

Go MAEDA wrote:
> Marius, thank you for improving the code but I noticed that attachment:0001-Get-the-list-of-new-is... Marius BĂLTEANU

05:15 Feature #4511: Allow adding user groups as watchers for issues

Marius, thank you for improving the code but I noticed that attachment:0001-Get-the-list-of-new-issue-watchers-using-... Go MAEDA

09:54 Patch #16133: Available watchers on new issue form include users who cannot even view issues

Here are some ideas in order to avoid the overhead:
1. If we really want to show some watchers in the new issue fo... Marius BĂLTEANU

09:45 Patch #33329: Improve watchers functionality to mark the users that are watching a non visible object and to not return watchers that cannot see the object

Go MAEDA wrote:
> Looks good to me.
>
> A similar patch #16133 was rejected 5 years ago due to performance concer... Marius BĂLTEANU

09:01 Patch #33329: Improve watchers functionality to mark the users that are watching a non visible object and to not return watchers that cannot see the object

Looks good to me.
A similar patch #16133 was rejected 5 years ago due to performance concerns when a project has a... Go MAEDA

09:30 Patch #33315: IssuesSystemTest#test_bulk_watch_issues_via_context_menu randomly fails due to Capybara clicks out out of context menu

Setting the target version to 4.2.0. Go MAEDA

08:47 Feature #33174 (Closed): Show groups in members box on project overview page

Go MAEDA wrote:
> I think it is how it should behave.
Thanks!
Marius BĂLTEANU

03:17 Feature #33174: Show groups in members box on project overview page

Marius BALTEANU wrote:
> Is it ok to show the builtin groups ("Anonymous users", "Non members users") and group memb... Go MAEDA

02:48 Defect #33350 (New): Rows in Forums tab of project setting are not striped according to odd/even rule

Tables in other tabs are striped. The table in the Forum tab should be striped as well.
!{width: 714px; border: 1p... Go MAEDA

00:12 Feature #30207: Hide menu item in the cross-project menu if the module is not enabled in any project

It is still displayed for roles that don't have permission to use any of those...
Once they click on projects tab... Aleksandar Pavic