Redmine

2021-04-02

22:50 Patch #32909: Replace pluck().first with pick()

I've rebased the patches added by Pavel, the changes looks good to me. Marius BĂLTEANU

22:49 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading

We should update Rubocop TargetRailsVersion to 6.1 Marius BĂLTEANU

07:57 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading

I've created #35002 to track the compatibility with MS SQL. Marius BĂLTEANU

03:17 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading

Pavel Rosický wrote:
> @yuichi activerecord-sqlserver-adapter doesn't support Rails 6.1 yet, but there's an open PR
... Yuichi HARADA

02:47 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading

@yuichi activerecord-sqlserver-adapter doesn't support Rails 6.1 yet, but there's an open PR
https://github.com/rail... Pavel Rosický

02:35 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading

Updating activerecord-sqlserver-adapter with r20900, but when I execute @bundle update@, the following error occurs.
... Yuichi HARADA

22:29 Defect #35009: db migration failed after updating to r20905

Do you have the secret token generated? It should be in @config/initializers/secret_token.rb@. If not, you can run @b... Marius BĂLTEANU

19:22 Defect #35009 (Closed): db migration failed after updating to r20905

error message was:
ArgumentError: Missing `secret_key_base` for 'development' environment, set this string with `bin... ChunChang (Nagaharu) Lo

22:17 Defect #35005: RuntimeError "Couldn't find Active Storage configuration" is raised at startup

Looks good to me. Marius BĂLTEANU

10:14 Defect #35005: RuntimeError "Couldn't find Active Storage configuration" is raised at startup

We can fix this by making the following change. Redmine currently does not use active_storage, so commenting out this... Go MAEDA

10:09 Defect #35005 (Closed): RuntimeError "Couldn't find Active Storage configuration" is raised at startup

Trying to run Redmine in production mode results in the error "Couldn't find Active Storage configuration in /path/to... Go MAEDA

22:15 Defect #35010 (Closed): redmine failed to start after updating to r20905

Duplicates #35005. Marius BĂLTEANU

20:12 Defect #35010 (Closed): redmine failed to start after updating to r20905

error message was:
Couldn't find Active Storage configuration in /var/www/html/redmine/config/storage.yml (RuntimeEr... ChunChang (Nagaharu) Lo

20:40 Patch #35012 (Closed): Czech translations

Pavel Rosický

20:36 Patch #35011 (Closed): Traditional Chinese translation (to r20905)

* New tag added
** error_invalid_authenticity_token, error_query_statement_invalid ChunChang (Nagaharu) Lo

16:35 Defect #35004: DEPRECATION WARNING during startup

refs #32938 Pavel Rosický

09:25 Defect #35004 (Closed): DEPRECATION WARNING during startup

... Go MAEDA

08:31 Feature #3143: Add an 'Add Note' function to issue, to avoid optimistic-lock of issue' update when user just want to add a note

Ismael Barros² wrote:
> Directories @a/@ and @b/@ won't actually exist on your filesystem, so I think you need to us... Leo L.

08:07 Defect #35003 (Closed): Update Rails UJS

Marius BĂLTEANU

07:56 Defect #35002 (Closed): Fix MS SQL on Rails 6.1

MS SQL support is broken for now because the gem supports only Rails 6.0, but I'm confident that will be fixed in the... Marius BĂLTEANU

07:55 Defect #32910 (Closed): Rails 6: add lookup_context to hook_test.rb

Fixed by r20889. Marius BĂLTEANU

05:26 Feature #35001: Disable API authentication with username and password when two-factor authentication is enabled for the user

The following code is a sample implementation.... Go MAEDA

05:18 Feature #35001 (Closed): Disable API authentication with username and password when two-factor authentication is enabled for the user

In Redmine 4.2, two-factor authentication has been introduced.
When two-factor authentication is enabled, it becom... Go MAEDA

04:11 Patch #35000 (Closed): Update SimpleCov to 0.21

Done. Go MAEDA

04:07 Patch #35000 (Closed): Update SimpleCov to 0.21

Go MAEDA

01:11 Feature #32938: Rails 6: Zeitwerk support

I had to remove some references due to your spam protection :) Pavel Rosický

01:10 Feature #32938: Rails 6: Zeitwerk support

sry, I don't. This is a pretty heavy change and Redmine has a lot of technical debt in this area. But I have a few hi... Pavel Rosický

2021-04-01

21:52 Feature #3143: Add an 'Add Note' function to issue, to avoid optimistic-lock of issue' update when user just want to add a note

Directories @a/@ and @b/@ won't actually exist on your filesystem, so I think you need to use @patch -p1@ instead of ... Ismael Barros²

18:16 Feature #3143: Add an 'Add Note' function to issue, to avoid optimistic-lock of issue' update when user just want to add a note

Ismael Barros² wrote:
> Which command did you use to apply the patch? @patch -p0@? @patch -p1@? @git apply@?
Hey ... Leo L.

21:46 Feature #32938: Rails 6: Zeitwerk support

Pavel, do you have any working patch for this? Marius BĂLTEANU

21:42 Defect #34999 (Closed): The result of Attachment.latest_attach is unstable if attachments have the same timestamp

refs #27780
test_latest_attach_should_support_unicode_case_folding... Pavel Rosický

20:13 Defect #32885: Rails 6: DEPRECATION WARNING: Single arity template handlers are deprecated

why not use the source directly? see the patch file Pavel Rosický

19:16 Defect #32885 (Closed): Rails 6: DEPRECATION WARNING: Single arity template handlers are deprecated

Done in r20886 as a part of #29914. Go MAEDA

19:05 Feature #31128 (Closed): Drop Ruby < 2.5 support

Done. Go MAEDA

18:12 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading

Committed 19 patches attached to #29914#note-38 and #29914#note-39 (r20879 .. r20901). Go MAEDA

10:29 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading

Go MAEDA wrote:
> The following error was reported while running the test suite.
>
> [...]
I will fix @Reposit... Go MAEDA

09:58 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading

The following error was reported while running the test suite.... Go MAEDA

17:45 Defect #32935 (Closed): Rails 6: fix set role_ids

Committed the patch as a part of #29914.
Go MAEDA

17:37 Defect #34984 (Closed): Rails 6.1 Rendering actions with '.' in the name is deprecated

Committed the patch as a part of #29914.
Go MAEDA

17:27 Defect #34985 (Closed): Rails 6.1 replace ActiveModel::Errors #<< with #add

Committed the patch as a part of #29914.
Go MAEDA

17:25 Defect #32923 (Closed): Rails 6: detach attachments when a conflict occurs

Committed the patch as a part of #29914.
Go MAEDA

17:22 Defect #32936 (Closed): Rails 6: disable AJ test adapter for integration tests

Committed the patch as a part of #29914.
Go MAEDA

17:19 Defect #32914 (Closed): Rails 6: remove #filename_for_content_disposition for MS browsers

Committed the patch as a part of #29914.
Go MAEDA

17:16 Defect #32913 (Closed): Rails 6: add filename header

Committed the patch as a part of #29914.
Go MAEDA

17:03 Defect #32939 (Closed): Rails 6: fix plugin migrations

Committed the patch as a part of #29914.
Go MAEDA

16:59 Defect #32921 (Closed): Rails 6: add header=present to csv tests

Committed the patch as a part of #29914.
Go MAEDA

16:49 Defect #32912 (Closed): Rails 6: update no longer bypass optimistic locking

Committed as a part of #29914.
Go MAEDA

16:41 Defect #32908 (Closed): Rails 6: Sending mail with DeliveryJob is deprecated

Committed as a part of #29914.
Go MAEDA

16:37 Defect #34980 (Closed): Fix "undefined method `represent_boolean_as_integer=' for nil:NilClass" in Rails 6.1

Committed as a part of #29914. Go MAEDA

16:35 Defect #32897 (Closed): Rails 6: Pass `case_sensitive: true` option explicitly to the uniqueness validator

Committed as a part of #29914. Go MAEDA

08:47 Feature #32898: PDF thumbnails support on Windows

Go MAEDA wrote:
> Steve Zhou wrote:
> > MAEDA-san, I tested the patch, it can successfully show PDF thumbnails on W... Steve Zhou

06:14 Feature #32898: PDF thumbnails support on Windows

Steve Zhou wrote:
> MAEDA-san, I tested the patch, it can successfully show PDF thumbnails on Windows with setting i... Go MAEDA

05:57 Feature #32898: PDF thumbnails support on Windows

Go MAEDA wrote:
> Steve Zhou, thank you for your feedback.
>
> Could you try the attached patch *without* setting... Steve Zhou

07:53 Defect #33127 (Closed): Assignee icon is misaligned when print stylesheet is applied

The current version of Firefox (87.0) does not have this issue. Closing. Go MAEDA

07:21 Defect #34998: Cannot open journal dropdown menu after editing note

Mizuki, one question, why not binding directly on document? Marius BĂLTEANU

03:31 Defect #34998: Cannot open journal dropdown menu after editing note

The following changes will resolve the issue.... Mizuki ISHIKAWA

02:09 Defect #34998 (Closed): Cannot open journal dropdown menu after editing note

After rewriting the journal note, clicking the journal dropdown does not open the menu. Reloading will fix the menu t... Mizuki ISHIKAWA

01:33 Feature #29285: Add "Assign to me" shortcut to issue edit form

Please open a new issue for feature requests or bug reports.
This issue has already closed and the feature has bee... Go MAEDA

2021-03-31

22:33 Feature #29285: Add "Assign to me" shortcut to issue edit form

Michael Michalewicz wrote:
> Hi all.
>
> Fantastic stuff with the 'Assign to me' button.
> I do have one suggest... Jenda Benda

15:41 Feature #32898 (New): PDF thumbnails support on Windows

Steve Zhou, thank you for your feedback.
Could you try the attached patch *without* setting imagemagick_convert_co... Go MAEDA

11:56 Feature #32898: PDF thumbnails support on Windows

Go MAEDA wrote:
> Redmine 4.1.2 will support a new setting @gs_command@ in config/configuration.yml (#33283). You ca... Steve Zhou

15:18 Defect #34995 (New): Running redmine in docker getting ssl error, any ideas what might be the issue?

Im having an issue with SSL. Im getting pretty crazy currently. Got the feeling that I miss something really simple :... rafaelteb rafaelteb

11:31 Feature #34981: Allow to change a project identifier

+1
I think this feature is needed.
The identifier change itself can simply be done in SQL.
I've done it dozen... Yuuki NARA

11:00 Patch #34969 (Closed): Remove dependency on MimeMagic

Backported to 4.1-stable in r20877 and r20878. Go MAEDA

10:39 Defect #34982 (Closed): Cannot change the default version and default assignee under settings

Go MAEDA

10:28 Defect #34982 (Resolved): Cannot change the default version and default assignee under settings

Committed the fix. Thank you. Go MAEDA

06:26 Defect #34982: Cannot change the default version and default assignee under settings

I've checked/tested the patch, too. I can confirm that it fixes the issue. Bernhard Rohloff

02:57 Defect #34982: Cannot change the default version and default assignee under settings

The patch verified and the defect was FIXED, thanks for your guys quick & selfless contributions! Sunding Wei

10:13 Feature #11543: Sort attachments by name

I implemented sorting in the attachments list of Issue and Wiki (I referred to #1718). Name, Description, Author, Cre... Yuichi HARADA

08:44 Feature #32424: CommonMark Markdown Text Formatting

Marius BALTEANU wrote:
> What do you think about the following plan for this issue?
> ...
I really like this app... Bernhard Rohloff

08:39 Feature #32424: CommonMark Markdown Text Formatting

What do you think about the following plan for this issue?
* We introduce this as third text formatting option in ve... Marius BĂLTEANU

08:40 Feature #34992 (Closed): Ruby 3.0 support

Ruby 3.0.0 has been released on 25 Dec 2020.
https://www.ruby-lang.org/en/news/2020/12/25/ruby-3-0-0-released/
Go MAEDA

04:59 Defect #33941: Do not use timezone unaware methods

Here is the result of the following command:... Go MAEDA

04:31 Feature #34974: Change the default value for "Preferred part of multipart (HTML) emails" from "Text" to "HTML"

Thank you for your feedback.
In our environment, some of the emails we received did not have a proper text part, a... Go MAEDA

02:29 Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading

Thank you all for working on this.
Marius BALTEANU wrote:
> My proposal is to have these patches committed as soo... Go MAEDA