Feature #1554

Private comments in tickets

Added by Philippe Lafoucrière over 3 years ago. Updated about 1 month ago.

Status:New Start date:2008-06-30
Priority:Normal Due date:
Assignee:- % Done:

50%

Category:Issues
Target version:Candidate for next major release
Resolution:

Description

Hi,

private issues would be great, but I'd like to propose a feature taken from Request Tracker (a great tool btw).
In RT3, it's possible for admins of a queue (~= project in redmine) to add comments to a tickets. Comments are different from answers in the way they can be viewed only by admin members.

Therefore, I can use those "hidden" comments to add info on tickets, and sometimes drive my team to the right path. For example, sometimes I just want to make sure they understood correctly, and will only add this very little line at bottom of file to fix the issue.

Having such feature in redmine would be a real advantage for my company.

Thanks,
Philippe

private_messages.patch - Used sources from /branches/1.2-stable/ r6484 (9.7 kB) Dmitry Polovka, 2011-08-20 12:43

20110820092133_add_private_to_journals.rb - migration which you need to run (204 Bytes) Dmitry Polovka, 2011-08-20 12:43

private_messages-2011-12-14.patch (11 kB) Shaun Gilroy, 2011-12-14 20:25

private_messages-2011-12-14-v1.3.patch (10.4 kB) Shaun Gilroy, 2011-12-14 23:15

patch_output.txt (1.9 kB) Pablo Bastari, 2012-01-05 15:10


Related issues

related to Feature #337: Private issues Closed
related to Feature #7412: Add an issue visibility level to each role Closed 2011-01-22

History

Updated by Philippe Lafoucrière over 3 years ago

Funny, I can't find the option to add a relation to a ticket when the issue is created, it is a bug ??

This ticket can be related to #337

Updated by Chris Cage about 3 years ago

I'd like to second the desire for this feature. We've been using Bugzilla as our issue tracker some time now. Bugzilla has the ability for private issues and private comments and I can say we use the private comments feature much more (although the private issue feature is helpful as well). Similar to what Philippe mentioned, we use the private comments to create clarification or ask questions internally that we would rather not share with our clients.

This actually has been the main issue causing us to hesitate in migrating to Redmine, although we will still probably jump in soon.

Updated by Simon Stearn about 3 years ago

+1

Updated by Jens Goldhammer almost 3 years ago

+1. This would be very useful.

Updated by Shaun Gilroy almost 3 years ago

We also could really use this functionality. This actually more important than 'private issues'...

Seems to me that this could be handled pretty easily as a plugin... Does anybody know of one that does this?

Updated by Jens Goldhammer over 2 years ago

JIRA uses a checkbox for marking a comment as private. I think, this would be a first quick hack.

Updated by Szabolcs Klement over 2 years ago

I make the following changes in app/models/journal.rb:
def notes
orignote=read_attribute(:notes).to_s
if (User.current.allowed_to?(:privnote, project)||self.user.to_s==User.current.to_s)||(aa[0..0]!='/')
orignot
else
"private note!"
end
end

when the first char is '/' then the note value is "private note"
the :privnote is a new permission in lib/redmine.rb:
map.permission :felelos_valasztas, :issues => :felelos_valasztas
But this solution is bad for the mail notification.

Updated by chris madler over 2 years ago

+1
I also think this feature is absolutely necessary for companies that want to keep some notes on issues only visible to staff members and other notes (also) visible to clients.

I suppose it would consist of having a field "visibility" with values (private, public) on each note that is added to an issue. Then in roles, a permission to view certain visibility values (private, public, or both?). Related to #1193.

Updated by Philippe Lafoucrière over 2 years ago

chris madler wrote:

I suppose it would consist of having a field "visibility" with values (private, public) on each note that is added to an issue. Then in roles, a permission to view certain visibility values (private, public, or both?). Related to #1193.

This might be more easy to use than having Comment / Reply models ?
On the other hand, since redmine has automatic notification, it sounds silly to change (=hide) a ticket update after a mail is sent, so the couple Comment(hidden) / Reply(visible) should be considered too.

Thanks !

Updated by Aron Rotteveel about 2 years ago

+1 definately.

This feature would be an awesome addition. Currently we use Redmine for larger projects. Both our developers as customers have access to the issue list and we have entire conversations regarding bugs/features in our applications. It would be great to have private comments that would be visible for only certain users or usergroups. That way we would be able to include internal task assignments in the comments without our customers being notified all the time.

Updated by Mike Heininger about 2 years ago

+1

Updated by Jani Partanen almost 2 years ago

Philippe Lafoucrière wrote:

This might be more easy to use than having Comment / Reply models ?
On the other hand, since redmine has automatic notification, it sounds silly to change (=hide) a ticket update after a mail is sent, so the couple Comment(hidden) / Reply(visible) should be considered too.

How about new setting "private issues"

When selected, then all comments in private in default, until you click "Answer author" checkbox

Hows that sounds?

Updated by Alex Popov almost 2 years ago

+1

Updated by Ronald Theile almost 2 years ago

Any news on this feature?
We use now a "internal" and a external project to hide comments and development steps to the customer. But they have to be on same status, so it's more work.

regards Ron

Updated by Oleg Volkov almost 2 years ago

Feature #337 is updated for current trunk version.

Updated by Philippe Lafoucrière almost 2 years ago

Great, thanks. Anyway, I want to make sure we're talking about the same thing. This issue is about private COMMENTS in tickets. It's somehow related to #337, but they are really not the same feature request.
Thanks
Philippe

Updated by Oleg Volkov almost 2 years ago

First you have to push in a trunk feature 337, then make private comments. Please test the feature 337.

Updated by Oleg Volkov almost 2 years ago

Philippe Lafoucrière wrote:

Great, thanks. Anyway, I want to make sure we're talking about the same thing. This issue is about private COMMENTS in tickets. It's somehow related to #337, but they are really not the same feature request.

In the trunk version for private comments, it will create a subtask with a private issue.

Updated by Oleg Volkov almost 2 years ago

I updated the # 337. Please test it.

Private notes are needed for NOT private issue?
Who should view private notes?

Updated by Philippe Lafoucrière almost 2 years ago

Oleg Volkov wrote:

I updated the # 337. Please test it.

Thanks Oleg, I'll test it.

Private notes are needed for NOT private issue?

Yes, privates notes and private issues are 2 different things. A ticket can be "public" (not private) and have private notes.

Who should view private notes?

This should be part of the roles configuration, but I'd say manager + developer. Generally, the reporter is the customer, they should not see private comments.

An example of private comment :

1- John_the_customer opens an issue : "I can't login on the demo site"
2- Bill_the_dev_leader adds a private comment : "Check that this jerk has created an account on demo, and if the last database has been imported"
3- Bob_the_dev adds a reply : "John, we'll check if you an account on demo, and if everything is in place and let you know asap".

John should not see step 2 :)

Updated by Oleg Volkov almost 2 years ago

Privileges "Hidden notes" for the possibility of adding / editing / viewing of hidden notes will be enough?

Updated by Philippe Lafoucrière almost 2 years ago

Exactly!
Thanks

Updated by Kioma Aldecoa almost 2 years ago

Would be great to have this feature, we'd also benefit greatly by being able to control which comments can be seen by customers. We also considered an internal/external project but this would be slow and cumbersome.

Updated by Wytze Keuning almost 2 years ago

Would be very useful indeed. That way a person working on an issue can update the issue with information not visible for "plain" viewers. A discrete comment so to speak.

Updated by Ivo Leite over 1 year ago

+1

Updated by Pradeep Achan over 1 year ago

+1

Updated by Roland Discein over 1 year ago

+1

Updated by Grant Show over 1 year ago

+1

Updated by Eric Peterson over 1 year ago

+1

Updated by Matt Meng over 1 year ago

+1

My organization is getting flustered with Redmine because there are no private comments. This would be a very good addition for us.

Updated by Karolina - over 1 year ago

Thank you for private issue, now we are waiting for private comments.

Updated by Darth Jesus over 1 year ago

Is anyone investigating this? This feature would greatly enhance our support environment.

Updated by Dan Scharon over 1 year ago

Oleg Volkov wrote:

Privileges "Hidden notes" for the possibility of adding / editing / viewing of hidden notes will be enough?

Yes, this would be absolutely sufficient, thus this one is not dependent on #337

Updated by Heiko Robert about 1 year ago

+1

Updated by Ant Radford about 1 year ago

+1

Updated by Marcel Hochuli about 1 year ago

+1

Updated by Cord Bellersen about 1 year ago

+1

Mantis has that feature as well and we are using it a lot. Our customers uses our issue management system and in almost every ticket we need to discuss something, that the customer is not supposed to see.

Updated by Karolina - 11 months ago

Can't wait for this feature!

Updated by Yuke Priyantoko 11 months ago

+1

Updated by David Gillard 11 months ago

+1 Is anyone on the Redmine team looking at putting this onto the roadmap? Thanks

Updated by Etienne Massip 10 months ago

  • Target version set to Candidate for next major release

Updated by Brian Kjelin Olsen 10 months ago

+1 Thanks Etienne, I can't wait either :)

Updated by Bartek W 8 months ago

+ me too

Updated by Terence Mill 8 months ago

+1

Updated by Christian Köwing 7 months ago

+1

Updated by Royce Williams 7 months ago

+1

Updated by Dmitry Polovka 6 months ago

As Eugene Kharkov mentioned before http://www.redmine.org/boards/1/topics/4325?r=25789#message-25789 Ruby and Rails not our strong side, so it would be nice if somebody of experienced Ruby developers cleaned up our code. We made patch from /branches/1.2-stable/ r6484 source code and added one permission "View private messages" which allow you view and also add private messages.

Updated by pasquale [:dedalus] 5 months ago

+1: necessary feature

Updated by Pawel Orzechowski 5 months ago

+1:

Updated by Jacob Weber 5 months ago

+1

Updated by Jérôme BATAILLE 5 months ago

+1

Updated by Sergey Kolodyazhnyy 5 months ago

+1
Please, implement this feature. My client shouldn't see programmer talks

Updated by Klaus Franken 5 months ago

Dmitry Polovka wrote:

As Eugene Kharkov mentioned before http://www.redmine.org/boards/1/topics/4325?r=25789#message-25789 Ruby and Rails not our strong side, so it would be nice if somebody of experienced Ruby developers cleaned up our code. We made patch from /branches/1.2-stable/ r6484 source code and added one permission "View private messages" which allow you view and also add private messages.

What I have to do with 20110820092133_add_private_to_journals.rb ?
I successfull patched the source, but I don't know how to change the database. Even with an "alter table journals add column private tinyint(1) default 0;" I cannot create a new notice.

NoMethodError in Issues#show
Showing app/views/issues/show.rhtml where line #94 raised:
undefined method `private' for #<Journal:0x4f8ec5c>

Updated by Chaim Peck 4 months ago

+1 Agreed - it would be very useful to be able to tag a comment as "private" or a drop-down that says "Make this comment viewable to: [All, Managers, Developers, Reporters]

Updated by Razi Baluchi 3 months ago

I've applied the patch to a 1.2.1 installation, and everything appears to work as expected with the exception of the activity log. This still shows all comments, private and non-private. Is there a step I might have missed?

Updated by Razi Baluchi 3 months ago

Resolved the activity log issue by adding:

1        # The private notes should be removed from events
2    events.delete_if { |e| e.is_a?(Journal) && e.private }

to app/controllers/activities_controller.rb

Updated by Ernesto Baschny 2 months ago

+1 on that feature...

Is anyone using the patch from Dmitry Polovka plus the additional change by Razi successfully? Is it safe to apply and try it out? Thanks!

Updated by Shaun Gilroy about 1 month ago

Razi Baluchi wrote:

Resolved the activity log issue by adding:

[...]

to app/controllers/activities_controller.rb

This method of hiding the activity is going to hide the private notes regardless of whether you have permission to see them or not. I'll fix it and post a patch if I manage to fix it.

Shouldn't logic like this be going into the model, not the controller?

Updated by Shaun Gilroy about 1 month ago

Alright--

This patch is compatible with 1.2-stable, but they've changed a few filenames in 1.3, so I couldn't get it to work with 1.3 without taking more time than I had on my hands today.

I've repaired a few things from the previous patch:
  1. Emails from private messages include a '[PRIVATE]' value i the subject to warn the user
  2. Incoming emails that update issues with '[PRIVATE]' in their subject will be added to the system as private notes (so you don't accidentally respond to a private note with a public response)
  3. I updated Razi Baluchi's change above to Activity Lists to only hide private notes from users who do not have permission to view private notes.

I made no changes to the migration, so I'm not uploading a new migration file.

Updated by Shaun Gilroy about 1 month ago

It bothered me to ditch on the 1.3 patch so quickly, so I went back and generated a 1.3 patch. Again, no new migration file was required. This should get anyone who's deployed 1.3.x up and running.

Updated by Alter Way about 1 month ago

  • Assignee set to Russell Hind

I am a newby on ruby: How do you run 20110820092133_add_private_to_journals.rb migration script ?
thx

Updated by Alter Way about 1 month ago

Forget my question i found how to do it

Alter Way wrote:

I am a newby on ruby: How do you run 20110820092133_add_private_to_journals.rb migration script ?
thx

Updated by Russell Hind about 1 month ago

Alter Way wrote:

I am a newby on ruby: How do you run 20110820092133_add_private_to_journals.rb migration script ?
thx

Please don't randomly assign tickets to people.

Updated by Russell Hind about 1 month ago

  • Assignee deleted (Russell Hind)

Updated by Pablo Bastari about 1 month ago

Nice feature you patched, but i am having problems to merge it with 1.3 stable i installed a few days ago. When i run the patch -p0 < private_messages-2011-12-14-v1.3.patch on the root dir of redmine and i get a lot of errors and rejected merges. Any idea why?
I am atacching the output of the patch.

Thanks.

Updated by Shaun Gilroy about 1 month ago

My initial thought is that you might not be running it from your redmine install directory. I occasionally get error like that when I try to apply a patch from ~/

This also might be caused if you've made modifications to redmine yourself or run a previous patch first. You really only need to run the last patch posted.

Also available in: Atom PDF